| Message ID | 20230705064823.9210-2-krzysztof.kozlowski@linaro.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp1685270vqx;
Wed, 5 Jul 2023 00:15:21 -0700 (PDT)
X-Google-Smtp-Source:
APBJJlHz41WORulAxtsDLYYZ+mH4IFIdTtDFhAzLnx5xs4F5TlYBzXJSCIeCVG34CulpBMI8O4bZ
X-Received: by 2002:a05:6358:e99:b0:12b:de12:617f with SMTP id
25-20020a0563580e9900b0012bde12617fmr7649133rwg.4.1688541321015;
Wed, 05 Jul 2023 00:15:21 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1688541320; cv=none;
d=google.com; s=arc-20160816;
b=JiQ6l50yoMR2uUOarag5wWTFcDB8oAh6to1DOBLIPhwDgVZeE/PDRpKpufo1LiwTJJ
ejbnPscTNSCClOBi269jOr4kwL+F4GEA0+lJOPDJVlyMzhnm6Jo+tHZk8XAcZGeGg4KE
LSasdqb2J5Ew+O1+ze3yeX+Nh2tJaAdCRnFXdI58M5YlI8VbfQ37GxKGj+O7WJCYZiDU
x12dZc1ME0sqsLc2S/kjh8X+4Bo0sZ/PXXN2o/W6R2ojc8NU1F6mb3ol80k0W69A0nKq
RELLzaZe1uxcu91x6GklVBlBAW9d41qLLkl1P3EM2lfeyrBYk5aMYajXn/wGXEcs2ll6
oGCg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=u+MkrFMagkeIVy8ddwJ2oj2EHTlEbXRG0oh1YfYd/3Q=;
fh=NmMpA087G+nW17gHqKuiF2+5kiwj87GNsRk/TNdOEQk=;
b=ZjWL3596SR0+QVQKKrbzqn0onU9Mha5byd3aL86CITIzGZafd5rKPN3IJimgnhqx10
b9YlHlg+TpgQW7+D186lWaP0pqhSQ6d9zaIN1/ZfMaWwQeQCRVbMpbB+hZXF+TLzwgf8
fsc6EllJdpDHuzYpNvVwbg9eMtBkVMCn593+SYjyHBEFf0r9Y6e2xC8/DnFrOdW/yy7I
fxTsvNAByzOM2JCLt249LoQcxosygH9EDTiCXpKo8AdoUCNCUOG/bFC/4c17IzRWPhHm
8aiRiDZpTvGkpsYcp9+6Es1IfVAURsnAU2/yyRNSfVJKGDjmXGS4j+cpk1hul9gUF3gO
w1Ug==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=iiIjNFLG;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
w8-20020a63f508000000b00552db57a742si22453502pgh.279.2023.07.05.00.15.07;
Wed, 05 Jul 2023 00:15:20 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=iiIjNFLG;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230432AbjGEGuG (ORCPT <rfc822;tebrre53rla2o@gmail.com>
+ 99 others); Wed, 5 Jul 2023 02:50:06 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50590 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S231886AbjGEGtk (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Wed, 5 Jul 2023 02:49:40 -0400
Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com
[IPv6:2a00:1450:4864:20::62c])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AFFFB2139
for <linux-kernel@vger.kernel.org>;
Tue, 4 Jul 2023 23:49:05 -0700 (PDT)
Received: by mail-ej1-x62c.google.com with SMTP id
a640c23a62f3a-99384a80af7so187623666b.2
for <linux-kernel@vger.kernel.org>;
Tue, 04 Jul 2023 23:49:05 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=linaro.org; s=google; t=1688539729; x=1691131729;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:from:to:cc:subject:date
:message-id:reply-to;
bh=u+MkrFMagkeIVy8ddwJ2oj2EHTlEbXRG0oh1YfYd/3Q=;
b=iiIjNFLGPfjNj1fI30V62Stc1tnzX5ajqXD6ASSEccaJfwC3Z8MJ2KpUhYDD5cH0a7
onLqb4b4fXe9mNW+xfaqEI4MFTjKn+nuLKx6lpj5To7cIzsG4YDHiwXMTR7n69zXpCJB
yonJuaE21eWHaezgbQTi2qw/ds0JHwuwXTF6ODm8TfMkrLwJgGHXovis3SfvqDlv25qD
fmMpPRQxEEfi9CVKpPCkmtxz0dmFVYi7NZq4CY/bB0qcle6THyLWn5H9+U5AfD0toC9S
anMvmvEaSgM1osViu/yAINGF3cWluHzXriqR79J9LKnm7kGgmq/pMQsrVQnkZMc7gABq
gcPA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20221208; t=1688539729; x=1691131729;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=u+MkrFMagkeIVy8ddwJ2oj2EHTlEbXRG0oh1YfYd/3Q=;
b=GDEhWd18PMJFif8vpFwiBe/8gSANf7wMCGVgoZxlzUl6ZtqtbK3CE44tZz12iBd8mP
nvMcS0c2XX8Ssd+89642PnOhletk/y2VKWp4FBoNrWnQFg+wXJ1+4TlldWb0+o13eCE4
zUWwDjxuqchFQD8hRUbmacq9YZn3sSjilPjhNJwzmUuy/ajdM83PsUSdlwN1ouNvRaWv
VgAYzvqDPOTyIROwgBJu0mcdk7Snrj6gEi+xeW0MFresbGcUoy7ReCnJVkhVMy4VnvGq
YgW3Y7+OGDUHacEHAraYZ+1nUkpsraakigDcV7YxtjId6k1u6Tsw1DXP7co6Ct00iKn0
2XGQ==
X-Gm-Message-State: ABy/qLaFEqczG/h03hyN3UyEvhGoLticwiUbmfDas4j6pjCsimkk0KQb
rGmbwaFEZW93Z9LcpIT3islsCw==
X-Received: by 2002:a17:906:37cc:b0:973:cc48:f19c with SMTP id
o12-20020a17090637cc00b00973cc48f19cmr8818117ejc.56.1688539729764;
Tue, 04 Jul 2023 23:48:49 -0700 (PDT)
Received: from krzk-bin.. ([178.197.219.26])
by smtp.gmail.com with ESMTPSA id
lj14-20020a170906f9ce00b00992bea2e9d2sm7504836ejb.62.2023.07.04.23.48.48
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Tue, 04 Jul 2023 23:48:49 -0700 (PDT)
From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Heiko Stuebner <heiko@sntech.de>, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Subject: [RFT PATCH 2/3] arm64: dts: rockchip: correct audio-codec interrupt
flag in Rock Pi 4B
Date: Wed, 5 Jul 2023 08:48:22 +0200
Message-Id: <20230705064823.9210-2-krzysztof.kozlowski@linaro.org>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20230705064823.9210-1-krzysztof.kozlowski@linaro.org>
References: <20230705064823.9210-1-krzysztof.kozlowski@linaro.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED
autolearn=unavailable autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1770563903979002399?=
X-GMAIL-MSGID: =?utf-8?q?1770563903979002399?=
|
| Series |
[RFT,1/3] arm64: dts: rockchip: correct audio-codec interrupt flag in eaidk-610
|
|
Commit Message
Krzysztof Kozlowski
July 5, 2023, 6:48 a.m. UTC
GPIO_ACTIVE_x flags are not correct in the context of interrupt flags.
These are simple defines so they could be used in DTS but they will not
have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE.
Correct the interrupt flags, assuming the author of the code wanted same
logical behavior behind the name "ACTIVE_xxx", this is:
ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Hi Krzysztof, On Wed, 2023-07-05 at 08:48 +0200, Krzysztof Kozlowski wrote: > GPIO_ACTIVE_x flags are not correct in the context of interrupt flags. > These are simple defines so they could be used in DTS but they will not > have the same meaning: GPIO_ACTIVE_HIGH = 0 = IRQ_TYPE_NONE. > > Correct the interrupt flags, assuming the author of the code wanted same > logical behavior behind the name "ACTIVE_xxx", this is: > ACTIVE_LOW => IRQ_TYPE_LEVEL_LOW > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- This works fine on my hardware. With that: Tested-by: Christopher Obbard <chris.obbard@collabora.com> > arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts > index cec3b7b1b947..8a17c1eaae15 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts > @@ -31,7 +31,7 @@ brcmf: wifi@1 { > compatible = "brcm,bcm4329-fmac"; > reg = <1>; > interrupt-parent = <&gpio0>; > - interrupts = <RK_PA3 GPIO_ACTIVE_HIGH>; > + interrupts = <RK_PA3 IRQ_TYPE_LEVEL_HIGH>; > interrupt-names = "host-wake"; > pinctrl-names = "default"; > pinctrl-0 = <&wifi_host_wake_l>;
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts index cec3b7b1b947..8a17c1eaae15 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock-pi-4b-plus.dts @@ -31,7 +31,7 @@ brcmf: wifi@1 { compatible = "brcm,bcm4329-fmac"; reg = <1>; interrupt-parent = <&gpio0>; - interrupts = <RK_PA3 GPIO_ACTIVE_HIGH>; + interrupts = <RK_PA3 IRQ_TYPE_LEVEL_HIGH>; interrupt-names = "host-wake"; pinctrl-names = "default"; pinctrl-0 = <&wifi_host_wake_l>;