Message ID | 1688395346-3126-3-git-send-email-quic_rohiagar@quicinc.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:9f45:0:b0:3ea:f831:8777 with SMTP id v5csp578548vqx; Mon, 3 Jul 2023 07:51:12 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5T75X0FSfVVvhU7D/eNFFkBp6B5J/B3u/PG6fE04AAi+eHshBuQDhB6hkYOQ9hXVKKtBTG X-Received: by 2002:a05:6a20:1446:b0:111:a0e5:d2b7 with SMTP id a6-20020a056a20144600b00111a0e5d2b7mr15436154pzi.4.1688395872284; Mon, 03 Jul 2023 07:51:12 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688395872; cv=none; d=google.com; s=arc-20160816; b=pjVRjCYVE0tdp9w5b7YGjcmpvEoAja/zHWG4/L9Dt5qvzxosmTK7tljsxVyHt7FmPI 9VLbfDChZE0bIj2DNjUSO4IIYUpsP1QsDfvFFzGqm++ScUSgqjPO2pqwqggg7wJepmm+ 86Qi+5pWNjBitSUrTtOCq3xNMYCrgW0vjhiWbxD4e1bMK32mbIxN3fdwSSr+sMSKSSZ1 tJN9EOMGUcuItGwtRYOlXV/uoF0ANUNXSsFr7FDDVaQKTc2FlqAEl/RaJWIPiVwmI3Gj 5c33xAd3uYHreoK//iTdwaqBC6TXpUGONfcz7EIbmVq3KLunSh6lvxxH5OkHi+BycsVm oE5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:references:in-reply-to:message-id:date:subject :cc:to:from:dkim-signature; bh=1YlMDlMrAqQyG4MxAKaXFXXx4CXfvhYYgzKfvZNime0=; fh=LmehYcqtIX1HNUoG0DTZjb5GDKXkJQ1TddbXxtGgSY0=; b=NxQA0y5ROJUxwPBrdiwUjSnPZK2T+4PzHcQo5GC8EeXqq3ZYRt+Tg6nMcBOZYWv1Yv HZUZD+N2Nw0jnQwTu8+KaD9TDAiBebz8ViVAbw7/erOPxSbWt19S1wu+90veGVPp/zLD wam89sQhloiAyoNub/3+dph8Rv46pFLPzNpH42njxAm2nKtl2IIFdZLZbFtqensMPPvk f84XlGX6W4I9HDWMSLlQugScdnS59tKMh7e311v8PwTReWa6kWr6iLgT58cqwkx7/AXo l+U/Okmda4OwAb9RvbRYvKh1kDY18+BCjAHQUUUPgdJlJj6drlZrX5eNH8N8QCZgEIEc QWQQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=Au0q23Xd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id y13-20020a17090322cd00b001b86671b3f1si8840787plg.190.2023.07.03.07.50.59; Mon, 03 Jul 2023 07:51:12 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@quicinc.com header.s=qcppdkim1 header.b=Au0q23Xd; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=quicinc.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230023AbjGCOm6 (ORCPT <rfc822;ivan.orlov0322@gmail.com> + 99 others); Mon, 3 Jul 2023 10:42:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57478 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231320AbjGCOmu (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 3 Jul 2023 10:42:50 -0400 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DA82810D3; Mon, 3 Jul 2023 07:42:41 -0700 (PDT) Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 363EJShm032321; Mon, 3 Jul 2023 14:42:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=quicinc.com; h=from : to : cc : subject : date : message-id : in-reply-to : references; s=qcppdkim1; bh=1YlMDlMrAqQyG4MxAKaXFXXx4CXfvhYYgzKfvZNime0=; b=Au0q23Xdf3IhjGjsxk7PaQUAkgenmH0iUlhJVqvIWv18To1LhJ5+ERM5VZhbcZwxfNWk g7Xr9s3ktX4Qhmt4Wsvq1mvISYLIMf7qeyNOfDHh9MAJNHepbsVV5OC03Q3SDDPuBBqF IP91SsyAZCDiBoOSDKW3sI3EsGMoxQXtn7nk1gLoNCSnVPQklL/L5uZH7lfz14pWrUNj 3EyQumIrvNoiVF248eBv64iKc2JXa87hHbB8tjEBLEmr690Y065Iv0kyjveDcz7+RmHp KyrtHhYVsJKzktCYSvpUDk0KOsf4EidK1e/e83SID3jYQnalENFEV1wDkHafAuGmLjLN Ow== Received: from apblrppmta02.qualcomm.com (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com [103.229.18.19]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 3rm00601gj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 03 Jul 2023 14:42:32 +0000 Received: from pps.filterd (APBLRPPMTA02.qualcomm.com [127.0.0.1]) by APBLRPPMTA02.qualcomm.com (8.17.1.5/8.17.1.5) with ESMTP id 363EgTpV031827; Mon, 3 Jul 2023 14:42:29 GMT Received: from pps.reinject (localhost [127.0.0.1]) by APBLRPPMTA02.qualcomm.com (PPS) with ESMTPS id 3rjd7k8gej-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 03 Jul 2023 14:42:29 +0000 Received: from APBLRPPMTA02.qualcomm.com (APBLRPPMTA02.qualcomm.com [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 363EgSxN031605; Mon, 3 Jul 2023 14:42:28 GMT Received: from hu-sgudaval-hyd.qualcomm.com (hu-rohiagar-hyd.qualcomm.com [10.213.106.138]) by APBLRPPMTA02.qualcomm.com (PPS) with ESMTP id 363EgSkv031522; Mon, 03 Jul 2023 14:42:28 +0000 Received: by hu-sgudaval-hyd.qualcomm.com (Postfix, from userid 3970568) id ECD5D503F; Mon, 3 Jul 2023 20:12:27 +0530 (+0530) From: Rohit Agarwal <quic_rohiagar@quicinc.com> To: agross@kernel.org, andersson@kernel.org, konrad.dybcio@linaro.org, lee@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, linus.walleij@linaro.org, lgirdwood@gmail.com, broonie@kernel.org, sboyd@kernel.org Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Rohit Agarwal <quic_rohiagar@quicinc.com> Subject: [PATCH 02/10] dt-bindings: power: Add rpm power domains for SDX75 Date: Mon, 3 Jul 2023 20:12:18 +0530 Message-Id: <1688395346-3126-3-git-send-email-quic_rohiagar@quicinc.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1688395346-3126-1-git-send-email-quic_rohiagar@quicinc.com> References: <1688395346-3126-1-git-send-email-quic_rohiagar@quicinc.com> X-QCInternal: smtphost X-QCInternal: smtphost X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-Virus-Version: vendor=nai engine=6200 definitions=5800 signatures=585085 X-Proofpoint-ORIG-GUID: KOUfFc9XFxhnCe7AaitWo4kZDPzdEim5 X-Proofpoint-GUID: KOUfFc9XFxhnCe7AaitWo4kZDPzdEim5 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.254,Aquarius:18.0.957,Hydra:6.0.591,FMLib:17.11.176.26 definitions=2023-07-03_11,2023-06-30_01,2023-05-22_02 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 suspectscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 mlxscore=0 mlxlogscore=590 adultscore=0 spamscore=0 impostorscore=0 malwarescore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2305260000 definitions=main-2307030132 X-Spam-Status: No, score=-1.8 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770411390331020078?= X-GMAIL-MSGID: =?utf-8?q?1770411390331020078?= |
Series |
Add Power Domains and Regulators in SDX75
|
|
Commit Message
Rohit Agarwal
July 3, 2023, 2:42 p.m. UTC
Add RPM power domain bindings for the SDX75 SoC.
Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com>
---
Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 1 +
include/dt-bindings/power/qcom-rpmpd.h | 8 ++++++++
2 files changed, 9 insertions(+)
Comments
On 3.07.2023 16:42, Rohit Agarwal wrote: > Add RPM power domain bindings for the SDX75 SoC. > > Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com> > --- > Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 1 + > include/dt-bindings/power/qcom-rpmpd.h | 8 ++++++++ > 2 files changed, 9 insertions(+) > > diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml > index afad313..58e1be8 100644 > --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml > +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml > @@ -40,6 +40,7 @@ properties: > - qcom,sdm845-rpmhpd > - qcom,sdx55-rpmhpd > - qcom,sdx65-rpmhpd > + - qcom,sdx75-rpmhpd > - qcom,sm6115-rpmpd > - qcom,sm6125-rpmpd > - qcom,sm6350-rpmhpd > diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h > index 1bf8e87..8092d0d 100644 > --- a/include/dt-bindings/power/qcom-rpmpd.h > +++ b/include/dt-bindings/power/qcom-rpmpd.h > @@ -57,6 +57,14 @@ > #define SDX65_CX_AO 4 > #define SDX65_MXC 5 > > +/* SDX75 Power Domain Indexes */ > +#define SDX75_CX 0 > +#define SDX75_CX_AO 1 > +#define SDX75_MSS 2 > +#define SDX75_MX 3 > +#define SDX75_MX_AO 4 > +#define SDX75_MXC 5 Please instead introduce a set of defines without the SoC prefix (i.e. CX, CX_AO, MX etc.). We've been putting this off for too long and you're the first unlucky guy that submitted new RPMhPD support after we've concluded it'd be the way to go! :D Sadly, we can't replace the existing ones retroactively.. Konrad > + > /* SM6350 Power Domain Indexes */ > #define SM6350_CX 0 > #define SM6350_GFX 1
On 7/3/2023 8:29 PM, Konrad Dybcio wrote: > On 3.07.2023 16:42, Rohit Agarwal wrote: >> Add RPM power domain bindings for the SDX75 SoC. >> >> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com> >> --- >> Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 1 + >> include/dt-bindings/power/qcom-rpmpd.h | 8 ++++++++ >> 2 files changed, 9 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml >> index afad313..58e1be8 100644 >> --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml >> +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml >> @@ -40,6 +40,7 @@ properties: >> - qcom,sdm845-rpmhpd >> - qcom,sdx55-rpmhpd >> - qcom,sdx65-rpmhpd >> + - qcom,sdx75-rpmhpd >> - qcom,sm6115-rpmpd >> - qcom,sm6125-rpmpd >> - qcom,sm6350-rpmhpd >> diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h >> index 1bf8e87..8092d0d 100644 >> --- a/include/dt-bindings/power/qcom-rpmpd.h >> +++ b/include/dt-bindings/power/qcom-rpmpd.h >> @@ -57,6 +57,14 @@ >> #define SDX65_CX_AO 4 >> #define SDX65_MXC 5 >> >> +/* SDX75 Power Domain Indexes */ >> +#define SDX75_CX 0 >> +#define SDX75_CX_AO 1 >> +#define SDX75_MSS 2 >> +#define SDX75_MX 3 >> +#define SDX75_MX_AO 4 >> +#define SDX75_MXC 5 > Please instead introduce a set of defines without the SoC prefix > (i.e. CX, CX_AO, MX etc.). We've been putting this off for too long > and you're the first unlucky guy that submitted new RPMhPD support after > we've concluded it'd be the way to go! :D Sadly, we can't replace the > existing ones retroactively.. Surely No issues. Will update it. Thanks, Rohit. > Konrad >> + >> /* SM6350 Power Domain Indexes */ >> #define SM6350_CX 0 >> #define SM6350_GFX 1
On 7/4/2023 11:47 AM, Rohit Agarwal wrote: > > On 7/3/2023 8:29 PM, Konrad Dybcio wrote: >> On 3.07.2023 16:42, Rohit Agarwal wrote: >>> Add RPM power domain bindings for the SDX75 SoC. >>> >>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com> >>> --- >>> Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 1 + >>> include/dt-bindings/power/qcom-rpmpd.h | 8 ++++++++ >>> 2 files changed, 9 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml >>> b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml >>> index afad313..58e1be8 100644 >>> --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml >>> +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml >>> @@ -40,6 +40,7 @@ properties: >>> - qcom,sdm845-rpmhpd >>> - qcom,sdx55-rpmhpd >>> - qcom,sdx65-rpmhpd >>> + - qcom,sdx75-rpmhpd >>> - qcom,sm6115-rpmpd >>> - qcom,sm6125-rpmpd >>> - qcom,sm6350-rpmhpd >>> diff --git a/include/dt-bindings/power/qcom-rpmpd.h >>> b/include/dt-bindings/power/qcom-rpmpd.h >>> index 1bf8e87..8092d0d 100644 >>> --- a/include/dt-bindings/power/qcom-rpmpd.h >>> +++ b/include/dt-bindings/power/qcom-rpmpd.h >>> @@ -57,6 +57,14 @@ >>> #define SDX65_CX_AO 4 >>> #define SDX65_MXC 5 >>> +/* SDX75 Power Domain Indexes */ >>> +#define SDX75_CX 0 >>> +#define SDX75_CX_AO 1 >>> +#define SDX75_MSS 2 >>> +#define SDX75_MX 3 >>> +#define SDX75_MX_AO 4 >>> +#define SDX75_MXC 5 >> Please instead introduce a set of defines without the SoC prefix >> (i.e. CX, CX_AO, MX etc.). We've been putting this off for too long >> and you're the first unlucky guy that submitted new RPMhPD support after >> we've concluded it'd be the way to go! :D Sadly, we can't replace the >> existing ones retroactively.. > Surely No issues. Will update it. I have a doubt here. Cant we completely omit the #defines here and directly index this as 0,1,... because if the intention of this #defines is to understand the name of the pd then we can get it from the .name attribute in rpmhpd as well, right? The problems with a common set of #define would be, lets say if we define CX_AO as 1 and some platform doesn't have CX_AO then wouldnt it leave a null entry in the driver entry of that platform? Thanks, Rohit. > > Thanks, > Rohit. >> Konrad >>> + >>> /* SM6350 Power Domain Indexes */ >>> #define SM6350_CX 0 >>> #define SM6350_GFX 1
On 5.07.2023 10:54, Rohit Agarwal wrote: > > On 7/4/2023 11:47 AM, Rohit Agarwal wrote: >> >> On 7/3/2023 8:29 PM, Konrad Dybcio wrote: >>> On 3.07.2023 16:42, Rohit Agarwal wrote: >>>> Add RPM power domain bindings for the SDX75 SoC. >>>> >>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com> >>>> --- >>>> Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 1 + >>>> include/dt-bindings/power/qcom-rpmpd.h | 8 ++++++++ >>>> 2 files changed, 9 insertions(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml >>>> index afad313..58e1be8 100644 >>>> --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml >>>> +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml >>>> @@ -40,6 +40,7 @@ properties: >>>> - qcom,sdm845-rpmhpd >>>> - qcom,sdx55-rpmhpd >>>> - qcom,sdx65-rpmhpd >>>> + - qcom,sdx75-rpmhpd >>>> - qcom,sm6115-rpmpd >>>> - qcom,sm6125-rpmpd >>>> - qcom,sm6350-rpmhpd >>>> diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h >>>> index 1bf8e87..8092d0d 100644 >>>> --- a/include/dt-bindings/power/qcom-rpmpd.h >>>> +++ b/include/dt-bindings/power/qcom-rpmpd.h >>>> @@ -57,6 +57,14 @@ >>>> #define SDX65_CX_AO 4 >>>> #define SDX65_MXC 5 >>>> +/* SDX75 Power Domain Indexes */ >>>> +#define SDX75_CX 0 >>>> +#define SDX75_CX_AO 1 >>>> +#define SDX75_MSS 2 >>>> +#define SDX75_MX 3 >>>> +#define SDX75_MX_AO 4 >>>> +#define SDX75_MXC 5 >>> Please instead introduce a set of defines without the SoC prefix >>> (i.e. CX, CX_AO, MX etc.). We've been putting this off for too long >>> and you're the first unlucky guy that submitted new RPMhPD support after >>> we've concluded it'd be the way to go! :D Sadly, we can't replace the >>> existing ones retroactively.. >> Surely No issues. Will update it. > > I have a doubt here. Cant we completely omit the #defines here and directly index this as 0,1,... > because if the intention of this #defines is to understand the name of the pd then we can get > it from the .name attribute in rpmhpd as well, right? > > The problems with a common set of #define would be, lets say if we define CX_AO as 1 and some platform > doesn't have CX_AO then wouldnt it leave a null entry in the driver entry of that platform? Yes. We already do this in the rpmh clock driver, as: 1. there are domains that all chips share (like CX etc.) 2. wasting a couple of bytes lets us massively save on convolution Konrad > > Thanks, > Rohit. > >> >> Thanks, >> Rohit. >>> Konrad >>>> + >>>> /* SM6350 Power Domain Indexes */ >>>> #define SM6350_CX 0 >>>> #define SM6350_GFX 1
On 7/5/2023 4:13 PM, Konrad Dybcio wrote: > On 5.07.2023 10:54, Rohit Agarwal wrote: >> On 7/4/2023 11:47 AM, Rohit Agarwal wrote: >>> On 7/3/2023 8:29 PM, Konrad Dybcio wrote: >>>> On 3.07.2023 16:42, Rohit Agarwal wrote: >>>>> Add RPM power domain bindings for the SDX75 SoC. >>>>> >>>>> Signed-off-by: Rohit Agarwal <quic_rohiagar@quicinc.com> >>>>> --- >>>>> Documentation/devicetree/bindings/power/qcom,rpmpd.yaml | 1 + >>>>> include/dt-bindings/power/qcom-rpmpd.h | 8 ++++++++ >>>>> 2 files changed, 9 insertions(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml >>>>> index afad313..58e1be8 100644 >>>>> --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml >>>>> +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml >>>>> @@ -40,6 +40,7 @@ properties: >>>>> - qcom,sdm845-rpmhpd >>>>> - qcom,sdx55-rpmhpd >>>>> - qcom,sdx65-rpmhpd >>>>> + - qcom,sdx75-rpmhpd >>>>> - qcom,sm6115-rpmpd >>>>> - qcom,sm6125-rpmpd >>>>> - qcom,sm6350-rpmhpd >>>>> diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h >>>>> index 1bf8e87..8092d0d 100644 >>>>> --- a/include/dt-bindings/power/qcom-rpmpd.h >>>>> +++ b/include/dt-bindings/power/qcom-rpmpd.h >>>>> @@ -57,6 +57,14 @@ >>>>> #define SDX65_CX_AO 4 >>>>> #define SDX65_MXC 5 >>>>> +/* SDX75 Power Domain Indexes */ >>>>> +#define SDX75_CX 0 >>>>> +#define SDX75_CX_AO 1 >>>>> +#define SDX75_MSS 2 >>>>> +#define SDX75_MX 3 >>>>> +#define SDX75_MX_AO 4 >>>>> +#define SDX75_MXC 5 >>>> Please instead introduce a set of defines without the SoC prefix >>>> (i.e. CX, CX_AO, MX etc.). We've been putting this off for too long >>>> and you're the first unlucky guy that submitted new RPMhPD support after >>>> we've concluded it'd be the way to go! :D Sadly, we can't replace the >>>> existing ones retroactively.. >>> Surely No issues. Will update it. >> I have a doubt here. Cant we completely omit the #defines here and directly index this as 0,1,... >> because if the intention of this #defines is to understand the name of the pd then we can get >> it from the .name attribute in rpmhpd as well, right? >> >> The problems with a common set of #define would be, lets say if we define CX_AO as 1 and some platform >> doesn't have CX_AO then wouldnt it leave a null entry in the driver entry of that platform? > Yes. > > We already do this in the rpmh clock driver, as: > > 1. there are domains that all chips share (like CX etc.) > 2. wasting a couple of bytes lets us massively save on convolution Ok, got it. Looks cleaner. Thanks, Rohit. > > Konrad >> Thanks, >> Rohit. >> >>> Thanks, >>> Rohit. >>>> Konrad >>>>> + >>>>> /* SM6350 Power Domain Indexes */ >>>>> #define SM6350_CX 0 >>>>> #define SM6350_GFX 1
diff --git a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml index afad313..58e1be8 100644 --- a/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml +++ b/Documentation/devicetree/bindings/power/qcom,rpmpd.yaml @@ -40,6 +40,7 @@ properties: - qcom,sdm845-rpmhpd - qcom,sdx55-rpmhpd - qcom,sdx65-rpmhpd + - qcom,sdx75-rpmhpd - qcom,sm6115-rpmpd - qcom,sm6125-rpmpd - qcom,sm6350-rpmhpd diff --git a/include/dt-bindings/power/qcom-rpmpd.h b/include/dt-bindings/power/qcom-rpmpd.h index 1bf8e87..8092d0d 100644 --- a/include/dt-bindings/power/qcom-rpmpd.h +++ b/include/dt-bindings/power/qcom-rpmpd.h @@ -57,6 +57,14 @@ #define SDX65_CX_AO 4 #define SDX65_MXC 5 +/* SDX75 Power Domain Indexes */ +#define SDX75_CX 0 +#define SDX75_CX_AO 1 +#define SDX75_MSS 2 +#define SDX75_MX 3 +#define SDX75_MX_AO 4 +#define SDX75_MXC 5 + /* SM6350 Power Domain Indexes */ #define SM6350_CX 0 #define SM6350_GFX 1