diff mbox series

[V2,1/2] arm64: dts: qcom: sc7280: Mark all Qualcomm reference boards as LTE

Message ID 20221108092207.8186-1-quic_sibis@quicinc.com
State New
Headers
Series [V2,1/2] arm64: dts: qcom: sc7280: Mark all Qualcomm reference boards as LTE |

Commit Message

Sibi Sankar Nov. 8, 2022, 9:22 a.m. UTC 
  When the modem node was re-located to a separate LTE source file
"sc7280-herobrine-lte-sku.dtsi", some of the previous LTE users
weren't marked appropriately. Fix this by marking all Qualcomm
reference devices as LTE.

Fix-suggested-by: Douglas Anderson <dianders@chromium.org>
Fixes: d42fae738f3a ("arm64: dts: qcom: Add LTE SKUs for sc7280-villager family")
Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sc7280-idp.dtsi | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Nov. 8, 2022, 9:34 a.m. UTC | #1 
On 08/11/2022 10:22, Sibi Sankar wrote:
> When the modem node was re-located to a separate LTE source file
> "sc7280-herobrine-lte-sku.dtsi", some of the previous LTE users
> weren't marked appropriately. Fix this by marking all Qualcomm
> reference devices as LTE.
> 
> Fix-suggested-by: Douglas Anderson <dianders@chromium.org>

There is no such tag. If it is a fix, use Reported-by. If it is not, use
Suggested-by.

> Fixes: d42fae738f3a ("arm64: dts: qcom: Add LTE SKUs for sc7280-villager family")
> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
> ---

Best regards,
Krzysztof
Sibi Sankar Nov. 8, 2022, 10:10 a.m. UTC | #2 
Krzysztof,
Thanks for taking time to review the series.


On 11/8/22 15:04, Krzysztof Kozlowski wrote:
> On 08/11/2022 10:22, Sibi Sankar wrote:
>> When the modem node was re-located to a separate LTE source file
>> "sc7280-herobrine-lte-sku.dtsi", some of the previous LTE users
>> weren't marked appropriately. Fix this by marking all Qualcomm
>> reference devices as LTE.
>>
>> Fix-suggested-by: Douglas Anderson <dianders@chromium.org>
> 
> There is no such tag. If it is a fix, use Reported-by. If it is not, use
> Suggested-by.

lol I should have just stuck with S-b but found the tag being used a
number of times. I'll fix this up if the series warrants a re-spin.

-Sibi

> 
>> Fixes: d42fae738f3a ("arm64: dts: qcom: Add LTE SKUs for sc7280-villager family")
>> Signed-off-by: Sibi Sankar <quic_sibis@quicinc.com>
>> ---
> 
> Best regards,
> Krzysztof
>
Krzysztof Kozlowski Nov. 8, 2022, 10:53 a.m. UTC | #3 
On 08/11/2022 11:10, Sibi Sankar wrote:
> Krzysztof,
> Thanks for taking time to review the series.
> 
> 
> On 11/8/22 15:04, Krzysztof Kozlowski wrote:
>> On 08/11/2022 10:22, Sibi Sankar wrote:
>>> When the modem node was re-located to a separate LTE source file
>>> "sc7280-herobrine-lte-sku.dtsi", some of the previous LTE users
>>> weren't marked appropriately. Fix this by marking all Qualcomm
>>> reference devices as LTE.
>>>
>>> Fix-suggested-by: Douglas Anderson <dianders@chromium.org>
>>
>> There is no such tag. If it is a fix, use Reported-by. If it is not, use
>> Suggested-by.
> 
> lol I should have just stuck with S-b but found the tag being used a
> number of times. I'll fix this up if the series warrants a re-spin.

It indeed appears in the log. Once (since v5.15). So that's a mistake,
not practice. Common tags are described here:
 - Documentation/process/submitting-patches.rst
 - scripts/checkpatch.pl

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
index 4884647a8a95..ca09367abb6c 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc7280-idp.dtsi
@@ -13,6 +13,7 @@ 
 #include "pmk8350.dtsi"
 
 #include "sc7280-chrome-common.dtsi"
+#include "sc7280-herobrine-lte-sku.dtsi"
 
 / {
 	aliases {