Message ID | 2023063022-retouch-kerosene-7e4a@gregkh |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp10167778vqr; Fri, 30 Jun 2023 00:29:39 -0700 (PDT) X-Google-Smtp-Source: APBJJlF+6buesrZ1OYY3kl3T0J39oYJtvDcKISEEPRWSuMaULwdJUfj6pHVw004DwIQuFc36KurS X-Received: by 2002:a17:90a:f301:b0:262:dc59:ee64 with SMTP id ca1-20020a17090af30100b00262dc59ee64mr1799527pjb.4.1688110178954; Fri, 30 Jun 2023 00:29:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688110178; cv=none; d=google.com; s=arc-20160816; b=tjgcDgh6GCiUdBhx+bcnZcenpwHlFg2G9+j8e8FKkVxL9vuLKbPM/rx0lXQ9A+BcEV KQuISHqM+/HFHbUnASTX4mc+LbpxYyyPT2vsQXa2DhVbg4408q7F9k4+64hiSuEDpwUi LRy33nU3MetcgB2jet5xt/Qkvo+KnQZn0OBAerRZckz7/4Ee+6zTZf2sVI7QHmrQvPub c6v98aqRxAILcFrr5HkdLzhpoOepvOBfJPaRIW5okYs7Ghb1pjiwC7MCmMupVViKQUi5 jsE5ry90sgQxsK3bi/KcVV/XMkcj3DzDPyAmWtH9cLWTOMfnwvGaycGLTH7GVaKMhPpR eJFQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:lines:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=VSFHJV1nSvIdD4dbMVU1VOXizNvCvIEAGVxzKFLfURo=; fh=Cjuo0ukgzGLrEgUpftwAK+4EaFKQDZTfKTxdCsB7k34=; b=CxYiTbURO54AVKncn+Fqae2svKEim9SLIOXRfuzLum42F+r1zcU9UquX4feK0wfRR7 8GF9QqjioHHelN72wY0vbYjuNjXlmKbrI+GIM/BAQQnSgf0oiKWXRZ2iPkCTJPnk44Be r3Bd7h9QhkUJj8AJ41bAI5sp4ypvyz3I+gj//89O3uDXpVDZLCnuD25urPX39gtNqm3b QRvst6mC46ICLiEhEokoB3EhamAtQIPcYm/12j/x/COVrJYusfz9SFB+0C32PygU8sgk 7CtCWwxu+2ctJmkfLsLRbftmq+XRRqK0kif3kuQpyq9MTvxT2e40nUGmWOYsH9HmC7tV wn8w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hwAyH0cM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id mh9-20020a17090b4ac900b00250d10c6fe7si15961822pjb.67.2023.06.30.00.29.25; Fri, 30 Jun 2023 00:29:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linuxfoundation.org header.s=korg header.b=hwAyH0cM; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231176AbjF3HOl (ORCPT <rfc822;ivan.orlov0322@gmail.com> + 99 others); Fri, 30 Jun 2023 03:14:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45550 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231617AbjF3HO2 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 30 Jun 2023 03:14:28 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E37B61FFA; Fri, 30 Jun 2023 00:14:27 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 7263F616D4; Fri, 30 Jun 2023 07:14:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B117C433C0; Fri, 30 Jun 2023 07:14:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1688109266; bh=PYqCnWF7IAzpYnZdeaPArwQn6IWMC08ErzlI9oBfh4o=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hwAyH0cMXXytdhps+l+CZl8PsJ798gPS4pZvhgJ4u+vAZUoMt/ZKxX+EVJ7hSKAqf awolAd9LBvw+CZTVTNA5vb1Jczb+DNMAzV1pafEZ5x6HFBLCi+b2691QrrDta+BDEt 2iJfpqDVugdnI8sZKiU2znS9a98WzWt0oPf81/NY= From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-doc@vger.kernel.org Cc: linux-kernel@vger.kernel.org, security@kernel.org, corbet@lwn.net, workflows@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org> Subject: [PATCH 2/2] Documentation: security-bugs.rst: clarify CVE handling Date: Fri, 30 Jun 2023 09:14:21 +0200 Message-ID: <2023063022-retouch-kerosene-7e4a@gregkh> X-Mailer: git-send-email 2.41.0 In-Reply-To: <2023063020-throat-pantyhose-f110@gregkh> References: <2023063020-throat-pantyhose-f110@gregkh> MIME-Version: 1.0 Lines: 34 X-Developer-Signature: v=1; a=openpgp-sha256; l=1604; i=gregkh@linuxfoundation.org; h=from:subject:message-id; bh=PYqCnWF7IAzpYnZdeaPArwQn6IWMC08ErzlI9oBfh4o=; b=owGbwMvMwCRo6H6F97bub03G02pJDCnzGs7J7u3/x9SV/eDmvwqfk3NervP2496welGr/iX11 0/YCqbe6ohlYRBkYpAVU2T5so3n6P6KQ4pehranYeawMoEMYeDiFICJPHJjmKf68PZKBpcOQ9s7 dVWrJWQTkk2StRkWbDdVEYt+WCh0bpussqXr7ap4Bwt2AA== X-Developer-Key: i=gregkh@linuxfoundation.org; a=openpgp; fpr=F4B60CC5BF78C2214A313DCB3147D40DDB2DFB29 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-7.1 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770111818891791047?= X-GMAIL-MSGID: =?utf-8?q?1770111818891791047?= |
Series |
[1/2] Documentation: security-bugs.rst: update preferences when dealing with the linux-distros group
|
|
Commit Message
Greg KH
June 30, 2023, 7:14 a.m. UTC
The kernel security team does NOT assign CVEs, so document that properly
and provide the "if you want one, ask MITRE for it" response that we
give on a weekly basis in the document, so we don't have to constantly
say it to everyone who asks.
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---
Documentation/process/security-bugs.rst | 11 ++++-------
1 file changed, 4 insertions(+), 7 deletions(-)
Comments
On Fri, Jun 30, 2023 at 09:14:21AM +0200, Greg Kroah-Hartman wrote: > The kernel security team does NOT assign CVEs, so document that properly > and provide the "if you want one, ask MITRE for it" response that we > give on a weekly basis in the document, so we don't have to constantly > say it to everyone who asks. > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > Documentation/process/security-bugs.rst | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/Documentation/process/security-bugs.rst b/Documentation/process/security-bugs.rst > index f12ac2316ce7..8b80e1eb7d79 100644 > --- a/Documentation/process/security-bugs.rst > +++ b/Documentation/process/security-bugs.rst > @@ -79,13 +79,10 @@ not contribute to actually fixing any potential security problems. > CVE assignment > -------------- > > -The security team does not normally assign CVEs, nor do we require them > -for reports or fixes, as this can needlessly complicate the process and > -may delay the bug handling. If a reporter wishes to have a CVE identifier > -assigned ahead of public disclosure, they will need to contact the private > -linux-distros list, described above. When such a CVE identifier is known > -before a patch is provided, it is desirable to mention it in the commit > -message if the reporter agrees. > +The security team does not assign CVEs, nor do we require them for > +reports or fixes, as this can needlessly complicate the process and may > +delay the bug handling. If a reporter wishes to have a CVE identifier > +assigned, they should contact MITRE directly. > > Non-disclosure agreements > ------------------------- > -- > 2.41.0 > If there are no objections to these, I'll take them in my tree after 6.5-rc1 is out to make it simpler. thanks, greg k-h
On Fri, Jun 30, 2023 at 09:14:21AM +0200, Greg Kroah-Hartman wrote: > The kernel security team does NOT assign CVEs, so document that properly > and provide the "if you want one, ask MITRE for it" response that we > give on a weekly basis in the document, so we don't have to constantly > say it to everyone who asks. > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > --- > Documentation/process/security-bugs.rst | 11 ++++------- > 1 file changed, 4 insertions(+), 7 deletions(-) > > diff --git a/Documentation/process/security-bugs.rst b/Documentation/process/security-bugs.rst > index f12ac2316ce7..8b80e1eb7d79 100644 > --- a/Documentation/process/security-bugs.rst > +++ b/Documentation/process/security-bugs.rst > @@ -79,13 +79,10 @@ not contribute to actually fixing any potential security problems. > CVE assignment > -------------- > > -The security team does not normally assign CVEs, nor do we require them > -for reports or fixes, as this can needlessly complicate the process and > -may delay the bug handling. If a reporter wishes to have a CVE identifier > -assigned ahead of public disclosure, they will need to contact the private > -linux-distros list, described above. When such a CVE identifier is known > -before a patch is provided, it is desirable to mention it in the commit > -message if the reporter agrees. > +The security team does not assign CVEs, nor do we require them for > +reports or fixes, as this can needlessly complicate the process and may > +delay the bug handling. If a reporter wishes to have a CVE identifier > +assigned, they should contact MITRE directly. Hmm. The language about "assigned ahead of public disclosure" was added intentionally due to trouble we'd had with coordination when a CVE was needed, etc. Additionally, it IS preferred to have a CVE in a patch when it IS known ahead of time, so I think that should be kept. How about this: diff --git a/Documentation/process/security-bugs.rst b/Documentation/process/security-bugs.rst index 82e29837d589..2f4060d49b31 100644 --- a/Documentation/process/security-bugs.rst +++ b/Documentation/process/security-bugs.rst @@ -81,13 +81,12 @@ the email Subject line with "[vs]" as described in the linux-distros wiki: CVE assignment -------------- -The security team does not normally assign CVEs, nor do we require them -for reports or fixes, as this can needlessly complicate the process and -may delay the bug handling. If a reporter wishes to have a CVE identifier -assigned ahead of public disclosure, they will need to contact the private -linux-distros list, described above. When such a CVE identifier is known -before a patch is provided, it is desirable to mention it in the commit -message if the reporter agrees. +The security team does not assign CVEs, nor do we require them for reports +or fixes, as this can needlessly complicate the process and may delay +the bug handling. If a reporter wishes to have a CVE identifier assigned +ahead of public disclosure, they will need to contact MITRE directly. +When such a CVE identifier is known before a patch is provided, it is +desirable to mention it in the commit message if the reporter agrees. Non-disclosure agreements -------------------------
On Fri, Jun 30, 2023 at 11:18:37AM -0700, Kees Cook wrote: > On Fri, Jun 30, 2023 at 09:14:21AM +0200, Greg Kroah-Hartman wrote: > > The kernel security team does NOT assign CVEs, so document that properly > > and provide the "if you want one, ask MITRE for it" response that we > > give on a weekly basis in the document, so we don't have to constantly > > say it to everyone who asks. > > > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > --- > > Documentation/process/security-bugs.rst | 11 ++++------- > > 1 file changed, 4 insertions(+), 7 deletions(-) > > > > diff --git a/Documentation/process/security-bugs.rst b/Documentation/process/security-bugs.rst > > index f12ac2316ce7..8b80e1eb7d79 100644 > > --- a/Documentation/process/security-bugs.rst > > +++ b/Documentation/process/security-bugs.rst > > @@ -79,13 +79,10 @@ not contribute to actually fixing any potential security problems. > > CVE assignment > > -------------- > > > > -The security team does not normally assign CVEs, nor do we require them > > -for reports or fixes, as this can needlessly complicate the process and > > -may delay the bug handling. If a reporter wishes to have a CVE identifier > > -assigned ahead of public disclosure, they will need to contact the private > > -linux-distros list, described above. When such a CVE identifier is known > > -before a patch is provided, it is desirable to mention it in the commit > > -message if the reporter agrees. > > +The security team does not assign CVEs, nor do we require them for > > +reports or fixes, as this can needlessly complicate the process and may > > +delay the bug handling. If a reporter wishes to have a CVE identifier > > +assigned, they should contact MITRE directly. > > Hmm. The language about "assigned ahead of public disclosure" was added > intentionally due to trouble we'd had with coordination when a CVE was > needed, etc. Additionally, it IS preferred to have a CVE in a patch when > it IS known ahead of time, so I think that should be kept. How about > this: > > > diff --git a/Documentation/process/security-bugs.rst b/Documentation/process/security-bugs.rst > index 82e29837d589..2f4060d49b31 100644 > --- a/Documentation/process/security-bugs.rst > +++ b/Documentation/process/security-bugs.rst > @@ -81,13 +81,12 @@ the email Subject line with "[vs]" as described in the linux-distros wiki: > CVE assignment > -------------- > > -The security team does not normally assign CVEs, nor do we require them > -for reports or fixes, as this can needlessly complicate the process and > -may delay the bug handling. If a reporter wishes to have a CVE identifier > -assigned ahead of public disclosure, they will need to contact the private > -linux-distros list, described above. When such a CVE identifier is known > -before a patch is provided, it is desirable to mention it in the commit > -message if the reporter agrees. > +The security team does not assign CVEs, nor do we require them for reports > +or fixes, as this can needlessly complicate the process and may delay > +the bug handling. If a reporter wishes to have a CVE identifier assigned > +ahead of public disclosure, they will need to contact MITRE directly. > +When such a CVE identifier is known before a patch is provided, it is > +desirable to mention it in the commit message if the reporter agrees. I can not, in good faith, with the current mess that MITRE is going through, tell anyone that they should contact MITRE ahead of public disclosure, sorry. All I can say is "if you really want one, go ask them for one", as everyone keeps asking us for one to pad their resume/CV. Also note that many non-US-based companies are not allowed to contact a US-government-backed entity for potential security issues for obvious reasons. So I don't want to even give a hint that we support or request this at all, or that it is something that changelog texts should contain for security issues (for the obvious reason of them being a "hint" one way or another.) External groups may wish to play the CVE "game" as it facilitates their engineering procedures to get changes past managers, but that's not anything that we should be encouraging at all for all of the various geopolitical and corporate reasons involved in that mess. thanks, greg k-h
On Sun, Jul 02, 2023 at 02:39:49PM +0200, Greg Kroah-Hartman wrote: > On Fri, Jun 30, 2023 at 11:18:37AM -0700, Kees Cook wrote: > > On Fri, Jun 30, 2023 at 09:14:21AM +0200, Greg Kroah-Hartman wrote: > > > The kernel security team does NOT assign CVEs, so document that properly > > > and provide the "if you want one, ask MITRE for it" response that we > > > give on a weekly basis in the document, so we don't have to constantly > > > say it to everyone who asks. > > > > > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > --- > > > Documentation/process/security-bugs.rst | 11 ++++------- > > > 1 file changed, 4 insertions(+), 7 deletions(-) > > > > > > diff --git a/Documentation/process/security-bugs.rst b/Documentation/process/security-bugs.rst > > > index f12ac2316ce7..8b80e1eb7d79 100644 > > > --- a/Documentation/process/security-bugs.rst > > > +++ b/Documentation/process/security-bugs.rst > > > @@ -79,13 +79,10 @@ not contribute to actually fixing any potential security problems. > > > CVE assignment > > > -------------- > > > > > > -The security team does not normally assign CVEs, nor do we require them > > > -for reports or fixes, as this can needlessly complicate the process and > > > -may delay the bug handling. If a reporter wishes to have a CVE identifier > > > -assigned ahead of public disclosure, they will need to contact the private > > > -linux-distros list, described above. When such a CVE identifier is known > > > -before a patch is provided, it is desirable to mention it in the commit > > > -message if the reporter agrees. > > > +The security team does not assign CVEs, nor do we require them for > > > +reports or fixes, as this can needlessly complicate the process and may > > > +delay the bug handling. If a reporter wishes to have a CVE identifier > > > +assigned, they should contact MITRE directly. > > > > Hmm. The language about "assigned ahead of public disclosure" was added > > intentionally due to trouble we'd had with coordination when a CVE was > > needed, etc. Additionally, it IS preferred to have a CVE in a patch when > > it IS known ahead of time, so I think that should be kept. How about > > this: > > > > > > diff --git a/Documentation/process/security-bugs.rst b/Documentation/process/security-bugs.rst > > index 82e29837d589..2f4060d49b31 100644 > > --- a/Documentation/process/security-bugs.rst > > +++ b/Documentation/process/security-bugs.rst > > @@ -81,13 +81,12 @@ the email Subject line with "[vs]" as described in the linux-distros wiki: > > CVE assignment > > -------------- > > > > -The security team does not normally assign CVEs, nor do we require them > > -for reports or fixes, as this can needlessly complicate the process and > > -may delay the bug handling. If a reporter wishes to have a CVE identifier > > -assigned ahead of public disclosure, they will need to contact the private > > -linux-distros list, described above. When such a CVE identifier is known > > -before a patch is provided, it is desirable to mention it in the commit > > -message if the reporter agrees. > > +The security team does not assign CVEs, nor do we require them for reports > > +or fixes, as this can needlessly complicate the process and may delay > > +the bug handling. If a reporter wishes to have a CVE identifier assigned > > +ahead of public disclosure, they will need to contact MITRE directly. > > +When such a CVE identifier is known before a patch is provided, it is > > +desirable to mention it in the commit message if the reporter agrees. > > I can not, in good faith, with the current mess that MITRE is going > through, tell anyone that they should contact MITRE ahead of public > disclosure, sorry. > > All I can say is "if you really want one, go ask them for one", as > everyone keeps asking us for one to pad their resume/CV. > > Also note that many non-US-based companies are not allowed to contact a > US-government-backed entity for potential security issues for obvious > reasons. > > So I don't want to even give a hint that we support or request this at > all, or that it is something that changelog texts should contain for > security issues (for the obvious reason of them being a "hint" one way > or another.) > > External groups may wish to play the CVE "game" as it facilitates their > engineering procedures to get changes past managers, but that's not > anything that we should be encouraging at all for all of the various > geopolitical and corporate reasons involved in that mess. I generally agree with your points above, and these can be easily summarized by indicating that the patch will not wait for this, and suggesting that MITRE is not the only possible source: The security team does not assign CVEs, nor do we require them for reports or fixes, as this can needlessly complicate the process and may delay the bug handling. If a reporter wishes to have a CVE identifier assigned, they should find one by themselves, for example by contacting MITRE directly. However under no circumstances will a patch inclusion be delayed to wait for a CVE identifier to arrive. This puts the responsibility for finding one in time on the reporter depending on what they expect, and if they want it in the commit message, they'd rather have one before reporting the problem. Willy
On Mon, Jul 03, 2023 at 06:08:00AM +0200, Willy Tarreau wrote: > On Sun, Jul 02, 2023 at 02:39:49PM +0200, Greg Kroah-Hartman wrote: > > On Fri, Jun 30, 2023 at 11:18:37AM -0700, Kees Cook wrote: > > > On Fri, Jun 30, 2023 at 09:14:21AM +0200, Greg Kroah-Hartman wrote: > > > > The kernel security team does NOT assign CVEs, so document that properly > > > > and provide the "if you want one, ask MITRE for it" response that we > > > > give on a weekly basis in the document, so we don't have to constantly > > > > say it to everyone who asks. > > > > > > > > Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> > > > > --- > > > > Documentation/process/security-bugs.rst | 11 ++++------- > > > > 1 file changed, 4 insertions(+), 7 deletions(-) > > > > > > > > diff --git a/Documentation/process/security-bugs.rst b/Documentation/process/security-bugs.rst > > > > index f12ac2316ce7..8b80e1eb7d79 100644 > > > > --- a/Documentation/process/security-bugs.rst > > > > +++ b/Documentation/process/security-bugs.rst > > > > @@ -79,13 +79,10 @@ not contribute to actually fixing any potential security problems. > > > > CVE assignment > > > > -------------- > > > > > > > > -The security team does not normally assign CVEs, nor do we require them > > > > -for reports or fixes, as this can needlessly complicate the process and > > > > -may delay the bug handling. If a reporter wishes to have a CVE identifier > > > > -assigned ahead of public disclosure, they will need to contact the private > > > > -linux-distros list, described above. When such a CVE identifier is known > > > > -before a patch is provided, it is desirable to mention it in the commit > > > > -message if the reporter agrees. > > > > +The security team does not assign CVEs, nor do we require them for > > > > +reports or fixes, as this can needlessly complicate the process and may > > > > +delay the bug handling. If a reporter wishes to have a CVE identifier > > > > +assigned, they should contact MITRE directly. > > > > > > Hmm. The language about "assigned ahead of public disclosure" was added > > > intentionally due to trouble we'd had with coordination when a CVE was > > > needed, etc. Additionally, it IS preferred to have a CVE in a patch when > > > it IS known ahead of time, so I think that should be kept. How about > > > this: > > > > > > > > > diff --git a/Documentation/process/security-bugs.rst b/Documentation/process/security-bugs.rst > > > index 82e29837d589..2f4060d49b31 100644 > > > --- a/Documentation/process/security-bugs.rst > > > +++ b/Documentation/process/security-bugs.rst > > > @@ -81,13 +81,12 @@ the email Subject line with "[vs]" as described in the linux-distros wiki: > > > CVE assignment > > > -------------- > > > > > > -The security team does not normally assign CVEs, nor do we require them > > > -for reports or fixes, as this can needlessly complicate the process and > > > -may delay the bug handling. If a reporter wishes to have a CVE identifier > > > -assigned ahead of public disclosure, they will need to contact the private > > > -linux-distros list, described above. When such a CVE identifier is known > > > -before a patch is provided, it is desirable to mention it in the commit > > > -message if the reporter agrees. > > > +The security team does not assign CVEs, nor do we require them for reports > > > +or fixes, as this can needlessly complicate the process and may delay > > > +the bug handling. If a reporter wishes to have a CVE identifier assigned > > > +ahead of public disclosure, they will need to contact MITRE directly. > > > +When such a CVE identifier is known before a patch is provided, it is > > > +desirable to mention it in the commit message if the reporter agrees. > > > > I can not, in good faith, with the current mess that MITRE is going > > through, tell anyone that they should contact MITRE ahead of public > > disclosure, sorry. > > > > All I can say is "if you really want one, go ask them for one", as > > everyone keeps asking us for one to pad their resume/CV. > > > > Also note that many non-US-based companies are not allowed to contact a > > US-government-backed entity for potential security issues for obvious > > reasons. > > > > So I don't want to even give a hint that we support or request this at > > all, or that it is something that changelog texts should contain for > > security issues (for the obvious reason of them being a "hint" one way > > or another.) > > > > External groups may wish to play the CVE "game" as it facilitates their > > engineering procedures to get changes past managers, but that's not > > anything that we should be encouraging at all for all of the various > > geopolitical and corporate reasons involved in that mess. > > I generally agree with your points above, and these can be easily > summarized by indicating that the patch will not wait for this, and > suggesting that MITRE is not the only possible source: > > The security team does not assign CVEs, nor do we require them for > reports or fixes, as this can needlessly complicate the process and may > delay the bug handling. If a reporter wishes to have a CVE identifier > assigned, they should find one by themselves, for example by contacting > MITRE directly. However under no circumstances will a patch inclusion > be delayed to wait for a CVE identifier to arrive. > > This puts the responsibility for finding one in time on the reporter > depending on what they expect, and if they want it in the commit > message, they'd rather have one before reporting the problem. Oh, nice wording, let me steal that! :) thanks, greg k-h
On Mon, Jul 03, 2023 at 05:00:15PM +0200, Greg Kroah-Hartman wrote: > On Mon, Jul 03, 2023 at 06:08:00AM +0200, Willy Tarreau wrote: > > The security team does not assign CVEs, nor do we require them for > > reports or fixes, as this can needlessly complicate the process and may > > delay the bug handling. If a reporter wishes to have a CVE identifier > > assigned, they should find one by themselves, for example by contacting > > MITRE directly. However under no circumstances will a patch inclusion > > be delayed to wait for a CVE identifier to arrive. > > > > This puts the responsibility for finding one in time on the reporter > > depending on what they expect, and if they want it in the commit > > message, they'd rather have one before reporting the problem. > > Oh, nice wording, let me steal that! :) Yeah, this is good. The last sentence is a little hard to parse, so how about this, with a little more rationale expansion: However under no circumstances will patch publication be delayed for CVE identifier assignment. Getting fixes landed takes precedence; the CVE database entry will already reference the commit, so there is no loss of information if the CVE is assigned later. -Kees
On Mon, Jul 03, 2023 at 11:35:37AM -0700, Kees Cook wrote: > On Mon, Jul 03, 2023 at 05:00:15PM +0200, Greg Kroah-Hartman wrote: > > On Mon, Jul 03, 2023 at 06:08:00AM +0200, Willy Tarreau wrote: > > > The security team does not assign CVEs, nor do we require them for > > > reports or fixes, as this can needlessly complicate the process and may > > > delay the bug handling. If a reporter wishes to have a CVE identifier > > > assigned, they should find one by themselves, for example by contacting > > > MITRE directly. However under no circumstances will a patch inclusion > > > be delayed to wait for a CVE identifier to arrive. > > > > > > This puts the responsibility for finding one in time on the reporter > > > depending on what they expect, and if they want it in the commit > > > message, they'd rather have one before reporting the problem. > > > > Oh, nice wording, let me steal that! :) > > Yeah, this is good. The last sentence is a little hard to parse, so how > about this, with a little more rationale expansion: > > However under no circumstances will patch publication be delayed for > CVE identifier assignment. Getting fixes landed takes precedence; the > CVE database entry will already reference the commit, so there is no loss > of information if the CVE is assigned later. "simple is better" should be the key here, reading a wall of text is hard for people, so let me just keep the one new sentance that Willy proposed and if people still struggle with the whole CVEs and security@k.o mess in the future, we can revise it again. Also, there is not really a "CVE database", I think that's what NVD from NIST does and CNNVD from China does, and "Something to be named in the future soon" will do for the EU. There is a "CVE List" at cve.org, but that thing is always out of date, and for all of this I don't want to have to try to explain it in our document as that's nothing we want to mess with :) thanks, greg k-h
On Mon, Jul 03, 2023 at 09:05:15PM +0200, Greg Kroah-Hartman wrote: > On Mon, Jul 03, 2023 at 11:35:37AM -0700, Kees Cook wrote: > > On Mon, Jul 03, 2023 at 05:00:15PM +0200, Greg Kroah-Hartman wrote: > > > On Mon, Jul 03, 2023 at 06:08:00AM +0200, Willy Tarreau wrote: > > > > The security team does not assign CVEs, nor do we require them for > > > > reports or fixes, as this can needlessly complicate the process and may > > > > delay the bug handling. If a reporter wishes to have a CVE identifier > > > > assigned, they should find one by themselves, for example by contacting > > > > MITRE directly. However under no circumstances will a patch inclusion > > > > be delayed to wait for a CVE identifier to arrive. > > > > > > > > This puts the responsibility for finding one in time on the reporter > > > > depending on what they expect, and if they want it in the commit > > > > message, they'd rather have one before reporting the problem. > > > > > > Oh, nice wording, let me steal that! :) > > > > Yeah, this is good. The last sentence is a little hard to parse, so how > > about this, with a little more rationale expansion: > > > > However under no circumstances will patch publication be delayed for > > CVE identifier assignment. Getting fixes landed takes precedence; the > > CVE database entry will already reference the commit, so there is no loss > > of information if the CVE is assigned later. > > "simple is better" should be the key here, reading a wall of text is > hard for people, so let me just keep the one new sentance that Willy > proposed and if people still struggle with the whole CVEs and > security@k.o mess in the future, we can revise it again. > > Also, there is not really a "CVE database", I think that's what NVD from > NIST does and CNNVD from China does, and "Something to be named in the > future soon" will do for the EU. There is a "CVE List" at cve.org, but > that thing is always out of date, and for all of this I don't want to > have to try to explain it in our document as that's nothing we want to > mess with :) Okay, fair, though please include something about it in the commit log so that other folks with concerns similar to Mathias Krause's will be answered: https://infosec.exchange/@minipli/110632971830936754 I still think this version of the sentence is more readable: However under no circumstances will patch publication be delayed for CVE identifier assignment. "patch inclusion" is less clear to me that "publication", and "be delayed to wait for" is redundant: a delay is a wait, and "to arrive" is just the assignment, which is the subject of the paragraph, so better to keep the language for that consistent. -Kees
On Mon, Jul 03, 2023 at 12:26:32PM -0700, Kees Cook wrote: > I still think this version of the sentence is more readable: > > However under no circumstances will patch publication be delayed for > CVE identifier assignment. > > "patch inclusion" is less clear to me that "publication", and "be > delayed to wait for" is redundant: a delay is a wait, and "to arrive" > is just the assignment, which is the subject of the paragraph, so better > to keep the language for that consistent. I agree, I find it better as well :-) Thanks, Willy
diff --git a/Documentation/process/security-bugs.rst b/Documentation/process/security-bugs.rst index f12ac2316ce7..8b80e1eb7d79 100644 --- a/Documentation/process/security-bugs.rst +++ b/Documentation/process/security-bugs.rst @@ -79,13 +79,10 @@ not contribute to actually fixing any potential security problems. CVE assignment -------------- -The security team does not normally assign CVEs, nor do we require them -for reports or fixes, as this can needlessly complicate the process and -may delay the bug handling. If a reporter wishes to have a CVE identifier -assigned ahead of public disclosure, they will need to contact the private -linux-distros list, described above. When such a CVE identifier is known -before a patch is provided, it is desirable to mention it in the commit -message if the reporter agrees. +The security team does not assign CVEs, nor do we require them for +reports or fixes, as this can needlessly complicate the process and may +delay the bug handling. If a reporter wishes to have a CVE identifier +assigned, they should contact MITRE directly. Non-disclosure agreements -------------------------