diff mbox series

[v12,01/10] cpufreq: blacklist MSM8998 in cpufreq-dt-platdev

Message ID 20230217-topic-cpr3h-v12-1-1a4d050e1e67@linaro.org
State New
Headers
Series (no cover subject) |

Commit Message

Konrad Dybcio June 28, 2023, 2 p.m. UTC 
  From: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>

Add the MSM8998 to the blacklist since the CPU scaling is handled
out of this.

Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 drivers/cpufreq/cpufreq-dt-platdev.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Rob Herring June 28, 2023, 3:56 p.m. UTC | #1 
On Wed, Jun 28, 2023 at 04:00:40PM +0200, Konrad Dybcio wrote:
> From: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> 
> Add the MSM8998 to the blacklist since the CPU scaling is handled

s/blacklist/denylist/ or s/blacklist/blocklist/

> out of this.
> 
> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
> ---
>  drivers/cpufreq/cpufreq-dt-platdev.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
> index e2b20080de3a..adb3579a1fee 100644
> --- a/drivers/cpufreq/cpufreq-dt-platdev.c
> +++ b/drivers/cpufreq/cpufreq-dt-platdev.c
> @@ -143,6 +143,7 @@ static const struct of_device_id blocklist[] __initconst = {
>  
>  	{ .compatible = "qcom,apq8096", },
>  	{ .compatible = "qcom,msm8996", },
> +	{ .compatible = "qcom,msm8998", },
>  	{ .compatible = "qcom,qcs404", },
>  	{ .compatible = "qcom,sa8155p" },
>  	{ .compatible = "qcom,sa8540p" },
> 
> -- 
> 2.41.0
>
Viresh Kumar July 3, 2023, 4:17 a.m. UTC | #2 
On 28-06-23, 09:56, Rob Herring wrote:
> On Wed, Jun 28, 2023 at 04:00:40PM +0200, Konrad Dybcio wrote:
> > From: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> > 
> > Add the MSM8998 to the blacklist since the CPU scaling is handled
> 
> s/blacklist/denylist/ or s/blacklist/blocklist/

They are already named allowlist and blocklist.

> > @@ -143,6 +143,7 @@ static const struct of_device_id blocklist[] __initconst = {
Krzysztof Kozlowski July 4, 2023, 8:06 a.m. UTC | #3 
On 28/06/2023 16:00, Konrad Dybcio wrote:
> From: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> 
> Add the MSM8998 to the blacklist since the CPU scaling is handled

It is "blocklist", not "blacklist" (both in commit msg and subject).



Best regards,
Krzysztof
Krzysztof Kozlowski July 4, 2023, 8:07 a.m. UTC | #4 
On 03/07/2023 06:17, Viresh Kumar wrote:
> On 28-06-23, 09:56, Rob Herring wrote:
>> On Wed, Jun 28, 2023 at 04:00:40PM +0200, Konrad Dybcio wrote:
>>> From: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
>>>
>>> Add the MSM8998 to the blacklist since the CPU scaling is handled
>>
>> s/blacklist/denylist/ or s/blacklist/blocklist/
> 
> They are already named allowlist and blocklist.

This was about commit msg and subject. They are not named like this.

Best regards,
Krzysztof
Viresh Kumar July 4, 2023, 9:21 a.m. UTC | #5 
On 04-07-23, 10:07, Krzysztof Kozlowski wrote:
> On 03/07/2023 06:17, Viresh Kumar wrote:
> > On 28-06-23, 09:56, Rob Herring wrote:
> >> On Wed, Jun 28, 2023 at 04:00:40PM +0200, Konrad Dybcio wrote:
> >>> From: AngeloGioacchino Del Regno <angelogioacchino.delregno@somainline.org>
> >>>
> >>> Add the MSM8998 to the blacklist since the CPU scaling is handled
> >>
> >> s/blacklist/denylist/ or s/blacklist/blocklist/
> > 
> > They are already named allowlist and blocklist.
> 
> This was about commit msg and subject. They are not named like this.

Yeah, I was just saying we have proper names in the code and they must be used
here in commit.  Sorry for not being clear earlier :)
diff mbox series

Patch

diff --git a/drivers/cpufreq/cpufreq-dt-platdev.c b/drivers/cpufreq/cpufreq-dt-platdev.c
index e2b20080de3a..adb3579a1fee 100644
--- a/drivers/cpufreq/cpufreq-dt-platdev.c
+++ b/drivers/cpufreq/cpufreq-dt-platdev.c
@@ -143,6 +143,7 @@  static const struct of_device_id blocklist[] __initconst = {
 
 	{ .compatible = "qcom,apq8096", },
 	{ .compatible = "qcom,msm8996", },
+	{ .compatible = "qcom,msm8998", },
 	{ .compatible = "qcom,qcs404", },
 	{ .compatible = "qcom,sa8155p" },
 	{ .compatible = "qcom,sa8540p" },