| Message ID | 20230701054714.30512-1-rdunlap@infradead.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp10858417vqr;
Fri, 30 Jun 2023 23:16:01 -0700 (PDT)
X-Google-Smtp-Source:
APBJJlGhrvnot2bh3nqwqO4cjMQSu0d3Ysudu4X1Lfd2y4SGqXPzBiStAAFNT7uV4Rtjcaal6+PQ
X-Received: by 2002:a05:6870:4993:b0:1a0:2fd5:150e with SMTP id
ho19-20020a056870499300b001a02fd5150emr6110896oab.48.1688192161473;
Fri, 30 Jun 2023 23:16:01 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1688192161; cv=none;
d=google.com; s=arc-20160816;
b=aXNk2evWrV9m81mb0XKKyknTJUXpRMsVD/kTVRuPkdPqJ8dBLpmAjYgP7cIqMJK4bL
ATOXQ22SWOUbTGjMLvN3veTnLLwC/Mr77Wfyw+NM5HJbpNF2EiEDdJ2+jOVRXdkwMw2X
mT7GrnnIKAbfd0Ej8LlUxMtsD+xTFbra+rcjf5XP8SXGVVnJSJm0JggjvNsj5kfSD0iX
5rNOkqfXYqmtTPYCh8FEDtBBI/P1Z/Vwekz3eT2sWY5mm0NrR8z2v4T+FBtx52uht+dn
Y3SPHhySqhTl3OpeEobNgL2QZ/xaibyQ2zil3t2yQBu0U727FCYYIhEI3g57EDUuzD9Y
rSGg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=8RecPPsiSTWBxpWdpzI5Sl/AYU7LBN8bZWqUZfNxw00=;
fh=BZBYumpHHsfane6a1QErVXuglKnSK2z6fDrg5UIisfs=;
b=nwC8Qny4dtony+A830YxYss3PlowkSwX++cJJHc3O6v07RCp14zVbBFiU1zWGBJvOo
yshJ4SWSXiMn3oH232tHG8ShxSaaGLZZLNgmUl39kqpBrBp9rrc04xthurGUZKbN4v8a
uAVEhJVJyR6dNr3arNE1NdW5RpVWZF4BrC5flOhFaOXRGRXd5IekfQ+Jtb0FcAoVbd08
3eQkoFsFDyYqPTm6I9xEzRoR01a6pPHGK+6etWd+AOx0TPhel4S5r0fHMNWzKClK8JCd
/uO3AILCPhRZEHAlN5A0FrCpRG/VrH+dbM+ghBiDvRca0d+DPHGaeDa962cHqWY9DdVD
Ne2Q==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@infradead.org header.s=bombadil.20210309
header.b=B7zw9yit;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
2-20020a631642000000b005133c334fe9si13897105pgw.847.2023.06.30.23.15.43;
Fri, 30 Jun 2023 23:16:01 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@infradead.org header.s=bombadil.20210309
header.b=B7zw9yit;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S229643AbjGAFrV (ORCPT <rfc822;nicolai.engesland@gmail.com>
+ 99 others); Sat, 1 Jul 2023 01:47:21 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34882 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229490AbjGAFrR (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Sat, 1 Jul 2023 01:47:17 -0400
Received: from bombadil.infradead.org (bombadil.infradead.org
[IPv6:2607:7c80:54:3::133])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EA148B7
for <linux-kernel@vger.kernel.org>;
Fri, 30 Jun 2023 22:47:15 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding:
Content-Type:MIME-Version:Message-ID:Date:Subject:Cc:To:From:Sender:Reply-To:
Content-ID:Content-Description:In-Reply-To:References;
bh=8RecPPsiSTWBxpWdpzI5Sl/AYU7LBN8bZWqUZfNxw00=;
b=B7zw9yitHEQTmDn2kjTgWPrHOh
WPMiXKAvJiw89W5PVFiIWljU0g7oQmHwQ/1zQOQbFc2feJyCz9x3egbwTkathgRDkXfEJfLwZp8xz
sV35J02ktnzA0LjbkTmLeZFhhUWWFZ25f+cKB2mmqnfc1tbuhEn0ZHHbcf77wupPqH6B9hVpCvcJ0
2PVs7pDJR5yKjw/Or8Hmz5YGk1TyNYyRxan6vJpx8QcVMudlOfaF+4Gvva1wFZdAHoJjN1pys7PQx
VaSyTwf3Xkmi7FnI1G7miGTzb4a0Juf5DhX6/x9JUfWBfA5C3CmFeFbvKFrHuOPyvDEx/fr/PUgPl
xZba4xhg==;
Received: from [2601:1c2:980:9ec0::2764] (helo=bombadil.infradead.org)
by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux))
id 1qFTRz-005E95-1c;
Sat, 01 Jul 2023 05:47:15 +0000
From: Randy Dunlap <rdunlap@infradead.org>
To: linux-kernel@vger.kernel.org
Cc: Randy Dunlap <rdunlap@infradead.org>,
Kumar Gala <galak@kernel.crashing.org>,
=?utf-8?q?Pali_Roh=C3=A1r?= <pali@kernel.org>,
Michael Ellerman <mpe@ellerman.id.au>, Nicholas Piggin <npiggin@gmail.com>,
Christophe Leroy <christophe.leroy@csgroup.eu>, linuxppc-dev@lists.ozlabs.org
Subject: [PATCH v2] powerpc: allow PPC_EARLY_DEBUG_CPM only when SERIAL_CPM=y
Date: Fri, 30 Jun 2023 22:47:12 -0700
Message-ID: <20230701054714.30512-1-rdunlap@infradead.org>
X-Mailer: git-send-email 2.41.0
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE,
SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1766065391718926284?=
X-GMAIL-MSGID: =?utf-8?q?1770197783946570231?=
|
| Series |
[v2] powerpc: allow PPC_EARLY_DEBUG_CPM only when SERIAL_CPM=y
|
|
Commit Message
Randy Dunlap
July 1, 2023, 5:47 a.m. UTC
In a randconfig with CONFIG_SERIAL_CPM=m and
CONFIG_PPC_EARLY_DEBUG_CPM=y, there is a build error:
ERROR: modpost: "udbg_putc" [drivers/tty/serial/cpm_uart/cpm_uart.ko] undefined!
Prevent the build error by allowing PPC_EARLY_DEBUG_CPM only when
SERIAL_CPM=y.
Fixes: c374e00e17f1 ("[POWERPC] Add early debug console for CPM serial ports.")
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Cc: Kumar Gala <galak@kernel.crashing.org>
Cc: "Pali Rohár" <pali@kernel.org>
Cc: Michael Ellerman <mpe@ellerman.id.au>
Cc: Nicholas Piggin <npiggin@gmail.com>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: linuxppc-dev@lists.ozlabs.org
Reviewed-by: Pali Rohár <pali@kernel.org>
---
v2: add Pali's R-b;
drop Scott Wood from Cc: list
arch/powerpc/Kconfig.debug | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
Le 01/07/2023 à 07:47, Randy Dunlap a écrit : > In a randconfig with CONFIG_SERIAL_CPM=m and > CONFIG_PPC_EARLY_DEBUG_CPM=y, there is a build error: > ERROR: modpost: "udbg_putc" [drivers/tty/serial/cpm_uart/cpm_uart.ko] undefined! > > Prevent the build error by allowing PPC_EARLY_DEBUG_CPM only when > SERIAL_CPM=y. > > Fixes: c374e00e17f1 ("[POWERPC] Add early debug console for CPM serial ports.") > Signed-off-by: Randy Dunlap <rdunlap@infradead.org> > Cc: Kumar Gala <galak@kernel.crashing.org> > Cc: "Pali Rohár" <pali@kernel.org> > Cc: Michael Ellerman <mpe@ellerman.id.au> > Cc: Nicholas Piggin <npiggin@gmail.com> > Cc: Christophe Leroy <christophe.leroy@csgroup.eu> > Cc: linuxppc-dev@lists.ozlabs.org > Reviewed-by: Pali Rohár <pali@kernel.org> Reviewed-by: Christophe Leroy <christophe.leroy@csgroup.eu> > --- > v2: add Pali's R-b; > drop Scott Wood from Cc: list > > arch/powerpc/Kconfig.debug | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff -- a/arch/powerpc/Kconfig.debug b/arch/powerpc/Kconfig.debug > --- a/arch/powerpc/Kconfig.debug > +++ b/arch/powerpc/Kconfig.debug > @@ -240,7 +240,7 @@ config PPC_EARLY_DEBUG_40x > > config PPC_EARLY_DEBUG_CPM > bool "Early serial debugging for Freescale CPM-based serial ports" > - depends on SERIAL_CPM > + depends on SERIAL_CPM=y > help > Select this to enable early debugging for Freescale chips > using a CPM-based serial port. This assumes that the bootwrapper
diff -- a/arch/powerpc/Kconfig.debug b/arch/powerpc/Kconfig.debug --- a/arch/powerpc/Kconfig.debug +++ b/arch/powerpc/Kconfig.debug @@ -240,7 +240,7 @@ config PPC_EARLY_DEBUG_40x config PPC_EARLY_DEBUG_CPM bool "Early serial debugging for Freescale CPM-based serial ports" - depends on SERIAL_CPM + depends on SERIAL_CPM=y help Select this to enable early debugging for Freescale chips using a CPM-based serial port. This assumes that the bootwrapper