Message ID | 20221026163646.37433-1-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp373862wru; Wed, 26 Oct 2022 09:43:49 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5HTqV7ZCdew+5oOqPPvuMQR3eHyVkDKRUS991HPjbMtCN2IwT22fxzr66HoopZtbRVs3bB X-Received: by 2002:a17:906:7308:b0:78e:191e:8389 with SMTP id di8-20020a170906730800b0078e191e8389mr38447417ejc.170.1666802618386; Wed, 26 Oct 2022 09:43:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666802618; cv=none; d=google.com; s=arc-20160816; b=RZSM5MPpqB981iVE7HH7D5fBN7du+JVvYfum6zG1Pwt+n4X3y0yLSSjFB16iZr54BY 7UL23IhHoIjGbRhKP0A9O9Lhk+Hh4v7/L0tofnvNiyitvLEcw0eOYLWT6suD05p7g3Se TSfE0lJActLQsfbpmV26SZ0vDC6KiHMSCorJDXbc889Wc/tFmemQYobeo9QhrqpnVVsn 4JZLUAmYG6abAiDeMD+I0EXDm82xCnN7D+UieEdIdYv7g7J5AFyQxlqIj7ib7DZVGscf iM8SqvxYJDrTNdSKnBhO1VlqKj46W80HdW3xV7hFpUfwFKVGGOHzccgZ17gIW8LwCNY/ byOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=+O6n1+4Noo4lqABNPcNmHpEdPhT1c2lxt97PdSfadgg=; b=KZ4G8EKItefJJuXpKqG6TxfNbkJ9cVGr8inyIl+gptV6QdAugSsWm4FEc/xIZ3sceD MYEjeKJqIBWfFaj0ReFbwdhyO8WO0m4B3dq6uTgUN0uTI2zkJRO5RJzaf1rcCahtbyBS NxDJLaYshEcgeXPID/CPwxX9I1UnmMNLVIjy/Phg2Fe5/LuglPX9Q4+sml4M14EXkfzo 5k4jlnPkh7o5kfRgrXlci/TQ8REgpFbxT9PKpyt1trBj7BYeUMxtLS2F+igyDFrxLjlH 5rebaITQhCTNmG/JoRcB3ja2r1xHlApsuUUhYU6++S7ttCBbfj4H7cBXtBzzYcBDW3Tm gglw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lGZQfp2o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id v14-20020a056402348e00b00461cb15df6dsi6961951edc.297.2022.10.26.09.43.11; Wed, 26 Oct 2022 09:43:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=lGZQfp2o; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233640AbiJZQgy (ORCPT <rfc822;pwkd43@gmail.com> + 99 others); Wed, 26 Oct 2022 12:36:54 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233460AbiJZQgw (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 26 Oct 2022 12:36:52 -0400 Received: from mail-qt1-x82c.google.com (mail-qt1-x82c.google.com [IPv6:2607:f8b0:4864:20::82c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BAE74AC2A1 for <linux-kernel@vger.kernel.org>; Wed, 26 Oct 2022 09:36:50 -0700 (PDT) Received: by mail-qt1-x82c.google.com with SMTP id hh9so10291318qtb.13 for <linux-kernel@vger.kernel.org>; Wed, 26 Oct 2022 09:36:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=+O6n1+4Noo4lqABNPcNmHpEdPhT1c2lxt97PdSfadgg=; b=lGZQfp2ouRZjOccXJJKrtcDtmvCxmhC4VwWrnGQrDqBqrTinjAK6oSLGGSKU6q8NI/ D7AkuJQCXxocXdMVUUSeCISSv0e3oMPgAZL3KbzSK3meS7rHCEBrqX0PmzNkRbv8v89v p2vZwwfodQZ2d/Ts5lq/OXwA0sYsYzTHtHZGPWZ8JnhsLjaBOJpx7B+V4bfQFaeBKRSx Hie6MX+Yvs4Fh9OaK2crkRH8Gs6ikBmlJF2vimFXoAvllkLUe6EIjzbI+1FOH+Pbzu9a vb92LPjLoOnXkV122OYrqkjywxDS1AR/kcs0hysf7a0qogvWKgBwPNSSYV6YIwLCxcFY 8LEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=+O6n1+4Noo4lqABNPcNmHpEdPhT1c2lxt97PdSfadgg=; b=SyOvC7zucQydTeZEw3zAKnnsoAPlARAvgUEkX6oV8zwMFC2FMUbzQV8W7Kf7i04v5I fm8iP7O5JuyO93IMXLxEYxQx9JJ2oVmBgnM1xmxEg9ZjyNyZgQee6OxIIErQish40MTl 7qXuK9TfX6p0+B0hf83RcZ4m8PsLD2hzybBe5KGTv+M26nRgGS/mPJOkWOpaN2Evxvhd ZITg6WsZdrA3ZJsEc2XIA06qjpDN9tUtQO4/8+nXIm+2iBihTmlGxzKK6LWxfxnP/3Bj nsWrQlaBmjQxV/6nCy44edGDaVvp/kZV2vihvg6SE4pca7isA4enFwBJTMUVlNy+qfKL bfVQ== X-Gm-Message-State: ACrzQf0CH6fgsWWdgCfo31Am+N9N6E4MuPIawgVkZwTvp8mbf/7DVLat wLuOS8XSBmk8/XKcGXLg+DCSDw== X-Received: by 2002:a05:622a:5cb:b0:39c:fb06:5f6c with SMTP id d11-20020a05622a05cb00b0039cfb065f6cmr34629412qtb.474.1666802209719; Wed, 26 Oct 2022 09:36:49 -0700 (PDT) Received: from krzk-bin.. ([64.57.193.93]) by smtp.gmail.com with ESMTPSA id w8-20020a05620a424800b006b949afa980sm4161223qko.56.2022.10.26.09.36.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Oct 2022 09:36:48 -0700 (PDT) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@somainline.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Martin Botka <martin.botka@somainline.org>, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Subject: [RESEND PATCH] arm64: dts: qcom: sm6125: fix SDHCI CQE reg names Date: Wed, 26 Oct 2022 12:36:46 -0400 Message-Id: <20221026163646.37433-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747769222850846957?= X-GMAIL-MSGID: =?utf-8?q?1747769222850846957?= |
Series |
[RESEND] arm64: dts: qcom: sm6125: fix SDHCI CQE reg names
|
|
Commit Message
Krzysztof Kozlowski
Oct. 26, 2022, 4:36 p.m. UTC
SM6125 comes with SDCC (SDHCI controller) v5, so the second range of
registers is cqhci, not core.
Fixes: cff4bbaf2a2d ("arm64: dts: qcom: Add support for SM6125")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Not tested on hardware, but no practical impact is expected, because
supports-cqe is not defined.
---
arch/arm64/boot/dts/qcom/sm6125.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On 2022-10-26 12:36:46, Krzysztof Kozlowski wrote: > SM6125 comes with SDCC (SDHCI controller) v5, so the second range of > registers is cqhci, not core. > > Fixes: cff4bbaf2a2d ("arm64: dts: qcom: Add support for SM6125") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Not tested on hardware, but no practical impact is expected, because > supports-cqe is not defined. Thanks for this! According to my downstream sources this reg is called cmdq_mem, that's not core indeed. Reviewed-by: Marijn Suijten <marijn.suijten@somainline.org> Tested-by: Marijn Suijten <marijn.suijten@somainline.org> # Sony Xperia 10 II And also according to my downstream sources, this SoC should support it. When adding supports-cqe _together with your patch_: [ 0.391950] sdhci_msm 4744000.mmc: mmc0: CQE init: success I'll send a followup to that effect. Thanks again for bringing this to my attention! - Marijn > --- > arch/arm64/boot/dts/qcom/sm6125.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qcom/sm6125.dtsi > index af49a748e511..24ee7c0c1195 100644 > --- a/arch/arm64/boot/dts/qcom/sm6125.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi > @@ -458,7 +458,7 @@ rpm_msg_ram: sram@45f0000 { > sdhc_1: mmc@4744000 { > compatible = "qcom,sm6125-sdhci", "qcom,sdhci-msm-v5"; > reg = <0x04744000 0x1000>, <0x04745000 0x1000>; > - reg-names = "hc", "core"; > + reg-names = "hc", "cqhci"; > > interrupts = <GIC_SPI 348 IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 352 IRQ_TYPE_LEVEL_HIGH>; > -- > 2.34.1 >
On Wed, 26 Oct 2022 12:36:46 -0400, Krzysztof Kozlowski wrote: > SM6125 comes with SDCC (SDHCI controller) v5, so the second range of > registers is cqhci, not core. > > Applied, thanks! [1/1] arm64: dts: qcom: sm6125: fix SDHCI CQE reg names commit: 3de1172624b3c4ca65730bc34333ab493510b3e1 Best regards,
diff --git a/arch/arm64/boot/dts/qcom/sm6125.dtsi b/arch/arm64/boot/dts/qcom/sm6125.dtsi index af49a748e511..24ee7c0c1195 100644 --- a/arch/arm64/boot/dts/qcom/sm6125.dtsi +++ b/arch/arm64/boot/dts/qcom/sm6125.dtsi @@ -458,7 +458,7 @@ rpm_msg_ram: sram@45f0000 { sdhc_1: mmc@4744000 { compatible = "qcom,sm6125-sdhci", "qcom,sdhci-msm-v5"; reg = <0x04744000 0x1000>, <0x04745000 0x1000>; - reg-names = "hc", "core"; + reg-names = "hc", "cqhci"; interrupts = <GIC_SPI 348 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 352 IRQ_TYPE_LEVEL_HIGH>;