diff mbox series

arm64: dts: qcom: Remove fingerprint node from herobrine-r1

Message ID 20221025180703.1806234-1-swboyd@chromium.org
State New
Headers
Series arm64: dts: qcom: Remove fingerprint node from herobrine-r1 |

Commit Message

Stephen Boyd Oct. 25, 2022, 6:07 p.m. UTC 
  It turns out that only a few people have the fingerprint sensor hooked
up on their board. Leaving this enabled is slowing down boot for
everyone else because the driver slowly fails to probe while trying to
communicate with a sensor that isn't there. Remove the node to speed up
boot, developers with the board can manually enable it themselves.

Reported-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Stephen Boyd <swboyd@chromium.org>
---
 arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dts | 4 ----
 1 file changed, 4 deletions(-)


base-commit: 9abf2313adc1ca1b6180c508c25f22f9395cc780

Comments

Doug Anderson Oct. 25, 2022, 7:39 p.m. UTC | #1 
Hi,

On Tue, Oct 25, 2022 at 11:07 AM Stephen Boyd <swboyd@chromium.org> wrote:
>
> It turns out that only a few people have the fingerprint sensor hooked
> up on their board. Leaving this enabled is slowing down boot for
> everyone else because the driver slowly fails to probe while trying to
> communicate with a sensor that isn't there. Remove the node to speed up
> boot, developers with the board can manually enable it themselves.
>
> Reported-by: Douglas Anderson <dianders@chromium.org>
> Signed-off-by: Stephen Boyd <swboyd@chromium.org>
> ---
>  arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dts | 4 ----
>  1 file changed, 4 deletions(-)

Reviewed-by: Douglas Anderson <dianders@chromium.org>
Bjorn Andersson Nov. 8, 2022, 1:27 a.m. UTC | #2 
On Tue, 25 Oct 2022 11:07:03 -0700, Stephen Boyd wrote:
> It turns out that only a few people have the fingerprint sensor hooked
> up on their board. Leaving this enabled is slowing down boot for
> everyone else because the driver slowly fails to probe while trying to
> communicate with a sensor that isn't there. Remove the node to speed up
> boot, developers with the board can manually enable it themselves.
> 
> 
> [...]

Applied, thanks!

[1/1] arm64: dts: qcom: Remove fingerprint node from herobrine-r1
      commit: a35ef6df1e61cba41a5266303f6a493d1a71b06b

Best regards,
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dts b/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dts
index c1a671968725..8d07401d852d 100644
--- a/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dts
+++ b/arch/arm64/boot/dts/qcom/sc7280-herobrine-herobrine-r1.dts
@@ -47,10 +47,6 @@  &pp1200_wf_cam {
 
 /* ADDITIONS TO NODES DEFINED IN PARENT DEVICE TREE FILES */
 
-&ap_spi_fp {
-	status = "okay";
-};
-
 /*
  * Although the trackpad is really part of the herobrine baseboard, we'll
  * put the actual definition in the board device tree since different boards