Message ID | 20230629104603.88612-2-andriy.shevchenko@linux.intel.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp9546853vqr; Thu, 29 Jun 2023 03:55:47 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ54Cyjd2r4HDaZ2TVgbf1pspAt+DytayXk7BFQjoZYuAhlPtnAebAooQcFkpQQkROW8AuVz X-Received: by 2002:a05:6a00:4212:b0:675:8521:ddc7 with SMTP id cd18-20020a056a00421200b006758521ddc7mr13553839pfb.0.1688036147028; Thu, 29 Jun 2023 03:55:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1688036147; cv=none; d=google.com; s=arc-20160816; b=bHjBOQvQc6rMbBO6+sFCemgN2pjmUmeG/fS3lYcnGaAsiZLVNVZHAqCHtyiyR4LFrj iibEh7+BeuFhPCiS8/YKQjPaN9adxDcFZ27VX3BQMXadF6J5rbb1n6V78iFuuRqRDQYf vRgmH5Dwoj2MauaRW3KZ8pLtoRwKVR4RZXUzYGIes4oa+8Yh6j+ZI30rj4yjBHJVyxQE OFKCJM5QSSXWHwgJITYMUZHMXX4Xwz8hYyZzNt30ck5yxS8UC31FKaMnb+Qnw1yDENul qssbeFYHqBTQ5fn5LtqpmnrduXBmNKdEsKp5ldfaE0/JawdMNudiGbxlKvke0rpZh02e slHQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=6cprKQ1367EhDYTDQtadflGuFbMs4HFGfkCKsSDHkN0=; fh=24Z9D4DUVobL/KCVNZ58EGolLoePZ94P995JhaeZ02Y=; b=XZ4sH5uI516W/JKp5a6IiwH+MBCmOfJh0Ha55NoguujBjvWO39t/5HFJHN42Cvx54Y GBNP2RCeP7wA8o9zDzJFuyJBzv3lNW1KY3I7kBS9Uw4lAPKhS0Rr8fpERPQorlIRwNe/ STAYYRRQQLCjvaFBioZZdhuJedCZntJiGSxo2bYKY86Iej+OcAIFYGCwvcNQpBg9tiUL K2yiO4xb1NQp7zCzJPcn/MeMiHRq4lXeeMdMh6KT1EFHPsp8k0dz0Lwf0BYoPUiibojI FywQ6nb15S9EyNUNNypLAJ1rBMkbyEK8Aq7LAYWq5O0AMIeitKUjm/O9333ShO69qG0H b3zA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=bNVosmNq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id q16-20020a056a00151000b006535a72d26csi3064179pfu.152.2023.06.29.03.55.32; Thu, 29 Jun 2023 03:55:47 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=bNVosmNq; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231918AbjF2KqL (ORCPT <rfc822;ivan.orlov0322@gmail.com> + 99 others); Thu, 29 Jun 2023 06:46:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56974 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229920AbjF2KqI (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 29 Jun 2023 06:46:08 -0400 Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D707B1FCB for <linux-kernel@vger.kernel.org>; Thu, 29 Jun 2023 03:46:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1688035567; x=1719571567; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=fwk5ABF4qGgGMZxv66u4XmVNCk/M9YuiuP7nMBK9Mn8=; b=bNVosmNqd1Wknzc1QymXdOhHlpgy5Akv2Xg4c1rIgSqGbM5RK5QvqlC5 vQNLDCQ86a8sy7DRosEpOUKDl1AtSbb+Koie6rR2FZnCs0Qu71AgJUGOq 1wrplvnY6K9iHDMDzpcIhxTtDGjRw/4on+6/DQ/z5zlIDH4FBrK0Pyg5B wpGCDFLIzLmLL9z9bQW9jNf9dB9Ke2jJX9OJv9CJGRMvLaHj0PdwBLKE3 3OsHZnbzcDJrn8GI7C6SDxPAbJo7SUNQaweDKjbY6Mi+O6v+29DyJmhJT PNcBqeuxJ2IA57NLjFE92eeQ88Nh88V6EJ2qhXI8K7y9aXpkxnO1Q5YK+ w==; X-IronPort-AV: E=McAfee;i="6600,9927,10755"; a="362115067" X-IronPort-AV: E=Sophos;i="6.01,168,1684825200"; d="scan'208";a="362115067" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Jun 2023 03:46:06 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10755"; a="963948380" X-IronPort-AV: E=Sophos;i="6.01,168,1684825200"; d="scan'208";a="963948380" Received: from black.fi.intel.com ([10.237.72.28]) by fmsmga006.fm.intel.com with ESMTP; 29 Jun 2023 03:46:04 -0700 Received: by black.fi.intel.com (Postfix, from userid 1003) id B8F06204; Thu, 29 Jun 2023 13:46:05 +0300 (EEST) From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org Cc: Oder Chiou <oder_chiou@realtek.com>, Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com> Subject: [PATCH v1 1/3] ASoC: rt5677: Use agnostic irq_domain_create_linear() Date: Thu, 29 Jun 2023 13:46:01 +0300 Message-Id: <20230629104603.88612-2-andriy.shevchenko@linux.intel.com> X-Mailer: git-send-email 2.40.0.1.gaa8946217a0b In-Reply-To: <20230629104603.88612-1-andriy.shevchenko@linux.intel.com> References: <20230629104603.88612-1-andriy.shevchenko@linux.intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,SPF_HELO_NONE, SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1770034190833250098?= X-GMAIL-MSGID: =?utf-8?q?1770034190833250098?= |
Series |
ASoC: rt5677: Refactor to use device_get_match_data()
|
|
Commit Message
Andy Shevchenko
June 29, 2023, 10:46 a.m. UTC
Instead of irq_domain_add_linear() that requires of_node,
use irq_domain_create_linear() that works outside of OF world.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
sound/soc/codecs/rt5677.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Thu, Jun 29, 2023 at 01:46:01PM +0300, Andy Shevchenko wrote: > Instead of irq_domain_add_linear() that requires of_node, > use irq_domain_create_linear() that works outside of OF world. ... > - rt5677->domain = irq_domain_add_linear(i2c->dev.of_node, > + rt5677->domain = irq_domain_create_linear(dev_fwnode(i2c->dev), > RT5677_IRQ_NUM, &rt5677_domain_ops, rt5677); Oops, this won't compile :-( Seems I tried in another branch that has this module disabled. > if (!rt5677->domain) { > dev_err(&i2c->dev, "Failed to create IRQ domain\n");
Hi Andy,
kernel test robot noticed the following build errors:
[auto build test ERROR on broonie-sound/for-next]
[also build test ERROR on linus/master v6.4 next-20230629]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Andy-Shevchenko/ASoC-rt5677-Use-agnostic-irq_domain_create_linear/20230629-184911
base: https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
patch link: https://lore.kernel.org/r/20230629104603.88612-2-andriy.shevchenko%40linux.intel.com
patch subject: [PATCH v1 1/3] ASoC: rt5677: Use agnostic irq_domain_create_linear()
config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20230630/202306300102.yMAJ3kZt-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce: (https://download.01.org/0day-ci/archive/20230630/202306300102.yMAJ3kZt-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202306300102.yMAJ3kZt-lkp@intel.com/
All errors (new ones prefixed by >>):
In file included from include/linux/acpi.h:16,
from sound/soc/codecs/rt5677.c:9:
sound/soc/codecs/rt5677.c: In function 'rt5677_init_irq':
>> include/linux/property.h:38:18: error: '_Generic' selector of type 'struct device' is not compatible with any association
38 | _Generic((dev), \
| ^
sound/soc/codecs/rt5677.c:5542:51: note: in expansion of macro 'dev_fwnode'
5542 | rt5677->domain = irq_domain_create_linear(dev_fwnode(i2c->dev),
| ^~~~~~~~~~
vim +38 include/linux/property.h
1b9863c6aa56d9 Suthikulpanit, Suravee 2015-10-28 34
b295d484b97081 Andy Shevchenko 2022-10-04 35 const struct fwnode_handle *__dev_fwnode_const(const struct device *dev);
b295d484b97081 Andy Shevchenko 2022-10-04 36 struct fwnode_handle *__dev_fwnode(struct device *dev);
b295d484b97081 Andy Shevchenko 2022-10-04 37 #define dev_fwnode(dev) \
b295d484b97081 Andy Shevchenko 2022-10-04 @38 _Generic((dev), \
b295d484b97081 Andy Shevchenko 2022-10-04 39 const struct device *: __dev_fwnode_const, \
b295d484b97081 Andy Shevchenko 2022-10-04 40 struct device *: __dev_fwnode)(dev)
e44bb0cbdc8868 Sakari Ailus 2017-03-28 41
diff --git a/sound/soc/codecs/rt5677.c b/sound/soc/codecs/rt5677.c index ad14d18860fc..4ef9c88cb20a 100644 --- a/sound/soc/codecs/rt5677.c +++ b/sound/soc/codecs/rt5677.c @@ -5539,7 +5539,7 @@ static int rt5677_init_irq(struct i2c_client *i2c) RT5677_GPIO1_PIN_MASK, RT5677_GPIO1_PIN_IRQ); /* Ready to listen for interrupts */ - rt5677->domain = irq_domain_add_linear(i2c->dev.of_node, + rt5677->domain = irq_domain_create_linear(dev_fwnode(i2c->dev), RT5677_IRQ_NUM, &rt5677_domain_ops, rt5677); if (!rt5677->domain) { dev_err(&i2c->dev, "Failed to create IRQ domain\n");