Message ID | 20230628092937.538683-2-AVKrasnov@sberdevices.ru |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp8796893vqr; Wed, 28 Jun 2023 02:52:22 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6PEsy681ZiyNmSovmXnkz98A7vfHkNhU00VixbqL15IgoHVL9Bn9ZB6vQqpWNP3CV8nQwx X-Received: by 2002:a17:902:e746:b0:1b6:6963:4cc0 with SMTP id p6-20020a170902e74600b001b669634cc0mr9620852plf.53.1687945942502; Wed, 28 Jun 2023 02:52:22 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687945942; cv=none; d=google.com; s=arc-20160816; b=jZ0yz1YsPjK4T5botlQAD/Dfeg2l12Ia5yOJoKVOOXOSicyWLZ2Wd3kr/9nbBivHwJ HJU95sQH5VyOUFj7pbZJ8X0UpngcvnN9DB7+kNJf8Osp6HN97Wg+VWIZ2Zu/R5DJxd7q Js6E5zl7ZOLJRBVe0OymiOFVAEQbEQHVDJG5599dCNPAL3eyf2ooL+KnfPgmIWOmEGE0 yCaRqt58sCsSs/ebIbhd0vEwyoiUWvtSs8sKq+92OGuBeNwcjaco8pOGDMwaRwIThBCv Jo/g2Qh8L0j6qLtEA1sl3GlwiqxJMPtcD5WXWZdoskamENpdbLxOG/2JM4/PygjWywio XTug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature:dkim-filter; bh=dOUQdfK74PQSGyCiBDX2998V8/GfU3xv1b3HjiouC2E=; fh=lJoip+811P4DCdtapn8hp1VALdd89JRa/wJoc6Om3Qk=; b=GBDoVkBDpXYxb18dQgJT0wgV1xqd+VktMbKtYGU5YTriQQbN24wzMhNlQE9mBWDAwN AVbNcrlWf7LA6rfh8PIE2bBIMZOo+SvDA8836ANxaE9ZRNLWAq/rTGP4jjKEKYufhfEP OXPIrd+B5z9wl7Nrbi+fYeJShtL2p4puOhRENAMkT+SPZXDPyEhGenig0IKRlesDUKgU XDtGoDqyhfeUAOPFwGWYGmeUaiKA2jlzwT/A2VL9J0IYFHvdKkXW1kVxGdNsl51zqgEZ eWFHcMeyK2fU1HegrTvqS5cUo0YPANcdvIp/SQS7RfcP0A7F9ZFpAO2a6pZ8s9Xk6gsY ai1w== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b="aKBK/RpK"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id r10-20020a170902e3ca00b001b6c462acc4si8107186ple.78.2023.06.28.02.52.08; Wed, 28 Jun 2023 02:52:22 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@sberdevices.ru header.s=mail header.b="aKBK/RpK"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=sberdevices.ru Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232531AbjF1JvR (ORCPT <rfc822;adanhawthorn@gmail.com> + 99 others); Wed, 28 Jun 2023 05:51:17 -0400 Received: from mx2.sberdevices.ru ([45.89.224.132]:26937 "EHLO mx1.sberdevices.ru" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S235569AbjF1JfQ (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 28 Jun 2023 05:35:16 -0400 Received: from p-infra-ksmg-sc-msk02 (localhost [127.0.0.1]) by mx1.sberdevices.ru (Postfix) with ESMTP id DE9F5120010; Wed, 28 Jun 2023 12:34:58 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.sberdevices.ru DE9F5120010 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sberdevices.ru; s=mail; t=1687944898; bh=dOUQdfK74PQSGyCiBDX2998V8/GfU3xv1b3HjiouC2E=; h=From:To:Subject:Date:Message-ID:MIME-Version:Content-Type:From; b=aKBK/RpKxYyT8ThvGIbVURq4k4RHsVWZ0kSqR+I633ilDxvsfigYOqlCeeXw8bevB x7Tx9/SoHG80nL5UfDA6HxNXcOzqcqc3MeeemF8NoTOKZxCnc58SIjfpLNZ7/gRf3G jGs/m0p3v61hR82BHuqHHK6xnW6ArRbtfwzDhW4isS2qLK2g4n0k78EkK91EcZxrq6 jvaToz2zOnXeTdl1tQv525ciU0jF4KH4keoSwlFtqmNnLKsmfy/d8lE/HHiboZNS9+ 3+8rtTj1gjQNn4iMw6BXtPeEbfXVGNBCpJT/f+Eg8pZM10s1/QLvoKZw/HYrApjek4 c9jMJUh7FYC0g== Received: from p-i-exch-sc-m01.sberdevices.ru (p-i-exch-sc-m01.sberdevices.ru [172.16.192.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.sberdevices.ru (Postfix) with ESMTPS; Wed, 28 Jun 2023 12:34:57 +0300 (MSK) Received: from localhost.localdomain (100.64.160.123) by p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1118.30; Wed, 28 Jun 2023 12:34:01 +0300 From: Arseniy Krasnov <AVKrasnov@sberdevices.ru> To: Liang Yang <liang.yang@amlogic.com>, Miquel Raynal <miquel.raynal@bootlin.com>, Richard Weinberger <richard@nod.at>, Vignesh Raghavendra <vigneshr@ti.com>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Neil Armstrong <neil.armstrong@linaro.org>, Kevin Hilman <khilman@baylibre.com>, Jerome Brunet <jbrunet@baylibre.com>, Martin Blumenstingl <martin.blumenstingl@googlemail.com> CC: <oxffffaa@gmail.com>, <kernel@sberdevices.ru>, Arseniy Krasnov <AVKrasnov@sberdevices.ru>, <linux-mtd@lists.infradead.org>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-amlogic@lists.infradead.org>, <linux-kernel@vger.kernel.org> Subject: [RFC PATCH v1 1/2] dt-bindings: nand: meson: support for 512B ECC step size Date: Wed, 28 Jun 2023 12:29:35 +0300 Message-ID: <20230628092937.538683-2-AVKrasnov@sberdevices.ru> X-Mailer: git-send-email 2.35.0 In-Reply-To: <20230628092937.538683-1-AVKrasnov@sberdevices.ru> References: <20230628092937.538683-1-AVKrasnov@sberdevices.ru> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [100.64.160.123] X-ClientProxiedBy: p-i-exch-sc-m02.sberdevices.ru (172.16.192.103) To p-i-exch-sc-m01.sberdevices.ru (172.16.192.107) X-KSMG-Rule-ID: 10 X-KSMG-Message-Action: clean X-KSMG-AntiSpam-Lua-Profiles: 178300 [Jun 28 2023] X-KSMG-AntiSpam-Version: 5.9.59.0 X-KSMG-AntiSpam-Envelope-From: AVKrasnov@sberdevices.ru X-KSMG-AntiSpam-Rate: 0 X-KSMG-AntiSpam-Status: not_detected X-KSMG-AntiSpam-Method: none X-KSMG-AntiSpam-Auth: dkim=none X-KSMG-AntiSpam-Info: LuaCore: 517 517 b0056c19d8e10afbb16cb7aad7258dedb0179a79, {Tracking_from_domain_doesnt_match_to}, d41d8cd98f00b204e9800998ecf8427e.com:7.1.1;p-i-exch-sc-m01.sberdevices.ru:5.0.1,7.1.1;127.0.0.199:7.1.2;sberdevices.ru:5.0.1,7.1.1, FromAlignment: s, {Tracking_white_helo}, ApMailHostAddress: 100.64.160.123 X-MS-Exchange-Organization-SCL: -1 X-KSMG-AntiSpam-Interceptor-Info: scan successful X-KSMG-AntiPhishing: Clean X-KSMG-LinksScanning: Clean X-KSMG-AntiVirus: Kaspersky Secure Mail Gateway, version 2.0.1.6960, bases: 2023/06/28 05:07:00 #21590415 X-KSMG-AntiVirus-Status: Clean, skipped Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769939604457402553?= X-GMAIL-MSGID: =?utf-8?q?1769939604457402553?= |
Series |
support 512B ECC step size for Meson NAND
|
|
Commit Message
Arseniy Krasnov
June 28, 2023, 9:29 a.m. UTC
Meson NAND supports both 512B and 1024B ECC step size, so replace
'const' for only 1024B step size with enum for both sizes.
Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru>
---
Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
On Wed, 28 Jun 2023 12:29:35 +0300, Arseniy Krasnov wrote: > Meson NAND supports both 512B and 1024B ECC step size, so replace > 'const' for only 1024B step size with enum for both sizes. > > Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru> > --- > Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > Acked-by: Rob Herring <robh@kernel.org>
Hi Arseniy, AVKrasnov@sberdevices.ru wrote on Wed, 28 Jun 2023 12:29:35 +0300: > Meson NAND supports both 512B and 1024B ECC step size, so replace > 'const' for only 1024B step size with enum for both sizes. > > Signed-off-by: Arseniy Krasnov <AVKrasnov@sberdevices.ru> > --- > Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml > index 3bec8af91bbb..d42daa285d17 100644 > --- a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml > +++ b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml > @@ -49,7 +49,7 @@ patternProperties: > const: hw > > nand-ecc-step-size: > - const: 1024 > + enum: [512, 1024] I believe you should as well mention the default value. > nand-ecc-strength: > enum: [8, 16, 24, 30, 40, 50, 60] > @@ -93,6 +93,7 @@ examples: > nand@0 { > reg = <0>; > nand-rb = <0>; > + nand-ecc-step-size = <1024>; And I don't think this line is really required, but I don't mind. > }; > }; > Thanks, Miquèl
diff --git a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml index 3bec8af91bbb..d42daa285d17 100644 --- a/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml +++ b/Documentation/devicetree/bindings/mtd/amlogic,meson-nand.yaml @@ -49,7 +49,7 @@ patternProperties: const: hw nand-ecc-step-size: - const: 1024 + enum: [512, 1024] nand-ecc-strength: enum: [8, 16, 24, 30, 40, 50, 60] @@ -93,6 +93,7 @@ examples: nand@0 { reg = <0>; nand-rb = <0>; + nand-ecc-step-size = <1024>; }; };