diff mbox series

[V3] remoteproc: imx_rproc: iterate all notifiyids in rx callback

Message ID 20230629093327.3376308-1-peng.fan@oss.nxp.com
State New
Headers
Series [V3] remoteproc: imx_rproc: iterate all notifiyids in rx callback |

Commit Message

Peng Fan (OSS) June 29, 2023, 9:33 a.m. UTC 
  From: Peng Fan <peng.fan@nxp.com>

The current code only supports one vdev and a single callback,
but there are cases need more vdevs. So iterate all notifyids to
support more vdevs with the single callback.

Signed-off-by: Peng Fan <peng.fan@nxp.com>
---

V3:
 Drop debug message in callback

V2:
 Update commit log

 drivers/remoteproc/imx_rproc.c | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

Comments

Mathieu Poirier June 29, 2023, 4:33 p.m. UTC | #1 
On Thu, 29 Jun 2023 at 03:28, Peng Fan (OSS) <peng.fan@oss.nxp.com> wrote:
>
> From: Peng Fan <peng.fan@nxp.com>
>
> The current code only supports one vdev and a single callback,
> but there are cases need more vdevs. So iterate all notifyids to
> support more vdevs with the single callback.
>

Much better - I'll pick this up when rc2 comes out.

Thanks,
Mathieu

> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>
> V3:
>  Drop debug message in callback
>
> V2:
>  Update commit log
>
>  drivers/remoteproc/imx_rproc.c | 13 +++++++++++--
>  1 file changed, 11 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index f9874fc5a80f..986d3db81596 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -725,13 +725,22 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,
>         return 0;
>  }
>
> +static int imx_rproc_notified_idr_cb(int id, void *ptr, void *data)
> +{
> +       struct rproc *rproc = data;
> +
> +       rproc_vq_interrupt(rproc, id);
> +
> +       return 0;
> +}
> +
>  static void imx_rproc_vq_work(struct work_struct *work)
>  {
>         struct imx_rproc *priv = container_of(work, struct imx_rproc,
>                                               rproc_work);
> +       struct rproc *rproc = priv->rproc;
>
> -       rproc_vq_interrupt(priv->rproc, 0);
> -       rproc_vq_interrupt(priv->rproc, 1);
> +       idr_for_each(&rproc->notifyids, imx_rproc_notified_idr_cb, rproc);
>  }
>
>  static void imx_rproc_rx_callback(struct mbox_client *cl, void *msg)
> --
> 2.37.1
>
Bjorn Andersson July 15, 2023, 7:45 p.m. UTC | #2 
On Thu, 29 Jun 2023 17:33:27 +0800, Peng Fan (OSS) wrote:
> The current code only supports one vdev and a single callback,
> but there are cases need more vdevs. So iterate all notifyids to
> support more vdevs with the single callback.
> 
> 

Applied, thanks!

[1/1] remoteproc: imx_rproc: iterate all notifiyids in rx callback
      commit: 0b6c3bc88bd920d2e89921cd308a0276f05ad8c7

Best regards,
diff mbox series

Patch

diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
index f9874fc5a80f..986d3db81596 100644
--- a/drivers/remoteproc/imx_rproc.c
+++ b/drivers/remoteproc/imx_rproc.c
@@ -725,13 +725,22 @@  static int imx_rproc_addr_init(struct imx_rproc *priv,
 	return 0;
 }
 
+static int imx_rproc_notified_idr_cb(int id, void *ptr, void *data)
+{
+	struct rproc *rproc = data;
+
+	rproc_vq_interrupt(rproc, id);
+
+	return 0;
+}
+
 static void imx_rproc_vq_work(struct work_struct *work)
 {
 	struct imx_rproc *priv = container_of(work, struct imx_rproc,
 					      rproc_work);
+	struct rproc *rproc = priv->rproc;
 
-	rproc_vq_interrupt(priv->rproc, 0);
-	rproc_vq_interrupt(priv->rproc, 1);
+	idr_for_each(&rproc->notifyids, imx_rproc_notified_idr_cb, rproc);
 }
 
 static void imx_rproc_rx_callback(struct mbox_client *cl, void *msg)