Message ID | 20230628102621.15016-2-srinivas.kandagatla@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp8819700vqr; Wed, 28 Jun 2023 03:35:30 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7fcZg33o+IFSMJdivThuf1nMNMSd8FIucBPqgzwxQDVtvcrjah2SAYgaOkhY/1xWm30sji X-Received: by 2002:a17:906:794d:b0:98c:8694:9525 with SMTP id l13-20020a170906794d00b0098c86949525mr21223808ejo.4.1687948530694; Wed, 28 Jun 2023 03:35:30 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687948530; cv=none; d=google.com; s=arc-20160816; b=etLSDyvDIv177GtqYrcNhY2Y4H9viwexBrxuUkFtMhqeBt9tDdXE9mJcA+7fHNM0US 1Co22pBqxeCyR2ekVe3sMU57RhFZRzN3KfL2BlN1vvnu8dDxx+EFqYC0XhPETq9eh52G bRIKUv4mkSlbppKM9fYe1YR22zw0xEhio2ZICSCX6O+ImuEtJ/BVT1c9sVTH2eNOrpKF W41lINI65cRvoC2GQor0pul/aFkJhKCAUgreyNvMFTl5kzjq1GtuFiToIzz5y1We5k0l v0GkckkhBToZCQQviyuBldp7hOMEkkBAz5frtEBRLZcon0FrBmTdr0GfZDiVtnlU+XQw tGUQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=LuHCd5iHQZEu3yLxK3H5002Fp9mhCHE1bYCUjxfT00w=; fh=ANVQFiC6mDhjeU+YM+r8EhAOx8zfpTZwkKvCCAMPXF8=; b=vBIZJU3XVXuo6RGY4qBiQMB9LtvynFOL/9XZ4GOYwW6Uu+oVjVjFvC8bwAbRj8In33 NGs0rjFg4FsumHmlyJo53lpdYdGI5xHIT4ch9RZhDjDSTp6jpCn/63PlOwihqdQTJ3ka t5MgDDOBBUjoqLTL3nUXh+CoJlPuPZCSZytKNmIvHw932pKOnx0ytToNUP+hoc8/fVTv YBws3QVoYNzvCioRF9TKGENkwhBxlDvjAjSuIfeU/7nO5F+JsBcaREqbDkTIh5i8ytNm ol4GPGXoBuJA5qHdOTitA8u40tJUPC/QxQtF3VYYGvnffpM4lfrrMT2O9QzQd3M7Jq2F 4/2Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kIrvu1fp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m22-20020a170906721600b009926928d482si772118ejk.447.2023.06.28.03.35.05; Wed, 28 Jun 2023 03:35:30 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=kIrvu1fp; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231607AbjF1K2x (ORCPT <rfc822;adanhawthorn@gmail.com> + 99 others); Wed, 28 Jun 2023 06:28:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57344 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231409AbjF1K0m (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 28 Jun 2023 06:26:42 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07C082D7D for <linux-kernel@vger.kernel.org>; Wed, 28 Jun 2023 03:26:40 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id 2adb3069b0e04-4fb761efa7aso4839514e87.0 for <linux-kernel@vger.kernel.org>; Wed, 28 Jun 2023 03:26:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687947998; x=1690539998; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LuHCd5iHQZEu3yLxK3H5002Fp9mhCHE1bYCUjxfT00w=; b=kIrvu1fp5N6kZkZzTu819ivlwe2RwOsvvRpr95K+WkF7h6uLaoxXcEFvbKFSfmnFWC 3G2msJZnhQgaP8TEEotmbMaajTUUw85K5DP0npluG7rDEEcyFElDo8YLKLbWJYujvX8L 0QA9udsFcOepH5hZ7Zp84DQR2rEU0XCk/6dOjNoYmGaCVDh179a2NG/AVmxx62eXjArA dSQHjhBHyxsStTn0TEzO80cAnCaowhhLQcjYyCiQLncSezOjxTBPUpy1F+TblUX+cEJ1 KbJB61BXm5w7yFtxabaKTIX2YtLeSTuXz00Aeu25PnDs2iTZw9KfOdCHqPd2wa5C4oKW X3RQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687947998; x=1690539998; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LuHCd5iHQZEu3yLxK3H5002Fp9mhCHE1bYCUjxfT00w=; b=dQuzYhi+Xfvdo82Mf4/qLQj8tbs5re+hxGAbn4UBC0x/yvor9F/e6tXWKCD1A0cDP3 IowKXpsxSj31viZS4+cgrppEogInW/aqGfN2FhMWeoYPb3qIuUu0MXl/DW968uxeqC72 AVHITfxaWjD27tCchPw+fNBdIHvyJYrh1zzjLOj8pozVNq8iyzTPj+K/yOcHqpksOnPr PVJulHo/2mxoIp9yz0dPyB4TvDHUa0cOtckxgs2wF/kZqjN6nXsfB2oooV47Dt4P6PqI lfPQfAsIPX4D0AT/tffvqkfPCjicdInlEmkPqaSDW1fu/q+g8q6ka58nk23upCYunUtD emvQ== X-Gm-Message-State: AC+VfDwCrmYkg0ja3HiTRj29SJQ9aYjpZnUFy8VHJ7t02ZCL1YprE8sT hJUh9O6AOfFbD9aeEhTXmuwPfg== X-Received: by 2002:a05:6512:2348:b0:4fb:76a5:2325 with SMTP id p8-20020a056512234800b004fb76a52325mr6782533lfu.24.1687947998165; Wed, 28 Jun 2023 03:26:38 -0700 (PDT) Received: from localhost.localdomain ([5.133.47.210]) by smtp.gmail.com with ESMTPSA id a10-20020a5d53ca000000b003140555c0ddsm2467780wrw.56.2023.06.28.03.26.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Jun 2023 03:26:37 -0700 (PDT) From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> To: krzysztof.kozlowski+dt@linaro.org, andersson@kernel.org, broonie@kernel.org Cc: robh+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org, dmitry.baryshkov@linaro.org, johan+linaro@kernel.org, perex@perex.cz, tiwai@suse.com, lgirdwood@gmail.com, ckeepax@opensource.cirrus.com, kuninori.morimoto.gx@renesas.com, linux-kernel@vger.kernel.org, pierre-louis.bossart@linux.intel.com, alsa-devel@alsa-project.org, Srinivas Kandagatla <srinivas.kandagatla@linaro.org> Subject: [PATCH 1/3] ASoC: dt-bindings: q6apm: add firmware-name bindings Date: Wed, 28 Jun 2023 11:26:19 +0100 Message-Id: <20230628102621.15016-2-srinivas.kandagatla@linaro.org> X-Mailer: git-send-email 2.21.0 In-Reply-To: <20230628102621.15016-1-srinivas.kandagatla@linaro.org> References: <20230628102621.15016-1-srinivas.kandagatla@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769942318312069665?= X-GMAIL-MSGID: =?utf-8?q?1769942318312069665?= |
Series |
ASoC: qcom: get tplg firmware-name from device tree
|
|
Commit Message
Srinivas Kandagatla
June 28, 2023, 10:26 a.m. UTC
Add bindings to get firmare-name from DT, this will provide more flexibility
to specify platform specific firmware file name and location. Also this brings
tplg firmware name inline with other board specific firmware locations.
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
---
Documentation/devicetree/bindings/sound/qcom,q6apm.yaml | 5 +++++
1 file changed, 5 insertions(+)
Comments
On Wed, 28 Jun 2023 11:26:19 +0100, Srinivas Kandagatla wrote: > Add bindings to get firmare-name from DT, this will provide more flexibility > to specify platform specific firmware file name and location. Also this brings > tplg firmware name inline with other board specific firmware locations. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > Documentation/devicetree/bindings/sound/qcom,q6apm.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/clock/milbeaut-clock.example.dtb: /example-2/serial@1e700010: failed to match any schema with compatible: ['socionext,milbeaut-usio-uart'] Documentation/devicetree/bindings/clock/sprd,sc9863a-clk.example.dtb: /example-1/syscon@20e00000: failed to match any schema with compatible: ['sprd,sc9863a-glbregs', 'syscon', 'simple-mfd'] Documentation/devicetree/bindings/leds/common.example.dtb: /example-2/i2c/led-controller@30: failed to match any schema with compatible: ['panasonic,an30259a'] Documentation/devicetree/bindings/sound/audio-graph-card2.example.dtb: /example-0/cpu: failed to match any schema with compatible: ['cpu-driver'] Documentation/devicetree/bindings/sound/audio-graph-card2.example.dtb: /example-0/codec: failed to match any schema with compatible: ['codec-driver'] /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/sound/qcom,q6apm.example.dtb: service@1: 'firmware-name' is a required property from schema $id: http://devicetree.org/schemas/sound/qcom,q6apm.yaml# Documentation/devicetree/bindings/thermal/brcm,avs-ro-thermal.example.dtb: /example-0/avs-monitor@7d5d2000: failed to match any schema with compatible: ['brcm,bcm2711-avs-monitor', 'syscon', 'simple-mfd'] Documentation/devicetree/bindings/thermal/imx-thermal.example.dtb: /example-0/anatop@20c8000: failed to match any schema with compatible: ['fsl,imx6q-anatop', 'syscon', 'simple-mfd'] Documentation/devicetree/bindings/i2c/qcom,i2c-cci.example.dtb: /example-0/cci@ac4a000/i2c-bus@1/camera@60: failed to match any schema with compatible: ['ovti,ov7251'] Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.example.dtb: /example-0/pmic: failed to match any schema with compatible: ['ti,twl6035-pmic', 'ti,palmas-pmic'] Documentation/devicetree/bindings/iio/adc/ti,palmas-gpadc.example.dtb: /example-0/pmic: failed to match any schema with compatible: ['ti,twl6035-pmic', 'ti,palmas-pmic'] Documentation/devicetree/bindings/input/mediatek,pmic-keys.example.dtb: /example-0/pmic: failed to match any schema with compatible: ['mediatek,mt6397'] Documentation/devicetree/bindings/input/sprd,sc27xx-vibrator.example.dtb: /example-0/pmic@0: failed to match any schema with compatible: ['sprd,sc2731'] Documentation/devicetree/bindings/dma/dma-controller.example.dtb: /example-0/dma-controller@48000000: failed to match any schema with compatible: ['ti,omap-sdma'] Documentation/devicetree/bindings/dma/dma-router.example.dtb: /example-0/dma-router@4a002b78: failed to match any schema with compatible: ['ti,dra7-dma-crossbar'] Documentation/devicetree/bindings/memory-controllers/ingenic,nemc.example.dtb: /example-0/memory-controller@13410000/ethernet@6: failed to match any schema with compatible: ['davicom,dm9000'] Documentation/devicetree/bindings/arm/hisilicon/controller/cpuctrl.example.dtb: /example-0/cpuctrl@a22000/clock@0: failed to match any schema with compatible: ['hisilicon,hix5hd2-clock'] Documentation/devicetree/bindings/arm/hisilicon/controller/hi3798cv200-perictrl.example.dtb: /example-0/peripheral-controller@8a20000/phy@850: failed to match any schema with compatible: ['hisilicon,hi3798cv200-combphy'] Documentation/devicetree/bindings/arm/hisilicon/controller/sysctrl.example.dtb: /example-0/system-controller@802000/clock@0: failed to match any schema with compatible: ['hisilicon,hi3620-clock'] Documentation/devicetree/bindings/media/rockchip-isp1.example.dtb: /example-0/parent/i2c/camera@36: failed to match any schema with compatible: ['ovti,ov5695'] Documentation/devicetree/bindings/net/marvell,mvusb.example.dtb: /example-0/usb/mdio@1/switch@0: failed to match any schema with compatible: ['marvell,mv88e6190'] Documentation/devicetree/bindings/net/qca,ar71xx.example.dtb: /example-0/ethernet@1a000000/mdio/switch@10: failed to match any schema with compatible: ['qca,ar9331-switch'] Documentation/devicetree/bindings/reset/hisilicon,hi3660-reset.example.dtb: /example-0/iomcu@ffd7e000: failed to match any schema with compatible: ['hisilicon,hi3660-iomcu', 'syscon'] /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/soc/qcom/qcom,apr.example.dtb: service@1: 'firmware-name' is a required property from schema $id: http://devicetree.org/schemas/sound/qcom,q6apm.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230628102621.15016-2-srinivas.kandagatla@linaro.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Wed, Jun 28, 2023 at 11:26:19AM +0100, Srinivas Kandagatla wrote: > Add bindings to get firmare-name from DT, this will provide more flexibility > to specify platform specific firmware file name and location. Also this brings > tplg firmware name inline with other board specific firmware locations. tplg? > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> > --- > Documentation/devicetree/bindings/sound/qcom,q6apm.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml b/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml > index ef1965aca254..c783451145ef 100644 > --- a/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml > +++ b/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml > @@ -31,6 +31,10 @@ properties: > unevaluatedProperties: false > description: Qualcomm DSP audio ports > > + firmware-name: > + $ref: /schemas/types.yaml#/definitions/string Already has a type, so you can drop. No default? Or pattern it should match? > + description: Audio Topology Firmware name > + > '#sound-dai-cells': > const: 0 > > @@ -38,6 +42,7 @@ required: > - compatible > - bedais > - dais > + - firmware-name Causes warnings. Test you bindings. > > unevaluatedProperties: false > > -- > 2.21.0 >
On 28/06/2023 16:54, Rob Herring wrote: > On Wed, Jun 28, 2023 at 11:26:19AM +0100, Srinivas Kandagatla wrote: >> Add bindings to get firmare-name from DT, this will provide more flexibility >> to specify platform specific firmware file name and location. Also this brings >> tplg firmware name inline with other board specific firmware locations. > > tplg? Topology, will update this in next version. > >> >> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org> >> --- >> Documentation/devicetree/bindings/sound/qcom,q6apm.yaml | 5 +++++ >> 1 file changed, 5 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml b/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml >> index ef1965aca254..c783451145ef 100644 >> --- a/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml >> +++ b/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml >> @@ -31,6 +31,10 @@ properties: >> unevaluatedProperties: false >> description: Qualcomm DSP audio ports >> >> + firmware-name: >> + $ref: /schemas/types.yaml#/definitions/string > > Already has a type, so you can drop. thankyou removed this now, but all the existing yaml still have this. > > No default? Or pattern it should match? no, its going to be hard to come up with a pattern to match file name or path for firmware. > >> + description: Audio Topology Firmware name >> + >> '#sound-dai-cells': >> const: 0 >> >> @@ -38,6 +42,7 @@ required: >> - compatible >> - bedais >> - dais >> + - firmware-name > > Causes warnings. Test you bindings. yes, examples need updating, will do that in next spin. --srini > >> >> unevaluatedProperties: false >> >> -- >> 2.21.0 >>
diff --git a/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml b/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml index ef1965aca254..c783451145ef 100644 --- a/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml +++ b/Documentation/devicetree/bindings/sound/qcom,q6apm.yaml @@ -31,6 +31,10 @@ properties: unevaluatedProperties: false description: Qualcomm DSP audio ports + firmware-name: + $ref: /schemas/types.yaml#/definitions/string + description: Audio Topology Firmware name + '#sound-dai-cells': const: 0 @@ -38,6 +42,7 @@ required: - compatible - bedais - dais + - firmware-name unevaluatedProperties: false