diff mbox series

[v2] arm64: dts: ti: k3-j721s2-main: Enable support for SDR104 speed mode

Message ID 20230412121415.860447-1-b-kapoor@ti.com
State New
Headers
Series [v2] arm64: dts: ti: k3-j721s2-main: Enable support for SDR104 speed mode |

Commit Message

Bhavya Kapoor April 12, 2023, 12:14 p.m. UTC 
  According to TRM for J721S2, SDR104 speed mode is supported by the SoC
but its capabilities were masked in device tree. Remove sdhci-caps-mask
to enable support for SDR104 speed mode for SD card in J721S2 SoC.

[+] Refer to : section 12.3.6.1.1 MMCSD Features, in J721S2 TRM
- https://www.ti.com/lit/zip/spruj28

Fixes: b8545f9d3a54 ("arm64: dts: ti: Add initial support for J721S2 SoC")
Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
---
Changelog v1->v2:
	- Modified Commit Message and Added Fixes tag

Link to v1 : https://lore.kernel.org/all/20230404091245.336732-1-b-kapoor@ti.com/

 arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 2 --
 1 file changed, 2 deletions(-)

Comments

Kumar, Udit June 28, 2023, 8:20 a.m. UTC | #1 
On 4/12/2023 5:44 PM, Bhavya Kapoor wrote:
> According to TRM for J721S2, SDR104 speed mode is supported by the SoC
> but its capabilities were masked in device tree. Remove sdhci-caps-mask
> to enable support for SDR104 speed mode for SD card in J721S2 SoC.
>
> [+] Refer to : section 12.3.6.1.1 MMCSD Features, in J721S2 TRM
> - https://www.ti.com/lit/zip/spruj28
>
> Fixes: b8545f9d3a54 ("arm64: dts: ti: Add initial support for J721S2 SoC")
> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
> ---
> Changelog v1->v2:
> 	- Modified Commit Message and Added Fixes tag
>
> Link to v1 : https://lore.kernel.org/all/20230404091245.336732-1-b-kapoor@ti.com/
>
>   arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 2 --
>   1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> index 8915132efcc1..95c6151ed10c 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> @@ -400,8 +400,6 @@ main_sdhci1: mmc@4fb0000 {
>   		ti,clkbuf-sel = <0x7>;
>   		ti,trm-icp = <0x8>;
>   		dma-coherent;
> -		/* Masking support for SDR104 capability */
> -		sdhci-caps-mask = <0x00000003 0x00000000>;


Reviewed-by: Udit Kumar <u-kumar1@ti.com>

>   	};
>   
>   	main_navss: bus@30000000 {
Nishanth Menon June 28, 2023, 10:59 a.m. UTC | #2 
On 13:50-20230628, Kumar, Udit wrote:
> 
> On 4/12/2023 5:44 PM, Bhavya Kapoor wrote:
> > According to TRM for J721S2, SDR104 speed mode is supported by the SoC
> > but its capabilities were masked in device tree. Remove sdhci-caps-mask
> > to enable support for SDR104 speed mode for SD card in J721S2 SoC.
> > 
> > [+] Refer to : section 12.3.6.1.1 MMCSD Features, in J721S2 TRM
> > - https://www.ti.com/lit/zip/spruj28
> > 
> > Fixes: b8545f9d3a54 ("arm64: dts: ti: Add initial support for J721S2 SoC")
> > Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
> > ---
> > Changelog v1->v2:
> > 	- Modified Commit Message and Added Fixes tag
> > 
> > Link to v1 : https://lore.kernel.org/all/20230404091245.336732-1-b-kapoor@ti.com/
> > 
> >   arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 2 --
> >   1 file changed, 2 deletions(-)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> > index 8915132efcc1..95c6151ed10c 100644
> > --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
> > @@ -400,8 +400,6 @@ main_sdhci1: mmc@4fb0000 {
> >   		ti,clkbuf-sel = <0x7>;
> >   		ti,trm-icp = <0x8>;
> >   		dma-coherent;
> > -		/* Masking support for SDR104 capability */
> > -		sdhci-caps-mask = <0x00000003 0x00000000>;
> 
> 
> Reviewed-by: Udit Kumar <u-kumar1@ti.com>

Please confirm if there are any changes in *tap-delay attributes.
> 
> >   	};
> >   	main_navss: bus@30000000 {

--
Regards,
Nishanth Menon
Bhavya Kapoor June 29, 2023, 5:29 a.m. UTC | #3 
On 28/06/23 16:29, Nishanth Menon wrote:
> On 13:50-20230628, Kumar, Udit wrote:
>> On 4/12/2023 5:44 PM, Bhavya Kapoor wrote:
>>> According to TRM for J721S2, SDR104 speed mode is supported by the SoC
>>> but its capabilities were masked in device tree. Remove sdhci-caps-mask
>>> to enable support for SDR104 speed mode for SD card in J721S2 SoC.
>>>
>>> [+] Refer to : section 12.3.6.1.1 MMCSD Features, in J721S2 TRM
>>> - https://www.ti.com/lit/zip/spruj28
>>>
>>> Fixes: b8545f9d3a54 ("arm64: dts: ti: Add initial support for J721S2 SoC")
>>> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
>>> ---
>>> Changelog v1->v2:
>>> 	- Modified Commit Message and Added Fixes tag
>>>
>>> Link to v1 : https://lore.kernel.org/all/20230404091245.336732-1-b-kapoor@ti.com/
>>>
>>>   arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi | 2 --
>>>   1 file changed, 2 deletions(-)
>>>
>>> diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>>> index 8915132efcc1..95c6151ed10c 100644
>>> --- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>>> +++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
>>> @@ -400,8 +400,6 @@ main_sdhci1: mmc@4fb0000 {
>>>   		ti,clkbuf-sel = <0x7>;
>>>   		ti,trm-icp = <0x8>;
>>>   		dma-coherent;
>>> -		/* Masking support for SDR104 capability */
>>> -		sdhci-caps-mask = <0x00000003 0x00000000>;
>>
>> Reviewed-by: Udit Kumar <u-kumar1@ti.com>
> Please confirm if there are any changes in *tap-delay attributes.
There is no changes in tap delay values .
>>>   	};
>>>   	main_navss: bus@30000000 {
> --
> Regards,
> Nishanth Menon
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
index 8915132efcc1..95c6151ed10c 100644
--- a/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
+++ b/arch/arm64/boot/dts/ti/k3-j721s2-main.dtsi
@@ -400,8 +400,6 @@  main_sdhci1: mmc@4fb0000 {
 		ti,clkbuf-sel = <0x7>;
 		ti,trm-icp = <0x8>;
 		dma-coherent;
-		/* Masking support for SDR104 capability */
-		sdhci-caps-mask = <0x00000003 0x00000000>;
 	};
 
 	main_navss: bus@30000000 {