Message ID | b747c41a478ca984f776165e2f6c99cba7ac862a.1687423204.git.geert+renesas@glider.be |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp4937835vqr; Thu, 22 Jun 2023 02:34:14 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ6hyJOEOYCngEVMZKctIe3FlQY2Z3wFcnpRwTUD+JZOLP5vcQOmOMVYNl6lRGFzAgJi1tnD X-Received: by 2002:a05:6a21:3297:b0:121:870b:886 with SMTP id yt23-20020a056a21329700b00121870b0886mr8863580pzb.29.1687426453965; Thu, 22 Jun 2023 02:34:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687426453; cv=none; d=google.com; s=arc-20160816; b=rvu0DuwYWQdSLNnbE9ScMdi11VooedZBG8l7iiXnWGbyTXgeF0uQ6rya4ZPK3NYkuW AYBlp3uHct3MQHJrr1RK+FPlT5oQWxfSVJ3dJs/qfMIe8PVYHzzUwbF/+nL5Rql+SAKJ 3VD+JjqO0WiSbxzoE97rOmaN3BhDaD+Ovx8Z9MNa7DEHMzpA/m22V3ESIukpzqXce+Kp 9cKeHAXIntrTKjAPspB7NhoxOyFSBop9xb8M9DU1jiFEl4HMhDvjWhRSk4RRtw1njTrh tYYS4IXFmVTaqzpFnagxgyjX3/BRfPSIDYnEIgLDwwXDoyCI48G8y0SO+MqeNLH06bPv +ZyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=e8lgzJ7OAc1MZsmCpTfss4sQctOxeI6rPSAGV8qaxcU=; b=idsesYbyvfvcWHiB/Rpf44rMIc8MXUxwzNQlpg4Bnm237egJqBM6wSO2QRHJ70fRCv ghzaKp6bmihaiKyEbeZu0z5YC9pcNF5umvXyHkphpOfVX+bRWcTaO5Fdqq+VFQDojLmj 6k5LkL1o5uCLWI1eQx/3gay7cGN3sqJkun+2NtzuG4O1dIzQbpLkNtVmItW2AT5TDns0 v+9au+D88Y6OuMZ6YyuARCrwMY6AIXDxuxc7+koJmUxtR+GUM+k/qr8pUe7yGrAv5Tx+ Y/eGA/AaaGyspX55ErDusXU/oUjCxEsMy8ytV2TX8mC3QvO1/Yrfa0TW3rUhxJyJLtQW DnOw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id m18-20020a170902e41200b001b516b77c42si5652576ple.402.2023.06.22.02.33.58; Thu, 22 Jun 2023 02:34:13 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232425AbjFVJcb (ORCPT <rfc822;maxin.john@gmail.com> + 99 others); Thu, 22 Jun 2023 05:32:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35036 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231757AbjFVJab (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 22 Jun 2023 05:30:31 -0400 Received: from xavier.telenet-ops.be (xavier.telenet-ops.be [IPv6:2a02:1800:120:4::f00:14]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A063F4487 for <linux-kernel@vger.kernel.org>; Thu, 22 Jun 2023 02:23:00 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed20:991a:a831:ea4b:6058]) by xavier.telenet-ops.be with bizsmtp id C9Nj2A0051yfRTD019NjEK; Thu, 22 Jun 2023 11:22:44 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from <geert@linux-m68k.org>) id 1qCGWX-000Bvz-KG; Thu, 22 Jun 2023 11:22:43 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from <geert@linux-m68k.org>) id 1qCGWZ-003VwV-7G; Thu, 22 Jun 2023 11:22:43 +0200 From: Geert Uytterhoeven <geert+renesas@glider.be> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Thomas Zimmermann <tzimmermann@suse.de>, Magnus Damm <magnus.damm@gmail.com> Cc: dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>, Geert Uytterhoeven <geert+renesas@glider.be> Subject: [PATCH 12/39] drm: renesas: shmobile: Don't set display info width and height twice Date: Thu, 22 Jun 2023 11:21:24 +0200 Message-Id: <b747c41a478ca984f776165e2f6c99cba7ac862a.1687423204.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 In-Reply-To: <cover.1687423204.git.geert+renesas@glider.be> References: <cover.1687423204.git.geert+renesas@glider.be> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769394881144290325?= X-GMAIL-MSGID: =?utf-8?q?1769394881144290325?= |
Series |
drm: renesas: shmobile: Atomic conversion + DT support
|
|
Commit Message
Geert Uytterhoeven
June 22, 2023, 9:21 a.m. UTC
From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> The display info width_mm and height_mm fields are set at init time and never overwritten, don't set them a second time when getting modes. Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> --- drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c | 3 --- 1 file changed, 3 deletions(-)
Comments
Hi On 2023/6/22 17:21, Geert Uytterhoeven wrote: > From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > > The display info width_mm and height_mm fields are set at init time and > never overwritten, don't set them a second time when getting modes. > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> Reviewed-by: Sui Jingfeng <suijingfeng@loongson.cn> > --- > drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c > index c775c1d49f0e1ce9..0eeb1410b662d74b 100644 > --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c > +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c > @@ -618,9 +618,6 @@ static int shmob_drm_connector_get_modes(struct drm_connector *connector) > drm_mode_set_name(mode); > drm_mode_probed_add(connector, mode); > > - connector->display_info.width_mm = sdev->pdata->panel.width_mm; > - connector->display_info.height_mm = sdev->pdata->panel.height_mm; > - > return 1; > } >
diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c index c775c1d49f0e1ce9..0eeb1410b662d74b 100644 --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_crtc.c @@ -618,9 +618,6 @@ static int shmob_drm_connector_get_modes(struct drm_connector *connector) drm_mode_set_name(mode); drm_mode_probed_add(connector, mode); - connector->display_info.width_mm = sdev->pdata->panel.width_mm; - connector->display_info.height_mm = sdev->pdata->panel.height_mm; - return 1; }