Message ID | 20221028155633.1.I6c4bfb31e88fad934e7360242cb662e01612c1bb@changeid |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp1083844wru; Fri, 28 Oct 2022 16:01:38 -0700 (PDT) X-Google-Smtp-Source: AMsMyM5fW8x8hYgW47H6Gj8+7L0pb8leodUHg8ETa775UmZ/MeSmFzomkvcD/4CEdhCTesa3S5kI X-Received: by 2002:a17:906:3019:b0:7a7:6425:7d1e with SMTP id 25-20020a170906301900b007a764257d1emr1418572ejz.663.1666998098021; Fri, 28 Oct 2022 16:01:38 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1666998098; cv=none; d=google.com; s=arc-20160816; b=WcFJG7UNP37zNZ8L9zTM/r5vMxAe400EecY0S1dJHc039XqlJX5DN1C8e+Mh+6uKpC MdXvif6cCA4Q5x7SEFKXCev5QjMJJn7AaNqTHegvlwxGiJR07RuJ58D6anKo6HTSfjNd K8v0+PkT0q6VgaIoMNL88RK9+n2W+qU60oa96+4kJ8p6JMml+wH76P5XZfOug3Lla7l/ 9HnmL5IGFfiRgnTcRjKbgM1uvE6GHrMTUxLCZK3QMWSv3Kk0vbE7nZKAHKxBU+rZ1MBT ZgPzJJWAo3h/RcTE7NsosVI1Kml+KQBmPVwMxNo79quF1PPFQted36/xIDbyT/Zcxni9 zgPg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=rzSJgKy5DjDXCyAQwtZ/P57gLVTMALzGk3IGcvzcMzw=; b=0lFkMiT1Xpfuv/KLgi/qvwx5RL3AnE5bXKHkyvEgSdLSHSKdYll88UoZMtHd9/Fkf+ yLyzpEDpNjY0UxzqtY/Fg4i0Z4eDvXHqTUwvRsYxg7ag0lFok8J4yiJKmO446fmyTate q5PUHGuJytzWvlwxAwQFPBBt5XMIA4gsEdsqlTrsXq3Xf2aOCfj3CIVKO+fEQtkA0B6g 3w126RsSuhEqRwbh7/OMn35mZzCi8MF6p2bSr4ykLdfY0JwUocG+WO1fQai2hG3I5892 uidmzSurTJfwQP4o6yzTbOLUYWCTjvzZ+xDTaAtpKHNgKR2edx74QA/RTqDEnrVrg6a3 a9oQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=UjNUyP9z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id sc21-20020a1709078a1500b007abafe45ab8si6039979ejc.787.2022.10.28.16.01.07; Fri, 28 Oct 2022 16:01:38 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@chromium.org header.s=google header.b=UjNUyP9z; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=chromium.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229947AbiJ1W5J (ORCPT <rfc822;pusanteemu@gmail.com> + 99 others); Fri, 28 Oct 2022 18:57:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46772 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230189AbiJ1W4o (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 28 Oct 2022 18:56:44 -0400 Received: from mail-pj1-x102d.google.com (mail-pj1-x102d.google.com [IPv6:2607:f8b0:4864:20::102d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8B98122E0C5 for <linux-kernel@vger.kernel.org>; Fri, 28 Oct 2022 15:56:41 -0700 (PDT) Received: by mail-pj1-x102d.google.com with SMTP id m14-20020a17090a3f8e00b00212dab39bcdso11212666pjc.0 for <linux-kernel@vger.kernel.org>; Fri, 28 Oct 2022 15:56:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=rzSJgKy5DjDXCyAQwtZ/P57gLVTMALzGk3IGcvzcMzw=; b=UjNUyP9zPuD187EGRc7XI956s4WuAYRtR1UbWLr8aTyWMm4IEloDh5HMwjKboxiqg7 DyockKVKwkIubAf89tNR3SbG3ChSdknkf0LghBIi/IJVPQ8KcLXcQa/iPA8FQHkJ2nL3 dzuTWMl76ElEAJ5ozjRq8caid2tWQVZNXwYRc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=rzSJgKy5DjDXCyAQwtZ/P57gLVTMALzGk3IGcvzcMzw=; b=xop0cwbDUPsV55TORe0ksCuhCtlwOAvPKfr+0PfUCQdY6WBjK+OBf8XHIIX8m6skk8 LEqlADrsyMa6PNUYi+rTg5pPBmgCdwIdiN2y2yEwYmsmYeYOyEg5/f6/OCgS5HULQ+v/ 7y3lCzHrt12357H32j53VcOirKZMx+2w2jiHKYemzqU+gh838uLt4GccokJFoOfs1jlU jfSUPCkfRQAXf2mEcKS89/G5TYYtQaefLPAACgRvV+lSufC70DWipLiD/Cq/06UVX2uv Z6AB3vzFBdFqcZFiVSgCNaHJvXrRVZqIkh7YT56AqTQYzB3qOt6DpuR7Bnk8KA+pu7kt iHHw== X-Gm-Message-State: ACrzQf3io6aY4QuOlV+r4qQodeMBRmFBAowBRbwW0Ay3hnjBD3EUZ0lT 6Oq+37dcv/FXr1owXy1N6yZ5anpRrqZfaQ== X-Received: by 2002:a17:902:f791:b0:17c:c1dd:a3b5 with SMTP id q17-20020a170902f79100b0017cc1dda3b5mr1336253pln.141.1666997800882; Fri, 28 Oct 2022 15:56:40 -0700 (PDT) Received: from localhost ([2620:15c:9d:2:65f9:c180:249c:190f]) by smtp.gmail.com with UTF8SMTPSA id u10-20020a170902bf4a00b001754064ac31sm3492890pls.280.2022.10.28.15.56.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 28 Oct 2022 15:56:40 -0700 (PDT) From: Brian Norris <briannorris@chromium.org> To: Ulf Hansson <ulf.hansson@linaro.org> Cc: linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, Adrian Hunter <adrian.hunter@intel.com>, Brian Norris <briannorris@chromium.org> Subject: [PATCH] mmc: sdhci-pci: Set PROBE_PREFER_ASYNCHRONOUS Date: Fri, 28 Oct 2022 15:56:37 -0700 Message-Id: <20221028155633.1.I6c4bfb31e88fad934e7360242cb662e01612c1bb@changeid> X-Mailer: git-send-email 2.38.1.273.g43a17bfeac-goog MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1747974197999430472?= X-GMAIL-MSGID: =?utf-8?q?1747974197999430472?= |
Series |
mmc: sdhci-pci: Set PROBE_PREFER_ASYNCHRONOUS
|
|
Commit Message
Brian Norris
Oct. 28, 2022, 10:56 p.m. UTC
This driver often takes on the order of 10ms to start, but in some cases
as much as 190ms. It shouldn't have many cross-device dependencies to
race with, nor racy access to shared state with other drivers, so this
should be a relatively low risk change. We've done similarly with a
variety of other MMC host drivers already.
This driver was pinpointed as part of a survey of top slowest initcalls
(i.e., are built in, and probing synchronously) on a lab of ChromeOS
systems.
Signed-off-by: Brian Norris <briannorris@chromium.org>
---
drivers/mmc/host/sdhci-pci-core.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
Comments
On 29/10/22 01:56, Brian Norris wrote: > This driver often takes on the order of 10ms to start, but in some cases > as much as 190ms. It shouldn't have many cross-device dependencies to > race with, nor racy access to shared state with other drivers, so this > should be a relatively low risk change. We've done similarly with a > variety of other MMC host drivers already. > > This driver was pinpointed as part of a survey of top slowest initcalls > (i.e., are built in, and probing synchronously) on a lab of ChromeOS > systems. > > Signed-off-by: Brian Norris <briannorris@chromium.org> Acked-by: Adrian Hunter <adrian.hunter@intel.com> > --- > > drivers/mmc/host/sdhci-pci-core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c > index 34ea1acbb3cc..0449630acbb3 100644 > --- a/drivers/mmc/host/sdhci-pci-core.c > +++ b/drivers/mmc/host/sdhci-pci-core.c > @@ -2281,7 +2281,8 @@ static struct pci_driver sdhci_driver = { > .probe = sdhci_pci_probe, > .remove = sdhci_pci_remove, > .driver = { > - .pm = &sdhci_pci_pm_ops > + .pm = &sdhci_pci_pm_ops, > + .probe_type = PROBE_PREFER_ASYNCHRONOUS, > }, > }; >
On Sat, 29 Oct 2022 at 00:56, Brian Norris <briannorris@chromium.org> wrote: > > This driver often takes on the order of 10ms to start, but in some cases > as much as 190ms. It shouldn't have many cross-device dependencies to > race with, nor racy access to shared state with other drivers, so this > should be a relatively low risk change. We've done similarly with a > variety of other MMC host drivers already. > > This driver was pinpointed as part of a survey of top slowest initcalls > (i.e., are built in, and probing synchronously) on a lab of ChromeOS > systems. > > Signed-off-by: Brian Norris <briannorris@chromium.org> Applied for next, thanks! Kind regards Uffe > --- > > drivers/mmc/host/sdhci-pci-core.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c > index 34ea1acbb3cc..0449630acbb3 100644 > --- a/drivers/mmc/host/sdhci-pci-core.c > +++ b/drivers/mmc/host/sdhci-pci-core.c > @@ -2281,7 +2281,8 @@ static struct pci_driver sdhci_driver = { > .probe = sdhci_pci_probe, > .remove = sdhci_pci_remove, > .driver = { > - .pm = &sdhci_pci_pm_ops > + .pm = &sdhci_pci_pm_ops, > + .probe_type = PROBE_PREFER_ASYNCHRONOUS, > }, > }; > > -- > 2.38.1.273.g43a17bfeac-goog >
diff --git a/drivers/mmc/host/sdhci-pci-core.c b/drivers/mmc/host/sdhci-pci-core.c index 34ea1acbb3cc..0449630acbb3 100644 --- a/drivers/mmc/host/sdhci-pci-core.c +++ b/drivers/mmc/host/sdhci-pci-core.c @@ -2281,7 +2281,8 @@ static struct pci_driver sdhci_driver = { .probe = sdhci_pci_probe, .remove = sdhci_pci_remove, .driver = { - .pm = &sdhci_pci_pm_ops + .pm = &sdhci_pci_pm_ops, + .probe_type = PROBE_PREFER_ASYNCHRONOUS, }, };