diff mbox series

counter: Fix menuconfig "Counter support" submenu entries disappearance

Message ID 20230620170159.556788-1-william.gray@linaro.org
State New
Headers
Series counter: Fix menuconfig "Counter support" submenu entries disappearance |

Commit Message

William Breathitt Gray June 20, 2023, 5:01 p.m. UTC 
  The current placement of the I8254 Kconfig entry results in the
disappearance of the "Counter support" submenu items in menuconfig. Move
the I8254 above the menuconfig COUNTER entry to restore the intended
submenu behavior.

Fixes: d428487471ba ("counter: i8254: Introduce the Intel 8254 interface library module")
Reported-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Closes: https://lore.kernel.org/all/32ddaa7b-53a8-d61f-d526-b545bd561337@linux.intel.com/
Signed-off-by: William Breathitt Gray <william.gray@linaro.org>
---
 drivers/counter/Kconfig | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)


base-commit: d428487471ba6640ee8bcdabaf830aec08b85400

Comments

Randy Dunlap June 20, 2023, 9 p.m. UTC | #1 
Hi,

On 6/20/23 10:01, William Breathitt Gray wrote:
> The current placement of the I8254 Kconfig entry results in the
> disappearance of the "Counter support" submenu items in menuconfig. Move
> the I8254 above the menuconfig COUNTER entry to restore the intended
> submenu behavior.
> 
> Fixes: d428487471ba ("counter: i8254: Introduce the Intel 8254 interface library module")
> Reported-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> Closes: https://lore.kernel.org/all/32ddaa7b-53a8-d61f-d526-b545bd561337@linux.intel.com/
> Signed-off-by: William Breathitt Gray <william.gray@linaro.org>

Reviewed-by: Randy Dunlap <rdunlap@infradead.org>

but why is I8254 here at all? Users cannot enable it
and nothing selects it.  Is it a WIP?

Thanks.

> ---
>  drivers/counter/Kconfig | 14 +++++++-------
>  1 file changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
> index a61a4b9b8ec6..86536c2cc531 100644
> --- a/drivers/counter/Kconfig
> +++ b/drivers/counter/Kconfig
> @@ -3,13 +3,6 @@
>  # Counter devices
>  #
>  
> -menuconfig COUNTER
> -	tristate "Counter support"
> -	help
> -	  This enables counter device support through the Generic Counter
> -	  interface. You only need to enable this, if you also want to enable
> -	  one or more of the counter device drivers below.
> -
>  config I8254
>  	tristate
>  	select COUNTER
> @@ -25,6 +18,13 @@ config I8254
>  
>  	  If built as a module its name will be i8254.
>  
> +menuconfig COUNTER
> +	tristate "Counter support"
> +	help
> +	  This enables counter device support through the Generic Counter
> +	  interface. You only need to enable this, if you also want to enable
> +	  one or more of the counter device drivers below.
> +
>  if COUNTER
>  
>  config 104_QUAD_8
> 
> base-commit: d428487471ba6640ee8bcdabaf830aec08b85400
William Breathitt Gray June 20, 2023, 9:12 p.m. UTC | #2 
On Tue, Jun 20, 2023 at 02:00:37PM -0700, Randy Dunlap wrote:
> Hi,
> 
> On 6/20/23 10:01, William Breathitt Gray wrote:
> > The current placement of the I8254 Kconfig entry results in the
> > disappearance of the "Counter support" submenu items in menuconfig. Move
> > the I8254 above the menuconfig COUNTER entry to restore the intended
> > submenu behavior.
> > 
> > Fixes: d428487471ba ("counter: i8254: Introduce the Intel 8254 interface library module")
> > Reported-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> > Closes: https://lore.kernel.org/all/32ddaa7b-53a8-d61f-d526-b545bd561337@linux.intel.com/
> > Signed-off-by: William Breathitt Gray <william.gray@linaro.org>
> 
> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
> 
> but why is I8254 here at all? Users cannot enable it
> and nothing selects it.  Is it a WIP?
> 
> Thanks.

There are pending patches for two drivers to use it: 104-dio-48e[^1] and
stx104[^2]. Those will be picked up in their respective subsystem trees
(by Bart and Jonathan I presume).

William Breathitt Gray

[^1]: https://lore.kernel.org/all/dc4d0d5ca6ea28eda18815df114ecb21226cb345.1681665189.git.william.gray@linaro.org/
[^2]: https://lore.kernel.org/all/45d35b6f6e8d51df788b2bc85c456bfd45476b1a.1681665189.git.william.gray@linaro.org/
Jarkko Nikula June 21, 2023, 7:04 a.m. UTC | #3 
On 6/21/23 00:12, William Breathitt Gray wrote:
> On Tue, Jun 20, 2023 at 02:00:37PM -0700, Randy Dunlap wrote:
>> Hi,
>>
>> On 6/20/23 10:01, William Breathitt Gray wrote:
>>> The current placement of the I8254 Kconfig entry results in the
>>> disappearance of the "Counter support" submenu items in menuconfig. Move
>>> the I8254 above the menuconfig COUNTER entry to restore the intended
>>> submenu behavior.
>>>
>>> Fixes: d428487471ba ("counter: i8254: Introduce the Intel 8254 interface library module")
>>> Reported-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
>>> Closes: https://lore.kernel.org/all/32ddaa7b-53a8-d61f-d526-b545bd561337@linux.intel.com/
>>> Signed-off-by: William Breathitt Gray <william.gray@linaro.org>
>>
>> Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
>>
Thanks, this fixes it.

Tested-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Reviewed-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
William Breathitt Gray June 21, 2023, 6:25 p.m. UTC | #4 
On Tue, Jun 20, 2023 at 01:01:59PM -0400, William Breathitt Gray wrote:
> The current placement of the I8254 Kconfig entry results in the
> disappearance of the "Counter support" submenu items in menuconfig. Move
> the I8254 above the menuconfig COUNTER entry to restore the intended
> submenu behavior.
> 
> Fixes: d428487471ba ("counter: i8254: Introduce the Intel 8254 interface library module")
> Reported-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> Closes: https://lore.kernel.org/all/32ddaa7b-53a8-d61f-d526-b545bd561337@linux.intel.com/
> Signed-off-by: William Breathitt Gray <william.gray@linaro.org>

Applied to counter-current.

William Breathitt Gray
Jonathan Cameron June 25, 2023, 11:11 a.m. UTC | #5 
On Tue, 20 Jun 2023 17:12:13 -0400
William Breathitt Gray <william.gray@linaro.org> wrote:

> On Tue, Jun 20, 2023 at 02:00:37PM -0700, Randy Dunlap wrote:
> > Hi,
> > 
> > On 6/20/23 10:01, William Breathitt Gray wrote:  
> > > The current placement of the I8254 Kconfig entry results in the
> > > disappearance of the "Counter support" submenu items in menuconfig. Move
> > > the I8254 above the menuconfig COUNTER entry to restore the intended
> > > submenu behavior.
> > > 
> > > Fixes: d428487471ba ("counter: i8254: Introduce the Intel 8254 interface library module")
> > > Reported-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> > > Closes: https://lore.kernel.org/all/32ddaa7b-53a8-d61f-d526-b545bd561337@linux.intel.com/
> > > Signed-off-by: William Breathitt Gray <william.gray@linaro.org>  
> > 
> > Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
> > 
> > but why is I8254 here at all? Users cannot enable it
> > and nothing selects it.  Is it a WIP?
> > 
> > Thanks.  
> 
> There are pending patches for two drivers to use it: 104-dio-48e[^1] and
> stx104[^2]. Those will be picked up in their respective subsystem trees
> (by Bart and Jonathan I presume).
> 

I missed the IIO patch in that series. Could you resend please.

Jonathan

> William Breathitt Gray
> 
> [^1]: https://lore.kernel.org/all/dc4d0d5ca6ea28eda18815df114ecb21226cb345.1681665189.git.william.gray@linaro.org/
> [^2]: https://lore.kernel.org/all/45d35b6f6e8d51df788b2bc85c456bfd45476b1a.1681665189.git.william.gray@linaro.org/
William Breathitt Gray June 26, 2023, 10:19 p.m. UTC | #6 
On Sun, Jun 25, 2023 at 12:11:08PM +0100, Jonathan Cameron wrote:
> On Tue, 20 Jun 2023 17:12:13 -0400
> William Breathitt Gray <william.gray@linaro.org> wrote:
> 
> > On Tue, Jun 20, 2023 at 02:00:37PM -0700, Randy Dunlap wrote:
> > > Hi,
> > > 
> > > On 6/20/23 10:01, William Breathitt Gray wrote:  
> > > > The current placement of the I8254 Kconfig entry results in the
> > > > disappearance of the "Counter support" submenu items in menuconfig. Move
> > > > the I8254 above the menuconfig COUNTER entry to restore the intended
> > > > submenu behavior.
> > > > 
> > > > Fixes: d428487471ba ("counter: i8254: Introduce the Intel 8254 interface library module")
> > > > Reported-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
> > > > Closes: https://lore.kernel.org/all/32ddaa7b-53a8-d61f-d526-b545bd561337@linux.intel.com/
> > > > Signed-off-by: William Breathitt Gray <william.gray@linaro.org>  
> > > 
> > > Reviewed-by: Randy Dunlap <rdunlap@infradead.org>
> > > 
> > > but why is I8254 here at all? Users cannot enable it
> > > and nothing selects it.  Is it a WIP?
> > > 
> > > Thanks.  
> > 
> > There are pending patches for two drivers to use it: 104-dio-48e[^1] and
> > stx104[^2]. Those will be picked up in their respective subsystem trees
> > (by Bart and Jonathan I presume).
> > 
> 
> I missed the IIO patch in that series. Could you resend please.
> 
> Jonathan
> 
> > William Breathitt Gray
> > 
> > [^1]: https://lore.kernel.org/all/dc4d0d5ca6ea28eda18815df114ecb21226cb345.1681665189.git.william.gray@linaro.org/
> > [^2]: https://lore.kernel.org/all/45d35b6f6e8d51df788b2bc85c456bfd45476b1a.1681665189.git.william.gray@linaro.org/

I8254 is expected to land in 6.5 so I'll wait and resend the IIO patch
rebased on 6.5-rc1 once it's released in a couple weeks. That'll make
things simple for you and avoid the need for an immutable branch.

William Breathitt Gray
diff mbox series

Patch

diff --git a/drivers/counter/Kconfig b/drivers/counter/Kconfig
index a61a4b9b8ec6..86536c2cc531 100644
--- a/drivers/counter/Kconfig
+++ b/drivers/counter/Kconfig
@@ -3,13 +3,6 @@ 
 # Counter devices
 #
 
-menuconfig COUNTER
-	tristate "Counter support"
-	help
-	  This enables counter device support through the Generic Counter
-	  interface. You only need to enable this, if you also want to enable
-	  one or more of the counter device drivers below.
-
 config I8254
 	tristate
 	select COUNTER
@@ -25,6 +18,13 @@  config I8254
 
 	  If built as a module its name will be i8254.
 
+menuconfig COUNTER
+	tristate "Counter support"
+	help
+	  This enables counter device support through the Generic Counter
+	  interface. You only need to enable this, if you also want to enable
+	  one or more of the counter device drivers below.
+
 if COUNTER
 
 config 104_QUAD_8