Message ID | 20230621143627.189134-1-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp4420579vqr; Wed, 21 Jun 2023 07:49:35 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7MXMYUT0o7qYZTKRPKmkOiaidzkDHTLRkMUD9x7WD3TZKoD4u7abCkA+0UWz9kqgovAP41 X-Received: by 2002:a05:6830:13cb:b0:6b1:593d:539 with SMTP id e11-20020a05683013cb00b006b1593d0539mr14728076otq.21.1687358974703; Wed, 21 Jun 2023 07:49:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687358974; cv=none; d=google.com; s=arc-20160816; b=pWo53uerrpW98aFLKNTD1nw/iGGgz+tCrw/ebDm5HKNjlxzZrNg8xaFhR/kbtTkgYB NhXsd15STtSeDs7k+8d3HqlupdoD5+M7mPgl3UAg2vwYKW4N61/JRcWxzwM5Yr3eAAq3 sWVMksCgh9snMNonrCCKFFDM5/oWIPGjfNdyP/nLpoo6BtfO03j0UXCavGvTfLQj9ntT bnHycqG8pswUGYU1ZLg76dDFRXZCcX1JMBKL36UbAyEz68YU/ZI3gsoCNySIX2/m+N39 +3KMf52i3e2fBXwQdGRpY0fDuHmWKRmwKBKJZYcD8Ejnv2aL9TjYc8N0k1QBlanaLmr8 uYqg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=Q267PzQvbc4qiFwzCDZZB6FJw0yi1HjyAE+qzfNhuaE=; b=GJXvSCTMY5VKGgruuq8uK4+802Suzt5JsJ3aXAZdc3cID1mENIuACmchTfQQN7XJ5B YPVrkKzWbEx5r1asp/qn0cHtooFYHemidXTjn841e7Ndazo2+J0adXKMGNQiJBGTCoD3 GYcjTVwljkaq6GqA6qvMzMu3xoNdxL/AnkqcwqFDUmGBcwrdB+GQeExIF61lbo9othjK sgAodGoDOcril6p+wdeCcC/VUyEfM5ofZf4DshWvb5YPMJu3xxgsJphCNQZIFEEh3LBh RHdt/fv9v7YKk049F4BAADoRk4ps5Kjx4fQAPWB4caIL5S/ChQmvbnVzK+7PhWGOGrmf i+9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rctvtICK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id j64-20020a638b43000000b005098590f1edsi1692907pge.757.2023.06.21.07.49.20; Wed, 21 Jun 2023 07:49:34 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=rctvtICK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232058AbjFUOgs (ORCPT <rfc822;maxin.john@gmail.com> + 99 others); Wed, 21 Jun 2023 10:36:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48248 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232066AbjFUOgj (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Wed, 21 Jun 2023 10:36:39 -0400 Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 887D81BCF for <linux-kernel@vger.kernel.org>; Wed, 21 Jun 2023 07:36:32 -0700 (PDT) Received: by mail-wm1-x32c.google.com with SMTP id 5b1f17b1804b1-3f8fcaa31c7so65644885e9.3 for <linux-kernel@vger.kernel.org>; Wed, 21 Jun 2023 07:36:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687358191; x=1689950191; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Q267PzQvbc4qiFwzCDZZB6FJw0yi1HjyAE+qzfNhuaE=; b=rctvtICKF4lpjMQ4GFaTKRkNEYiwDdBGk+QsCrkbDIvg2uKEXYwGN3Wa0p+Vkp04Qu Mc+CJdKQoGg2fnW3O2noq9sVKVt1r2fp4uGqKX8clqnunM31HC2FP78fjWw16TzOIJze yG6G9rpvpMV9bVY1CxNBf0JbNnSU0ACalWYnWbsOh7tSZ59syXRaQMYxm8kaLiZJ4MSF qj3FILCAHpak5gHHfuP5rLYG1uJK3fBWnr9xLRiyalNDbRc6nYwRPLLMImk0Ijf+iTCS K3StGdsijCQgTHT9Tm0nDauIz4fR8T0CZr4wVVEaCfCkc1CnkrnQHCoX6wlYLQLEYsfW 65Uw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687358191; x=1689950191; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Q267PzQvbc4qiFwzCDZZB6FJw0yi1HjyAE+qzfNhuaE=; b=LY9tnZdhM+mwPHqCJ6BRi9dNDorvMBN6KTp8wWE3+6sMzU9H8TwiUORuMGfcfnaxMI FHLrGcFTWJZyXltnpcJYbDUaGsSH6XoY1HhbAG4V/lZ5/VTb7sLCCQ5rFpeFFWtO5asg 2afB4ILYtrU2RGMGVess3j5sKblCNNzynr9QrdLF/hxPKIZOsmG9L0XbaVxAPQqWlma3 WAvjm/dvFE3ijEyE2xV96fUssEFD2d6aHw2P1EMlrnT0D0V72hJCuiQTPFww53umN3a5 o6Wl5/h+Mo1+yZg9WZhbKevoZmgWmRWQUhyUUn6Cf1UZOolL1AsOYsL1NX+ZoQIWkEgt x9dg== X-Gm-Message-State: AC+VfDybrvJoeKkuQbVl2imQ6mSC9GG5e5xjziKFUGw9uXUE/T2ElCwy iMAogJwnIlOsTAFPPK/ZW7waNmuKcwwgknYNMMM= X-Received: by 2002:a05:600c:281:b0:3f9:960:2bb7 with SMTP id 1-20020a05600c028100b003f909602bb7mr11643793wmk.23.1687358190927; Wed, 21 Jun 2023 07:36:30 -0700 (PDT) Received: from krzk-bin.. ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id y9-20020adfdf09000000b0031122bd3c82sm4642396wrl.17.2023.06.21.07.36.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Jun 2023 07:36:30 -0700 (PDT) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Bhupesh Sharma <bhupesh.sharma@linaro.org>, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> Subject: [PATCH] arm64: dts: qcom: sm8350: fix BAM DMA crash and reboot Date: Wed, 21 Jun 2023 16:36:27 +0200 Message-Id: <20230621143627.189134-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769324047215126732?= X-GMAIL-MSGID: =?utf-8?q?1769324124191114815?= |
Series |
arm64: dts: qcom: sm8350: fix BAM DMA crash and reboot
|
|
Commit Message
Krzysztof Kozlowski
June 21, 2023, 2:36 p.m. UTC
SM8350 HDK and MTP boards were silently dying and rebooting during BAM
DMA probe:
[ 1.574304] vreg_bob: Setting 3008000-3960000uV
[ 1.576918] bam-dFormat: Log Type - Time(microsec) - Message -
Optional Info
Log Type: B - Since Boot(Power On Reset), D - Delta, S - Statistic
S - QC_IMAGE_VERSION_STRING=BOOT.MXF.1.0-00637.1-LAHAINA-1
S - IMAGE_VARIANT_STRING=SocLahainaLAA
S - OEM_IMAGE_VERSION_STRING=crm-ubuntu77
S - Boot Interface: UFS
It seems that BAM DMA is locally controller (not by firmware) and
requires proper initialization by the driver prior to use, at least on
HDK8350 and MTP8350, but probably on all boards.
Fixes: f1040a7fe8f0 ("arm64: dts: qcom: sm8350: Add Crypto Engine support")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
---
arch/arm64/boot/dts/qcom/sm8350.dtsi | 1 -
1 file changed, 1 deletion(-)
Comments
On 21.06.2023 16:36, Krzysztof Kozlowski wrote: > SM8350 HDK and MTP boards were silently dying and rebooting during BAM > DMA probe: > > [ 1.574304] vreg_bob: Setting 3008000-3960000uV > [ 1.576918] bam-dFormat: Log Type - Time(microsec) - Message - > Optional Info > Log Type: B - Since Boot(Power On Reset), D - Delta, S - Statistic > S - QC_IMAGE_VERSION_STRING=BOOT.MXF.1.0-00637.1-LAHAINA-1 > S - IMAGE_VARIANT_STRING=SocLahainaLAA > S - OEM_IMAGE_VERSION_STRING=crm-ubuntu77 > S - Boot Interface: UFS > > It seems that BAM DMA is locally controller (not by firmware) and > requires proper initialization by the driver prior to use, at least on > HDK8350 and MTP8350, but probably on all boards. > > Fixes: f1040a7fe8f0 ("arm64: dts: qcom: sm8350: Add Crypto Engine support") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org> Tested-by: Konrad Dybcio <konrad.dybcio@linaro.org> # SM8350 PDX215 Konrad > > Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > arch/arm64/boot/dts/qcom/sm8350.dtsi | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi > index 88ef478cb5cc..b382ce66387e 100644 > --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi > @@ -1741,7 +1741,6 @@ cryptobam: dma-controller@1dc4000 { > interrupts = <GIC_SPI 272 IRQ_TYPE_LEVEL_HIGH>; > #dma-cells = <1>; > qcom,ee = <0>; > - qcom,controlled-remotely; > iommus = <&apps_smmu 0x594 0x0011>, > <&apps_smmu 0x596 0x0011>; > };
On Wed, Jun 21, 2023 at 04:36:27PM +0200, Krzysztof Kozlowski wrote: > SM8350 HDK and MTP boards were silently dying and rebooting during BAM > DMA probe: > > [ 1.574304] vreg_bob: Setting 3008000-3960000uV > [ 1.576918] bam-dFormat: Log Type - Time(microsec) - Message - > Optional Info > Log Type: B - Since Boot(Power On Reset), D - Delta, S - Statistic > S - QC_IMAGE_VERSION_STRING=BOOT.MXF.1.0-00637.1-LAHAINA-1 > S - IMAGE_VARIANT_STRING=SocLahainaLAA > S - OEM_IMAGE_VERSION_STRING=crm-ubuntu77 > S - Boot Interface: UFS > > It seems that BAM DMA is locally controller (not by firmware) and > requires proper initialization by the driver prior to use, at least on > HDK8350 and MTP8350, but probably on all boards. > > Fixes: f1040a7fe8f0 ("arm64: dts: qcom: sm8350: Add Crypto Engine support") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> - Mani > > --- > > Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > arch/arm64/boot/dts/qcom/sm8350.dtsi | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi > index 88ef478cb5cc..b382ce66387e 100644 > --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi > @@ -1741,7 +1741,6 @@ cryptobam: dma-controller@1dc4000 { > interrupts = <GIC_SPI 272 IRQ_TYPE_LEVEL_HIGH>; > #dma-cells = <1>; > qcom,ee = <0>; > - qcom,controlled-remotely; > iommus = <&apps_smmu 0x594 0x0011>, > <&apps_smmu 0x596 0x0011>; > }; > -- > 2.34.1 >
Linux regression tracking (Thorsten Leemhuis)
June 26, 2023, 10:52 a.m. UTC |
#3
Addressed
Unaddressed
On 21.06.23 16:37, Krzysztof Kozlowski wrote: > On 21/06/2023 16:36, Krzysztof Kozlowski wrote: >> SM8350 HDK and MTP boards were silently dying and rebooting during BAM >> DMA probe: >> >> [ 1.574304] vreg_bob: Setting 3008000-3960000uV >> [ 1.576918] bam-dFormat: Log Type - Time(microsec) - Message - >> Optional Info >> Log Type: B - Since Boot(Power On Reset), D - Delta, S - Statistic >> S - QC_IMAGE_VERSION_STRING=BOOT.MXF.1.0-00637.1-LAHAINA-1 >> S - IMAGE_VARIANT_STRING=SocLahainaLAA >> S - OEM_IMAGE_VERSION_STRING=crm-ubuntu77 >> S - Boot Interface: UFS >> >> It seems that BAM DMA is locally controller (not by firmware) and >> requires proper initialization by the driver prior to use, at least on >> HDK8350 and MTP8350, but probably on all boards. >> >> Fixes: f1040a7fe8f0 ("arm64: dts: qcom: sm8350: Add Crypto Engine support") BTW, did this make any progress? It's not yet in -next afaics; might be nice to have this merged so it goes to Linus together with f1040a7fe8f0. >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Many thx for fixing and involving regzbot. FWIW, this... > #regzbot fix: f1040a7fe8f069d2259ab3dab9190210005ceb33 ...didn't work, as you got things backwards: The fix command is used in reply to a report to specify which commit fixes it. I'll take care of fixing that (and also mediate about the docs, maybe this misunderstanding can be avoided by improving things). Side note: using a Link: https://lore.kernel.org/lkml/d239ad07-fbdd-16fa-3555-5bcf33c67059@linaro.org/ (or Closes:) in the patch description would have been the ideal way for regzbot here. Those Links are also what Linus wants to see so everyone can when needed understand the backstory (now or in the future), which is why regzbot relies on them. Whatever, not all that important. Thx again for giving regzbot a try. Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat) -- Everything you wanna know about Linux kernel regression tracking: https://linux-regtracking.leemhuis.info/about/#tldr If I did something stupid, please tell me, as explained on that page.
Hi Krzysztof, On Wed Jun 21, 2023 at 4:36 PM CEST, Krzysztof Kozlowski wrote: > SM8350 HDK and MTP boards were silently dying and rebooting during BAM > DMA probe: > > [ 1.574304] vreg_bob: Setting 3008000-3960000uV > [ 1.576918] bam-dFormat: Log Type - Time(microsec) - Message - > Optional Info > Log Type: B - Since Boot(Power On Reset), D - Delta, S - Statistic > S - QC_IMAGE_VERSION_STRING=BOOT.MXF.1.0-00637.1-LAHAINA-1 > S - IMAGE_VARIANT_STRING=SocLahainaLAA > S - OEM_IMAGE_VERSION_STRING=crm-ubuntu77 > S - Boot Interface: UFS > > It seems that BAM DMA is locally controller (not by firmware) and > requires proper initialization by the driver prior to use, at least on > HDK8350 and MTP8350, but probably on all boards. Are you sure that the bam (and subsequent the qce) actually probes with this change? From reading the code I don't see how the bam should probe without either qcom,controlled-remotely or qcom,powered-remotely but no clocks supplied. I think the probe just fails with this change, right? Regards Luca > > Fixes: f1040a7fe8f0 ("arm64: dts: qcom: sm8350: Add Crypto Engine support") > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > Cc: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org> > --- > arch/arm64/boot/dts/qcom/sm8350.dtsi | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi > index 88ef478cb5cc..b382ce66387e 100644 > --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi > @@ -1741,7 +1741,6 @@ cryptobam: dma-controller@1dc4000 { > interrupts = <GIC_SPI 272 IRQ_TYPE_LEVEL_HIGH>; > #dma-cells = <1>; > qcom,ee = <0>; > - qcom,controlled-remotely; > iommus = <&apps_smmu 0x594 0x0011>, > <&apps_smmu 0x596 0x0011>; > };
On 26/06/2023 13:32, Luca Weiss wrote: > Hi Krzysztof, > > On Wed Jun 21, 2023 at 4:36 PM CEST, Krzysztof Kozlowski wrote: >> SM8350 HDK and MTP boards were silently dying and rebooting during BAM >> DMA probe: >> >> [ 1.574304] vreg_bob: Setting 3008000-3960000uV >> [ 1.576918] bam-dFormat: Log Type - Time(microsec) - Message - >> Optional Info >> Log Type: B - Since Boot(Power On Reset), D - Delta, S - Statistic >> S - QC_IMAGE_VERSION_STRING=BOOT.MXF.1.0-00637.1-LAHAINA-1 >> S - IMAGE_VARIANT_STRING=SocLahainaLAA >> S - OEM_IMAGE_VERSION_STRING=crm-ubuntu77 >> S - Boot Interface: UFS >> >> It seems that BAM DMA is locally controller (not by firmware) and >> requires proper initialization by the driver prior to use, at least on >> HDK8350 and MTP8350, but probably on all boards. > > Are you sure that the bam (and subsequent the qce) actually probes with > this change? From reading the code I don't see how the bam should probe > without either qcom,controlled-remotely or qcom,powered-remotely but no Why the binding does not require either this or that? Eh, buggy stuff... > clocks supplied. I think the probe just fails with this change, right? I will need to double check. I was happy enough to be able to boot my device instead of having crashes, but indeed it would be nice to fix it fully. Best regards, Krzysztof
On 26/06/2023 14:46, Krzysztof Kozlowski wrote: > On 26/06/2023 13:32, Luca Weiss wrote: >> Hi Krzysztof, >> >> On Wed Jun 21, 2023 at 4:36 PM CEST, Krzysztof Kozlowski wrote: >>> SM8350 HDK and MTP boards were silently dying and rebooting during BAM >>> DMA probe: >>> >>> [ 1.574304] vreg_bob: Setting 3008000-3960000uV >>> [ 1.576918] bam-dFormat: Log Type - Time(microsec) - Message - >>> Optional Info >>> Log Type: B - Since Boot(Power On Reset), D - Delta, S - Statistic >>> S - QC_IMAGE_VERSION_STRING=BOOT.MXF.1.0-00637.1-LAHAINA-1 >>> S - IMAGE_VARIANT_STRING=SocLahainaLAA >>> S - OEM_IMAGE_VERSION_STRING=crm-ubuntu77 >>> S - Boot Interface: UFS >>> >>> It seems that BAM DMA is locally controller (not by firmware) and >>> requires proper initialization by the driver prior to use, at least on >>> HDK8350 and MTP8350, but probably on all boards. >> >> Are you sure that the bam (and subsequent the qce) actually probes with >> this change? From reading the code I don't see how the bam should probe >> without either qcom,controlled-remotely or qcom,powered-remotely but no > > Why the binding does not require either this or that? Eh, buggy stuff... > > >> clocks supplied. I think the probe just fails with this change, right? > > I will need to double check. I was happy enough to be able to boot my > device instead of having crashes, but indeed it would be nice to fix it > fully. You were right and my patch is not correct. I checked downstream and there are no clocks there. Therefore I assume something else is wrong here. I will send v2 disabling this. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/qcom/sm8350.dtsi b/arch/arm64/boot/dts/qcom/sm8350.dtsi index 88ef478cb5cc..b382ce66387e 100644 --- a/arch/arm64/boot/dts/qcom/sm8350.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8350.dtsi @@ -1741,7 +1741,6 @@ cryptobam: dma-controller@1dc4000 { interrupts = <GIC_SPI 272 IRQ_TYPE_LEVEL_HIGH>; #dma-cells = <1>; qcom,ee = <0>; - qcom,controlled-remotely; iommus = <&apps_smmu 0x594 0x0011>, <&apps_smmu 0x596 0x0011>; };