| Message ID | 20221031091945.531874-1-pierre.gondois@arm.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp2203082wru;
Mon, 31 Oct 2022 02:21:32 -0700 (PDT)
X-Google-Smtp-Source:
AMsMyM5tmkjV8cnK0gD7+UwTUyHaKr8DYk1lJqKH5Tzm4NVqmnyTUBrbdNbSLf9dKCHm9QyInJGY
X-Received: by 2002:a17:907:3da2:b0:78d:45df:b4f with SMTP id
he34-20020a1709073da200b0078d45df0b4fmr11514842ejc.651.1667208092237;
Mon, 31 Oct 2022 02:21:32 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1667208092; cv=none;
d=google.com; s=arc-20160816;
b=DDS045OC195F0GaOU5W0Zpf3kBz1TdjfVchHzNCHfgctKN8LNO4pn7o3tId8Ak0qOg
1A6MSCWPQiPen8ATQGy2QYoyAcVu+nvNyxen73wDKVYO2l2yYEAQJ06S0RJ1gIr/JVhP
dI8Fr1SFPCj6hAUfy6W/q7SA0ONRVeJWORb6B99gF1+ASIRlS2v5trC3m/4sb+kcn4y/
2paS9K4jXGUeuFGlp4uQM7MvpBGUFIRtIRTdkG5EVoTwqSbyZoUDdy5VyPyjled1xUOH
7pUC2aO6NhE9GMIh565HpOfdRJHCRko9O7GH9lq5DZCbBffbXCypkM/hfBtjwBeSsWen
cjSw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from;
bh=z4890zArxm3bI67VuSwUIMSY7gfzrkyVHj+zCFshI5w=;
b=eK9Rg9+skNIsnHUgt0RlUa+W1Xl2x0i0prnO+w00+EcWHWE8JWcF+9yvCwdGmJUNkm
Lq8klqIsi80BOjZcbyyAAGMEI7XBcYHom/qe7dClcWL9nEaWOtRQl3vQXky06cv6fLux
CtZ85WMu1Niwss3nB8JH5OsSrNtt7OLEC9ZAW/hE3f2DgCnEqQ4EJQCXklmKWdZsIcGO
YcJChlT8zXh40Uzncn0B4oT96/D4KvuiFQEFzxPa74MwjPse7X18krC7F5vbUJ3ouBmz
hJ4ZBxzf0+bFrPjSAg03q1JB6Lx7xsJ1iCtFLaBOp9Ta0CbqbyWI1EXAng1tg+cTp0p+
ZDUA==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
dn19-20020a17090794d300b007824786a7easi7868196ejc.724.2022.10.31.02.21.06;
Mon, 31 Oct 2022 02:21:32 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=arm.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230254AbiJaJUN (ORCPT <rfc822;kartikey406@gmail.com>
+ 99 others); Mon, 31 Oct 2022 05:20:13 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50852 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S230165AbiJaJTv (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Mon, 31 Oct 2022 05:19:51 -0400
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
by lindbergh.monkeyblade.net (Postfix) with ESMTP id 4A8C3DF35;
Mon, 31 Oct 2022 02:19:47 -0700 (PDT)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 5754823A;
Mon, 31 Oct 2022 02:19:53 -0700 (PDT)
Received: from pierre123.arm.com (unknown [10.57.7.107])
by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id
AD2403F703;
Mon, 31 Oct 2022 02:19:44 -0700 (PDT)
From: Pierre Gondois <pierre.gondois@arm.com>
To: linux-kernel@vger.kernel.org
Cc: pierre.gondois@arm.com, Rob.Herring@arm.com,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org
Subject: [PATCH 06/20] arm64: dts: Update cache properties for exynos
Date: Mon, 31 Oct 2022 10:19:45 +0100
Message-Id: <20221031091945.531874-1-pierre.gondois@arm.com>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_MED,
SPF_HELO_NONE,SPF_NONE autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1748194392463299707?=
X-GMAIL-MSGID: =?utf-8?q?1748194392463299707?=
|
| Series |
Update cache properties for arm64 DTS
|
|
Commit Message
Pierre Gondois
Oct. 31, 2022, 9:19 a.m. UTC
The DeviceTree Specification v0.3 specifies that the cache node
'compatible' and 'cache-level' properties are 'required'. Cf.
s3.8 Multi-level and Shared Cache Nodes
The recently added init_of_cache_level() function checks
these properties. Add them if missing.
Signed-off-by: Pierre Gondois <pierre.gondois@arm.com>
---
arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 ++
arch/arm64/boot/dts/exynos/exynos7.dtsi | 1 +
2 files changed, 3 insertions(+)
Comments
On Mon, 31 Oct 2022 10:19:45 +0100, Pierre Gondois wrote: > The DeviceTree Specification v0.3 specifies that the cache node > 'compatible' and 'cache-level' properties are 'required'. Cf. > s3.8 Multi-level and Shared Cache Nodes > > The recently added init_of_cache_level() function checks > these properties. Add them if missing. > > [...] Applied, thanks! [06/20] arm64: dts: Update cache properties for exynos https://git.kernel.org/krzk/linux/c/58710ae94589a2b2baaab6b6986064b691124b0d Best regards,
Hi Pierre >-----Original Message----- >From: Pierre Gondois [mailto:pierre.gondois@arm.com] >Sent: Monday, October 31, 2022 2:50 PM >To: linux-kernel@vger.kernel.org >Cc: pierre.gondois@arm.com; Rob.Herring@arm.com; Rob Herring ><robh+dt@kernel.org>; Krzysztof Kozlowski ><krzysztof.kozlowski+dt@linaro.org>; Alim Akhtar ><alim.akhtar@samsung.com>; devicetree@vger.kernel.org; linux-arm- >kernel@lists.infradead.org; linux-samsung-soc@vger.kernel.org >Subject: [PATCH 06/20] arm64: dts: Update cache properties for exynos > >The DeviceTree Specification v0.3 specifies that the cache node 'compatible' >and 'cache-level' properties are 'required'. Cf. >s3.8 Multi-level and Shared Cache Nodes > Not sure if this need to be documented in schema/yaml file as well or already part of schema? >The recently added init_of_cache_level() function checks these properties. >Add them if missing. > >Signed-off-by: Pierre Gondois <pierre.gondois@arm.com> >--- Changes looks good though. Reviewed-by: Alim Akhtar <alim.akhtar@samsung.com> > arch/arm64/boot/dts/exynos/exynos5433.dtsi | 2 ++ > arch/arm64/boot/dts/exynos/exynos7.dtsi | 1 + > 2 files changed, 3 insertions(+) > >diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi >b/arch/arm64/boot/dts/exynos/exynos5433.dtsi >index bd6a354b9cb5..e9eda46801f8 100644 >--- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi >+++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi >@@ -229,6 +229,7 @@ cluster_a57_l2: l2-cache0 { > cache-size = <0x200000>; > cache-line-size = <64>; > cache-sets = <2048>; >+ cache-level = <2>; > }; > > cluster_a53_l2: l2-cache1 { >@@ -236,6 +237,7 @@ cluster_a53_l2: l2-cache1 { > cache-size = <0x40000>; > cache-line-size = <64>; > cache-sets = <256>; >+ cache-level = <2>; > }; > }; > >diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi >b/arch/arm64/boot/dts/exynos/exynos7.dtsi >index 1cd771c90b47..aca1c32a6411 100644 >--- a/arch/arm64/boot/dts/exynos/exynos7.dtsi >+++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi >@@ -110,6 +110,7 @@ atlas_l2: l2-cache0 { > cache-size = <0x200000>; > cache-line-size = <64>; > cache-sets = <2048>; >+ cache-level = <2>; > }; > }; > >-- >2.25.1
On 02/11/2022 21:21, Krzysztof Kozlowski wrote: > On Mon, 31 Oct 2022 10:19:45 +0100, Pierre Gondois wrote: >> The DeviceTree Specification v0.3 specifies that the cache node >> 'compatible' and 'cache-level' properties are 'required'. Cf. >> s3.8 Multi-level and Shared Cache Nodes >> >> The recently added init_of_cache_level() function checks >> these properties. Add them if missing. >> >> [...] > > Applied, thanks! > > [06/20] arm64: dts: Update cache properties for exynos > https://git.kernel.org/krzk/linux/c/58710ae94589a2b2baaab6b6986064b691124b0d Now dropped. I understand this is the intention/request of v2. When resending be sure to use proper subject prefixes. Best regards, Krzysztof
Hello Krzysztof, This patch and [1] were dropped after a bad patch management from my part. v1 and v2 are identical, but [2] lead to the 2 patches to be removed. Not willing to worsen the situation, I wanted to wait a bit before getting back to these 2 patches and let them be removed. Would it be possible to take back these 2 patches ? Regards, Pierre [1] https://lore.kernel.org/all/2d8b2d85-7bc6-026a-baf9-11a47171ddc5@linaro.org/ [2] https://lore.kernel.org/all/bb36df3f-5aee-256a-4d64-eaeb9bff998e@arm.com/ On 11/2/22 21:21, Krzysztof Kozlowski wrote: > On Mon, 31 Oct 2022 10:19:45 +0100, Pierre Gondois wrote: >> The DeviceTree Specification v0.3 specifies that the cache node >> 'compatible' and 'cache-level' properties are 'required'. Cf. >> s3.8 Multi-level and Shared Cache Nodes >> >> The recently added init_of_cache_level() function checks >> these properties. Add them if missing. >> >> [...] > > Applied, thanks! > > [06/20] arm64: dts: Update cache properties for exynos > https://git.kernel.org/krzk/linux/c/58710ae94589a2b2baaab6b6986064b691124b0d > > Best regards,
On 22/11/2022 17:52, Pierre Gondois wrote: > Hello Krzysztof, > > This patch and [1] were dropped after a bad patch management from my part. > v1 and v2 are identical, but [2] lead to the 2 patches to be removed. > Not willing to worsen the situation, I wanted to wait a bit before getting > back to these 2 patches and let them be removed. > Would it be possible to take back these 2 patches ? > > Regards, > Pierre > > [1] https://lore.kernel.org/all/2d8b2d85-7bc6-026a-baf9-11a47171ddc5@linaro.org/ > [2] https://lore.kernel.org/all/bb36df3f-5aee-256a-4d64-eaeb9bff998e@arm.com/ > I was expecting a resend with: 1. Fixed subject. 2. Changelog. 3. Trimmed list. Best regards, Krzysztof
diff --git a/arch/arm64/boot/dts/exynos/exynos5433.dtsi b/arch/arm64/boot/dts/exynos/exynos5433.dtsi index bd6a354b9cb5..e9eda46801f8 100644 --- a/arch/arm64/boot/dts/exynos/exynos5433.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos5433.dtsi @@ -229,6 +229,7 @@ cluster_a57_l2: l2-cache0 { cache-size = <0x200000>; cache-line-size = <64>; cache-sets = <2048>; + cache-level = <2>; }; cluster_a53_l2: l2-cache1 { @@ -236,6 +237,7 @@ cluster_a53_l2: l2-cache1 { cache-size = <0x40000>; cache-line-size = <64>; cache-sets = <256>; + cache-level = <2>; }; }; diff --git a/arch/arm64/boot/dts/exynos/exynos7.dtsi b/arch/arm64/boot/dts/exynos/exynos7.dtsi index 1cd771c90b47..aca1c32a6411 100644 --- a/arch/arm64/boot/dts/exynos/exynos7.dtsi +++ b/arch/arm64/boot/dts/exynos/exynos7.dtsi @@ -110,6 +110,7 @@ atlas_l2: l2-cache0 { cache-size = <0x200000>; cache-line-size = <64>; cache-sets = <2048>; + cache-level = <2>; }; };