[v4,11/13] dt-bindings: iio: temperature: ltc2983: use generic node name in example

Message ID 20221103130041.2153295-12-demonsingur@gmail.com
State New
Headers
Series Support more parts in LTC2983 |

Commit Message

Cosmin Tanislav Nov. 3, 2022, 1 p.m. UTC
  From: Cosmin Tanislav <cosmin.tanislav@analog.com>

Examples should use the generic IIO node name. Fix it.

Signed-off-by: Cosmin Tanislav <cosmin.tanislav@analog.com>
---
 .../devicetree/bindings/iio/temperature/adi,ltc2983.yaml        | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Rob Herring Nov. 7, 2022, 6:13 p.m. UTC | #1
On Thu, Nov 03, 2022 at 03:00:39PM +0200, Cosmin Tanislav wrote:
> From: Cosmin Tanislav <cosmin.tanislav@analog.com>
> 
> Examples should use the generic IIO node name. Fix it.
> 
> Signed-off-by: Cosmin Tanislav <cosmin.tanislav@analog.com>
> ---
>  .../devicetree/bindings/iio/temperature/adi,ltc2983.yaml        | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml
> index 467e165e9b0b..bd357ff28e65 100644
> --- a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml
> +++ b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml
> @@ -420,7 +420,7 @@ examples:
>          #address-cells = <1>;
>          #size-cells = <0>;
>  
> -        sensor_ltc2983: ltc2983@0 {
> +        temp@0 {

The DT spec defines 'temperature-sensor'.

>                  compatible = "adi,ltc2983";
>                  reg = <0>;
>  
> -- 
> 2.38.1
> 
>
  
Cosmin Tanislav Nov. 8, 2022, 8:37 a.m. UTC | #2
On Mon, 2022-11-07 at 12:13 -0600, Rob Herring wrote:
> On Thu, Nov 03, 2022 at 03:00:39PM +0200, Cosmin Tanislav wrote:
> > From: Cosmin Tanislav <cosmin.tanislav@analog.com>
> > 
> > Examples should use the generic IIO node name. Fix it.
> > 
> > Signed-off-by: Cosmin Tanislav <cosmin.tanislav@analog.com>
> > ---
> >  .../devicetree/bindings/iio/temperature/adi,ltc2983.yaml        |
> > 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git
> > a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yam
> > l
> > b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yam
> > l
> > index 467e165e9b0b..bd357ff28e65 100644
> > ---
> > a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yam
> > l
> > +++
> > b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yam
> > l
> > @@ -420,7 +420,7 @@ examples:
> >          #address-cells = <1>;
> >          #size-cells = <0>;
> >  
> > -        sensor_ltc2983: ltc2983@0 {
> > +        temp@0 {
> 
> The DT spec defines 'temperature-sensor'.

Jonathan, could you maybe fix this (replace 'temp' with
'temperature-sensor') while picking it up? Thanks.

> 
> >                  compatible = "adi,ltc2983";
> >                  reg = <0>;
> >  
> > -- 
> > 2.38.1
> > 
> >
  
Jonathan Cameron Nov. 12, 2022, 3:43 p.m. UTC | #3
On Tue, 08 Nov 2022 10:37:23 +0200
Cosmin Tanislav <demonsingur@gmail.com> wrote:

> On Mon, 2022-11-07 at 12:13 -0600, Rob Herring wrote:
> > On Thu, Nov 03, 2022 at 03:00:39PM +0200, Cosmin Tanislav wrote:  
> > > From: Cosmin Tanislav <cosmin.tanislav@analog.com>
> > > 
> > > Examples should use the generic IIO node name. Fix it.
> > > 
> > > Signed-off-by: Cosmin Tanislav <cosmin.tanislav@analog.com>
> > > ---
> > >  .../devicetree/bindings/iio/temperature/adi,ltc2983.yaml        |
> > > 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git
> > > a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yam
> > > l
> > > b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yam
> > > l
> > > index 467e165e9b0b..bd357ff28e65 100644
> > > ---
> > > a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yam
> > > l
> > > +++
> > > b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yam
> > > l
> > > @@ -420,7 +420,7 @@ examples:
> > >          #address-cells = <1>;
> > >          #size-cells = <0>;
> > >  
> > > -        sensor_ltc2983: ltc2983@0 {
> > > +        temp@0 {  
> > 
> > The DT spec defines 'temperature-sensor'.  
> 
> Jonathan, could you maybe fix this (replace 'temp' with
> 'temperature-sensor') while picking it up? Thanks.

Done.
> 
> >   
> > >                  compatible = "adi,ltc2983";
> > >                  reg = <0>;
> > >  
> > > -- 
> > > 2.38.1
> > > 
> > >   
>
  

Patch

diff --git a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml
index 467e165e9b0b..bd357ff28e65 100644
--- a/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml
+++ b/Documentation/devicetree/bindings/iio/temperature/adi,ltc2983.yaml
@@ -420,7 +420,7 @@  examples:
         #address-cells = <1>;
         #size-cells = <0>;
 
-        sensor_ltc2983: ltc2983@0 {
+        temp@0 {
                 compatible = "adi,ltc2983";
                 reg = <0>;