diff mbox series

[v1] RISC-V: Remove duplicated extern function_base decl

Message ID 20230626093656.502976-1-pan2.li@intel.com
State Accepted
Headers
Series [v1] RISC-V: Remove duplicated extern function_base decl |

Checks

Context Check Description
snail/gcc-patch-check success Github commit url

Commit Message

Li, Pan2 via Gcc-patches June 26, 2023, 9:36 a.m. UTC 
  From: Pan Li <pan2.li@intel.com>

Signed-off-by: Pan Li <pan2.li@intel.com>

gcc/ChangeLog:

	* config/riscv/riscv-vector-builtins-bases.h: Remove duplicated decl.
---
 gcc/config/riscv/riscv-vector-builtins-bases.h | 5 -----
 1 file changed, 5 deletions(-)

Comments

juzhe.zhong@rivai.ai June 26, 2023, 9:39 a.m. UTC | #1 
LGTM



juzhe.zhong@rivai.ai
 
From: pan2.li
Date: 2023-06-26 17:36
To: gcc-patches
CC: juzhe.zhong; rdapp.gcc; jeffreyalaw; pan2.li; yanzhang.wang; kito.cheng
Subject: [PATCH v1] RISC-V: Remove duplicated extern function_base decl
From: Pan Li <pan2.li@intel.com>
 
Signed-off-by: Pan Li <pan2.li@intel.com>
 
gcc/ChangeLog:
 
* config/riscv/riscv-vector-builtins-bases.h: Remove duplicated decl.
---
gcc/config/riscv/riscv-vector-builtins-bases.h | 5 -----
1 file changed, 5 deletions(-)
 
diff --git a/gcc/config/riscv/riscv-vector-builtins-bases.h b/gcc/config/riscv/riscv-vector-builtins-bases.h
index 62ff38a2811..fb95d6afdf0 100644
--- a/gcc/config/riscv/riscv-vector-builtins-bases.h
+++ b/gcc/config/riscv/riscv-vector-builtins-bases.h
@@ -121,8 +121,6 @@ extern const function_base *const vsmul;
extern const function_base *const vssra;
extern const function_base *const vssrl;
extern const function_base *const vnclip;
-extern const function_base *const vnclip;
-extern const function_base *const vnclipu;
extern const function_base *const vnclipu;
extern const function_base *const vmand;
extern const function_base *const vmnand;
@@ -144,8 +142,6 @@ extern const function_base *const vmsof;
extern const function_base *const viota;
extern const function_base *const vid;
extern const function_base *const vfadd;
-extern const function_base *const vfadd;
-extern const function_base *const vfsub;
extern const function_base *const vfsub;
extern const function_base *const vfrsub;
extern const function_base *const vfwadd;
@@ -153,7 +149,6 @@ extern const function_base *const vfwsub;
extern const function_base *const vfmul;
extern const function_base *const vfmul;
extern const function_base *const vfdiv;
-extern const function_base *const vfdiv;
extern const function_base *const vfrdiv;
extern const function_base *const vfwmul;
extern const function_base *const vfmacc;
-- 
2.34.1
Kito Cheng June 26, 2023, 9:50 a.m. UTC | #2 
Lgtm

juzhe.zhong@rivai.ai <juzhe.zhong@rivai.ai>於 2023年6月26日 週一，17:40寫道：

> LGTM
>
>
>
> juzhe.zhong@rivai.ai
>
> From: pan2.li
> Date: 2023-06-26 17:36
> To: gcc-patches
> CC: juzhe.zhong; rdapp.gcc; jeffreyalaw; pan2.li; yanzhang.wang;
> kito.cheng
> Subject: [PATCH v1] RISC-V: Remove duplicated extern function_base decl
> From: Pan Li <pan2.li@intel.com>
>
> Signed-off-by: Pan Li <pan2.li@intel.com>
>
> gcc/ChangeLog:
>
> * config/riscv/riscv-vector-builtins-bases.h: Remove duplicated decl.
> ---
> gcc/config/riscv/riscv-vector-builtins-bases.h | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/gcc/config/riscv/riscv-vector-builtins-bases.h
> b/gcc/config/riscv/riscv-vector-builtins-bases.h
> index 62ff38a2811..fb95d6afdf0 100644
> --- a/gcc/config/riscv/riscv-vector-builtins-bases.h
> +++ b/gcc/config/riscv/riscv-vector-builtins-bases.h
> @@ -121,8 +121,6 @@ extern const function_base *const vsmul;
> extern const function_base *const vssra;
> extern const function_base *const vssrl;
> extern const function_base *const vnclip;
> -extern const function_base *const vnclip;
> -extern const function_base *const vnclipu;
> extern const function_base *const vnclipu;
> extern const function_base *const vmand;
> extern const function_base *const vmnand;
> @@ -144,8 +142,6 @@ extern const function_base *const vmsof;
> extern const function_base *const viota;
> extern const function_base *const vid;
> extern const function_base *const vfadd;
> -extern const function_base *const vfadd;
> -extern const function_base *const vfsub;
> extern const function_base *const vfsub;
> extern const function_base *const vfrsub;
> extern const function_base *const vfwadd;
> @@ -153,7 +149,6 @@ extern const function_base *const vfwsub;
> extern const function_base *const vfmul;
> extern const function_base *const vfmul;
> extern const function_base *const vfdiv;
> -extern const function_base *const vfdiv;
> extern const function_base *const vfrdiv;
> extern const function_base *const vfwmul;
> extern const function_base *const vfmacc;
> --
> 2.34.1
>
>
>
Li, Pan2 via Gcc-patches June 26, 2023, 11:06 a.m. UTC | #3 
Committed, thanks kito and juzhe.

Pan

From: Kito Cheng <kito.cheng@gmail.com>
Sent: Monday, June 26, 2023 5:51 PM
To: juzhe.zhong@rivai.ai
Cc: Robin Dapp <rdapp.gcc@gmail.com>; gcc-patches <gcc-patches@gcc.gnu.org>; jeffreyalaw <jeffreyalaw@gmail.com>; Li, Pan2 <pan2.li@intel.com>; Wang, Yanzhang <yanzhang.wang@intel.com>
Subject: Re: [PATCH v1] RISC-V: Remove duplicated extern function_base decl

Lgtm

juzhe.zhong@rivai.ai<mailto:juzhe.zhong@rivai.ai> <juzhe.zhong@rivai.ai<mailto:juzhe.zhong@rivai.ai>>於 2023年6月26日 週一，17:40寫道：
LGTM



juzhe.zhong@rivai.ai<mailto:juzhe.zhong@rivai.ai>

From: pan2.li<http://pan2.li>
Date: 2023-06-26 17:36
To: gcc-patches
CC: juzhe.zhong; rdapp.gcc; jeffreyalaw; pan2.li<http://pan2.li>; yanzhang.wang; kito.cheng
Subject: [PATCH v1] RISC-V: Remove duplicated extern function_base decl
From: Pan Li <pan2.li@intel.com<mailto:pan2.li@intel.com>>

Signed-off-by: Pan Li <pan2.li@intel.com<mailto:pan2.li@intel.com>>

gcc/ChangeLog:

* config/riscv/riscv-vector-builtins-bases.h: Remove duplicated decl.
---
gcc/config/riscv/riscv-vector-builtins-bases.h | 5 -----
1 file changed, 5 deletions(-)

diff --git a/gcc/config/riscv/riscv-vector-builtins-bases.h b/gcc/config/riscv/riscv-vector-builtins-bases.h
index 62ff38a2811..fb95d6afdf0 100644
--- a/gcc/config/riscv/riscv-vector-builtins-bases.h
+++ b/gcc/config/riscv/riscv-vector-builtins-bases.h
@@ -121,8 +121,6 @@ extern const function_base *const vsmul;
extern const function_base *const vssra;
extern const function_base *const vssrl;
extern const function_base *const vnclip;
-extern const function_base *const vnclip;
-extern const function_base *const vnclipu;
extern const function_base *const vnclipu;
extern const function_base *const vmand;
extern const function_base *const vmnand;
@@ -144,8 +142,6 @@ extern const function_base *const vmsof;
extern const function_base *const viota;
extern const function_base *const vid;
extern const function_base *const vfadd;
-extern const function_base *const vfadd;
-extern const function_base *const vfsub;
extern const function_base *const vfsub;
extern const function_base *const vfrsub;
extern const function_base *const vfwadd;
@@ -153,7 +149,6 @@ extern const function_base *const vfwsub;
extern const function_base *const vfmul;
extern const function_base *const vfmul;
extern const function_base *const vfdiv;
-extern const function_base *const vfdiv;
extern const function_base *const vfrdiv;
extern const function_base *const vfwmul;
extern const function_base *const vfmacc;
--
2.34.1
diff mbox series

Patch

diff --git a/gcc/config/riscv/riscv-vector-builtins-bases.h b/gcc/config/riscv/riscv-vector-builtins-bases.h
index 62ff38a2811..fb95d6afdf0 100644
--- a/gcc/config/riscv/riscv-vector-builtins-bases.h
+++ b/gcc/config/riscv/riscv-vector-builtins-bases.h
@@ -121,8 +121,6 @@  extern const function_base *const vsmul;
 extern const function_base *const vssra;
 extern const function_base *const vssrl;
 extern const function_base *const vnclip;
-extern const function_base *const vnclip;
-extern const function_base *const vnclipu;
 extern const function_base *const vnclipu;
 extern const function_base *const vmand;
 extern const function_base *const vmnand;
@@ -144,8 +142,6 @@  extern const function_base *const vmsof;
 extern const function_base *const viota;
 extern const function_base *const vid;
 extern const function_base *const vfadd;
-extern const function_base *const vfadd;
-extern const function_base *const vfsub;
 extern const function_base *const vfsub;
 extern const function_base *const vfrsub;
 extern const function_base *const vfwadd;
@@ -153,7 +149,6 @@  extern const function_base *const vfwsub;
 extern const function_base *const vfmul;
 extern const function_base *const vfmul;
 extern const function_base *const vfdiv;
-extern const function_base *const vfdiv;
 extern const function_base *const vfrdiv;
 extern const function_base *const vfwmul;
 extern const function_base *const vfmacc;