diff mbox series

[v2,1/2] arm64: dts: agilex/stratix10: Updated QSPI Flash layout for UBIFS

Message ID 20230622123432.593548-1-kah.jing.lee@intel.com
State New
Headers
Series : Enable UBIFS support |

Commit Message

Lee, Kah Jing June 22, 2023, 12:34 p.m. UTC 
  From: Alif Zakuan Yuslaimi <alif.zakuan.yuslaimi@intel.com>

This patch is to update the QSPI flash layout to support UBIFS in mtd
root partition.

Signed-off-by: Alif Zakuan Yuslaimi <alif.zakuan.yuslaimi@intel.com>
Signed-off-by: Kah Jing Lee <kah.jing.lee@intel.com>
---
v2: Update subject prefix
---
 arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts | 8 ++++----
 arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts     | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)

Comments

Lee, Kah Jing June 23, 2023, 9:42 a.m. UTC | #1 
> -----Original Message-----
> From: Markus Elfring <Markus.Elfring@web.de>
> Sent: Thursday, 22 June, 2023 9:05 PM
> To: Yuslaimi, Alif Zakuan <alif.zakuan.yuslaimi@intel.com>; Lee, Kah Jing
> <kah.jing.lee@intel.com>; devicetree@vger.kernel.org; kernel-
> janitors@vger.kernel.org; Catalin Marinas <catalin.marinas@arm.com>;
> Conor Dooley <conor+dt@kernel.org>; Dinh Nguyen
> <dinguyen@kernel.org>; Rob Herring <robh+dt@kernel.org>; Krzysztof
> Kozlowski <krzysztof.kozlowski+dt@linaro.org>; Will Deacon
> <will@kernel.org>
> Cc: LKML <linux-kernel@vger.kernel.org>; cocci@inria.fr
> Subject: Re: [PATCH v2 1/2] arm64: dts: agilex/stratix10: Updated QSPI Flash
> layout for UBIFS
> 
> > This patch is to update the QSPI flash layout to support UBIFS in mtd
> > root partition.
> 
> Please replace this sentence by an imperative change suggestion.
> 
> See also:
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Docu
> mentation/process/submitting-patches.rst?h=v6.4-rc7#n94
> 
> Regards,
> Markus

Updated in v3 - Commit message: 
Update the QSPI flash layout to support UBIFS in mtd root partition.
Flash layout is updated in order to store non-UBIFS related boot and fpga data in qspi_boot(mtd0) 
while keep the rootfs with UBIFS in the root partition(mtd1).

Thanks. 

Regards, 
Kah Jing
Lee, Kah Jing June 24, 2023, 3:31 a.m. UTC | #2 
> -----Original Message-----
> From: Markus Elfring <Markus.Elfring@web.de>
> Sent: Friday, 23 June, 2023 7:04 PM
> To: Lee, Kah Jing <kah.jing.lee@intel.com>; Yuslaimi, Alif Zakuan
> <alif.zakuan.yuslaimi@intel.com>; devicetree@vger.kernel.org; kernel-
> janitors@vger.kernel.org; Catalin Marinas <catalin.marinas@arm.com>;
> Conor Dooley <conor+dt@kernel.org>; Dinh Nguyen <dinguyen@kernel.org>;
> Rob Herring <robh+dt@kernel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@linaro.org>; Will Deacon <will@kernel.org>
> Cc: LKML <linux-kernel@vger.kernel.org>; cocci@inria.fr
> Subject: Re: [v2 1/2] arm64: dts: agilex/stratix10: Updated QSPI Flash layout
> for UBIFS
> 
> > Updated in v3 - Commit message:
> > Update the QSPI flash layout to support UBIFS in mtd root partition.
> > Flash layout is updated in order to store non-UBIFS related boot and
> > fpga data in qspi_boot(mtd0) while keep the rootfs with UBIFS in the root
> partition(mtd1).
> 
> I got the impression that this change description is also improvable a bit.
> How do you think about a wording variant like the following?
> 
> 
> Non-UBIFS related boot and fpga data should be stored in qspi_boot (mtd0)
> while keeping the rootfs with UBIFS in the root partition “mtd1”.
> Thus update the QSPI flash layout to support UBIFS in the mtd root partition.
> 
> 
> Will similar adjustments become helpful for subsequent update steps?
Sounds good to me. Will update the commit message for v3.
Thanks.
> 
> Regards,
> Markus

Regards, 
Lee, Kah Jing
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
index 38ae674f2f02..12b960b9183c 100644
--- a/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
+++ b/arch/arm64/boot/dts/altera/socfpga_stratix10_socdk.dts
@@ -202,12 +202,12 @@  partitions {
 
 			qspi_boot: partition@0 {
 				label = "Boot and fpga data";
-				reg = <0x0 0x03FE0000>;
+				reg = <0x0 0x04200000>;
 			};
 
-			qspi_rootfs: partition@3FE0000 {
-				label = "Root Filesystem - JFFS2";
-				reg = <0x03FE0000 0x0C020000>;
+			root: partition@4200000 {
+				label = "Root Filesystem - UBIFS";
+				reg = <0x04200000 0x0BE00000>;
 			};
 		};
 	};
diff --git a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
index 07c3f8876613..608017e6e36a 100644
--- a/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
+++ b/arch/arm64/boot/dts/intel/socfpga_agilex_socdk.dts
@@ -128,12 +128,12 @@  partitions {
 
 			qspi_boot: partition@0 {
 				label = "Boot and fpga data";
-				reg = <0x0 0x03FE0000>;
+				reg = <0x0 0x04200000>;
 			};
 
-			qspi_rootfs: partition@3FE0000 {
-				label = "Root Filesystem - JFFS2";
-				reg = <0x03FE0000 0x0C020000>;
+			root: partition@4200000 {
+				label = "Root Filesystem - UBIFS";
+				reg = <0x04200000 0x0BE00000>;
 			};
 		};
 	};