Message ID | 20230623135635.4100947-1-juzhe.zhong@rivai.ai |
---|---|
State | Accepted |
Headers |
Return-Path: <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp5790227vqr; Fri, 23 Jun 2023 06:57:13 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ720mtujl0XLk2QhMDk83YbZWMDB1b5ef4WDBijYxtnZlLqHPHIRkr0t1Eaac2uMgv3IebC X-Received: by 2002:a05:6402:3c9:b0:51b:fc9b:9813 with SMTP id t9-20020a05640203c900b0051bfc9b9813mr646993edw.24.1687528633425; Fri, 23 Jun 2023 06:57:13 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687528633; cv=none; d=google.com; s=arc-20160816; b=sm00qdlJ8YP14oxGtdWHI551e5mRHHMtPaW8G+2DHw3QPuITGMdPNZcB7AEaPhHGI0 0nh88sWaqKpZNspYXtH2xl+0NrQ8jD1plzEWYzIUd3LBTU9fEiF8Zw4rG/Y9ndFqkjDN E0L5+CTMDTu/QO5F9y7M33OBJttp5t5GQLs8Ak0XqD1l2hTHcgWLZbIXgWnp3N7vSWNm 6yvG0rTsDDrLCTGzKPc4YlHzhl/iebsn5qlbkdG84SjNvoGRqT493e3Ne0G5IYJcmEVV 4n9IhBjPuZz1eSY0474Eot9TlErU+DzDLqq4It61bb+t8BnUhA8d6DUe5BivDSWcjxf2 2iSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:feedback-id :content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:dmarc-filter:delivered-to; bh=LDH7hIuHBehMaQzn6YOMd9PW63N2k7e53VwLGYbRx7o=; b=EKkMDgQSOJNy5AG5c16Bnxvu7mpdUcQ+GjoekuhsuuAAHhvxebxize2/6OsA4F7IWd 1jE9RpouRE1dP3LvuX/AYtvIdomQOrBaUDxF9vteHwhxUyiQ3GKgnXP2W6jSgv+BcMnx PMrBfMRaoxVFu2XM3Febh1rJrcA89RlABsPXIZSjSTLueTph6PMf8wSj5oSQcOSGRr/T vk5gla3mMNTVi1dhH7qt1rNL+SwT6qHApdO1+RbnjhGGQ/5ObIbNgYMYLEMINQ14/vaY cjUGNydTXpU48Uj93GPNJKcJp3yWBXWVoV/+E+r5Lu/WXxQXML/govIKnftOIMAGt9jF XCHQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from sourceware.org (server2.sourceware.org. [2620:52:3:1:0:246e:9693:128c]) by mx.google.com with ESMTPS id v14-20020aa7d80e000000b0051843d33c1asi4581812edq.143.2023.06.23.06.57.13 for <ouuuleilei@gmail.com> (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jun 2023 06:57:13 -0700 (PDT) Received-SPF: pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) client-ip=2620:52:3:1:0:246e:9693:128c; Authentication-Results: mx.google.com; spf=pass (google.com: domain of gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org designates 2620:52:3:1:0:246e:9693:128c as permitted sender) smtp.mailfrom="gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org" Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 6FC0A385842B for <ouuuleilei@gmail.com>; Fri, 23 Jun 2023 13:57:06 +0000 (GMT) X-Original-To: gcc-patches@gcc.gnu.org Delivered-To: gcc-patches@gcc.gnu.org Received: from smtpbg150.qq.com (smtpbg150.qq.com [18.132.163.193]) by sourceware.org (Postfix) with ESMTPS id 8732E3858CD1 for <gcc-patches@gcc.gnu.org>; Fri, 23 Jun 2023 13:56:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 8732E3858CD1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivai.ai Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivai.ai X-QQ-mid: bizesmtp76t1687528597t73ippgj Received: from rios-cad5.localdomain ( [58.60.1.11]) by bizesmtp.qq.com (ESMTP) with id ; Fri, 23 Jun 2023 21:56:36 +0800 (CST) X-QQ-SSF: 01400000000000G0S000000A0000000 X-QQ-FEAT: tA/k9KUJEmb8YoQj1RLCiVXEo6cx2TuQHtufK8DLhjNvV89wo1EtULo/TgrIX OngEsn0Y6EjeIHnQyW3g7IIq/xHPwJ955jUNQip5O64VfV8HwcJu4fe8iLZd+96Opw1mE6I TqkAbvpQV0n0pb8FIPpzjV2igwDDmzSRUUh8zTIccFrjx07HXPitnDNsCzcVjwnw0wp1jiO di+4OZxltUJEqQYaXPQI3oU4uRR49oAbp71XPVZzi1ZiaXxO8TDDjgtNsNKY8AqXdxjICGL TNF2G+rC2uY59rZlBP1k5CsNZ63qPbQFM03kkltMDgLeDmHNpoP3gNitHbgMZ7+FxJw627j rfWKWRfgs4g2ry9XcXCQaZyr6W+ZyuLTAgOkCIPt0MhMONyDXk0Stm8QGfxStO4YTaZKZA5 X-QQ-GoodBg: 2 X-BIZMAIL-ID: 16430416265273649311 From: juzhe.zhong@rivai.ai To: gcc-patches@gcc.gnu.org Cc: rguenther@suse.de, richard.sandiford@arm.com, Ju-Zhe Zhong <juzhe.zhong@rivai.ai> Subject: [PATCH] SSA ALIAS: Apply LEN_MASK_{LOAD, STORE} into SSA alias analysis Date: Fri, 23 Jun 2023 21:56:35 +0800 Message-Id: <20230623135635.4100947-1-juzhe.zhong@rivai.ai> X-Mailer: git-send-email 2.36.3 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-QQ-SENDSIZE: 520 Feedback-ID: bizesmtp:rivai.ai:qybglogicsvrgz:qybglogicsvrgz7a-one-0 X-Spam-Status: No, score=-12.1 required=5.0 tests=BAYES_00, GIT_PATCH_0, KAM_DMARC_STATUS, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org> List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe> List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/> List-Post: <mailto:gcc-patches@gcc.gnu.org> List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help> List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>, <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe> Errors-To: gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org Sender: "Gcc-patches" <gcc-patches-bounces+ouuuleilei=gmail.com@gcc.gnu.org> X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769502024339973120?= X-GMAIL-MSGID: =?utf-8?q?1769502024339973120?= |
Series |
SSA ALIAS: Apply LEN_MASK_{LOAD, STORE} into SSA alias analysis
|
|
Checks
Context | Check | Description |
---|---|---|
snail/gcc-patch-check | success | Github commit url |
Commit Message
juzhe.zhong@rivai.ai
June 23, 2023, 1:56 p.m. UTC
From: Ju-Zhe Zhong <juzhe.zhong@rivai.ai>
gcc/ChangeLog:
* tree-ssa-alias.cc (ref_maybe_used_by_call_p_1): Apply LEN_MASK_{LOAD,STORE}
---
gcc/tree-ssa-alias.cc | 2 ++
1 file changed, 2 insertions(+)
Comments
On 6/23/23 07:56, juzhe.zhong@rivai.ai wrote: > From: Ju-Zhe Zhong <juzhe.zhong@rivai.ai> > > gcc/ChangeLog: > > * tree-ssa-alias.cc (ref_maybe_used_by_call_p_1): Apply LEN_MASK_{LOAD,STORE} > > --- > gcc/tree-ssa-alias.cc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/gcc/tree-ssa-alias.cc b/gcc/tree-ssa-alias.cc > index e1bc04b82ba..92dc1bb9987 100644 > --- a/gcc/tree-ssa-alias.cc > +++ b/gcc/tree-ssa-alias.cc > @@ -2815,11 +2815,13 @@ ref_maybe_used_by_call_p_1 (gcall *call, ao_ref *ref, bool tbaa_p) > case IFN_SCATTER_STORE: > case IFN_MASK_SCATTER_STORE: > case IFN_LEN_STORE: > + case IFN_LEN_MASK_STORE: > return false; > case IFN_MASK_STORE_LANES: > goto process_args; > case IFN_MASK_LOAD: > case IFN_LEN_LOAD: > + case IFN_LEN_MASK_LOAD: > case IFN_MASK_LOAD_LANES: > { > ao_ref rhs_ref; Don't you need to adjust how you compute the size for the LEN_MASK_LOAD case? jeff
Not sure since I saw MASK_STORE/LEN_STORE didn't compute size. juzhe.zhong@rivai.ai From: Jeff Law Date: 2023-06-24 03:20 To: juzhe.zhong; gcc-patches CC: rguenther; richard.sandiford Subject: Re: [PATCH] SSA ALIAS: Apply LEN_MASK_{LOAD, STORE} into SSA alias analysis On 6/23/23 07:56, juzhe.zhong@rivai.ai wrote: > From: Ju-Zhe Zhong <juzhe.zhong@rivai.ai> > > gcc/ChangeLog: > > * tree-ssa-alias.cc (ref_maybe_used_by_call_p_1): Apply LEN_MASK_{LOAD,STORE} > > --- > gcc/tree-ssa-alias.cc | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/gcc/tree-ssa-alias.cc b/gcc/tree-ssa-alias.cc > index e1bc04b82ba..92dc1bb9987 100644 > --- a/gcc/tree-ssa-alias.cc > +++ b/gcc/tree-ssa-alias.cc > @@ -2815,11 +2815,13 @@ ref_maybe_used_by_call_p_1 (gcall *call, ao_ref *ref, bool tbaa_p) > case IFN_SCATTER_STORE: > case IFN_MASK_SCATTER_STORE: > case IFN_LEN_STORE: > + case IFN_LEN_MASK_STORE: > return false; > case IFN_MASK_STORE_LANES: > goto process_args; > case IFN_MASK_LOAD: > case IFN_LEN_LOAD: > + case IFN_LEN_MASK_LOAD: > case IFN_MASK_LOAD_LANES: > { > ao_ref rhs_ref; Don't you need to adjust how you compute the size for the LEN_MASK_LOAD case? jeff
On 6/23/23 17:21, 钟居哲 wrote:
> Not sure since I saw MASK_STORE/LEN_STORE didn't compute size.
Yea, I think you're right. We take the size from the LHS. My mistake.
This is fine for the trunk.
jeff
Committed, thanks Jeff. Pan -----Original Message----- From: Gcc-patches <gcc-patches-bounces+pan2.li=intel.com@gcc.gnu.org> On Behalf Of Jeff Law via Gcc-patches Sent: Saturday, June 24, 2023 10:09 PM To: 钟居哲 <juzhe.zhong@rivai.ai>; gcc-patches <gcc-patches@gcc.gnu.org> Cc: rguenther <rguenther@suse.de>; richard.sandiford <richard.sandiford@arm.com> Subject: Re: [PATCH] SSA ALIAS: Apply LEN_MASK_{LOAD, STORE} into SSA alias analysis On 6/23/23 17:21, 钟居哲 wrote: > Not sure since I saw MASK_STORE/LEN_STORE didn't compute size. Yea, I think you're right. We take the size from the LHS. My mistake. This is fine for the trunk. jeff
diff --git a/gcc/tree-ssa-alias.cc b/gcc/tree-ssa-alias.cc index e1bc04b82ba..92dc1bb9987 100644 --- a/gcc/tree-ssa-alias.cc +++ b/gcc/tree-ssa-alias.cc @@ -2815,11 +2815,13 @@ ref_maybe_used_by_call_p_1 (gcall *call, ao_ref *ref, bool tbaa_p) case IFN_SCATTER_STORE: case IFN_MASK_SCATTER_STORE: case IFN_LEN_STORE: + case IFN_LEN_MASK_STORE: return false; case IFN_MASK_STORE_LANES: goto process_args; case IFN_MASK_LOAD: case IFN_LEN_LOAD: + case IFN_LEN_MASK_LOAD: case IFN_MASK_LOAD_LANES: { ao_ref rhs_ref;