Message ID | 20230623113009.2512206-5-abel.vesa@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp5707055vqr; Fri, 23 Jun 2023 04:44:28 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7uIJxxse+ULXwfd+Sw7t0R8/gWM72ZEa21Z94waGVhAO3T1jNhwp2H8qJemiwYAXD5x5X1 X-Received: by 2002:a05:6a00:1799:b0:668:7292:b2c6 with SMTP id s25-20020a056a00179900b006687292b2c6mr12720284pfg.14.1687520668530; Fri, 23 Jun 2023 04:44:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687520668; cv=none; d=google.com; s=arc-20160816; b=nJmdIEy4V+sTD2vBYWII77nXQQw4KRObMzY5Enr7tXuXhzzkkxK9UPK0cGDEW/R2E4 OIq5XPwyW3nVPHi+KIcCd68JL1gzaNbtDUE2jWgz5hEDwOuYtajm8nl08I9LH8YvgoVE SWX3cqRVXJENDPl2kqH6QvRLGDay6IsMedPShGG3UwRUgAc83N7bFToxqsTwEK33DFTL PLMSUvVoV0A9m5mTUCAG9c7+8T+GNW000hEU4N+OwT0ArNVRL3GqgpplkJw3E6nx1h/l 66Onkmf8ghXauDbUdJlZt56WKMLBBEsCgliDQvbVQ3BgNczRg8IIZd81K/oyawmFFf5t G8qw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=CHaK7rdeki9lfbQ0L5n5XKF0tPcuK6yq3LmKlu+Ivww=; b=U6KAT/1vMt1fah1n/KvhEBkUUVibq0uh9GoZQ6hHXskcs1aFEUbEISjwy1mMDB7GaJ 8uycXpNPzOt72k3QbcA4MeXDmjciuMd0GRgi0j/AGL7l3Am0AGKC15AKHmMGKTcjyEvK pZlFuY0GoLBvFB9FICZ6nk6u/FFOf+zhGzWpW2HpEyroFG02YqERXlfksdrSz9iQSi7y wVmkXJ7KQcbx0lQoxIvYlb0creoqlxzsxGqlmQY87y8V7Kri3fwp9YkEGnmpMF6sAW2T 15QEj0maVrr6harofhaLAwKp6IfpRhGQYIhmfFa2zfWO3xQ5nRu9px2iMNbVpdb4INTy JHqw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fSaEd9sr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id p65-20020a625b44000000b0064f6a531c88si8221158pfb.323.2023.06.23.04.44.13; Fri, 23 Jun 2023 04:44:28 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=fSaEd9sr; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231752AbjFWLaq (ORCPT <rfc822;maxin.john@gmail.com> + 99 others); Fri, 23 Jun 2023 07:30:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59890 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231683AbjFWLa3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 23 Jun 2023 07:30:29 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6C29A26B7 for <linux-kernel@vger.kernel.org>; Fri, 23 Jun 2023 04:30:22 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-51a3e6a952aso532301a12.3 for <linux-kernel@vger.kernel.org>; Fri, 23 Jun 2023 04:30:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687519821; x=1690111821; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=CHaK7rdeki9lfbQ0L5n5XKF0tPcuK6yq3LmKlu+Ivww=; b=fSaEd9srqlW02t5EJIQeM2hse3zR9gmx3WuT3NE1AjtZVL3CZf8n94Kn2z9ki1NMuI sGOyQIBwsuc26lpQrl0mmIqU1IIXV9Dpf29zJOg++QsDvL28tShS00zdAchY5fMlZs0d 86tjC0uiX7U6ZwK+I0gqr5IVUo95JpdduZfL4hLIKJBYdt44ia7LHU6prA/Zz6i1zHtt 80o6z7SFxpvFyG6+pPmACxGS/zyDKdJ1XkLS8umQdOlGU8mJzFatDynZyqhBrGhNCQDB BJPzQpStmicRGPzE9+w3ggL5myuXjxTA9KqMuBGDBlJv+F7tdmk33N/WnH85EgBLTNJd oYyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687519821; x=1690111821; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CHaK7rdeki9lfbQ0L5n5XKF0tPcuK6yq3LmKlu+Ivww=; b=DKKGjj5x3yrHXVbUvcQAFCcQ40lC0UlJcaYemmnMi0aWtjX9VF3zsF371EhQWzIVfF hkZ8BubJJ/l/s+TWlOgQ7jVu+yzn/v9rJodzAwT6D9E5C2Ja4l5lS3pHbAYpqIvx+ScH 3SUENWBOe2lTqLiJOUxV7G6qZsPIIw9UGnd91/rf+O+WmEGEseiYgEPogLCWBDIe2mou AgGsoV3CL4NT3G5ad4KSyE5ogP41+qMbKouCyhe+Nl1O87WzChwbgCfmeQ5rNnd6Bm9w gfUcOA9KggRFhN2MdcIMGmNFztjujThTmTumVZ0BFkfHzArPBwvYbcdxxiuq02OAxqUl REkA== X-Gm-Message-State: AC+VfDy1baLgXFuAsslWgO8IOqJTlxA6OSzBzl/JoWV8Xio8y8KeetBa lt9k4dH0gikUEpHJDJ41hLlVWw== X-Received: by 2002:a17:907:7ba5:b0:973:fd02:a41f with SMTP id ne37-20020a1709077ba500b00973fd02a41fmr21528891ejc.40.1687519820927; Fri, 23 Jun 2023 04:30:20 -0700 (PDT) Received: from hackbox.lan ([62.231.110.100]) by smtp.gmail.com with ESMTPSA id z17-20020a1709063ad100b009821ce1ea33sm5908033ejd.7.2023.06.23.04.30.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jun 2023 04:30:19 -0700 (PDT) From: Abel Vesa <abel.vesa@linaro.org> To: Manivannan Sadhasivam <mani@kernel.org>, Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, "Martin K . Petersen" <martin.petersen@oracle.com>, Alim Akhtar <alim.akhtar@samsung.com>, Avri Altman <avri.altman@wdc.com>, Bart Van Assche <bvanassche@acm.org> Cc: linux-arm-msm@vger.kernel.org, linux-scsi@vger.kernel.org, devicetree@vger.kernel.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org> Subject: [PATCH 4/5] scsi: dt-bindings: ufs: qcom: Fix sm8450 clocks Date: Fri, 23 Jun 2023 14:30:08 +0300 Message-Id: <20230623113009.2512206-5-abel.vesa@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230623113009.2512206-1-abel.vesa@linaro.org> References: <20230623113009.2512206-1-abel.vesa@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769493672164062883?= X-GMAIL-MSGID: =?utf-8?q?1769493672164062883?= |
Series |
scsi: dt-bindings: ufs: qcom: Some fixes to clear all dtbs_check warnings
|
|
Commit Message
Abel Vesa
June 23, 2023, 11:30 a.m. UTC
The sm8450 has an ICE clock, so move the compatible to the proper
clocks check.
Fixes: 462c5c0aa798 ("dt-bindings: ufs: qcom,ufs: convert to dtschema")
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Comments
On Fri, 23 Jun 2023 14:30:08 +0300, Abel Vesa wrote: > The sm8450 has an ICE clock, so move the compatible to the proper > clocks check. > > Fixes: 462c5c0aa798 ("dt-bindings: ufs: qcom,ufs: convert to dtschema") > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: clocks: [[4294967295, 151], [4294967295, 10], [4294967295, 150], [4294967295, 166], [4294967295, 0], [4294967295, 164], [4294967295, 160], [4294967295, 162]] is too short from schema $id: http://devicetree.org/schemas/ufs/qcom,ufs.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: clock-names: ['core_clk', 'bus_aggr_clk', 'iface_clk', 'core_clk_unipro', 'ref_clk', 'tx_lane0_sync_clk', 'rx_lane0_sync_clk', 'rx_lane1_sync_clk'] is too short from schema $id: http://devicetree.org/schemas/ufs/qcom,ufs.yaml# /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: reg: [[0, 30949376, 0, 12288]] is too short from schema $id: http://devicetree.org/schemas/ufs/qcom,ufs.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230623113009.2512206-5-abel.vesa@linaro.org The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Fri, Jun 23, 2023 at 06:21:24AM -0600, Rob Herring wrote: > > On Fri, 23 Jun 2023 14:30:08 +0300, Abel Vesa wrote: > > The sm8450 has an ICE clock, so move the compatible to the proper > > clocks check. > > > > Fixes: 462c5c0aa798 ("dt-bindings: ufs: qcom,ufs: convert to dtschema") > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > > --- > > Documentation/devicetree/bindings/ufs/qcom,ufs.yaml | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' > on your patch (DT_CHECKER_FLAGS is new in v5.13): > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: clocks: [[4294967295, 151], [4294967295, 10], [4294967295, 150], [4294967295, 166], [4294967295, 0], [4294967295, 164], [4294967295, 160], [4294967295, 162]] is too short > from schema $id: http://devicetree.org/schemas/ufs/qcom,ufs.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: clock-names: ['core_clk', 'bus_aggr_clk', 'iface_clk', 'core_clk_unipro', 'ref_clk', 'tx_lane0_sync_clk', 'rx_lane0_sync_clk', 'rx_lane1_sync_clk'] is too short > from schema $id: http://devicetree.org/schemas/ufs/qcom,ufs.yaml# > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/ufs/qcom,ufs.example.dtb: ufs@1d84000: reg: [[0, 30949376, 0, 12288]] is too short > from schema $id: http://devicetree.org/schemas/ufs/qcom,ufs.yaml# Looks like patch 1 didn't apply for me and would fix this. Rob
diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml index 4dad3f9ba81f..0209713d1f88 100644 --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml @@ -118,7 +118,6 @@ allOf: - qcom,sc8280xp-ufshc - qcom,sm8250-ufshc - qcom,sm8350-ufshc - - qcom,sm8450-ufshc - qcom,sm8550-ufshc then: properties: @@ -147,6 +146,7 @@ allOf: - qcom,sdm845-ufshc - qcom,sm6350-ufshc - qcom,sm8150-ufshc + - qcom,sm8450-ufshc then: properties: clocks: