diff mbox series

mtd: nand: raw: qcom_nandc: handle ret from parse with codeword_fixup

Message ID 20221021165304.19991-1-ansuelsmth@gmail.com
State New
Headers
Series mtd: nand: raw: qcom_nandc: handle ret from parse with codeword_fixup |

Commit Message

Christian Marangi Oct. 21, 2022, 4:53 p.m. UTC 
  With use_codeword_fixup enabled, any return from
mtd_device_parse_register gets overwritten. Aside from the clear bug, this
is also problematic as a parser can EPROBE_DEFER and because this is not
correctly handled, the nand is never rescanned later in the bootup
process.

An example of this problem is when smem requires additional time to be
probed and nandc use qcomsmempart as parser. Parser will return
EPROBE_DEFER but in the current code this ret gets overwritten by
qcom_nand_host_parse_boot_partitions and qcom_nand_host_init_and_register
return 0.

Correctly handle the return code from mtd_device_parse_register so that
any error from this function is not ignored.

Fixes: 862bdedd7f4b ("mtd: nand: raw: qcom_nandc: add support for unprotected spare data pages")
Cc: stable@vger.kernel.org # v6.0+
Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>
---
 drivers/mtd/nand/raw/qcom_nandc.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

Comments

Miquel Raynal Nov. 7, 2022, 4:20 p.m. UTC | #1 
On Fri, 2022-10-21 at 16:53:04 UTC, Christian Marangi wrote:
> With use_codeword_fixup enabled, any return from
> mtd_device_parse_register gets overwritten. Aside from the clear bug, this
> is also problematic as a parser can EPROBE_DEFER and because this is not
> correctly handled, the nand is never rescanned later in the bootup
> process.
> 
> An example of this problem is when smem requires additional time to be
> probed and nandc use qcomsmempart as parser. Parser will return
> EPROBE_DEFER but in the current code this ret gets overwritten by
> qcom_nand_host_parse_boot_partitions and qcom_nand_host_init_and_register
> return 0.
> 
> Correctly handle the return code from mtd_device_parse_register so that
> any error from this function is not ignored.
> 
> Fixes: 862bdedd7f4b ("mtd: nand: raw: qcom_nandc: add support for unprotected spare data pages")
> Cc: stable@vger.kernel.org # v6.0+
> Signed-off-by: Christian Marangi <ansuelsmth@gmail.com>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git mtd/fixes, thanks.

Miquel
diff mbox series

Patch

diff --git a/drivers/mtd/nand/raw/qcom_nandc.c b/drivers/mtd/nand/raw/qcom_nandc.c
index 8f80019a9f01..198a44794d2d 100644
--- a/drivers/mtd/nand/raw/qcom_nandc.c
+++ b/drivers/mtd/nand/raw/qcom_nandc.c
@@ -3167,16 +3167,18 @@  static int qcom_nand_host_init_and_register(struct qcom_nand_controller *nandc,
 
 	ret = mtd_device_parse_register(mtd, probes, NULL, NULL, 0);
 	if (ret)
-		nand_cleanup(chip);
+		goto err;
 
 	if (nandc->props->use_codeword_fixup) {
 		ret = qcom_nand_host_parse_boot_partitions(nandc, host, dn);
-		if (ret) {
-			nand_cleanup(chip);
-			return ret;
-		}
+		if (ret)
+			goto err;
 	}
 
+	return 0;
+
+err:
+	nand_cleanup(chip);
 	return ret;
 }