| Message ID | ZJR66f3UY0UFZJ01@work |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp5212940vqr;
Thu, 22 Jun 2023 10:03:52 -0700 (PDT)
X-Google-Smtp-Source:
ACHHUZ5oQiWs8LHrO4X5Y84WbSYu35DmdOHKcuZLX6Q+HgAL+o9TIvQQjRehkUBrYS2F+398DkXR
X-Received: by 2002:a05:6a20:3c8e:b0:120:e40a:a117 with SMTP id
b14-20020a056a203c8e00b00120e40aa117mr15851861pzj.10.1687453432105;
Thu, 22 Jun 2023 10:03:52 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1687453432; cv=none;
d=google.com; s=arc-20160816;
b=Gt+ctnmB7l6dvSZAD7OPsuB7ls8lszxH9E9q1MMatQWpJoadK9iO3aVFBH5yid+wFt
lNMV9V1X1nwFr81PdkXT+xnEwemnwHSV1LUnkhCfDbcEQKqbgaXBhVA+5V6DaihM4G/x
wciGThgwzQh5+vfuaELVVHHTIh3omnnU9PlRDQ3en/1eHnqjTWmnfOioQHL9xMQp0hHm
JjrPio4aBKfIVUhJLTEF5m3/kH1wC4qfl6RCqDyr/eCqd2KgwwVxn51asPDVfKpzuMMX
jRfmUAi2xWQcXGUpQzvxs7pkJ7T3uuC6kHYAIx/+Zn3JbG4ywm8MsdWtG/6a7XNvBPWy
cVUg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-disposition:mime-version:message-id
:subject:cc:to:from:date:dkim-signature;
bh=U0x5AWlPS+ZiB9Jt4d8oHhfZXefhee7FweXi2oblYW8=;
b=psqCiOQ1+DG2p3J/FVTV7aGuVZRjq5KXXUk+zZjiqA5upfJWwksbuG7cVlNX7AYTrS
XfZrXYbo/qta8W+1uNGjDEYtxvLoj9WOOBlgcpoKnDAmLzTMcBJX0QHdi/Oh3y3boS7J
yJcIO7ZnJq48AX9iSeEHoAzfPvF0VTpzZ+o+Iau2hULjeiHKxwr7QosBZ+R3Dns1sahy
hhCFAbxvNtQpkRJws2mLzUfKmnhVteoHXErODbrfr0muhg+Ikr69csAfNbyW6DYBGEAJ
P6eYGQ/uPlSdg6Hde0p9zYEz6dJInNUC+p21iYdEAVjoSlE8CznSkI3r6pzNfHz+gAZa
Lo7g==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RVvLNYYI;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
x8-20020a656aa8000000b00553828de1cbsi2720352pgu.791.2023.06.22.10.03.11;
Thu, 22 Jun 2023 10:03:52 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@kernel.org header.s=k20201202 header.b=RVvLNYYI;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231311AbjFVQpn (ORCPT <rfc822;maxin.john@gmail.com> + 99 others);
Thu, 22 Jun 2023 12:45:43 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39148 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229812AbjFVQpk (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Thu, 22 Jun 2023 12:45:40 -0400
Received: from dfw.source.kernel.org (dfw.source.kernel.org
[IPv6:2604:1380:4641:c500::1])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 668F21FCC;
Thu, 22 Jun 2023 09:45:39 -0700 (PDT)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (2048 bits))
(No client certificate requested)
by dfw.source.kernel.org (Postfix) with ESMTPS id F00F0618B0;
Thu, 22 Jun 2023 16:45:38 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id A2C70C433C0;
Thu, 22 Jun 2023 16:45:37 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
s=k20201202; t=1687452338;
bh=mPXln+DmOt1KklaFQd3MJkA1//mD28lDoq4prtu8Qoo=;
h=Date:From:To:Cc:Subject:From;
b=RVvLNYYIvAmGiq4BaiJ+/c8othvgt+IMGlJMhdFQy9LZVYJ2Xh3k64zYSQloMZJxq
rQUpRTSch8lojQ25h/Zkqy36qoY2/cYl0Fe5skuKVC8TNUW4Bzdhv3qgCosnUssb4L
AmrPOEMU57ueZ/pSZr8IBXKKv+rYNEx55PnTrKLtV+eihP/7kntUs/EF9RzRL5/Mv3
Srf/2XvnQa8LObzVYlGc1ZQYan5qonEfQc7KNytrYp5PiFRZy0Z6LMmI1PbguFJpXm
HpaTe9Kwwuo757fSU8ESd7Xlu+L93xv+Bh1KEmOc/7eCSt3RgcemqSqPGx0ppW+/J5
expgtpPfn9WuQ==
Date: Thu, 22 Jun 2023 10:46:33 -0600
From: "Gustavo A. R. Silva" <gustavoars@kernel.org>
To: Helge Deller <deller@gmx.de>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
linux-hardening@vger.kernel.org
Subject: [PATCH][next] fbdev: sh7760fb: Fix -Wimplicit-fallthrough warnings
Message-ID: <ZJR66f3UY0UFZJ01@work>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,
DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED,
SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1769423170093208254?=
X-GMAIL-MSGID: =?utf-8?q?1769423170093208254?=
|
| Series |
[next] fbdev: sh7760fb: Fix -Wimplicit-fallthrough warnings
|
|
Commit Message
Gustavo A. R. Silva
June 22, 2023, 4:46 p.m. UTC
Fix the following fallthrough warnings seen after building sh
architecture with sh7763rdp_defconfig configuration:
drivers/video/fbdev/sh7760fb.c: In function 'sh7760fb_get_color_info':
drivers/video/fbdev/sh7760fb.c:138:23: warning: this statement may fall through [-Wimplicit-fallthrough=]
138 | lgray = 1;
| ~~~~~~^~~
drivers/video/fbdev/sh7760fb.c:139:9: note: here
139 | case LDDFR_4BPP:
| ^~~~
drivers/video/fbdev/sh7760fb.c:143:23: warning: this statement may fall through [-Wimplicit-fallthrough=]
143 | lgray = 1;
| ~~~~~~^~~
drivers/video/fbdev/sh7760fb.c:144:9: note: here
144 | case LDDFR_8BPP:
| ^~~~
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
---
drivers/video/fbdev/sh7760fb.c | 2 ++
1 file changed, 2 insertions(+)
Comments
On 6/22/23 18:46, Gustavo A. R. Silva wrote: > Fix the following fallthrough warnings seen after building sh > architecture with sh7763rdp_defconfig configuration: > > drivers/video/fbdev/sh7760fb.c: In function 'sh7760fb_get_color_info': > drivers/video/fbdev/sh7760fb.c:138:23: warning: this statement may fall through [-Wimplicit-fallthrough=] > 138 | lgray = 1; > | ~~~~~~^~~ > drivers/video/fbdev/sh7760fb.c:139:9: note: here > 139 | case LDDFR_4BPP: > | ^~~~ > drivers/video/fbdev/sh7760fb.c:143:23: warning: this statement may fall through [-Wimplicit-fallthrough=] > 143 | lgray = 1; > | ~~~~~~^~~ > drivers/video/fbdev/sh7760fb.c:144:9: note: here > 144 | case LDDFR_8BPP: > | ^~~~ > > Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org> applied. Thanks! Helge > --- > drivers/video/fbdev/sh7760fb.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/video/fbdev/sh7760fb.c b/drivers/video/fbdev/sh7760fb.c > index 768011bdb430..98c5227098a8 100644 > --- a/drivers/video/fbdev/sh7760fb.c > +++ b/drivers/video/fbdev/sh7760fb.c > @@ -136,11 +136,13 @@ static int sh7760fb_get_color_info(struct device *dev, > break; > case LDDFR_4BPP_MONO: > lgray = 1; > + fallthrough; > case LDDFR_4BPP: > lbpp = 4; > break; > case LDDFR_6BPP_MONO: > lgray = 1; > + fallthrough; > case LDDFR_8BPP: > lbpp = 8; > break;
diff --git a/drivers/video/fbdev/sh7760fb.c b/drivers/video/fbdev/sh7760fb.c index 768011bdb430..98c5227098a8 100644 --- a/drivers/video/fbdev/sh7760fb.c +++ b/drivers/video/fbdev/sh7760fb.c @@ -136,11 +136,13 @@ static int sh7760fb_get_color_info(struct device *dev, break; case LDDFR_4BPP_MONO: lgray = 1; + fallthrough; case LDDFR_4BPP: lbpp = 4; break; case LDDFR_6BPP_MONO: lgray = 1; + fallthrough; case LDDFR_8BPP: lbpp = 8; break;