diff mbox series

[1/7] dt-bindings: qcom: Document new msm8916-samsung devices

Message ID 20230622000254.48260-1-linmengbo0689@protonmail.com
State New
Headers
Series arm64: dts: qcom: msm8916-samsung-fortuna: Add initial device trees |

Commit Message

Lin, Meng-Bo June 22, 2023, 12:03 a.m. UTC 
  Document the new following device tree bindings used in their
device trees:

- samsung,fortuna3g
- samsung,fortunaltezt
- samsung,gprimeltecan
- samsung,grandprimelte
- samsung,heatqlte
- samsung,rossa

Signed-off-by: Lin, Meng-Bo <linmengbo0689@protonmail.com>
---
 Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
 1 file changed, 6 insertions(+)

Comments

Krzysztof Kozlowski June 22, 2023, 8:31 a.m. UTC | #1 
On 22/06/2023 02:03, Lin, Meng-Bo wrote:
> Document the new following device tree bindings used in their
> device trees:
> 
> - samsung,fortuna3g
> - samsung,fortunaltezt
> - samsung,gprimeltecan
> - samsung,grandprimelte
> - samsung,heatqlte
> - samsung,rossa

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC.  It might happen, that command when run on an older
kernel, gives you outdated entries.  Therefore please be sure you base
your patches on recent Linux kernel.

You missed at least DT list (maybe more), so this won't be tested by our
tools. Performing review on untested code might be a waste of time, thus
I will skip this patch entirely till you follow the process allowing the
patch to be tested.

Please kindly resend and include all necessary To/Cc entries.

You just ignored maintainers entirely... It's not even about testing but
no one would apply it.

Best regards,
Krzysztof
Rob Herring June 22, 2023, 2:40 p.m. UTC | #2 
On Thu, Jun 22, 2023 at 10:31:24AM +0200, Krzysztof Kozlowski wrote:
> On 22/06/2023 02:03, Lin, Meng-Bo wrote:
> > Document the new following device tree bindings used in their
> > device trees:
> > 
> > - samsung,fortuna3g
> > - samsung,fortunaltezt
> > - samsung,gprimeltecan
> > - samsung,grandprimelte
> > - samsung,heatqlte
> > - samsung,rossa
> 
> Please use scripts/get_maintainers.pl to get a list of necessary people
> and lists to CC.  It might happen, that command when run on an older
> kernel, gives you outdated entries.  Therefore please be sure you base
> your patches on recent Linux kernel.
> 
> You missed at least DT list (maybe more), so this won't be tested by our
> tools. Performing review on untested code might be a waste of time, thus
> I will skip this patch entirely till you follow the process allowing the
> patch to be tested.
> 
> Please kindly resend and include all necessary To/Cc entries.
> 
> You just ignored maintainers entirely... It's not even about testing but
> no one would apply it.

Something strange going on with this one as it still made it to the DT 
patchwork, so it did go to the DT list. Must have been Bcc'ed.

The patches are also quoted-printable encoded which shouldn't be used.

Rob
Krzysztof Kozlowski June 22, 2023, 3:04 p.m. UTC | #3 
On 22/06/2023 16:40, Rob Herring wrote:
> On Thu, Jun 22, 2023 at 10:31:24AM +0200, Krzysztof Kozlowski wrote:
>> On 22/06/2023 02:03, Lin, Meng-Bo wrote:
>>> Document the new following device tree bindings used in their
>>> device trees:
>>>
>>> - samsung,fortuna3g
>>> - samsung,fortunaltezt
>>> - samsung,gprimeltecan
>>> - samsung,grandprimelte
>>> - samsung,heatqlte
>>> - samsung,rossa
>>
>> Please use scripts/get_maintainers.pl to get a list of necessary people
>> and lists to CC.  It might happen, that command when run on an older
>> kernel, gives you outdated entries.  Therefore please be sure you base
>> your patches on recent Linux kernel.
>>
>> You missed at least DT list (maybe more), so this won't be tested by our
>> tools. Performing review on untested code might be a waste of time, thus
>> I will skip this patch entirely till you follow the process allowing the
>> patch to be tested.
>>
>> Please kindly resend and include all necessary To/Cc entries.
>>
>> You just ignored maintainers entirely... It's not even about testing but
>> no one would apply it.
> 
> Something strange going on with this one as it still made it to the DT 
> patchwork, so it did go to the DT list. Must have been Bcc'ed.
> 
> The patches are also quoted-printable encoded which shouldn't be used.

Maybe hidden feature of protonmail... Although other mails in the thread
were sent to everyone.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 450f616774e0..7172f657bfa4 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -235,11 +235,17 @@  properties:
               - samsung,a5u-eur
               - samsung,e5
               - samsung,e7
+              - samsung,fortuna3g
+              - samsung,fortunaltezt
+              - samsung,gprimeltecan
               - samsung,grandmax
+              - samsung,grandprimelte
               - samsung,gt510
               - samsung,gt58
+              - samsung,heatqlte
               - samsung,j5
               - samsung,j5x
+              - samsung,rossa
               - samsung,serranove
               - thwc,uf896
               - thwc,ufi001c