drm/mgag200: Fix a warning reported by Fi.CI.SPARSE

Message ID 20230621191139.2291139-1-suijingfeng@loongson.cn
State New
Headers
Series drm/mgag200: Fix a warning reported by Fi.CI.SPARSE |

Commit Message

Sui Jingfeng June 21, 2023, 7:11 p.m. UTC
  drivers/gpu/drm/mgag200/mgag200_drv.c:23:5: warning: symbol 'mgag200_modeset' was not declared. Should it be static?

Found in the log of Fi.CI.SPARSE test [1]

[1] https://patchwork.freedesktop.org/series/119249/

Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
---
 drivers/gpu/drm/mgag200/mgag200_drv.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Jocelyn Falempe June 22, 2023, 12:35 p.m. UTC | #1
This patch was already sent by Tom Rix last month:
https://patchwork.freedesktop.org/series/117881/

I can push it to drm-misc-next, if Thomas is ok.

Best regards,
  
Sui Jingfeng June 22, 2023, 1:32 p.m. UTC | #2
Hi,

Ah,  I forgot to check that before send a patch, sorry for the noise  :-)


On 2023/6/22 20:35, Jocelyn Falempe wrote:
> This patch was already sent by Tom Rix last month:
> https://patchwork.freedesktop.org/series/117881/
>
> I can push it to drm-misc-next, if Thomas is ok.
>
That sounds fine.

> Best regards,
>
  

Patch

diff --git a/drivers/gpu/drm/mgag200/mgag200_drv.c b/drivers/gpu/drm/mgag200/mgag200_drv.c
index 976f0ab2006b..abddf37f0ea1 100644
--- a/drivers/gpu/drm/mgag200/mgag200_drv.c
+++ b/drivers/gpu/drm/mgag200/mgag200_drv.c
@@ -20,7 +20,7 @@ 
 
 #include "mgag200_drv.h"
 
-int mgag200_modeset = -1;
+static int mgag200_modeset = -1;
 MODULE_PARM_DESC(modeset, "Disable/Enable modesetting");
 module_param_named(modeset, mgag200_modeset, int, 0400);