Message ID | 7cc1dea4833e6fb9b30aa35f801f14338578dfb1.1687423204.git.geert+renesas@glider.be |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp4943896vqr; Thu, 22 Jun 2023 02:50:09 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ4ohJCEjB4rKX97QkCHPEaWiCIm6tbzDbqlxHlPOEMdvu7p9u6OSxWdI13uMM784chcCjBV X-Received: by 2002:a17:90a:eb18:b0:25e:c876:26e9 with SMTP id j24-20020a17090aeb1800b0025ec87626e9mr21593581pjz.22.1687427409592; Thu, 22 Jun 2023 02:50:09 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1687427409; cv=none; d=google.com; s=arc-20160816; b=Zv55M+I2J5tBgUfPcG/ZeMdn9G4M/uNoqV6teWTCs2Bf2khXQk/NEiDBrQ1UL3zcZO LcFko2+JnI65imexmHr2BpeMJK1q+tacpNdG205VOcllJ/FqEz3KNLVfIIfY89nrHnBF aAc4t76C0kmeE6Hnud8pbEd6tL941zm/JZq4+4JMhkbGYEhL+DvClBcMvCBkfIWc54de Jzw/arOos43nHPT2Z8RGzmIH4P76JSFL6jidWeZDILTP/N8j+t90oGFBwT9p7u+Tqhdy abLf6vH1CC1JRQLsWOzYDVFiaVwrDbZBojg2qEP7GN/r3rRYOMsL0pBcf0kkG3xm4iPC IiVQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from; bh=npaepgHE+SANahOnIwVKBTvWdyFMP30URQTrbG6KQ1Y=; b=AQp1VjKiU7TWiU/PcpoXu3xsTbgrOiyizoILdYSR8GmxDmKRS32QKDqijW/OUjfnBI vF9NmQ0WdhdQjjqJbfcpI6+X/F7FHPp3VA+A1+ggzC3hz4R4rQOi3YCAdRWhsmptlvUF WJczmilzNYwvccmIL2jpKS0hHgaCdWb0pJeVUIbHGKN8NLe3Unx83doLL9mNPOtrEBQO h3ygyuvft6x9RARylwxHeOIcEstnih5QE568m7vrcxrtYP6mLKAzNZgfZasCHsZgvmFN hE+7Cpn4p8bSRQ7g88MLF+lRNt0T/YdeRsoaNIvglWxV0ROaBPjPXV19Tss+3u+pRxKf R+5g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id nh16-20020a17090b365000b00256551043fdsi6277798pjb.72.2023.06.22.02.49.57; Thu, 22 Jun 2023 02:50:09 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232170AbjFVJah (ORCPT <rfc822;maxin.john@gmail.com> + 99 others); Thu, 22 Jun 2023 05:30:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:36286 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232000AbjFVJ3n (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Thu, 22 Jun 2023 05:29:43 -0400 Received: from andre.telenet-ops.be (andre.telenet-ops.be [IPv6:2a02:1800:120:4::f00:15]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 987604220 for <linux-kernel@vger.kernel.org>; Thu, 22 Jun 2023 02:22:44 -0700 (PDT) Received: from ramsan.of.borg ([IPv6:2a02:1810:ac12:ed20:991a:a831:ea4b:6058]) by andre.telenet-ops.be with bizsmtp id C9Nj2A0021yfRTD019NjNe; Thu, 22 Jun 2023 11:22:43 +0200 Received: from rox.of.borg ([192.168.97.57]) by ramsan.of.borg with esmtp (Exim 4.95) (envelope-from <geert@linux-m68k.org>) id 1qCGWX-000BvU-CF; Thu, 22 Jun 2023 11:22:43 +0200 Received: from geert by rox.of.borg with local (Exim 4.95) (envelope-from <geert@linux-m68k.org>) id 1qCGWY-003Vvt-VX; Thu, 22 Jun 2023 11:22:42 +0200 From: Geert Uytterhoeven <geert+renesas@glider.be> To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>, Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>, David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>, Thomas Zimmermann <tzimmermann@suse.de>, Magnus Damm <magnus.damm@gmail.com> Cc: dri-devel@lists.freedesktop.org, linux-renesas-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Geert Uytterhoeven <geert+renesas@glider.be> Subject: [PATCH 04/39] drm: renesas: shmobile: Fix ARGB32 overlay format typo Date: Thu, 22 Jun 2023 11:21:16 +0200 Message-Id: <7cc1dea4833e6fb9b30aa35f801f14338578dfb1.1687423204.git.geert+renesas@glider.be> X-Mailer: git-send-email 2.34.1 In-Reply-To: <cover.1687423204.git.geert+renesas@glider.be> References: <cover.1687423204.git.geert+renesas@glider.be> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_NONE, T_SCC_BODY_TEXT_LINE autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1769395883414456731?= X-GMAIL-MSGID: =?utf-8?q?1769395883414456731?= |
Series |
drm: renesas: shmobile: Atomic conversion + DT support
|
|
Commit Message
Geert Uytterhoeven
June 22, 2023, 9:21 a.m. UTC
When configurating a CHn Source Image Format Register (LDBBSIFR), one
should use the corresponding LDBBSIFR_RPKF_* definition for overlay
planes, not the DDFR_PKF_* definition for the primary plane.
Fortunately both definitions resolve to the same value, so this bug did
not cause any harm.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
Comments
Hello! On 6/22/23 12:21 PM, Geert Uytterhoeven wrote: > When configurating Configuring? My spellchecker trips. :-) > a CHn Source Image Format Register (LDBBSIFR), one > should use the corresponding LDBBSIFR_RPKF_* definition for overlay > planes, not the DDFR_PKF_* definition for the primary plane. > > Fortunately both definitions resolve to the same value, so this bug did > not cause any harm. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> [...] MBR, Sergey
Hi Geert, Thank you for the patch. On Thu, Jun 22, 2023 at 11:21:16AM +0200, Geert Uytterhoeven wrote: > When configurating a CHn Source Image Format Register (LDBBSIFR), one > should use the corresponding LDBBSIFR_RPKF_* definition for overlay > planes, not the DDFR_PKF_* definition for the primary plane. > > Fortunately both definitions resolve to the same value, so this bug did > not cause any harm. > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be> With the typo in the commit message fixed, Reviewed-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com> > --- > drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c > index 0e34573c3cb3d032..7e49e2873da1bb6f 100644 > --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c > +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c > @@ -94,10 +94,10 @@ static void __shmob_drm_plane_setup(struct shmob_drm_plane *splane, > format |= LDBBSIFR_AL_1 | LDBBSIFR_RY | LDBBSIFR_RPKF_RGB24; > break; > case DRM_FORMAT_ARGB8888: > - format |= LDBBSIFR_AL_PK | LDBBSIFR_RY | LDDFR_PKF_ARGB32; > + format |= LDBBSIFR_AL_PK | LDBBSIFR_RY | LDBBSIFR_RPKF_ARGB32; > break; > case DRM_FORMAT_XRGB8888: > - format |= LDBBSIFR_AL_1 | LDBBSIFR_RY | LDDFR_PKF_ARGB32; > + format |= LDBBSIFR_AL_1 | LDBBSIFR_RY | LDBBSIFR_RPKF_ARGB32; > break; > case DRM_FORMAT_NV12: > case DRM_FORMAT_NV21:
diff --git a/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c b/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c index 0e34573c3cb3d032..7e49e2873da1bb6f 100644 --- a/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c +++ b/drivers/gpu/drm/renesas/shmobile/shmob_drm_plane.c @@ -94,10 +94,10 @@ static void __shmob_drm_plane_setup(struct shmob_drm_plane *splane, format |= LDBBSIFR_AL_1 | LDBBSIFR_RY | LDBBSIFR_RPKF_RGB24; break; case DRM_FORMAT_ARGB8888: - format |= LDBBSIFR_AL_PK | LDBBSIFR_RY | LDDFR_PKF_ARGB32; + format |= LDBBSIFR_AL_PK | LDBBSIFR_RY | LDBBSIFR_RPKF_ARGB32; break; case DRM_FORMAT_XRGB8888: - format |= LDBBSIFR_AL_1 | LDBBSIFR_RY | LDDFR_PKF_ARGB32; + format |= LDBBSIFR_AL_1 | LDBBSIFR_RY | LDBBSIFR_RPKF_ARGB32; break; case DRM_FORMAT_NV12: case DRM_FORMAT_NV21: