[5/5] arm64: dts: qcom: sdm845-mtp: add chassis-type property

Message ID 20230622-topic-sm8x50-upstream-chassis-type-v1-5-13f676eb71f3@linaro.org
State New
Headers
Series arm64: dts: qcom: add chassis-type to reference platforms |

Commit Message

Neil Armstrong June 22, 2023, 8:57 a.m. UTC
  Qualcomm's Mobile Test Platforms devices are handsets, set the
chassis-type property to 'handset'.

Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
---
 arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 1 +
 1 file changed, 1 insertion(+)
  

Comments

Konrad Dybcio June 22, 2023, 9:02 a.m. UTC | #1
On 22.06.2023 10:57, Neil Armstrong wrote:
> Qualcomm's Mobile Test Platforms devices are handsets, set the
> chassis-type property to 'handset'.
> 
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>

Konrad
>  arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> index b2d4336e764b..41675a8de268 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> @@ -15,6 +15,7 @@
>  / {
>  	model = "Qualcomm Technologies, Inc. SDM845 MTP";
>  	compatible = "qcom,sdm845-mtp", "qcom,sdm845";
> +	chassis-type = "handset";
>  
>  	aliases {
>  		serial0 = &uart9;
>
  
Dmitry Baryshkov June 22, 2023, 10:48 a.m. UTC | #2
On Thu, 22 Jun 2023 at 12:06, Neil Armstrong <neil.armstrong@linaro.org> wrote:
>
> Qualcomm's Mobile Test Platforms devices are handsets, set the
> chassis-type property to 'handset'.

Is it really a device that you can take into your hand and put close
to the head?

>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> index b2d4336e764b..41675a8de268 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> @@ -15,6 +15,7 @@
>  / {
>         model = "Qualcomm Technologies, Inc. SDM845 MTP";
>         compatible = "qcom,sdm845-mtp", "qcom,sdm845";
> +       chassis-type = "handset";
>
>         aliases {
>                 serial0 = &uart9;
>
> --
> 2.34.1
>
  
Konrad Dybcio June 22, 2023, 10:49 a.m. UTC | #3
On 22.06.2023 12:48, Dmitry Baryshkov wrote:
> On Thu, 22 Jun 2023 at 12:06, Neil Armstrong <neil.armstrong@linaro.org> wrote:
>>
>> Qualcomm's Mobile Test Platforms devices are handsets, set the
>> chassis-type property to 'handset'.
> 
> Is it really a device that you can take into your hand and put close
> to the head?
If you don't mind getting a bit microwavey, yes

Konrad
> 
>>
>> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
>> ---
>>  arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
>> index b2d4336e764b..41675a8de268 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
>> @@ -15,6 +15,7 @@
>>  / {
>>         model = "Qualcomm Technologies, Inc. SDM845 MTP";
>>         compatible = "qcom,sdm845-mtp", "qcom,sdm845";
>> +       chassis-type = "handset";
>>
>>         aliases {
>>                 serial0 = &uart9;
>>
>> --
>> 2.34.1
>>
> 
>
  
Krzysztof Kozlowski June 22, 2023, 11:16 a.m. UTC | #4
On 22/06/2023 12:49, Konrad Dybcio wrote:
> On 22.06.2023 12:48, Dmitry Baryshkov wrote:
>> On Thu, 22 Jun 2023 at 12:06, Neil Armstrong <neil.armstrong@linaro.org> wrote:
>>>
>>> Qualcomm's Mobile Test Platforms devices are handsets, set the
>>> chassis-type property to 'handset'.
>>
>> Is it really a device that you can take into your hand and put close
>> to the head?
> If you don't mind getting a bit microwavey, yes

Handset should not poke your brain, so the chassis is not really
handset. Maybe it is just embedded?

Best regards,
Krzysztof
  
Bjorn Andersson July 10, 2023, 4:21 a.m. UTC | #5
On Thu, Jun 22, 2023 at 01:48:30PM +0300, Dmitry Baryshkov wrote:
> On Thu, 22 Jun 2023 at 12:06, Neil Armstrong <neil.armstrong@linaro.org> wrote:
> >
> > Qualcomm's Mobile Test Platforms devices are handsets, set the
> > chassis-type property to 'handset'.
> 
> Is it really a device that you can take into your hand and put close
> to the head?
> 

It's a little bit bulky, but it looks like a handset.

Regards,
Bjorn

> >
> > Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> > ---
> >  arch/arm64/boot/dts/qcom/sdm845-mtp.dts | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> > index b2d4336e764b..41675a8de268 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> > +++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
> > @@ -15,6 +15,7 @@
> >  / {
> >         model = "Qualcomm Technologies, Inc. SDM845 MTP";
> >         compatible = "qcom,sdm845-mtp", "qcom,sdm845";
> > +       chassis-type = "handset";
> >
> >         aliases {
> >                 serial0 = &uart9;
> >
> > --
> > 2.34.1
> >
> 
> 
> -- 
> With best wishes
> Dmitry
  

Patch

diff --git a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
index b2d4336e764b..41675a8de268 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sdm845-mtp.dts
@@ -15,6 +15,7 @@ 
 / {
 	model = "Qualcomm Technologies, Inc. SDM845 MTP";
 	compatible = "qcom,sdm845-mtp", "qcom,sdm845";
+	chassis-type = "handset";
 
 	aliases {
 		serial0 = &uart9;