Message ID | 20230408214041.533749-2-abel.vesa@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp1071494vqo; Sat, 8 Apr 2023 14:41:56 -0700 (PDT) X-Google-Smtp-Source: AKy350aL1qqIDgdx9Yki0fc7K0nWIOWUmMYT9FjkbH3MGKNai0/cXRKo3B3DbbRt5JbGm/UuPvEW X-Received: by 2002:a05:6a20:b716:b0:d3:78ab:77c3 with SMTP id fg22-20020a056a20b71600b000d378ab77c3mr6037701pzb.48.1680990115858; Sat, 08 Apr 2023 14:41:55 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1680990115; cv=none; d=google.com; s=arc-20160816; b=lWgUpR8tZ+2/8XLtvKjDWtD8m5rGeJ7lgixqDZt9s3U9bQxZUAfA7WXuAKMpyvDxZK jHmxGClvYa/UXm7NCpuvW9w/z+8MMJg8x+OlsNmFf4SnHybjEy+fzPV+t5aWHjcT75k/ h3E6hlLvQiwnJ3POHRCiEjv52lKipMyoTujtxDzsuuMmt4MxcSI5zUAPVw/ZQwJXPhPm 9MWQLVaJG0N6pgwtup1NunFjHcLPBJQhkrzV9XxZuF3I8llxxPiKMxI4xkZVGYY3BK6F Its8BeHEZH31DuD/698+AOFh67ABE07/GiJXsKhnUN9s6kYZ80kVKQ3/I3V/QA/wigqB 20YQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=G/ds8fvt8IhNIUkcMPcB2187U+f/tO5X7bx8/qa8ONM=; b=QljQxf+T9eRxFo40qf+zmKIPHrkLp3r7lF5abuIzBV7I2zqZsZMC/CeTzsHIQ1zDg4 +/lPsR/g60G6FwpKk8a6a+wIf7vK+C7DJ+tX+hgyBZrwnECOJ3BlItp4UHPZqnd2/InP xWXBJ2Orcr6SZgZmXZ0irmQr1OvbZpkZ7PhivPUm23gtP0sU2+VSiHqSh+WvBLxaRu9i qiv7PhNvFcKzTH/WI1kqvSp2WLbGJ/+kYk5xnE5G2Xh+ihjxn36KFwB6CO+19xVSGwgn 72zzHqzQ/4FtHVc2Z72X0JcMA8yFkPcwQpRF0DRpJSrVUfv/yeBco9F0aJB1t+gM/gp+ /B+g== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=m0SLzn1i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id u11-20020a6540cb000000b0050fad5c0e52si6441243pgp.830.2023.04.08.14.41.43; Sat, 08 Apr 2023 14:41:55 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=m0SLzn1i; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229539AbjDHVk4 (ORCPT <rfc822;a1648639935@gmail.com> + 99 others); Sat, 8 Apr 2023 17:40:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38908 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229503AbjDHVkv (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Sat, 8 Apr 2023 17:40:51 -0400 Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0596A6E8F for <linux-kernel@vger.kernel.org>; Sat, 8 Apr 2023 14:40:50 -0700 (PDT) Received: by mail-wr1-x433.google.com with SMTP id g5so4922065wrb.5 for <linux-kernel@vger.kernel.org>; Sat, 08 Apr 2023 14:40:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680990048; x=1683582048; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=G/ds8fvt8IhNIUkcMPcB2187U+f/tO5X7bx8/qa8ONM=; b=m0SLzn1iqfD6YsYtHojGNxnFSimTvg28gxXYWGvhbeFi3ywBXyW2aKpPKcOOnk81GA pLcEC/zzrZ2ZJakFH4GZvs1NXYVS8Q5ZATw+aSem6W2Z4reoZoq35ICKnVa68eA/Po/7 BFDtRtkmaD6WxD4wCiLae4gl/1Q2r4k3JeKUpjo012rA+ctcgAR0df1Cf5XPDm4XLmRV YMWY1CvCaELFO2/x7NQzHDQWbhzCpl7SOTToN6mh4//P9fwC7b1iIqg+NZ8ZIVkIWySc Pi2SUMiMC5Z6faMkDkzq3p3ZxBXZ2Nq+Es4E+Y0cqnd3Kht+YjeQRGlh9xH60wew+601 brew== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680990048; x=1683582048; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=G/ds8fvt8IhNIUkcMPcB2187U+f/tO5X7bx8/qa8ONM=; b=5lgBWx6QK/1Tkj9MyuU08TyAtMe4wqc+1rARKriBbHzWphTD0O5B6qLJQxHLPu2uRI W349AKJr0pgcym8QVWKWUZy/WK9Usk6XpxkPYeLfvTABx5N1HeA56XxWbYUkKLHF5XQE h8XabnTf/fUQJp1WQTkTbKY7HtsOOBjbt2ldnbVSTKl99Q9ufe58xVs0jJesSoj76Qq/ 1lnLFKA3np/Lzx6iUVIjJFjuXEhxMz0iLpyrnFodl+XxCmGEKLCq8nNd8PWM6AIbUXCl Tr2kKEWlDiPfSynVQydey3VOOFYrfulgtSK7dmEdY4HYl/TpUcQou6T+kRvrP/1JEcUd R9yA== X-Gm-Message-State: AAQBX9dCIE7zV7XIBgZZlXRd4A1RJmTxTqXh/psUvyhvdgqnsU7QTKmM SSrxoeUm593O6ZMZSOSk/dpnjQ== X-Received: by 2002:adf:dc07:0:b0:2e2:730a:c7de with SMTP id t7-20020adfdc07000000b002e2730ac7demr1863136wri.24.1680990048420; Sat, 08 Apr 2023 14:40:48 -0700 (PDT) Received: from localhost.localdomain ([188.25.26.161]) by smtp.gmail.com with ESMTPSA id s6-20020a5d4ec6000000b002efb6e0c495sm3061377wrv.91.2023.04.08.14.40.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 08 Apr 2023 14:40:48 -0700 (PDT) From: Abel Vesa <abel.vesa@linaro.org> To: Ulf Hansson <ulf.hansson@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Andy Gross <agross@kernel.org>, Bjorn Andersson <andersson@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Manivannan Sadhasivam <mani@kernel.org>, Alim Akhtar <alim.akhtar@samsung.com>, Avri Altman <avri.altman@wdc.com>, Bart Van Assche <bvanassche@acm.org>, Adrian Hunter <adrian.hunter@intel.com>, "James E . J . Bottomley" <jejb@linux.ibm.com>, "Martin K . Petersen" <martin.petersen@oracle.com>, Herbert Xu <herbert@gondor.apana.org.au>, "David S . Miller" <davem@davemloft.net>, Eric Biggers <ebiggers@kernel.org> Cc: linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, Linux Kernel Mailing List <linux-kernel@vger.kernel.org>, linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org, linux-scsi@vger.kernel.org Subject: [PATCH v7 1/3] dt-bindings: ufs: qcom: Add ICE phandle Date: Sun, 9 Apr 2023 00:40:39 +0300 Message-Id: <20230408214041.533749-2-abel.vesa@linaro.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230408214041.533749-1-abel.vesa@linaro.org> References: <20230408214041.533749-1-abel.vesa@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-0.2 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1762645891559394724?= X-GMAIL-MSGID: =?utf-8?q?1762645891559394724?= |
Series |
Add dedicated Qcom ICE driver
|
|
Commit Message
Abel Vesa
April 8, 2023, 9:40 p.m. UTC
Starting with SM8550, the ICE will have its own devicetree node
so add the qcom,ice property to reference it.
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
The v6 is here:
https://lore.kernel.org/all/20230407105029.2274111-3-abel.vesa@linaro.org/
Changes since v6:
* Dropped the minItems for both the qcom,ice and the reg in the
qcom,ice compatile subschema, like Krzysztof suggested
Changes since v5:
* dropped the sm8550 specific subschema and replaced it with one that
mutually excludes the qcom,ice vs both the ICE specific reg range
and the ICE clock
Changes since v4:
* Added check for sm8550 compatible w.r.t. qcom,ice in order to enforce
it while making sure none of the other platforms are allowed to use it
Changes since v3:
* dropped the "and drop core clock" part from subject line
Changes since v2:
* dropped all changes except the qcom,ice property
.../devicetree/bindings/ufs/qcom,ufs.yaml | 24 +++++++++++++++++++
1 file changed, 24 insertions(+)
Comments
On 08/04/2023 23:40, Abel Vesa wrote: > Starting with SM8550, the ICE will have its own devicetree node > so add the qcom,ice property to reference it. > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 08/04/2023 23:40, Abel Vesa wrote: > Starting with SM8550, the ICE will have its own devicetree node > so add the qcom,ice property to reference it. > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- > > The v6 is here: > https://lore.kernel.org/all/20230407105029.2274111-3-abel.vesa@linaro.org/ > > Changes since v6: > * Dropped the minItems for both the qcom,ice and the reg in the > qcom,ice compatile subschema, like Krzysztof suggested > > Changes since v5: > * dropped the sm8550 specific subschema and replaced it with one that > mutually excludes the qcom,ice vs both the ICE specific reg range > and the ICE clock > > Changes since v4: > * Added check for sm8550 compatible w.r.t. qcom,ice in order to enforce > it while making sure none of the other platforms are allowed to use it > > Changes since v3: > * dropped the "and drop core clock" part from subject line > > Changes since v2: > * dropped all changes except the qcom,ice property > > > .../devicetree/bindings/ufs/qcom,ufs.yaml | 24 +++++++++++++++++++ > 1 file changed, 24 insertions(+) > I see dt_binding_check errors after applying this patch. Are you sure this was tested? Best regards, Krzysztof
On 05/05/2023 20:47, Krzysztof Kozlowski wrote: > On 08/04/2023 23:40, Abel Vesa wrote: >> Starting with SM8550, the ICE will have its own devicetree node >> so add the qcom,ice property to reference it. >> >> Signed-off-by: Abel Vesa <abel.vesa@linaro.org> >> --- >> >> The v6 is here: >> https://lore.kernel.org/all/20230407105029.2274111-3-abel.vesa@linaro.org/ >> >> Changes since v6: >> * Dropped the minItems for both the qcom,ice and the reg in the >> qcom,ice compatile subschema, like Krzysztof suggested >> >> Changes since v5: >> * dropped the sm8550 specific subschema and replaced it with one that >> mutually excludes the qcom,ice vs both the ICE specific reg range >> and the ICE clock >> >> Changes since v4: >> * Added check for sm8550 compatible w.r.t. qcom,ice in order to enforce >> it while making sure none of the other platforms are allowed to use it >> >> Changes since v3: >> * dropped the "and drop core clock" part from subject line >> >> Changes since v2: >> * dropped all changes except the qcom,ice property >> >> >> .../devicetree/bindings/ufs/qcom,ufs.yaml | 24 +++++++++++++++++++ >> 1 file changed, 24 insertions(+) >> > > I see dt_binding_check errors after applying this patch. Are you sure > this was tested? False alarm, it was other patch in my tree. This one is good. Best regards, Krzysztof
On 08/04/2023 23:40, Abel Vesa wrote: > Starting with SM8550, the ICE will have its own devicetree node > so add the qcom,ice property to reference it. > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- > > The v6 is here: > https://lore.kernel.org/all/20230407105029.2274111-3-abel.vesa@linaro.org/ > > Changes since v6: > * Dropped the minItems for both the qcom,ice and the reg in the > qcom,ice compatile subschema, like Krzysztof suggested > > Changes since v5: > * dropped the sm8550 specific subschema and replaced it with one that > mutually excludes the qcom,ice vs both the ICE specific reg range > and the ICE clock > > Changes since v4: > * Added check for sm8550 compatible w.r.t. qcom,ice in order to enforce > it while making sure none of the other platforms are allowed to use it > > Changes since v3: > * dropped the "and drop core clock" part from subject line > > Changes since v2: > * dropped all changes except the qcom,ice property > > > .../devicetree/bindings/ufs/qcom,ufs.yaml | 24 +++++++++++++++++++ > 1 file changed, 24 insertions(+) > > diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > index c5a06c048389..10d426ba1959 100644 > --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml > @@ -70,6 +70,10 @@ properties: > power-domains: > maxItems: 1 > > + qcom,ice: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: phandle to the Inline Crypto Engine node > + > reg: > minItems: 1 > maxItems: 2 > @@ -187,6 +191,26 @@ allOf: > > # TODO: define clock bindings for qcom,msm8994-ufshc > > + - if: > + properties: > + qcom,ice: Un-reviewed. This is broken and was never tested. After applying this patch, I can see many new warnings in all DTBs (so it is easy to spot that it was not actually tested). Your probably meant here: if: required: Best regards, Krzysztof
Abel, > Un-reviewed. This is broken and was never tested. After applying this > patch, I can see many new warnings in all DTBs (so it is easy to spot > that it was not actually tested). > > Your probably meant here: > if: > required: Please provide a fix for this. I don't want to rebase this late in the cycle. Thanks!
On 22/06/2023 03:19, Martin K. Petersen wrote: > > Abel, > >> Un-reviewed. This is broken and was never tested. After applying this >> patch, I can see many new warnings in all DTBs (so it is easy to spot >> that it was not actually tested). >> >> Your probably meant here: >> if: >> required: > > Please provide a fix for this. I don't want to rebase this late in the > cycle. AFAIK, this was not applied. At least as of next 20210621 and I commented on this few days ago. Anything changed here? Best regards, Krzysztof
On 23-06-22 08:07:51, Krzysztof Kozlowski wrote: > On 22/06/2023 03:19, Martin K. Petersen wrote: > > > > Abel, > > > >> Un-reviewed. This is broken and was never tested. After applying this > >> patch, I can see many new warnings in all DTBs (so it is easy to spot > >> that it was not actually tested). > >> > >> Your probably meant here: > >> if: > >> required: > > > > Please provide a fix for this. I don't want to rebase this late in the > > cycle. > > AFAIK, this was not applied. At least as of next 20210621 and I > commented on this few days ago. Anything changed here? Check this one: https://lore.kernel.org/all/yq1a5x1wl4g.fsf@ca-mkp.ca.oracle.com/ I'll send a fix today. > > Best regards, > Krzysztof >
On 22/06/2023 09:02, Abel Vesa wrote: > On 23-06-22 08:07:51, Krzysztof Kozlowski wrote: >> On 22/06/2023 03:19, Martin K. Petersen wrote: >>> >>> Abel, >>> >>>> Un-reviewed. This is broken and was never tested. After applying this >>>> patch, I can see many new warnings in all DTBs (so it is easy to spot >>>> that it was not actually tested). >>>> >>>> Your probably meant here: >>>> if: >>>> required: >>> >>> Please provide a fix for this. I don't want to rebase this late in the >>> cycle. >> >> AFAIK, this was not applied. At least as of next 20210621 and I >> commented on this few days ago. Anything changed here? > > Check this one: > https://lore.kernel.org/all/yq1a5x1wl4g.fsf@ca-mkp.ca.oracle.com/ > So staging tree is not in next? If it cannot be rebased "that late in the cycle", this means it should be in the next. :/ Best regards, Krzysztof
Hi Krzysztof! > AFAIK, this was not applied. At least as of next 20210621 and I > commented on this few days ago. Anything changed here? It's definitely there in 20230621: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/log/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml?h=next-20230621 I merged the series on the 16th prior to you withdrawing your Reviewed-by: tag. But let's just get the bindings fixed.
diff --git a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml index c5a06c048389..10d426ba1959 100644 --- a/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml +++ b/Documentation/devicetree/bindings/ufs/qcom,ufs.yaml @@ -70,6 +70,10 @@ properties: power-domains: maxItems: 1 + qcom,ice: + $ref: /schemas/types.yaml#/definitions/phandle + description: phandle to the Inline Crypto Engine node + reg: minItems: 1 maxItems: 2 @@ -187,6 +191,26 @@ allOf: # TODO: define clock bindings for qcom,msm8994-ufshc + - if: + properties: + qcom,ice: + maxItems: 1 + then: + properties: + reg: + maxItems: 1 + clocks: + minItems: 8 + maxItems: 8 + else: + properties: + reg: + minItems: 2 + maxItems: 2 + clocks: + minItems: 9 + maxItems: 11 + unevaluatedProperties: false examples: