[net-next] dt-bindings: net: bluetooth: qualcomm: document VDD_CH1

Message ID 20230617165716.279857-1-krzysztof.kozlowski@linaro.org
State New
Headers
Series [net-next] dt-bindings: net: bluetooth: qualcomm: document VDD_CH1 |

Commit Message

Krzysztof Kozlowski June 17, 2023, 4:57 p.m. UTC
  WCN3990 comes with two chains - CH0 and CH1 - where each takes VDD
regulator.  It seems VDD_CH1 is optional (Linux driver does not care
about it), so document it to fix dtbs_check warnings like:

  sdm850-lenovo-yoga-c630.dtb: bluetooth: 'vddch1-supply' does not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
 .../devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml  | 3 +++
 1 file changed, 3 insertions(+)
  

Comments

Conor Dooley June 17, 2023, 8:38 p.m. UTC | #1
On Sat, Jun 17, 2023 at 06:57:16PM +0200, Krzysztof Kozlowski wrote:
> WCN3990 comes with two chains - CH0 and CH1 - where each takes VDD
> regulator.  It seems VDD_CH1 is optional (Linux driver does not care
> about it), so document it to fix dtbs_check warnings like:
> 
>   sdm850-lenovo-yoga-c630.dtb: bluetooth: 'vddch1-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.
  
Jakub Kicinski June 20, 2023, 6:14 p.m. UTC | #2
On Sat, 17 Jun 2023 18:57:16 +0200 Krzysztof Kozlowski wrote:
> WCN3990 comes with two chains - CH0 and CH1 - where each takes VDD
> regulator.  It seems VDD_CH1 is optional (Linux driver does not care
> about it), so document it to fix dtbs_check warnings like:
> 
>   sdm850-lenovo-yoga-c630.dtb: bluetooth: 'vddch1-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Hi Luiz, I don't see you CCed here, should we take it directly 
to net-next?

> diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
> index e3a51d66527c..2735c6a4f336 100644
> --- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
> +++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
> @@ -52,6 +52,9 @@ properties:
>    vddch0-supply:
>      description: VDD_CH0 supply regulator handle
>  
> +  vddch1-supply:
> +    description: VDD_CH1 supply regulator handle
> +
>    vddaon-supply:
>      description: VDD_AON supply regulator handle
>
  
Krzysztof Kozlowski June 21, 2023, 6:05 a.m. UTC | #3
On 20/06/2023 20:14, Jakub Kicinski wrote:
> On Sat, 17 Jun 2023 18:57:16 +0200 Krzysztof Kozlowski wrote:
>> WCN3990 comes with two chains - CH0 and CH1 - where each takes VDD
>> regulator.  It seems VDD_CH1 is optional (Linux driver does not care
>> about it), so document it to fix dtbs_check warnings like:
>>
>>   sdm850-lenovo-yoga-c630.dtb: bluetooth: 'vddch1-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> Hi Luiz, I don't see you CCed here, should we take it directly 
> to net-next?

Bluetooth bindings are not part of BLUETOOTH entry, so obviously no Cc
for bluetooth maintainers. I'll send a patch to update maintainers.

Best regards,
Krzysztof
  
Jakub Kicinski June 21, 2023, 11:54 p.m. UTC | #4
On Wed, 21 Jun 2023 08:05:50 +0200 Krzysztof Kozlowski wrote:
> On 20/06/2023 20:14, Jakub Kicinski wrote:
> > Hi Luiz, I don't see you CCed here, should we take it directly 
> > to net-next?  

Lemme take it, it's trivial enough.

> Bluetooth bindings are not part of BLUETOOTH entry, so obviously no Cc
> for bluetooth maintainers. I'll send a patch to update maintainers.

Thanks!!
  
patchwork-bot+netdevbpf@kernel.org June 22, 2023, midnight UTC | #5
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Sat, 17 Jun 2023 18:57:16 +0200 you wrote:
> WCN3990 comes with two chains - CH0 and CH1 - where each takes VDD
> regulator.  It seems VDD_CH1 is optional (Linux driver does not care
> about it), so document it to fix dtbs_check warnings like:
> 
>   sdm850-lenovo-yoga-c630.dtb: bluetooth: 'vddch1-supply' does not match any of the regexes: 'pinctrl-[0-9]+'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> 
> [...]

Here is the summary with links:
  - [net-next] dt-bindings: net: bluetooth: qualcomm: document VDD_CH1
    https://git.kernel.org/netdev/net-next/c/6a0a6dd8df9b

You are awesome, thank you!
  

Patch

diff --git a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
index e3a51d66527c..2735c6a4f336 100644
--- a/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
+++ b/Documentation/devicetree/bindings/net/bluetooth/qualcomm-bluetooth.yaml
@@ -52,6 +52,9 @@  properties:
   vddch0-supply:
     description: VDD_CH0 supply regulator handle
 
+  vddch1-supply:
+    description: VDD_CH1 supply regulator handle
+
   vddaon-supply:
     description: VDD_AON supply regulator handle