diff mbox series

[net-next] bnxt_en: Link representors to PCI device

Message ID 20230620144855.288443-1-ivecera@redhat.com
State New
Headers
Series [net-next] bnxt_en: Link representors to PCI device |

Commit Message

Ivan Vecera June 20, 2023, 2:48 p.m. UTC 
  Link VF representors to parent PCI device to benefit from
systemd defined naming scheme.

Without this change the representor is visible as ethN.

Signed-off-by: Ivan Vecera <ivecera@redhat.com>
---
 drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Simon Horman June 20, 2023, 3:54 p.m. UTC | #1 
On Tue, Jun 20, 2023 at 04:48:55PM +0200, Ivan Vecera wrote:
> Link VF representors to parent PCI device to benefit from
> systemd defined naming scheme.
> 
> Without this change the representor is visible as ethN.
> 
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>

Reviewed-by: Simon Horman <simon.horman@corigine.com>
Sriharsha Basavapatna June 20, 2023, 4:49 p.m. UTC | #2 
On Tue, Jun 20, 2023 at 10:00 PM Ivan Vecera <ivecera@redhat.com> wrote:
>
> Link VF representors to parent PCI device to benefit from
> systemd defined naming scheme.
>
> Without this change the representor is visible as ethN.
>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
Acked-by: Sriharsha Basavapatna <sriharsha.basavapatna@broadcom.com>
> ---
>  drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c
> index 2f1a1f2d2157..1467b94a6427 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c
> @@ -468,6 +468,7 @@ static void bnxt_vf_rep_netdev_init(struct bnxt *bp, struct bnxt_vf_rep *vf_rep,
>         struct net_device *pf_dev = bp->dev;
>         u16 max_mtu;
>
> +       SET_NETDEV_DEV(dev, &bp->pdev->dev);
>         dev->netdev_ops = &bnxt_vf_rep_netdev_ops;
>         dev->ethtool_ops = &bnxt_vf_rep_ethtool_ops;
>         /* Just inherit all the featues of the parent PF as the VF-R
> --
> 2.39.3
>
>
Jakub Kicinski June 20, 2023, 4:56 p.m. UTC | #3 
On Tue, 20 Jun 2023 22:19:32 +0530 Sriharsha Basavapatna wrote:
> This electronic communication and the information and any files transmitted 
> with it, or attached to it, are confidential and are intended solely for 
> the use of the individual or entity to whom it is addressed and may contain 
> information that is confidential, legally privileged, protected by privacy 
> laws, or otherwise restricted from disclosure to anyone else. If you are 
> not the intended recipient or the person responsible for delivering the 
> e-mail to the intended recipient, you are hereby notified that any use, 
> copying, distributing, dissemination, forwarding, printing, or copying of 
> this e-mail is strictly prohibited. If you received this e-mail in error, 
> please return the e-mail to the sender, delete it from your computer, and 
> destroy any printed copy of it.

Your emails to the list must not include any legal note of this nature.
I'll have to manually delete your review tag from the system.
Michael Chan June 20, 2023, 5:26 p.m. UTC | #4 
On Tue, Jun 20, 2023 at 7:52 AM Ivan Vecera <ivecera@redhat.com> wrote:
>
> Link VF representors to parent PCI device to benefit from
> systemd defined naming scheme.
>
> Without this change the representor is visible as ethN.
>
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>

Thanks.

Reviewed-by: Michael Chan <michael.chan@broadcon.com>
Simon Horman June 20, 2023, 7:41 p.m. UTC | #5 
On Tue, Jun 20, 2023 at 10:26:21AM -0700, Michael Chan wrote:
> On Tue, Jun 20, 2023 at 7:52 AM Ivan Vecera <ivecera@redhat.com> wrote:
> >
> > Link VF representors to parent PCI device to benefit from
> > systemd defined naming scheme.
> >
> > Without this change the representor is visible as ethN.
> >
> > Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> 
> Thanks.
> 
> Reviewed-by: Michael Chan <michael.chan@broadcon.com>

nit:) broadcon -> broadcom
Michael Chan June 20, 2023, 8:12 p.m. UTC | #6 
On Tue, Jun 20, 2023 at 12:41 PM Simon Horman <simon.horman@corigine.com> wrote:
>
> On Tue, Jun 20, 2023 at 10:26:21AM -0700, Michael Chan wrote:
> > On Tue, Jun 20, 2023 at 7:52 AM Ivan Vecera <ivecera@redhat.com> wrote:
> > >
> > > Link VF representors to parent PCI device to benefit from
> > > systemd defined naming scheme.
> > >
> > > Without this change the representor is visible as ethN.
> > >
> > > Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> >
> > Thanks.
> >
> > Reviewed-by: Michael Chan <michael.chan@broadcon.com>
>
> nit:) broadcon -> broadcom
>
>

Typo fixed.

Reviewed-by: Michael Chan <michael.chan@broadcom.com>
patchwork-bot+netdevbpf@kernel.org June 21, 2023, 9:10 p.m. UTC | #7 
Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 20 Jun 2023 16:48:55 +0200 you wrote:
> Link VF representors to parent PCI device to benefit from
> systemd defined naming scheme.
> 
> Without this change the representor is visible as ethN.
> 
> Signed-off-by: Ivan Vecera <ivecera@redhat.com>
> 
> [...]

Here is the summary with links:
  - [net-next] bnxt_en: Link representors to PCI device
    https://git.kernel.org/netdev/net-next/c/7ad7b7023fcb

You are awesome, thank you!
diff mbox series

Patch

diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c
index 2f1a1f2d2157..1467b94a6427 100644
--- a/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c
+++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_vfr.c
@@ -468,6 +468,7 @@  static void bnxt_vf_rep_netdev_init(struct bnxt *bp, struct bnxt_vf_rep *vf_rep,
 	struct net_device *pf_dev = bp->dev;
 	u16 max_mtu;
 
+	SET_NETDEV_DEV(dev, &bp->pdev->dev);
 	dev->netdev_ops = &bnxt_vf_rep_netdev_ops;
 	dev->ethtool_ops = &bnxt_vf_rep_ethtool_ops;
 	/* Just inherit all the featues of the parent PF as the VF-R