| Message ID | 20230614173633.2430653-2-robh@kernel.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp132477vqr;
Wed, 14 Jun 2023 11:02:27 -0700 (PDT)
X-Google-Smtp-Source:
ACHHUZ40dkVGdvLoGhnpH3MGC8RTT0tG1VyMEhDeHQ79IL615zU3cTOyS7oAir0MIIXVQtPljQ/M
X-Received: by 2002:aa7:d155:0:b0:518:7b8d:daae with SMTP id
r21-20020aa7d155000000b005187b8ddaaemr2579222edo.9.1686765747534;
Wed, 14 Jun 2023 11:02:27 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1686765747; cv=none;
d=google.com; s=arc-20160816;
b=CtNEE+bSFyHXOkL6R0vPkYdHO3+5UyoaTAPdIed78JLyeKn+zsCHmw9dsn4x0lJ8ga
/127GNfNkFi7hvuxEj/wezrDRmeZaRuBhzedhky8LxkzuP0QnuriBt8YC1Tt2tfQWJGw
FZNu6H/yKmVe+9tifmcLZaIRUGA+a/rY8aJG6JNsgXOh1PV/lXkJaCo9V/wfT6fyhcwt
cI6WLUfvSANzH3VyjaVJNkuFnkEoxwQ39D9X32ni0olC4hRgLb5c6Ctv9DZEZTK5ri3Q
8b6aZxw2ppVnAMUctxd3XZ7XS6mV7ErrvSSRQK95lXN44J6ZC5BHmsLKTktRWX28qRM0
Aw4A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from;
bh=4AzIfgp2T+o1encwZlg2BP9N2PGCvG8KAxb0WUXTbaA=;
b=GJU0OH0zwv1+4qV2xLKP9O7OokAyZ8wnUn47Dna9FpRlQQ1w0ERVAF5Dz1FHz9sq+i
6YSKy35W6swqY1VW0wfV60BlG/FoQCLedMdJmCvMiBWZ/dP1hAk9/Fp7molLwG0bf8PY
Tl+b0/kTNjJw52aCoVDl7tBc2rYJGzgFVM1OnK4IY6OG3H03sucf4tPICyPF/Jdmjnt8
6wWmkzucikgA94tCsR7vv4kwIZ9KNOFTcqnk+5n9af+AvK8bp4/zAAJdj0gpRq4iBCe8
p+q6lY925tyPD3OekWOr5V8wt60rVhH+suuSB3awJqQ3O2qY2GGoFnOvyqTETQuxXXs/
uEQg==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
ca19-20020aa7cd73000000b005149e348be9si9217951edb.86.2023.06.14.11.01.59;
Wed, 14 Jun 2023 11:02:27 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S237387AbjFNRif (ORCPT <rfc822;n2h9z4@gmail.com> + 99 others);
Wed, 14 Jun 2023 13:38:35 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53228 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S230388AbjFNRid (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Wed, 14 Jun 2023 13:38:33 -0400
Received: from mail-io1-f53.google.com (mail-io1-f53.google.com
[209.85.166.53])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 416EF10FE;
Wed, 14 Jun 2023 10:38:32 -0700 (PDT)
Received: by mail-io1-f53.google.com with SMTP id
ca18e2360f4ac-77a62a84855so273308139f.1;
Wed, 14 Jun 2023 10:38:32 -0700 (PDT)
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20221208; t=1686764311; x=1689356311;
h=content-transfer-encoding:mime-version:references:in-reply-to
:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc
:subject:date:message-id:reply-to;
bh=4AzIfgp2T+o1encwZlg2BP9N2PGCvG8KAxb0WUXTbaA=;
b=WsaDMIrpnSLwIqqldn34MWu2sKw3HindMBvKSXpBROS/Q7ZdF29tfkcMXzh5LiJV3H
Z8Sihnu5vkJuwegr9BO4WcCh6Zzd2p7rhdO3JTtDKUEj2EQbSbxoVX4ksYeDuYCUs/JO
SOj+TUukxh8tv6VYr4opnW7YR3DRTj8ZAPUMy2Mkyuag+8HbM6mHbFaYjxVw3hOGNJXq
xRvvnvqz9ekWc5uw0K9YiS279Pt7M7mhO+kPanBU4SLe1EpaiUIHG46FPWWb0Qm77c+y
iY9oxKZxvrBWKy3Zi7+uW/awMZG4M9SKSAbP1qZCaG4dEXp1+0rdtVD+ZscREXmarrRe
P48w==
X-Gm-Message-State: AC+VfDxR+u1kOEyYajaNviVWAtWvB1KjCG7anS52RuMxCdDIU8ljgmAW
TYCLBjrGkr6q+L3ObLmxAEUxpvIVFg==
X-Received: by 2002:a05:6e02:684:b0:33b:ef57:65bc with SMTP id
o4-20020a056e02068400b0033bef5765bcmr13558330ils.20.1686764311406;
Wed, 14 Jun 2023 10:38:31 -0700 (PDT)
Received: from robh_at_kernel.org ([64.188.179.250])
by smtp.gmail.com with ESMTPSA id
p20-20020a02c814000000b004165ce4456fsm5009151jao.33.2023.06.14.10.38.30
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Wed, 14 Jun 2023 10:38:30 -0700 (PDT)
Received: (nullmailer pid 2433146 invoked by uid 1000);
Wed, 14 Jun 2023 17:38:29 -0000
From: Rob Herring <robh@kernel.org>
To: Damien Le Moal <dlemoal@kernel.org>,
Sergey Shtylyov <s.shtylyov@omp.ru>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-ide@vger.kernel.org, linux-mips@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: [PATCH 2/2] ata: octeon: Add compile test support
Date: Wed, 14 Jun 2023 11:36:33 -0600
Message-Id: <20230614173633.2430653-2-robh@kernel.org>
X-Mailer: git-send-email 2.39.2
In-Reply-To: <20230614173633.2430653-1-robh@kernel.org>
References: <20230614173633.2430653-1-robh@kernel.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-1.2 required=5.0 tests=BAYES_00,
FREEMAIL_ENVFROM_END_DIGIT,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM,
HEADER_FROM_DIFFERENT_DOMAINS,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H2,
SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=no
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1768702080592705693?=
X-GMAIL-MSGID: =?utf-8?q?1768702080592705693?=
|
| Series |
[1/2] MIPS: octeon: Fix cvmx_writeq_csr/cvmx_readq_csr on 32-bit builds
|
|
Commit Message
Rob Herring
June 14, 2023, 5:36 p.m. UTC
Add COMPILE_TEST to enable building Cavium Octeon drivers in MIPS
allyesconfig/allmodconfig builds. There's a dependency on MIPS headers,
so other arches can't be enabled.
Signed-off-by: Rob Herring <robh@kernel.org>
---
Tested on allmodconfig build. Not sure if there's other MIPS configs
where this doesn't work. We'll see what 0-day says.
drivers/ata/Kconfig | 4 ++--
drivers/ata/pata_octeon_cf.c | 4 ++--
2 files changed, 4 insertions(+), 4 deletions(-)
Comments
On 6/15/23 02:36, Rob Herring wrote: > Add COMPILE_TEST to enable building Cavium Octeon drivers in MIPS > allyesconfig/allmodconfig builds. There's a dependency on MIPS headers, > so other arches can't be enabled. Yes, I tried... That is unfortunate. Looks good to me though. If I get an Ack for patch 1, I can queue this up through the ata tree. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > Tested on allmodconfig build. Not sure if there's other MIPS configs > where this doesn't work. We'll see what 0-day says. > > drivers/ata/Kconfig | 4 ++-- > drivers/ata/pata_octeon_cf.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig > index 42b51c9812a0..4572f837e504 100644 > --- a/drivers/ata/Kconfig > +++ b/drivers/ata/Kconfig > @@ -239,7 +239,7 @@ config AHCI_MVEBU > > config AHCI_OCTEON > tristate "Cavium Octeon Soc Serial ATA" > - depends on SATA_AHCI_PLATFORM && CAVIUM_OCTEON_SOC > + depends on SATA_AHCI_PLATFORM && MIPS && (CAVIUM_OCTEON_SOC || COMPILE_TEST) > default y > help > This option enables support for Cavium Octeon SoC Serial ATA. > @@ -373,7 +373,7 @@ config PDC_ADMA > > config PATA_OCTEON_CF > tristate "OCTEON Boot Bus Compact Flash support" > - depends on CAVIUM_OCTEON_SOC > + depends on MIPS && (CAVIUM_OCTEON_SOC || COMPILE_TEST) > select PATA_TIMINGS > help > This option enables a polled compact flash driver for use with > diff --git a/drivers/ata/pata_octeon_cf.c b/drivers/ata/pata_octeon_cf.c > index 57b2166a6d5d..cc9e4b63ded9 100644 > --- a/drivers/ata/pata_octeon_cf.c > +++ b/drivers/ata/pata_octeon_cf.c > @@ -853,8 +853,8 @@ static int octeon_cf_probe(struct platform_device *pdev) > of_node_put(dma_node); > return -EINVAL; > } > - cf_port->dma_base = (u64)devm_ioremap(&pdev->dev, res_dma->start, > - resource_size(res_dma)); > + cf_port->dma_base = (uintptr_t)devm_ioremap(&pdev->dev, res_dma->start, > + resource_size(res_dma)); > if (!cf_port->dma_base) { > put_device(&dma_dev->dev); > of_node_put(dma_node);
On 6/15/23 02:36, Rob Herring wrote: > Add COMPILE_TEST to enable building Cavium Octeon drivers in MIPS > allyesconfig/allmodconfig builds. There's a dependency on MIPS headers, > so other arches can't be enabled. > > Signed-off-by: Rob Herring <robh@kernel.org> Applied this and 1/2 to for-6.5. Thanks !
On Wed, Jun 14, 2023 at 11:36:33AM -0600, Rob Herring wrote: > Add COMPILE_TEST to enable building Cavium Octeon drivers in MIPS > allyesconfig/allmodconfig builds. There's a dependency on MIPS headers, > so other arches can't be enabled. > > Signed-off-by: Rob Herring <robh@kernel.org> > --- > Tested on allmodconfig build. Not sure if there's other MIPS configs > where this doesn't work. We'll see what 0-day says. Odd, in next-20230621 I get: Building mips:allmodconfig ... failed -------------- Error log: ERROR: modpost: "__udivdi3" [drivers/ata/pata_octeon_cf.ko] undefined! ERROR: modpost: "octeon_get_io_clock_rate" [drivers/ata/pata_octeon_cf.ko] undefined! ERROR: modpost: "__tracepoint_ata_bmdma_stop" [drivers/ata/pata_octeon_cf.ko] undefined! ERROR: modpost: "__traceiter_ata_bmdma_stop" [drivers/ata/pata_octeon_cf.ko] undefined! ERROR: modpost: "__divdi3" [drivers/ata/pata_octeon_cf.ko] undefined! make[2]: [scripts/Makefile.modpost:144: Module.symvers] Error 1 (ignored) make[2]: *** No rule to make target 'kernel/locking/locktorture.ko', needed by '__modfinal'. Stop. make[1]: [Makefile:1933: modules] Error 2 (ignored) Guenter
On 6/22/23 01:51, Guenter Roeck wrote: > On Wed, Jun 14, 2023 at 11:36:33AM -0600, Rob Herring wrote: >> Add COMPILE_TEST to enable building Cavium Octeon drivers in MIPS >> allyesconfig/allmodconfig builds. There's a dependency on MIPS headers, >> so other arches can't be enabled. >> >> Signed-off-by: Rob Herring <robh@kernel.org> >> --- >> Tested on allmodconfig build. Not sure if there's other MIPS configs >> where this doesn't work. We'll see what 0-day says. > > Odd, in next-20230621 I get: > > Building mips:allmodconfig ... failed Indeed odd. Given that this is an allmodconfig, I would assume that CONFIG_CAVIUM_OCTEON_SOC is set ? > -------------- > Error log: > ERROR: modpost: "__udivdi3" [drivers/ata/pata_octeon_cf.ko] undefined! > ERROR: modpost: "octeon_get_io_clock_rate" [drivers/ata/pata_octeon_cf.ko] undefined! > ERROR: modpost: "__tracepoint_ata_bmdma_stop" [drivers/ata/pata_octeon_cf.ko] undefined! > ERROR: modpost: "__traceiter_ata_bmdma_stop" [drivers/ata/pata_octeon_cf.ko] undefined! > ERROR: modpost: "__divdi3" [drivers/ata/pata_octeon_cf.ko] undefined! > make[2]: [scripts/Makefile.modpost:144: Module.symvers] Error 1 (ignored) > make[2]: *** No rule to make target 'kernel/locking/locktorture.ko', needed by '__modfinal'. Stop. > make[1]: [Makefile:1933: modules] Error 2 (ignored) > > Guenter
On 6/21/23 17:57, Damien Le Moal wrote: > On 6/22/23 01:51, Guenter Roeck wrote: >> On Wed, Jun 14, 2023 at 11:36:33AM -0600, Rob Herring wrote: >>> Add COMPILE_TEST to enable building Cavium Octeon drivers in MIPS >>> allyesconfig/allmodconfig builds. There's a dependency on MIPS headers, >>> so other arches can't be enabled. >>> >>> Signed-off-by: Rob Herring <robh@kernel.org> >>> --- >>> Tested on allmodconfig build. Not sure if there's other MIPS configs >>> where this doesn't work. We'll see what 0-day says. >> >> Odd, in next-20230621 I get: >> >> Building mips:allmodconfig ... failed > > Indeed odd. Given that this is an allmodconfig, I would assume that > CONFIG_CAVIUM_OCTEON_SOC is set ? > No, it is not. CONFIG_CAVIUM_OCTEON_SOC is a choice option, meaning only one of the choices can be set, and mips:allmodconfig selects a different choice. Guenter >> -------------- >> Error log: >> ERROR: modpost: "__udivdi3" [drivers/ata/pata_octeon_cf.ko] undefined! >> ERROR: modpost: "octeon_get_io_clock_rate" [drivers/ata/pata_octeon_cf.ko] undefined! >> ERROR: modpost: "__tracepoint_ata_bmdma_stop" [drivers/ata/pata_octeon_cf.ko] undefined! >> ERROR: modpost: "__traceiter_ata_bmdma_stop" [drivers/ata/pata_octeon_cf.ko] undefined! >> ERROR: modpost: "__divdi3" [drivers/ata/pata_octeon_cf.ko] undefined! >> make[2]: [scripts/Makefile.modpost:144: Module.symvers] Error 1 (ignored) >> make[2]: *** No rule to make target 'kernel/locking/locktorture.ko', needed by '__modfinal'. Stop. >> make[1]: [Makefile:1933: modules] Error 2 (ignored) >> >> Guenter >
On 6/22/23 12:01, Guenter Roeck wrote: > On 6/21/23 17:57, Damien Le Moal wrote: >> On 6/22/23 01:51, Guenter Roeck wrote: >>> On Wed, Jun 14, 2023 at 11:36:33AM -0600, Rob Herring wrote: >>>> Add COMPILE_TEST to enable building Cavium Octeon drivers in MIPS >>>> allyesconfig/allmodconfig builds. There's a dependency on MIPS headers, >>>> so other arches can't be enabled. >>>> >>>> Signed-off-by: Rob Herring <robh@kernel.org> >>>> --- >>>> Tested on allmodconfig build. Not sure if there's other MIPS configs >>>> where this doesn't work. We'll see what 0-day says. >>> >>> Odd, in next-20230621 I get: >>> >>> Building mips:allmodconfig ... failed >> >> Indeed odd. Given that this is an allmodconfig, I would assume that >> CONFIG_CAVIUM_OCTEON_SOC is set ? >> > > No, it is not. CONFIG_CAVIUM_OCTEON_SOC is a choice option, > meaning only one of the choices can be set, and mips:allmodconfig > selects a different choice. OK. Then I think I need to drop this patch as I do not see how to allow COMPILE_TEST without CONFIG_CAVIUM_OCTEON_SOC being set. Rob ? > > Guenter > >>> -------------- >>> Error log: >>> ERROR: modpost: "__udivdi3" [drivers/ata/pata_octeon_cf.ko] undefined! >>> ERROR: modpost: "octeon_get_io_clock_rate" [drivers/ata/pata_octeon_cf.ko] undefined! >>> ERROR: modpost: "__tracepoint_ata_bmdma_stop" [drivers/ata/pata_octeon_cf.ko] undefined! >>> ERROR: modpost: "__traceiter_ata_bmdma_stop" [drivers/ata/pata_octeon_cf.ko] undefined! >>> ERROR: modpost: "__divdi3" [drivers/ata/pata_octeon_cf.ko] undefined! >>> make[2]: [scripts/Makefile.modpost:144: Module.symvers] Error 1 (ignored) >>> make[2]: *** No rule to make target 'kernel/locking/locktorture.ko', needed by '__modfinal'. Stop. >>> make[1]: [Makefile:1933: modules] Error 2 (ignored) >>> >>> Guenter >> >
On 6/21/23 21:26, Damien Le Moal wrote: > On 6/22/23 12:01, Guenter Roeck wrote: >> On 6/21/23 17:57, Damien Le Moal wrote: >>> On 6/22/23 01:51, Guenter Roeck wrote: >>>> On Wed, Jun 14, 2023 at 11:36:33AM -0600, Rob Herring wrote: >>>>> Add COMPILE_TEST to enable building Cavium Octeon drivers in MIPS >>>>> allyesconfig/allmodconfig builds. There's a dependency on MIPS headers, >>>>> so other arches can't be enabled. >>>>> >>>>> Signed-off-by: Rob Herring <robh@kernel.org> >>>>> --- >>>>> Tested on allmodconfig build. Not sure if there's other MIPS configs >>>>> where this doesn't work. We'll see what 0-day says. >>>> >>>> Odd, in next-20230621 I get: >>>> >>>> Building mips:allmodconfig ... failed >>> >>> Indeed odd. Given that this is an allmodconfig, I would assume that >>> CONFIG_CAVIUM_OCTEON_SOC is set ? >>> >> >> No, it is not. CONFIG_CAVIUM_OCTEON_SOC is a choice option, >> meaning only one of the choices can be set, and mips:allmodconfig >> selects a different choice. > > OK. Then I think I need to drop this patch as I do not see how to allow > COMPILE_TEST without CONFIG_CAVIUM_OCTEON_SOC being set. > That is a contradiction anyway. COMPILE_TEST implies that the target is independent of any other compile flags. If it depends on CONFIG_CAVIUM_OCTEON_SOC, overriding that with COMPILE_TEST does not make sense. Guenter > Rob ? > >> >> Guenter >> >>>> -------------- >>>> Error log: >>>> ERROR: modpost: "__udivdi3" [drivers/ata/pata_octeon_cf.ko] undefined! >>>> ERROR: modpost: "octeon_get_io_clock_rate" [drivers/ata/pata_octeon_cf.ko] undefined! >>>> ERROR: modpost: "__tracepoint_ata_bmdma_stop" [drivers/ata/pata_octeon_cf.ko] undefined! >>>> ERROR: modpost: "__traceiter_ata_bmdma_stop" [drivers/ata/pata_octeon_cf.ko] undefined! >>>> ERROR: modpost: "__divdi3" [drivers/ata/pata_octeon_cf.ko] undefined! >>>> make[2]: [scripts/Makefile.modpost:144: Module.symvers] Error 1 (ignored) >>>> make[2]: *** No rule to make target 'kernel/locking/locktorture.ko', needed by '__modfinal'. Stop. >>>> make[1]: [Makefile:1933: modules] Error 2 (ignored) >>>> >>>> Guenter >>> >> >
On Wed, Jun 21, 2023 at 10:26 PM Damien Le Moal <dlemoal@kernel.org> wrote: > > On 6/22/23 12:01, Guenter Roeck wrote: > > On 6/21/23 17:57, Damien Le Moal wrote: > >> On 6/22/23 01:51, Guenter Roeck wrote: > >>> On Wed, Jun 14, 2023 at 11:36:33AM -0600, Rob Herring wrote: > >>>> Add COMPILE_TEST to enable building Cavium Octeon drivers in MIPS > >>>> allyesconfig/allmodconfig builds. There's a dependency on MIPS headers, > >>>> so other arches can't be enabled. > >>>> > >>>> Signed-off-by: Rob Herring <robh@kernel.org> > >>>> --- > >>>> Tested on allmodconfig build. Not sure if there's other MIPS configs > >>>> where this doesn't work. We'll see what 0-day says. > >>> > >>> Odd, in next-20230621 I get: > >>> > >>> Building mips:allmodconfig ... failed > >> > >> Indeed odd. Given that this is an allmodconfig, I would assume that > >> CONFIG_CAVIUM_OCTEON_SOC is set ? > >> > > > > No, it is not. CONFIG_CAVIUM_OCTEON_SOC is a choice option, > > meaning only one of the choices can be set, and mips:allmodconfig > > selects a different choice. > > OK. Then I think I need to drop this patch as I do not see how to allow > COMPILE_TEST without CONFIG_CAVIUM_OCTEON_SOC being set. > > Rob ? These could be fixed, but not sure it's worth the effort. > > > > Guenter > > > >>> -------------- > >>> Error log: > >>> ERROR: modpost: "__udivdi3" [drivers/ata/pata_octeon_cf.ko] undefined! This is due to 64-bit divides on 32-bit build, so do_div() needs to be used. > >>> ERROR: modpost: "octeon_get_io_clock_rate" [drivers/ata/pata_octeon_cf.ko] undefined! We'd need a static inline in the header for octeon_get_io_clock_rate(). Of course the real fix is Octeon needs to move to use the clock framework. > >>> ERROR: modpost: "__tracepoint_ata_bmdma_stop" [drivers/ata/pata_octeon_cf.ko] undefined! > >>> ERROR: modpost: "__traceiter_ata_bmdma_stop" [drivers/ata/pata_octeon_cf.ko] undefined! Probably can just drop the trace_ata_bmdma_stop() call. It was added to replace a printk. Rob
On 6/22/23 22:41, Rob Herring wrote: > On Wed, Jun 21, 2023 at 10:26 PM Damien Le Moal <dlemoal@kernel.org> wrote: >> >> On 6/22/23 12:01, Guenter Roeck wrote: >>> On 6/21/23 17:57, Damien Le Moal wrote: >>>> On 6/22/23 01:51, Guenter Roeck wrote: >>>>> On Wed, Jun 14, 2023 at 11:36:33AM -0600, Rob Herring wrote: >>>>>> Add COMPILE_TEST to enable building Cavium Octeon drivers in MIPS >>>>>> allyesconfig/allmodconfig builds. There's a dependency on MIPS headers, >>>>>> so other arches can't be enabled. >>>>>> >>>>>> Signed-off-by: Rob Herring <robh@kernel.org> >>>>>> --- >>>>>> Tested on allmodconfig build. Not sure if there's other MIPS configs >>>>>> where this doesn't work. We'll see what 0-day says. >>>>> >>>>> Odd, in next-20230621 I get: >>>>> >>>>> Building mips:allmodconfig ... failed >>>> >>>> Indeed odd. Given that this is an allmodconfig, I would assume that >>>> CONFIG_CAVIUM_OCTEON_SOC is set ? >>>> >>> >>> No, it is not. CONFIG_CAVIUM_OCTEON_SOC is a choice option, >>> meaning only one of the choices can be set, and mips:allmodconfig >>> selects a different choice. >> >> OK. Then I think I need to drop this patch as I do not see how to allow >> COMPILE_TEST without CONFIG_CAVIUM_OCTEON_SOC being set. >> >> Rob ? > > These could be fixed, but not sure it's worth the effort. Agreed. And given that we are at rc7 already, this effort should not be now anyway. I will drop this patch.
diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig index 42b51c9812a0..4572f837e504 100644 --- a/drivers/ata/Kconfig +++ b/drivers/ata/Kconfig @@ -239,7 +239,7 @@ config AHCI_MVEBU config AHCI_OCTEON tristate "Cavium Octeon Soc Serial ATA" - depends on SATA_AHCI_PLATFORM && CAVIUM_OCTEON_SOC + depends on SATA_AHCI_PLATFORM && MIPS && (CAVIUM_OCTEON_SOC || COMPILE_TEST) default y help This option enables support for Cavium Octeon SoC Serial ATA. @@ -373,7 +373,7 @@ config PDC_ADMA config PATA_OCTEON_CF tristate "OCTEON Boot Bus Compact Flash support" - depends on CAVIUM_OCTEON_SOC + depends on MIPS && (CAVIUM_OCTEON_SOC || COMPILE_TEST) select PATA_TIMINGS help This option enables a polled compact flash driver for use with diff --git a/drivers/ata/pata_octeon_cf.c b/drivers/ata/pata_octeon_cf.c index 57b2166a6d5d..cc9e4b63ded9 100644 --- a/drivers/ata/pata_octeon_cf.c +++ b/drivers/ata/pata_octeon_cf.c @@ -853,8 +853,8 @@ static int octeon_cf_probe(struct platform_device *pdev) of_node_put(dma_node); return -EINVAL; } - cf_port->dma_base = (u64)devm_ioremap(&pdev->dev, res_dma->start, - resource_size(res_dma)); + cf_port->dma_base = (uintptr_t)devm_ioremap(&pdev->dev, res_dma->start, + resource_size(res_dma)); if (!cf_port->dma_base) { put_device(&dma_dev->dev); of_node_put(dma_node);