diff mbox series

[PATCHv2] dt-bindings: arm: socionext: add Synquacer platforms

Message ID 20230620170725.13794-1-jaswinder.singh@linaro.org
State New
Headers
Series [PATCHv2] dt-bindings: arm: socionext: add Synquacer platforms |

Commit Message

Jassi Brar June 20, 2023, 5:07 p.m. UTC 
  From: Jassi Brar <jaswinder.singh@linaro.org>

Socionext's DeveloperBox is based on the SC2A11B SoC (Synquacer).
Specify bindings for the platform and boards based on that.

Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
---
 .../bindings/arm/socionext/synquacer.yaml     | 29 +++++++++++++++++++
 1 file changed, 29 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/arm/socionext/synquacer.yaml

Comments

Krzysztof Kozlowski June 20, 2023, 5:16 p.m. UTC | #1 
On 20/06/2023 19:07, jaswinder.singh@linaro.org wrote:
> From: Jassi Brar <jaswinder.singh@linaro.org>
> 
> Socionext's DeveloperBox is based on the SC2A11B SoC (Synquacer).
> Specify bindings for the platform and boards based on that.
> 
> Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
> ---

Attach changelog after ---.

>  .../bindings/arm/socionext/synquacer.yaml     | 29 +++++++++++++++++++
>  1 file changed, 29 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/arm/socionext/synquacer.yaml
> 
> diff --git a/Documentation/devicetree/bindings/arm/socionext/synquacer.yaml b/Documentation/devicetree/bindings/arm/socionext/synquacer.yaml
> new file mode 100644
> index 000000000000..c582d9c31213
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/socionext/synquacer.yaml
> @@ -0,0 +1,29 @@
> +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/socionext/synquacer.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Socionext Synquacer platform
> +
> +maintainers:
> +  - Masahisa Kojima <masahisa.kojima@linaro.org>
> +  - Jassi Brar <jaswinder.singh@linaro.org>
> +
> +description:
> +  Socionext SC2A11B (Synquacer) SoC based boards
> +
> +properties:
> +  $nodename:
> +    const: '/'
> +  compatible:
> +    oneOf:
> +      - items:
> +          - enum:
> +              - socionext,developer-box
> +              - socionext,synquacer
> +          - const: socionext,sc2a11b

That's quite different change. What is synquacer in this case? You claim
now it is a board, but based on previous discussions and U-Boot source
it does not look like such. What's more, it does not match U-Boot
sources and there is no Linux user of this, so it contradicts points of
our previous discussion.


Best regards,
Krzysztof
Jassi Brar June 20, 2023, 5:24 p.m. UTC | #2 
On Tue, 20 Jun 2023 at 12:16, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 20/06/2023 19:07, jaswinder.singh@linaro.org wrote:
> > From: Jassi Brar <jaswinder.singh@linaro.org>
> >
> > Socionext's DeveloperBox is based on the SC2A11B SoC (Synquacer).
> > Specify bindings for the platform and boards based on that.
> >
> > Signed-off-by: Jassi Brar <jaswinder.singh@linaro.org>
> > ---
>
> Attach changelog after ---.
>
> >  .../bindings/arm/socionext/synquacer.yaml     | 29 +++++++++++++++++++
> >  1 file changed, 29 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/arm/socionext/synquacer.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/arm/socionext/synquacer.yaml b/Documentation/devicetree/bindings/arm/socionext/synquacer.yaml
> > new file mode 100644
> > index 000000000000..c582d9c31213
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/arm/socionext/synquacer.yaml
> > @@ -0,0 +1,29 @@
> > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/arm/socionext/synquacer.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Socionext Synquacer platform
> > +
> > +maintainers:
> > +  - Masahisa Kojima <masahisa.kojima@linaro.org>
> > +  - Jassi Brar <jaswinder.singh@linaro.org>
> > +
> > +description:
> > +  Socionext SC2A11B (Synquacer) SoC based boards
> > +
> > +properties:
> > +  $nodename:
> > +    const: '/'
> > +  compatible:
> > +    oneOf:
> > +      - items:
> > +          - enum:
> > +              - socionext,developer-box
> > +              - socionext,synquacer
> > +          - const: socionext,sc2a11b
>
> That's quite different change.
>
So it is not carrying your ack.

> What is synquacer in this case? You claim
> now it is a board, but based on previous discussions and U-Boot source
> it does not look like such.
>
I never made that claim. I said Kojima-san will confirm. He informed
Synquacer is a brand name.

Currently no code internally or externally differentiates between
SC2A11B and Synquacer and we might as well keep living with Synquacer
only. This patch is an attempt to be accurate.

-j
Krzysztof Kozlowski June 20, 2023, 5:54 p.m. UTC | #3 
On 20/06/2023 19:24, Jassi Brar wrote:
>>> +properties:
>>> +  $nodename:
>>> +    const: '/'
>>> +  compatible:
>>> +    oneOf:
>>> +      - items:
>>> +          - enum:
>>> +              - socionext,developer-box
>>> +              - socionext,synquacer
>>> +          - const: socionext,sc2a11b
>>
>> That's quite different change.
>>
> So it is not carrying your ack.
> 
>> What is synquacer in this case? You claim
>> now it is a board, but based on previous discussions and U-Boot source
>> it does not look like such.
>>
> I never made that claim. I said Kojima-san will confirm. He informed
> Synquacer is a brand name.
> 
> Currently no code internally or externally differentiates between
> SC2A11B and Synquacer and we might as well keep living with Synquacer
> only. This patch is an attempt to be accurate.

Then the patch is not correct, because synquacer is not a board. We
should anyway choose only one for adding to documentation.

Best regards,
Krzysztof
Jassi Brar June 20, 2023, 6:21 p.m. UTC | #4 
On Tue, 20 Jun 2023 at 12:54, Krzysztof Kozlowski
<krzysztof.kozlowski@linaro.org> wrote:
>
> On 20/06/2023 19:24, Jassi Brar wrote:
> >>> +properties:
> >>> +  $nodename:
> >>> +    const: '/'
> >>> +  compatible:
> >>> +    oneOf:
> >>> +      - items:
> >>> +          - enum:
> >>> +              - socionext,developer-box
> >>> +              - socionext,synquacer
> >>> +          - const: socionext,sc2a11b
> >>
> >> That's quite different change.
> >>
> > So it is not carrying your ack.
> >
> >> What is synquacer in this case? You claim
> >> now it is a board, but based on previous discussions and U-Boot source
> >> it does not look like such.
> >>
> > I never made that claim. I said Kojima-san will confirm. He informed
> > Synquacer is a brand name.
> >
> > Currently no code internally or externally differentiates between
> > SC2A11B and Synquacer and we might as well keep living with Synquacer
> > only. This patch is an attempt to be accurate.
>
> Then the patch is not correct, because synquacer is not a board. We
> should anyway choose only one for adding to documentation.
>
OK. I will revert to using the brand name Synquacer.

thnkx
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/arm/socionext/synquacer.yaml b/Documentation/devicetree/bindings/arm/socionext/synquacer.yaml
new file mode 100644
index 000000000000..c582d9c31213
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/socionext/synquacer.yaml
@@ -0,0 +1,29 @@ 
+# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/arm/socionext/synquacer.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Socionext Synquacer platform
+
+maintainers:
+  - Masahisa Kojima <masahisa.kojima@linaro.org>
+  - Jassi Brar <jaswinder.singh@linaro.org>
+
+description:
+  Socionext SC2A11B (Synquacer) SoC based boards
+
+properties:
+  $nodename:
+    const: '/'
+  compatible:
+    oneOf:
+      - items:
+          - enum:
+              - socionext,developer-box
+              - socionext,synquacer
+          - const: socionext,sc2a11b
+
+additionalProperties: true
+
+...