| Message ID | 20221221074047.233473-1-umang.jain@ideasonboard.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:adf:e747:0:0:0:0:0 with SMTP id c7csp3391332wrn;
Tue, 20 Dec 2022 23:49:37 -0800 (PST)
X-Google-Smtp-Source:
AMrXdXuuw7JAH1Qf4qYFHXA2VXTOI7D8iY5yYvoZtKJ9YgedU2cVb0ngwTlbb8yMZOb5hrv7xIhP
X-Received: by 2002:a17:907:1710:b0:7c0:c36d:f5df with SMTP id
le16-20020a170907171000b007c0c36df5dfmr593580ejc.70.1671608977828;
Tue, 20 Dec 2022 23:49:37 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1671608977; cv=none;
d=google.com; s=arc-20160816;
b=jHLS6nvFCUNT+OvpQidxPyUIN1F/f55xFeuD0TdXDHWVz0RCb7xhfv0wUvotlcL00P
jFq1jm4qjFhNq4Dckvo0jhkkbHdvWFft62m3yOaeOkDxWubR7/kSwr10xpYK0USb/8JS
7NM+FZqWI7GZ1KD9/d4OTxyPJeyq8hyqfs1/JO/UGJmKKAxUxS6ZY4HK7IyvA1ZYNDo/
4eBEvEzdrMbbAJFchVt1tBJa8AqdxJ24+MdMku2rmRepLNJod+AMVJmBHHElNshO1Ed0
GJnEJisdura/Hy20Srb2YR7oGLE7J/+pireNKf6p5fkuLpfSwYmYjLdPS+eV/84lhyKu
6FXw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=EFbvpWNPHfuEqpG7nwMVI/9Yiztc2VKMMA8tkNEtDV4=;
b=vVjS80la8CPgw3QC9afgLXoRSyW5U03LfGkn5mIvC2kZiiIleBCe3W54yGeza8eoTL
RU9A0vtVDK+xO64joqt+7Q9AdY4ok3LV83+2aEiPbNphqx/pE2WNf95a/bdccTKLlXtv
f6q4sOKSHCX/ew/HIYSGe4DXEJyERI6MB1JeemGkGwRJRy+RSZaERghZnH/iAY5C1CTC
Rmkqe1vKyNdtHonEyiaNdKZalvdRuK2WlyajiHsY2zVTP6RjLT9wCNqNBtJ2NLxE7dz8
5VdlNnW6UE5XiGbek9MWLoj4L9tR3jmWmwkghqkTrojNUEFZNLVkiVRnfKe1r/Ziw4U8
jRaQ==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail
header.b=oD54nE+M;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
qw11-20020a1709066a0b00b007e49443849asi14964423ejc.218.2022.12.20.23.49.14;
Tue, 20 Dec 2022 23:49:37 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail
header.b=oD54nE+M;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S231610AbiLUHlR (ORCPT <rfc822;pacteraone@gmail.com> + 99 others);
Wed, 21 Dec 2022 02:41:17 -0500
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34544 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S229472AbiLUHlM (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Wed, 21 Dec 2022 02:41:12 -0500
Received: from perceval.ideasonboard.com (perceval.ideasonboard.com
[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 491B163ED
for <linux-kernel@vger.kernel.org>;
Tue, 20 Dec 2022 23:41:11 -0800 (PST)
Received: from umang.jainideasonboard.com (unknown
[IPv6:2409:4041:6e00:8664:7b2b:8fb:60de:a205])
by perceval.ideasonboard.com (Postfix) with ESMTPSA id 6649EFB;
Wed, 21 Dec 2022 08:41:03 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;
s=mail; t=1671608468;
bh=eFlNBXwSSXctvuPUS9pXmGHrLnv5YhS5W9CJ67PeCAI=;
h=From:To:Cc:Subject:Date:From;
b=oD54nE+MO8FZZBeM2qhzezzombfMcjovY29Zc3E2ooJVEzhWBpC8s4lh9nZ/ekiqP
bS2nSMcIyQcJH/1COl9mW9x9XHy0b3+6bT8gzWuK/66SHMrpfKtS38C4ocKyvj0nAx
QfPsbtU3+09gHNSzxEzeglfviTLTQ0ULIFQ0+Lhw=
From: Umang Jain <umang.jain@ideasonboard.com>
To: linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev,
linux-rpi-kernel@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Adrien Thierry <athierry@redhat.com>,
Stefan Wahren <stefan.wahren@i2se.com>,
Kieran Bingham <kieran.bingham@ideasonboard.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Umang Jain <umang.jain@ideasonboard.com>
Subject: [PATCH] staging: vchiq_arm: Remove extra struct vchiq_instance
declaration
Date: Wed, 21 Dec 2022 13:10:47 +0530
Message-Id: <20221221074047.233473-1-umang.jain@ideasonboard.com>
X-Mailer: git-send-email 2.38.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS
autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1752809055471758352?=
X-GMAIL-MSGID: =?utf-8?q?1752809055471758352?=
|
| Series |
staging: vchiq_arm: Remove extra struct vchiq_instance declaration
|
|
Commit Message
Umang Jain
Dec. 21, 2022, 7:40 a.m. UTC
Additional declaration of struct vchiq_instance was introduced in the
commit 726e79f8a648 ("staging: vchiq_arm: pass vchiq instance to
service callbacks"). Drop the extra declaration.
Fixes: 726e79f8a648 ("staging: vchiq_arm: pass vchiq instance to service callbacks")
Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>
---
drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h | 2 --
1 file changed, 2 deletions(-)
Comments
Am 21.12.22 um 08:40 schrieb Umang Jain: > Additional declaration of struct vchiq_instance was introduced in the > commit 726e79f8a648 ("staging: vchiq_arm: pass vchiq instance to > service callbacks"). Drop the extra declaration. > > Fixes: 726e79f8a648 ("staging: vchiq_arm: pass vchiq instance to service callbacks") > Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> Reviewed-by: Stefan Wahren <stefan.wahren@i2se.com>
Quoting Umang Jain (2022-12-21 07:40:47) > Additional declaration of struct vchiq_instance was introduced in the > commit 726e79f8a648 ("staging: vchiq_arm: pass vchiq instance to > service callbacks"). Drop the extra declaration. > > Fixes: 726e79f8a648 ("staging: vchiq_arm: pass vchiq instance to service callbacks") > Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> It's tempting to move the other instance up to near the top of the file too, but not necessary. Reviewed-by: Kieran Bingham <kieran.bingham@ideasonboard.com> > --- > drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h b/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h > index 66965da11443..52e106f117da 100644 > --- a/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h > +++ b/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h > @@ -78,8 +78,6 @@ struct vchiq_service_params_kernel { > short version_min; /* Update for incompatible changes */ > }; > > -struct vchiq_instance; > - > extern int vchiq_initialise(struct vchiq_instance **pinstance); > extern int vchiq_shutdown(struct vchiq_instance *instance); > extern int vchiq_connect(struct vchiq_instance *instance); > -- > 2.38.1 >
Hi again, Can this be collected please?. The series has two R-b tags and I think it got skipped during the last window? On 12/21/22 1:10 PM, Umang Jain wrote: > Additional declaration of struct vchiq_instance was introduced in the > commit 726e79f8a648 ("staging: vchiq_arm: pass vchiq instance to > service callbacks"). Drop the extra declaration. > > Fixes: 726e79f8a648 ("staging: vchiq_arm: pass vchiq instance to service callbacks") > Signed-off-by: Umang Jain <umang.jain@ideasonboard.com> > --- > drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h b/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h > index 66965da11443..52e106f117da 100644 > --- a/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h > +++ b/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h > @@ -78,8 +78,6 @@ struct vchiq_service_params_kernel { > short version_min; /* Update for incompatible changes */ > }; > > -struct vchiq_instance; > - > extern int vchiq_initialise(struct vchiq_instance **pinstance); > extern int vchiq_shutdown(struct vchiq_instance *instance); > extern int vchiq_connect(struct vchiq_instance *instance);
On Tue, Jun 20, 2023 at 07:16:15PM +0530, Umang Jain wrote: > Hi again, > > Can this be collected please?. The series has two R-b tags and I think it > got skipped during the last window? SOrry for the delay, this got dropped somewhere, now queued up. greg k-h
diff --git a/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h b/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h index 66965da11443..52e106f117da 100644 --- a/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h +++ b/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h @@ -78,8 +78,6 @@ struct vchiq_service_params_kernel { short version_min; /* Update for incompatible changes */ }; -struct vchiq_instance; - extern int vchiq_initialise(struct vchiq_instance **pinstance); extern int vchiq_shutdown(struct vchiq_instance *instance); extern int vchiq_connect(struct vchiq_instance *instance);