diff mbox series

ACPI: APEI: mark some functions __init

Message ID 20230617080708.2002287-1-linmiaohe@huawei.com
State New
Headers
Series ACPI: APEI: mark some functions __init |

Commit Message

Miaohe Lin June 17, 2023, 8:07 a.m. UTC 
  hest_esrc_len() and apei_hest_parse() are only called inside __init
section. So mark them __init too.

Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
---
 drivers/acpi/apei/hest.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Shuai Xue June 20, 2023, 3:43 a.m. UTC | #1 
On 2023/6/17 16:07, Miaohe Lin wrote:
> hest_esrc_len() and apei_hest_parse() are only called inside __init
> section. So mark them __init too.

Hi, Miaohe,

should ghes_estatus_pool_init also be marked with __init?

Thanks.

Best Regards,
Shuai


> 
> Signed-off-by: Miaohe Lin <linmiaohe@huawei.com>
> ---
>  drivers/acpi/apei/hest.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/acpi/apei/hest.c b/drivers/acpi/apei/hest.c
> index 6aef1ee5e1bd..2d78e808ab8b 100644
> --- a/drivers/acpi/apei/hest.c
> +++ b/drivers/acpi/apei/hest.c
> @@ -55,7 +55,7 @@ static inline bool is_generic_error(struct acpi_hest_header *hest_hdr)
>  	       hest_hdr->type == ACPI_HEST_TYPE_GENERIC_ERROR_V2;
>  }
>  
> -static int hest_esrc_len(struct acpi_hest_header *hest_hdr)
> +static int __init hest_esrc_len(struct acpi_hest_header *hest_hdr)
>  {
>  	u16 hest_type = hest_hdr->type;
>  	int len;
> @@ -88,7 +88,7 @@ static int hest_esrc_len(struct acpi_hest_header *hest_hdr)
>  
>  typedef int (*apei_hest_func_t)(struct acpi_hest_header *hest_hdr, void *data);
>  
> -static int apei_hest_parse(apei_hest_func_t func, void *data)
> +static int __init apei_hest_parse(apei_hest_func_t func, void *data)
>  {
>  	struct acpi_hest_header *hest_hdr;
>  	int i, rc, len;
Miaohe Lin June 20, 2023, 3:58 a.m. UTC | #2 
On 2023/6/20 11:43, Shuai Xue wrote:
> 
> 
> On 2023/6/17 16:07, Miaohe Lin wrote:
>> hest_esrc_len() and apei_hest_parse() are only called inside __init
>> section. So mark them __init too.
> 
> Hi, Miaohe,
> 
> should ghes_estatus_pool_init also be marked with __init?

Yes, I think so. It's only called within __init section too. And it's in fact on my plan
in another patch. Thanks for your comment.

> 
> Thanks.
> 
> Best Regards,
> Shuai
> 
>
diff mbox series

Patch

diff --git a/drivers/acpi/apei/hest.c b/drivers/acpi/apei/hest.c
index 6aef1ee5e1bd..2d78e808ab8b 100644
--- a/drivers/acpi/apei/hest.c
+++ b/drivers/acpi/apei/hest.c
@@ -55,7 +55,7 @@  static inline bool is_generic_error(struct acpi_hest_header *hest_hdr)
 	       hest_hdr->type == ACPI_HEST_TYPE_GENERIC_ERROR_V2;
 }
 
-static int hest_esrc_len(struct acpi_hest_header *hest_hdr)
+static int __init hest_esrc_len(struct acpi_hest_header *hest_hdr)
 {
 	u16 hest_type = hest_hdr->type;
 	int len;
@@ -88,7 +88,7 @@  static int hest_esrc_len(struct acpi_hest_header *hest_hdr)
 
 typedef int (*apei_hest_func_t)(struct acpi_hest_header *hest_hdr, void *data);
 
-static int apei_hest_parse(apei_hest_func_t func, void *data)
+static int __init apei_hest_parse(apei_hest_func_t func, void *data)
 {
 	struct acpi_hest_header *hest_hdr;
 	int i, rc, len;