diff mbox series

[v3,01/11] media: mediatek: vcodec: remove unused parameter

Message ID	20230617103255.20239-2-yunfei.dong@mediatek.com
State	New
Headers	Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; From: Yunfei Dong <yunfei.dong@mediatek.com> To: =?utf-8?q?N=C3=ADcolas_F_=2E_R_=2E_A_=2E_Prado?= <nfraprado@collabora.com>, Nicolas Dufresne <nicolas.dufresne@collabora.com>, Hans Verkuil <hverkuil-cisco@xs4all.nl>, AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>, Benjamin Gaignard <benjamin.gaignard@collabora.com>, Nathan Hebert <nhebert@chromium.org> CC: Yunfei Dong <yunfei.dong@mediatek.com>, Chen-Yu Tsai <wenst@chromium.org>, Hsin-Yi Wang <hsinyi@chromium.org>, Fritz Koenig <frkoenig@chromium.org>, Daniel Vetter <daniel@ffwll.ch>, Steve Cho <stevecho@chromium.org>, <linux-media@vger.kernel.org>, <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-mediatek@lists.infradead.org>, <Project_Global_Chrome_Upstream_Group@mediatek.com> Subject: [PATCH v3,01/11] media: mediatek: vcodec: remove unused parameter Date: Sat, 17 Jun 2023 18:32:45 +0800 Message-ID: <20230617103255.20239-2-yunfei.dong@mediatek.com> In-Reply-To: <20230617103255.20239-1-yunfei.dong@mediatek.com> References: <20230617103255.20239-1-yunfei.dong@mediatek.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain Precedence: bulk
Series	media: mediatek: vcodec: separate encoder and decoder \| [v3,0/11] media: mediatek: vcodec: separate encoder and decoder [v3,01/11] media: mediatek: vcodec: remove unused parameter [v3,02/11] media: mediatek: vcodec: align fw interface [v3,03/11] media: mediatek: vcodec: re-write shared interface [v3,04/11] media: mediatek: vcodec: remove useless debug log [v3,05/11] media: mediatek: vcodec: remove the dependency of vcodec debug log [v3,06/11] mediatek: vcodec: replace pr_* with dev_* for v4l2 debug message [v3,07/11] mediatek: vcodec: separate struct mtk_vcodec_ctx [v3,08/11] mediatek: vcodec: separate struct mtk_vcodec_dev [v3,09/11] mediatek: vcodec: fix unreasonable parameter definition and style [v3,10/11] mediatek: vcodec: remove unused include header [v3,11/11] mediatek: vcodec: separete decoder and encoder

Commit Message

Yunfei Dong (董云飞) June 17, 2023, 10:32 a.m. UTC

  remove unused parameter in struct mtk_vcodec_dev.

Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>
---
 drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c | 2 --
 drivers/media/platform/mediatek/vcodec/mtk_vcodec_drv.h     | 6 ------
 drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c | 2 --
 3 files changed, 10 deletions(-)

Comments

Nicolas Dufresne June 19, 2023, 2:42 p.m. UTC | #1

Le samedi 17 juin 2023 à 18:32 +0800, Yunfei Dong a écrit :
> remove unused parameter in struct mtk_vcodec_dev.
> 
> Signed-off-by: Yunfei Dong <yunfei.dong@mediatek.com>

Reviewed-by: Nicolas Dufresne <nicolas.dufresne@collabora.com>

> ---
>  drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c | 2 --
>  drivers/media/platform/mediatek/vcodec/mtk_vcodec_drv.h     | 6 ------
>  drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c | 2 --
>  3 files changed, 10 deletions(-)
> 
> diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c
> index d41f2121b94f..03721eda2769 100644
> --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c
> +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c
> @@ -336,8 +336,6 @@ static int mtk_vcodec_probe(struct platform_device *pdev)
>  		goto err_core_workq;
>  	}
>  
> -	init_waitqueue_head(&dev->queue);
> -
>  	vfd_dec = video_device_alloc();
>  	if (!vfd_dec) {
>  		mtk_v4l2_err("Failed to allocate video device");
> diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_drv.h b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_drv.h
> index f17d67e781c9..e3230a4d7b8e 100644
> --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_drv.h
> +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_drv.h
> @@ -448,10 +448,7 @@ struct mtk_vcodec_enc_pdata {
>   * @decode_workqueue: decode work queue
>   * @encode_workqueue: encode work queue
>   *
> - * @int_cond: used to identify interrupt condition happen
> - * @int_type: used to identify what kind of interrupt condition happen
>   * @dev_mutex: video_device lock
> - * @queue: waitqueue for waiting for completion of device commands
>   *
>   * @dec_irq: decoder irq resource
>   * @enc_irq: h264 encoder irq resource
> @@ -496,10 +493,7 @@ struct mtk_vcodec_dev {
>  
>  	struct workqueue_struct *decode_workqueue;
>  	struct workqueue_struct *encode_workqueue;
> -	int int_cond;
> -	int int_type;
>  	struct mutex dev_mutex;
> -	wait_queue_head_t queue;
>  
>  	int dec_irq;
>  	int enc_irq;
> diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c
> index 5df0a22ff3b5..a56652e476c2 100644
> --- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c
> +++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c
> @@ -311,8 +311,6 @@ static int mtk_vcodec_probe(struct platform_device *pdev)
>  		goto err_res;
>  	}
>  
> -	init_waitqueue_head(&dev->queue);
> -
>  	/* allocate video device for encoder and register it */
>  	vfd_enc = video_device_alloc();
>  	if (!vfd_enc) {

diff mbox series

Patch

diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c
index d41f2121b94f..03721eda2769 100644
--- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c
+++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_dec_drv.c
@@ -336,8 +336,6 @@  static int mtk_vcodec_probe(struct platform_device *pdev)
 		goto err_core_workq;
 	}
 
-	init_waitqueue_head(&dev->queue);
-
 	vfd_dec = video_device_alloc();
 	if (!vfd_dec) {
 		mtk_v4l2_err("Failed to allocate video device");
diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_drv.h b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_drv.h
index f17d67e781c9..e3230a4d7b8e 100644
--- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_drv.h
+++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_drv.h
@@ -448,10 +448,7 @@  struct mtk_vcodec_enc_pdata {
  * @decode_workqueue: decode work queue
  * @encode_workqueue: encode work queue
  *
- * @int_cond: used to identify interrupt condition happen
- * @int_type: used to identify what kind of interrupt condition happen
  * @dev_mutex: video_device lock
- * @queue: waitqueue for waiting for completion of device commands
  *
  * @dec_irq: decoder irq resource
  * @enc_irq: h264 encoder irq resource
@@ -496,10 +493,7 @@  struct mtk_vcodec_dev {
 
 	struct workqueue_struct *decode_workqueue;
 	struct workqueue_struct *encode_workqueue;
-	int int_cond;
-	int int_type;
 	struct mutex dev_mutex;
-	wait_queue_head_t queue;
 
 	int dec_irq;
 	int enc_irq;
diff --git a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c
index 5df0a22ff3b5..a56652e476c2 100644
--- a/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c
+++ b/drivers/media/platform/mediatek/vcodec/mtk_vcodec_enc_drv.c
@@ -311,8 +311,6 @@  static int mtk_vcodec_probe(struct platform_device *pdev)
 		goto err_res;
 	}
 
-	init_waitqueue_head(&dev->queue);
-
 	/* allocate video device for encoder and register it */
 	vfd_enc = video_device_alloc();
 	if (!vfd_enc) {