[-next,v2] crypto: rockchip: Remove surplus dev_err() when using platform_get_irq()
Message ID | 20221104074527.37353-1-yang.lee@linux.alibaba.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp238917wru; Fri, 4 Nov 2022 01:02:31 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7u+O9YMov28kmKsTLA0ki2veLURFA7mUe1vEIINzpslCW3ngjS8Chj4HQx2BGsEWIlwonu X-Received: by 2002:a17:906:9be6:b0:7ad:a73b:40c7 with SMTP id de38-20020a1709069be600b007ada73b40c7mr33435147ejc.483.1667548951032; Fri, 04 Nov 2022 01:02:31 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1667548951; cv=none; d=google.com; s=arc-20160816; b=p6PsK7FKEOBdl1990N42v+CDeuqr8l9bnG3Br3+ertt53ts5/0ZE3jTZiHdub1NsQv ZDgiBBUx0GZ/OM4iv0Kb/Zm25KZT/6umAVQ0mZQGelUrHaozSLiFeKn+a0vZ614U4Q1C WBhB79pcIiMbR3Aq70V8vw5uhTU/FSmgej9M/77v1citMnAPeS4yZgj8+pOEuyKvJLZJ gnt+4ilLhpuOpHpN03Gd7VEb+bEV7pQXgSE3nQL5oI3zDj93WGDsd6Bu1G4qHdJvHKXU flL6CncyyQAKa7xHEeUSmKdtEy9kw10BkY5PwG876rj4rXBqJb9QIHEaihBn3NJUnRO/ LSHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from; bh=pbxXdFGH+As+inREa8LvJoDYVMKxoTA3ghAguySPIjU=; b=T+tisSCpmntVayA+HUF1kGBVAS6tobdHsO8VR6a3Lhjo/uNpnq4HPEgAmjPGBubpGi HKwlU0MdHl+NEXrTRu0ZyDTMeBp/8AqJJK0czlx7V+ztjEye7X0dbR49jbjIjO/vCZJC VujvK+yvQuGGbM8yEjjmQeCmD0++QoOuHshpnJmKR0XSttzrL0vkdb9C2+pqpVhm9u37 tnLy2ufv4ZGIcqiVy863r4VPpTw1oo1N7w2vofB1qHOOjIiUpbsB5Ly5ZK3hiOBzt3Zw ovQNSuRAS3riR7nQbdycZENbb0sIkDEtup4oN7ScHWN4pyUFgexzYlXkmGTaBFDK1gQm Vt/g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id b23-20020aa7cd17000000b004587e99bcc2si3433606edw.383.2022.11.04.01.02.06; Fri, 04 Nov 2022 01:02:31 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231324AbiKDHph (ORCPT <rfc822;jimliu8233@gmail.com> + 99 others); Fri, 4 Nov 2022 03:45:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34276 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231182AbiKDHpd (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 4 Nov 2022 03:45:33 -0400 Received: from out30-57.freemail.mail.aliyun.com (out30-57.freemail.mail.aliyun.com [115.124.30.57]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F38A42018B; Fri, 4 Nov 2022 00:45:31 -0700 (PDT) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R271e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018045192;MF=yang.lee@linux.alibaba.com;NM=1;PH=DS;RN=10;SR=0;TI=SMTPD_---0VTw1.EU_1667547928; Received: from localhost(mailfrom:yang.lee@linux.alibaba.com fp:SMTPD_---0VTw1.EU_1667547928) by smtp.aliyun-inc.com; Fri, 04 Nov 2022 15:45:29 +0800 From: Yang Li <yang.lee@linux.alibaba.com> To: clabbe@baylibre.com Cc: herbert@gondor.apana.org.au, davem@davemloft.net, heiko@sntech.de, linux-crypto@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org, Yang Li <yang.lee@linux.alibaba.com>, Abaci Robot <abaci@linux.alibaba.com> Subject: [PATCH -next v2] crypto: rockchip: Remove surplus dev_err() when using platform_get_irq() Date: Fri, 4 Nov 2022 15:45:27 +0800 Message-Id: <20221104074527.37353-1-yang.lee@linux.alibaba.com> X-Mailer: git-send-email 2.20.1.7.g153144c MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-9.9 required=5.0 tests=BAYES_00, ENV_AND_HDR_SPF_MATCH,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,USER_IN_DEF_SPF_WL autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1748551808548057056?= X-GMAIL-MSGID: =?utf-8?q?1748551808548057056?= |
Series |
[-next,v2] crypto: rockchip: Remove surplus dev_err() when using platform_get_irq()
|
|
Commit Message
Yang Li
Nov. 4, 2022, 7:45 a.m. UTC
There is no need to call the dev_err() function directly to print a
custom message when handling an error from either the platform_get_irq()
or platform_get_irq_byname() functions as both are going to display an
appropriate error message in case of a failure.
./drivers/crypto/rockchip/rk3288_crypto.c:351:2-9: line 351 is
redundant because platform_get_irq() already prints an error
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2677
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
change in v2:
--According to Corentin's suggestion, make the subject started by "crypto: rockchip:".
drivers/crypto/rockchip/rk3288_crypto.c | 1 -
1 file changed, 1 deletion(-)
Comments
Le Fri, Nov 04, 2022 at 03:45:27PM +0800, Yang Li a écrit : > There is no need to call the dev_err() function directly to print a > custom message when handling an error from either the platform_get_irq() > or platform_get_irq_byname() functions as both are going to display an > appropriate error message in case of a failure. > > ./drivers/crypto/rockchip/rk3288_crypto.c:351:2-9: line 351 is > redundant because platform_get_irq() already prints an error > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2677 > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > > change in v2: > --According to Corentin's suggestion, make the subject started by "crypto: rockchip:". > > drivers/crypto/rockchip/rk3288_crypto.c | 1 - > 1 file changed, 1 deletion(-) > Hello Acked-by: Corentin Labbe <clabbe@baylibre.com> Thanks
On Fri, Nov 04, 2022 at 03:45:27PM +0800, Yang Li wrote: > There is no need to call the dev_err() function directly to print a > custom message when handling an error from either the platform_get_irq() > or platform_get_irq_byname() functions as both are going to display an > appropriate error message in case of a failure. > > ./drivers/crypto/rockchip/rk3288_crypto.c:351:2-9: line 351 is > redundant because platform_get_irq() already prints an error > > Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=2677 > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > > change in v2: > --According to Corentin's suggestion, make the subject started by "crypto: rockchip:". > > drivers/crypto/rockchip/rk3288_crypto.c | 1 - > 1 file changed, 1 deletion(-) Patch applied. Thanks.
diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/rockchip/rk3288_crypto.c index 6217e73ba4c4..9f6ba770a90a 100644 --- a/drivers/crypto/rockchip/rk3288_crypto.c +++ b/drivers/crypto/rockchip/rk3288_crypto.c @@ -348,7 +348,6 @@ static int rk_crypto_probe(struct platform_device *pdev) crypto_info->irq = platform_get_irq(pdev, 0); if (crypto_info->irq < 0) { - dev_err(&pdev->dev, "control Interrupt is not available.\n"); err = crypto_info->irq; goto err_crypto; }