| Message ID | 20230607110650.569522-1-suijingfeng@loongson.cn |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a05:6358:3046:b0:115:7a1d:dabb with SMTP id p6csp277813rwl;
Wed, 7 Jun 2023 04:29:28 -0700 (PDT)
X-Google-Smtp-Source:
ACHHUZ6SB/ujDtu1zdauPnhlMoVaLxsTMFfnz1LaLnLFeuvBeeOAR12SUzfWGksbWkUYI+KiuGZf
X-Received: by 2002:a05:6358:4e0a:b0:123:4e5e:d65 with SMTP id
cf10-20020a0563584e0a00b001234e5e0d65mr3558945rwb.10.1686137368701;
Wed, 07 Jun 2023 04:29:28 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1686137368; cv=none;
d=google.com; s=arc-20160816;
b=Sk/87sOlh4Bj/+LkbWbIVbS2ty775PX2S+0cQsnxIzLaaUG4pIFajrW6tvklsdfmKM
msMSoDYcgMtlO5mkIy9jrSLKaQlFWggzQw4vsDy2SVburflnnwhSOZ6ausCPjU6ODltU
MrOi5unjZr+oZLY3c9qs/jveV7ADZlQsR5KRCDQC0adVW8DqQZLKRrKknPQc3qIxsWGO
Yp4XZznuymawjyYWQGMqn1LtCs9B2sR90gKzu/knEjFlVeEJkNprT5wWtaOPH5VwY4gV
Y8QHAxXFeBo8jntz66FWrM7cTbTDYMhoqNdfmd9GLEYZTc6CrIM4RnGrkgok/EKDi4H+
2i5g==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from;
bh=JGmbH+o9t9vISSWSQmyEYt/zfmjThHnB03jzaca7gFo=;
b=RehdKoSgIFsCYXEwAbOLK3zswecwuXvXsQZk6wUzDBc8trKLZYdLaoDVplpbx8iZH1
6jmdbDtKSJJh5CvxnRJBWkAnxTgNuAOqyQ414jl1+A+z8L2pNg33bdG+ObdIB1hN/W6/
V7mcXX7sDyDqC4CiSz7pGL1F7jKJgr2TntWk62zDIHOVsDbAxklBM7e3mux3qn2LivHf
WNEZzfalJuPN1KMirbCOJUjcdpxAobXurqrSI5xtWBW/wHD2OsKULI7aKafu/Ri8o2Zp
dxvpwhQhOiFX3QnLUkUtW5E20JjbEfl0rqrh+UjJuNmKeszp2+uVPIlNuvl5y10v0YPg
oedQ==
ARC-Authentication-Results: i=1; mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
ob9-20020a17090b390900b0025096763f46si1028752pjb.94.2023.06.07.04.29.12;
Wed, 07 Jun 2023 04:29:28 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S235696AbjFGLHn (ORCPT <rfc822;literming00@gmail.com>
+ 99 others); Wed, 7 Jun 2023 07:07:43 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45604 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S240192AbjFGLHj (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Wed, 7 Jun 2023 07:07:39 -0400
Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163])
by lindbergh.monkeyblade.net (Postfix) with ESMTP id D2C5A1BE5;
Wed, 7 Jun 2023 04:07:09 -0700 (PDT)
Received: from loongson.cn (unknown [10.20.42.43])
by gateway (Coremail) with SMTP id _____8DxzOrLZIBkGB0AAA--.467S3;
Wed, 07 Jun 2023 19:06:51 +0800 (CST)
Received: from openarena.loongson.cn (unknown [10.20.42.43])
by localhost.localdomain (Coremail) with SMTP id
AQAAf8DxGOXKZIBkUW0EAA--.16030S2;
Wed, 07 Jun 2023 19:06:50 +0800 (CST)
From: Sui Jingfeng <suijingfeng@loongson.cn>
To: Paul Cercueil <paul@crapouillou.net>,
David Airlie <airlied@gmail.com>,
Daniel Vetter <daniel@ffwll.ch>
Cc: linux-mips@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: [PATCH v2] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO
Date: Wed, 7 Jun 2023 19:06:50 +0800
Message-Id: <20230607110650.569522-1-suijingfeng@loongson.cn>
X-Mailer: git-send-email 2.25.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-CM-TRANSID: AQAAf8DxGOXKZIBkUW0EAA--.16030S2
X-CM-SenderInfo: xvxlyxpqjiv03j6o00pqjv00gofq/
X-Coremail-Antispam: 1Uk129KBj93XoWxJr1UJr13Gw45JF1xWrWUKFX_yoW8Gr1Upr
s8tw18uFZ7ZFW0kFW7AF1xWFy5X3WDXFWSkr93twn09rn8AFWjyr9IyFW5GFyUAry7WrWU
Xas3KFy7JFy8A3XCm3ZEXasCq-sJn29KB7ZKAUJUUUU8529EdanIXcx71UUUUU7KY7ZEXa
sCq-sGcSsGvfJ3Ic02F40EFcxC0VAKzVAqx4xG6I80ebIjqfuFe4nvWSU5nxnvy29KBjDU
0xBIdaVrnRJUUUkIb4IE77IF4wAFF20E14v26r1j6r4UM7CY07I20VC2zVCF04k26cxKx2
IYs7xG6rWj6s0DM7CIcVAFz4kK6r106r15M28lY4IEw2IIxxk0rwA2F7IY1VAKz4vEj48v
e4kI8wA2z4x0Y4vE2Ix0cI8IcVAFwI0_Jr0_JF4l84ACjcxK6xIIjxv20xvEc7CjxVAFwI
0_Jr0_Gr1l84ACjcxK6I8E87Iv67AKxVWxJr0_GcWl84ACjcxK6I8E87Iv6xkF7I0E14v2
6F4UJVW0owAS0I0E0xvYzxvE52x082IY62kv0487Mc804VCY07AIYIkI8VC2zVCFFI0UMc
02F40EFcxC0VAKzVAqx4xG6I80ewAv7VC0I7IYx2IY67AKxVWUGVWUXwAv7VC2z280aVAF
wI0_Cr0_Gr1UMcvjeVCFs4IE7xkEbVWUJVW8JwACjcxG0xvY0x0EwIxGrwCF04k20xvY0x
0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8JwC20s026c02F40E14v26r1j6r18MI8I3I0E
7480Y4vE14v26r106r1rMI8E67AF67kF1VAFwI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcV
C0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjxv20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF
04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2jsIE14v26F4j6r4UJwCI42IY6I8E87Iv6x
kF7I0E14v26r4UJVWxJrUvcSsGvfC2KfnxnUUI43ZEXa7IU14lk7UUUUU==
X-Spam-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_NONE,
SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham
autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1768028289700006174?=
X-GMAIL-MSGID: =?utf-8?q?1768043177435763480?=
|
| Series |
[v2] drm/ingenic: Kconfig: select REGMAP and REGMAP_MMIO
|
|
Commit Message
Sui Jingfeng
June 7, 2023, 11:06 a.m. UTC
Otherwise its failed to pass basic compile test on platform without
REGMAP_MMIO selected by defconfig
make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64-
SYNC include/config/auto.conf.cmd
Checking missing-syscalls for N32
CALL scripts/checksyscalls.sh
Checking missing-syscalls for O32
CALL scripts/checksyscalls.sh
CALL scripts/checksyscalls.sh
MODPOST Module.symvers
ERROR: modpost: "__devm_regmap_init_mmio_clk" [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1
make: *** [Makefile:1978: modpost] Error 2
V2: Order alphabetically
Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn>
---
drivers/gpu/drm/ingenic/Kconfig | 2 ++
1 file changed, 2 insertions(+)
Comments
Hi, Humble ping ? On 2023/6/7 19:06, Sui Jingfeng wrote: > Otherwise its failed to pass basic compile test on platform without > REGMAP_MMIO selected by defconfig > > make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64- > > SYNC include/config/auto.conf.cmd > Checking missing-syscalls for N32 > CALL scripts/checksyscalls.sh > Checking missing-syscalls for O32 > CALL scripts/checksyscalls.sh > CALL scripts/checksyscalls.sh > MODPOST Module.symvers > ERROR: modpost: "__devm_regmap_init_mmio_clk" [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined! > make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1 > make: *** [Makefile:1978: modpost] Error 2 > > V2: Order alphabetically > > Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn> > --- > drivers/gpu/drm/ingenic/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/ingenic/Kconfig b/drivers/gpu/drm/ingenic/Kconfig > index a53f475d33df..b440e0cdc057 100644 > --- a/drivers/gpu/drm/ingenic/Kconfig > +++ b/drivers/gpu/drm/ingenic/Kconfig > @@ -9,6 +9,8 @@ config DRM_INGENIC > select DRM_PANEL_BRIDGE > select DRM_KMS_HELPER > select DRM_GEM_DMA_HELPER > + select REGMAP > + select REGMAP_MMIO > select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE > help > Choose this option for DRM support for the Ingenic SoCs.
Hi, Le mercredi 07 juin 2023 à 19:06 +0800, Sui Jingfeng a écrit : > Otherwise its failed to pass basic compile test on platform without > REGMAP_MMIO selected by defconfig > > make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64- > > SYNC include/config/auto.conf.cmd > Checking missing-syscalls for N32 > CALL scripts/checksyscalls.sh > Checking missing-syscalls for O32 > CALL scripts/checksyscalls.sh > CALL scripts/checksyscalls.sh > MODPOST Module.symvers > ERROR: modpost: "__devm_regmap_init_mmio_clk" > [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined! > make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1 > make: *** [Makefile:1978: modpost] Error 2 > > V2: Order alphabetically > > Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn> The patch looks good to me. But I need an ACK from someone else to apply to drm-misc-next. Cheers, -Paul > --- > drivers/gpu/drm/ingenic/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/ingenic/Kconfig > b/drivers/gpu/drm/ingenic/Kconfig > index a53f475d33df..b440e0cdc057 100644 > --- a/drivers/gpu/drm/ingenic/Kconfig > +++ b/drivers/gpu/drm/ingenic/Kconfig > @@ -9,6 +9,8 @@ config DRM_INGENIC > select DRM_PANEL_BRIDGE > select DRM_KMS_HELPER > select DRM_GEM_DMA_HELPER > + select REGMAP > + select REGMAP_MMIO > select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE > help > Choose this option for DRM support for the Ingenic SoCs.
Hi Paul, On Sat, Jun 17, 2023 at 09:13:37PM +0200, Paul Cercueil wrote: > Hi, > > Le mercredi 07 juin 2023 à 19:06 +0800, Sui Jingfeng a écrit : > > Otherwise its failed to pass basic compile test on platform without > > REGMAP_MMIO selected by defconfig > > > > make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64- > > > > SYNC include/config/auto.conf.cmd > > Checking missing-syscalls for N32 > > CALL scripts/checksyscalls.sh > > Checking missing-syscalls for O32 > > CALL scripts/checksyscalls.sh > > CALL scripts/checksyscalls.sh > > MODPOST Module.symvers > > ERROR: modpost: "__devm_regmap_init_mmio_clk" > > [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined! > > make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error 1 > > make: *** [Makefile:1978: modpost] Error 2 > > > > V2: Order alphabetically > > > > Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn> > > The patch looks good to me. But I need an ACK from someone else to > apply to drm-misc-next. Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
Hi, Le samedi 17 juin 2023 à 21:48 +0200, Sam Ravnborg a écrit : > Hi Paul, > On Sat, Jun 17, 2023 at 09:13:37PM +0200, Paul Cercueil wrote: > > Hi, > > > > Le mercredi 07 juin 2023 à 19:06 +0800, Sui Jingfeng a écrit : > > > Otherwise its failed to pass basic compile test on platform > > > without > > > REGMAP_MMIO selected by defconfig > > > > > > make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64- > > > > > > SYNC include/config/auto.conf.cmd > > > Checking missing-syscalls for N32 > > > CALL scripts/checksyscalls.sh > > > Checking missing-syscalls for O32 > > > CALL scripts/checksyscalls.sh > > > CALL scripts/checksyscalls.sh > > > MODPOST Module.symvers > > > ERROR: modpost: "__devm_regmap_init_mmio_clk" > > > [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined! > > > make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error > > > 1 > > > make: *** [Makefile:1978: modpost] Error 2 > > > > > > V2: Order alphabetically > > > > > > Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn> > > > > The patch looks good to me. But I need an ACK from someone else to > > apply to drm-misc-next. > Reviewed-by: Sam Ravnborg <sam@ravnborg.org> Thanks Sam! Applied to drm-misc-next. Cheers, -Paul
Hi, On 2023/6/18 04:41, Paul Cercueil wrote: > Hi, > > Le samedi 17 juin 2023 à 21:48 +0200, Sam Ravnborg a écrit : >> Hi Paul, >> On Sat, Jun 17, 2023 at 09:13:37PM +0200, Paul Cercueil wrote: >>> Hi, >>> >>> Le mercredi 07 juin 2023 à 19:06 +0800, Sui Jingfeng a écrit : >>>> Otherwise its failed to pass basic compile test on platform >>>> without >>>> REGMAP_MMIO selected by defconfig >>>> >>>> make -j$(nproc) ARCH=mips CROSS_COMPILE=mips64el-linux-gnuabi64- >>>> >>>> SYNC include/config/auto.conf.cmd >>>> Checking missing-syscalls for N32 >>>> CALL scripts/checksyscalls.sh >>>> Checking missing-syscalls for O32 >>>> CALL scripts/checksyscalls.sh >>>> CALL scripts/checksyscalls.sh >>>> MODPOST Module.symvers >>>> ERROR: modpost: "__devm_regmap_init_mmio_clk" >>>> [drivers/gpu/drm/ingenic/ingenic-drm.ko] undefined! >>>> make[1]: *** [scripts/Makefile.modpost:136: Module.symvers] Error >>>> 1 >>>> make: *** [Makefile:1978: modpost] Error 2 >>>> >>>> V2: Order alphabetically >>>> >>>> Signed-off-by: Sui Jingfeng <suijingfeng@loongson.cn> >>> The patch looks good to me. But I need an ACK from someone else to >>> apply to drm-misc-next. >> Reviewed-by: Sam Ravnborg <sam@ravnborg.org> > Thanks Sam! Sam and Paul, thanks a lot, :-) > Applied to drm-misc-next. > > Cheers, > -Paul
diff --git a/drivers/gpu/drm/ingenic/Kconfig b/drivers/gpu/drm/ingenic/Kconfig index a53f475d33df..b440e0cdc057 100644 --- a/drivers/gpu/drm/ingenic/Kconfig +++ b/drivers/gpu/drm/ingenic/Kconfig @@ -9,6 +9,8 @@ config DRM_INGENIC select DRM_PANEL_BRIDGE select DRM_KMS_HELPER select DRM_GEM_DMA_HELPER + select REGMAP + select REGMAP_MMIO select VT_HW_CONSOLE_BINDING if FRAMEBUFFER_CONSOLE help Choose this option for DRM support for the Ingenic SoCs.