[RESEND,1/3] dt-bindings: remoteproc: qcom,pas: correct memory-region constraints
Commit Message
Qualcomm PAS devices expect exactly one memory region, not many. Also,
the memory-region is now defined in device specific binding, not in
qcom,pas-common.yaml, thus also require it in the same place.
Fixes: cee616c68846 ("dt-bindings: remoteproc: qcom: adsp: move memory-region and firmware-name out of pas-common")
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Reviewed-by: Rob Herring <robh@kernel.org>
---
Following dtbs_check errors are expected (not related):
- qcom,halt-regs:0: [142] is too short
- clocks: [[24, 222], [24, 223], [24, 157], [16], [24, 229], [24, 224], [24, 225], [27, 2], [27, 8]] is too short
- 'px-supply' is a required property
---
Documentation/devicetree/bindings/remoteproc/qcom,adsp.yaml | 1 +
.../devicetree/bindings/remoteproc/qcom,pas-common.yaml | 1 -
.../devicetree/bindings/remoteproc/qcom,qcs404-pas.yaml | 3 ++-
.../devicetree/bindings/remoteproc/qcom,sc7180-pas.yaml | 3 ++-
.../devicetree/bindings/remoteproc/qcom,sc8180x-pas.yaml | 3 ++-
.../devicetree/bindings/remoteproc/qcom,sc8280xp-pas.yaml | 3 ++-
.../devicetree/bindings/remoteproc/qcom,sdx55-pas.yaml | 3 ++-
.../devicetree/bindings/remoteproc/qcom,sm6350-pas.yaml | 3 ++-
.../devicetree/bindings/remoteproc/qcom,sm8150-pas.yaml | 3 ++-
.../devicetree/bindings/remoteproc/qcom,sm8350-pas.yaml | 3 ++-
10 files changed, 17 insertions(+), 9 deletions(-)
Comments
On 31/03/2023 11:21, Krzysztof Kozlowski wrote:
> Qualcomm PAS devices expect exactly one memory region, not many. Also,
> the memory-region is now defined in device specific binding, not in
> qcom,pas-common.yaml, thus also require it in the same place.
>
> Fixes: cee616c68846 ("dt-bindings: remoteproc: qcom: adsp: move memory-region and firmware-name out of pas-common")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
> ---
I sent it in March. Then on 31st of March I resent it. Almost three
months ago.
Shall I resend it one more time? Any comments? Applying?
Best regards,
Krzysztof
On Fri, 31 Mar 2023 11:21:23 +0200, Krzysztof Kozlowski wrote:
> Qualcomm PAS devices expect exactly one memory region, not many. Also,
> the memory-region is now defined in device specific binding, not in
> qcom,pas-common.yaml, thus also require it in the same place.
>
>
Applied, thanks!
[1/3] dt-bindings: remoteproc: qcom,pas: correct memory-region constraints
commit: 1e5c6933483b7cf8eab9e2b1c8a12af1451df4fa
[2/3] dt-bindings: remoteproc: qcom,sm6115-pas: correct memory-region constraints
commit: 66530ffe964ce35da6e8d3787c5620b4fba5a9f9
[3/3] dt-bindings: remoteproc: qcom,sm8550-pas: require memory-region
commit: ed8503220bdd86840eadc5795ae4583c62dd9739
Best regards,
@@ -46,6 +46,7 @@ properties:
required:
- compatible
+ - memory-region
unevaluatedProperties: false
@@ -82,7 +82,6 @@ required:
- clock-names
- interrupts
- interrupt-names
- - memory-region
- qcom,smem-states
- qcom,smem-state-names
@@ -42,7 +42,7 @@ properties:
smd-edge: false
memory-region:
- minItems: 1
+ maxItems: 1
description: Reference to the reserved-memory for the Hexagon core
firmware-name:
@@ -52,6 +52,7 @@ properties:
required:
- compatible
- reg
+ - memory-region
allOf:
- $ref: /schemas/remoteproc/qcom,pas-common.yaml#
@@ -51,7 +51,7 @@ properties:
- const: mss
memory-region:
- minItems: 1
+ maxItems: 1
description: Reference to the reserved-memory for the Hexagon core
qcom,qmp:
@@ -67,6 +67,7 @@ properties:
required:
- compatible
- reg
+ - memory-region
allOf:
- $ref: /schemas/remoteproc/qcom,pas-common.yaml#
@@ -38,7 +38,7 @@ properties:
smd-edge: false
memory-region:
- minItems: 1
+ maxItems: 1
description: Reference to the reserved-memory for the Hexagon core
firmware-name:
@@ -48,6 +48,7 @@ properties:
required:
- compatible
- reg
+ - memory-region
allOf:
- $ref: /schemas/remoteproc/qcom,pas-common.yaml#
@@ -38,7 +38,7 @@ properties:
smd-edge: false
memory-region:
- minItems: 1
+ maxItems: 1
description: Reference to the reserved-memory for the Hexagon core
firmware-name:
@@ -48,6 +48,7 @@ properties:
required:
- compatible
- reg
+ - memory-region
allOf:
- $ref: /schemas/remoteproc/qcom,pas-common.yaml#
@@ -46,7 +46,7 @@ properties:
- const: mss
memory-region:
- minItems: 1
+ maxItems: 1
description: Reference to the reserved-memory for the Hexagon core
qcom,qmp:
@@ -62,6 +62,7 @@ properties:
required:
- compatible
- reg
+ - memory-region
allOf:
- $ref: /schemas/remoteproc/qcom,pas-common.yaml#
@@ -36,7 +36,7 @@ properties:
description: Reference to the AOSS side-channel message RAM.
memory-region:
- minItems: 1
+ maxItems: 1
description: Reference to the reserved-memory for the Hexagon core
smd-edge: false
@@ -48,6 +48,7 @@ properties:
required:
- compatible
- reg
+ - memory-region
allOf:
- $ref: /schemas/remoteproc/qcom,pas-common.yaml#
@@ -40,7 +40,7 @@ properties:
description: Reference to the AOSS side-channel message RAM.
memory-region:
- minItems: 1
+ maxItems: 1
description: Reference to the reserved-memory for the Hexagon core
smd-edge: false
@@ -52,6 +52,7 @@ properties:
required:
- compatible
- reg
+ - memory-region
allOf:
- $ref: /schemas/remoteproc/qcom,pas-common.yaml#
@@ -43,7 +43,7 @@ properties:
smd-edge: false
memory-region:
- minItems: 1
+ maxItems: 1
description: Reference to the reserved-memory for the Hexagon core
firmware-name:
@@ -53,6 +53,7 @@ properties:
required:
- compatible
- reg
+ - memory-region
allOf:
- $ref: /schemas/remoteproc/qcom,pas-common.yaml#