Message ID | 20230616103127.285608-1-krzysztof.kozlowski@linaro.org |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1256434vqr; Fri, 16 Jun 2023 04:06:40 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7rpN3GVwc2xjqfjNja4qYkheMTJMfqtFM6yK5IhOUklGI7uokTOnOCmVNmUVJc/wjXvvp3 X-Received: by 2002:a05:6a20:2d25:b0:10c:5745:3f44 with SMTP id g37-20020a056a202d2500b0010c57453f44mr1654523pzl.61.1686913600051; Fri, 16 Jun 2023 04:06:40 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686913600; cv=none; d=google.com; s=arc-20160816; b=qtFgoYLv+S3W4jeaPPBjFnavrIzUOwZ85tX1HcEwkXpH2rmybOGzfiZcZb9UiNg6Yx zN1/5ZIWn+KoGjbP44m8+w1xThf/zJeY0Fx/urSW2YvuSRhzlKkxIWvKnrA0lbLcv+9F GPmjA0FhskgDJFzQMznqPIqKKT0KPf/iu1MbY0Y+0c+sYdhjU5cGPG0bob42HxNYpHii OtE/SG72UaNkaufK7v5kXmJUh+KnRiqSCKqyqe1xDiRGL3lHj09UZzehQaS1ro+R2Dyc 6LRZRW0ZtXRy/cB7jGK8CAEQMQaRO1MASMXdBNLFU+jGMgLA2ha7JK7uVURqg55X6lG1 OvOA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=l7UUUCEiDOQDFLQBmgYOU/VRB87rfpeTkrh78SXewlQ=; b=nwVtIU7XjxaxvI9fQQQREAsauXmoR2uxCoRpqRGqvUtbdI2Ttj8K/UByN1lx38sSiC JsHarOw3rySHqQSLUGFdv6C2DixlK5sluANKbZl+c/rGVUF+j8Ew0hqU6rNchY1VFXiM BZZ36GB6WVIfm9S501FCBRBKjfVRWqWIFMjH7i7+LhCJ5dlf8wTXNLQEySb4EAS0Fqui AqEMUa54c0+tj/mTQgM8y+0LsIbvM0+VnHIhgBYRrNF8QAHCuBT++3GB89pCapl6ahj9 +cLD7gYrZ9t0j8LWQCA3JgnPg3mdjWx/L2Kg2iBcsg/48HD9um43iRUDK4lBJNIpH9Dl /4Jw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="d/HoqkPN"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id n14-20020a170902e54e00b001a51c26f601si15281980plf.627.2023.06.16.04.06.24; Fri, 16 Jun 2023 04:06:40 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b="d/HoqkPN"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344942AbjFPKve (ORCPT <rfc822;maxin.john@gmail.com> + 99 others); Fri, 16 Jun 2023 06:51:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344895AbjFPKvS (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Fri, 16 Jun 2023 06:51:18 -0400 Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7BE9A5B86 for <linux-kernel@vger.kernel.org>; Fri, 16 Jun 2023 03:43:14 -0700 (PDT) Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-31122c346f4so270166f8f.3 for <linux-kernel@vger.kernel.org>; Fri, 16 Jun 2023 03:43:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686912174; x=1689504174; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=l7UUUCEiDOQDFLQBmgYOU/VRB87rfpeTkrh78SXewlQ=; b=d/HoqkPNJhmfrZK92gGm3XCSxr3gRxMKmYS1pBA3mH4DonHRJxzkoCjrNHzbFM3Xkh 4r+gd1AQ4E4rtecdZB56qSPEKlSoUAAbD4Zpv0SAQM7DLOp/AuulZmQJjWW3mFqBIL+M 8AD0YD/y4kzGuuT2UG6nWYMn3CFlHQKkW/nw/qMoritzMdZK9LxLM3ON7OSP5s0sCtTJ QOYWzIfYFk3xavNfKs5z3NoWeep1RoeML6N6+PLwGZjg1X9yFBv22Y2LeBeegHvYpMT8 ltQv1plpsh5ZqungEDhdA1vRxgdPQWGAtUv+ZlprMp1jIHGRVMbiG06t4Y6MEQuwbLU6 JIEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686912174; x=1689504174; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=l7UUUCEiDOQDFLQBmgYOU/VRB87rfpeTkrh78SXewlQ=; b=bHOMWgLESvvkM4JjbGmlkFMXu6bpLaKBuNHyISXVlxD3uQ64scFOq5wpcJ/sctCIZC VuzYwYVIWUDS6Oq5qFf7mpr/Ib9a3MI8xcNer0CEs81U2A0HKtSkrr2pMjf8EOSBJdwz xGCE5bGENH1Ns5C8A5p4EqLqhL9JhAUo5bMzO+vTvIpaO6tvBdpDxqufPCQQF2rVExiB Zff/7nlulXZtdKRfakGanqNl/R78E3EbcKgijrBf9Pievvt57HED+BTddCTlg8VaJ6bF ylQPo7inlN33UVmq2VbdJ/GovzlhgWCf0MMtnL7ReAprakgOouVY1zQj1TLldEWo4oOl d22w== X-Gm-Message-State: AC+VfDxby7TLv2Lehn0nKeOyoRQQzNQWnOB/PTtOvCC7aBYTwodbSIc7 shQWhmPta5xJNm8PiVktApbl+FfqyTiwMwzFh8M= X-Received: by 2002:a17:906:da8a:b0:96f:e45f:92e9 with SMTP id xh10-20020a170906da8a00b0096fe45f92e9mr1493906ejb.16.1686911495167; Fri, 16 Jun 2023 03:31:35 -0700 (PDT) Received: from krzk-bin.. ([178.197.219.26]) by smtp.gmail.com with ESMTPSA id s20-20020a170906961400b009829d2e892csm2251098ejx.15.2023.06.16.03.31.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 16 Jun 2023 03:31:34 -0700 (PDT) From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> To: Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, Thomas Bogendoerfer <tsbogend@alpha.franken.de>, Giuseppe Cavallaro <peppe.cavallaro@st.com>, Alexandre Torgue <alexandre.torgue@foss.st.com>, Jose Abreu <joabreu@synopsys.com>, "David S. Miller" <davem@davemloft.net>, Eric Dumazet <edumazet@google.com>, Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>, Maxime Coquelin <mcoquelin.stm32@gmail.com>, devicetree@vger.kernel.org, linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Cc: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Subject: [RFT PATCH 1/2] stmmac: dwmac-loongson: drop useless check for compatible fallback Date: Fri, 16 Jun 2023 12:31:26 +0200 Message-Id: <20230616103127.285608-1-krzysztof.kozlowski@linaro.org> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768857115045811352?= X-GMAIL-MSGID: =?utf-8?q?1768857115045811352?= |
Series |
[RFT,1/2] stmmac: dwmac-loongson: drop useless check for compatible fallback
|
|
Commit Message
Krzysztof Kozlowski
June 16, 2023, 10:31 a.m. UTC
Device binds to proper PCI ID (LOONGSON, 0x7a03), already listed in DTS,
so checking for some other compatible does not make sense. It cannot be
bound to unsupported platform.
Drop useless, incorrect (space in between) and undocumented compatible.
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c | 5 -----
1 file changed, 5 deletions(-)
Comments
On Fri, Jun 16, 2023 at 12:31:26PM +0200, Krzysztof Kozlowski wrote: > Device binds to proper PCI ID (LOONGSON, 0x7a03), already listed in DTS, > so checking for some other compatible does not make sense. It cannot be > bound to unsupported platform. > > Drop useless, incorrect (space in between) and undocumented compatible. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Might be worth noting that dropping it is required to allow the new loongarch dts stuff to be functional with a sane set of compatibles. Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor.
在 2023/6/17 02:52, Conor Dooley 写道: > On Fri, Jun 16, 2023 at 12:31:26PM +0200, Krzysztof Kozlowski wrote: >> Device binds to proper PCI ID (LOONGSON, 0x7a03), already listed in DTS, >> so checking for some other compatible does not make sense. It cannot be >> bound to unsupported platform. >> >> Drop useless, incorrect (space in between) and undocumented compatible. >> >> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Might be worth noting that dropping it is required to allow the > new loongarch dts stuff to be functional with a sane set of compatibles. > > Reviewed-by: Conor Dooley <conor.dooley@microchip.com> Thank you Krzysztof for your work. when I am adding more devices support to stmmac, I found that your two patches seemed to be forgotten. Thomas, Jiaxun. Can the two patches get an Acked-by? My stmmac patch thread: <https://lore.kernel.org/loongarch/cover.1699533745.git .siyanteng@loongson.cn/T/#md3108d29a5efe71b27f4c5ccf5d0217571bf6586> Thanks, Yanteng > > Cheers, > Conor.
在2023年12月10日十二月 上午6:48,Yanteng Si写道: > 在 2023/6/17 02:52, Conor Dooley 写道: >> On Fri, Jun 16, 2023 at 12:31:26PM +0200, Krzysztof Kozlowski wrote: >>> Device binds to proper PCI ID (LOONGSON, 0x7a03), already listed in DTS, >>> so checking for some other compatible does not make sense. It cannot be >>> bound to unsupported platform. >>> >>> Drop useless, incorrect (space in between) and undocumented compatible. >>> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >> Might be worth noting that dropping it is required to allow the >> new loongarch dts stuff to be functional with a sane set of compatibles. >> >> Reviewed-by: Conor Dooley <conor.dooley@microchip.com> > Thank you Krzysztof for your work. when I am > adding more devices support to stmmac, I found that your > two patches seemed to be forgotten. > Thomas, Jiaxun. Can the two patches get an Acked-by? > My stmmac patch thread: > <https://lore.kernel.org/loongarch/cover.1699533745.git > .siyanteng@loongson.cn/T/#md3108d29a5efe71b27f4c5ccf5d0217571bf6586> Acked-by: Jiaxun Yang <jiaxun.yang@flygoat.com> Better to resend without RFC :-) Thanks > Thanks, > Yanteng > >> >> Cheers, >> Conor.
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c index a25c187d3185..900972521b59 100644 --- a/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c +++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-loongson.c @@ -59,11 +59,6 @@ static int loongson_dwmac_probe(struct pci_dev *pdev, const struct pci_device_id return -ENODEV; } - if (!of_device_is_compatible(np, "loongson, pci-gmac")) { - pr_info("dwmac_loongson_pci: Incompatible OF node\n"); - return -ENODEV; - } - plat = devm_kzalloc(&pdev->dev, sizeof(*plat), GFP_KERNEL); if (!plat) return -ENOMEM;