| Message ID | 20230616135922.442979-12-tomi.valkeinen@ideasonboard.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp1365390vqr;
Fri, 16 Jun 2023 07:03:13 -0700 (PDT)
X-Google-Smtp-Source:
ACHHUZ7XMVwI/sMbCi1lCdyHr8cREmY1Evjwe36/IEUvyXbcJ4GIixQXdzBFdx/fRQHJ8bXvz1ma
X-Received: by 2002:a05:6a00:1343:b0:663:5fbe:c695 with SMTP id
k3-20020a056a00134300b006635fbec695mr3027668pfu.16.1686924192896;
Fri, 16 Jun 2023 07:03:12 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1686924192; cv=none;
d=google.com; s=arc-20160816;
b=WWLFn9VYDqka+bDsBbl1FUxcW1SrsWnkVxTSHd2CyIKJrlkjGNsjvxawGH3X54a30O
rqi9yzD7+TWdymonKmWFAzc8U8fEqMCCZT5pbhuK8q1NI5oQzlMK1stlH5er+7Lw1KWI
b11k41MslslGLl0tHfRAOx1ueqKwcZ0BWyGUmBpkgxQE1YKc3JkNMnWiVlH+RirgV7n5
sy+8VFcTDZVHKTY/S+02YaUFboEpJZqn9rFPxXjCcM5J239Ho3hclya7I1FId7L8NOdR
9S52JaLXfpKX80kqxyD9dA15il11p1R3i6TGubb6rhP1fXQ0E6A766X+r0a+QD9p+VPO
3AgA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=xVx9L4nR6lYQiU7Dz3hFSGMN1SNmXlvb3lSMWFzps7w=;
b=tVAmy9r4cVi+lWRj6ms3XO6Sc7JQ1vU21CXRkN1Hk+qeqRaR48rogUGp0X76dRx+Il
TztaO40zprnDg1IA2qCU54bfNwT0qmPSeiHTe9d5UUt8kUbR6KCNqbY3myg5a96UiFEG
Br9Id3V2YJvdaENEVC/IJE4lPNk5tKLVAOkwiscMm4/tADJ69YyNy/2KOEOdv2WGDTjS
BU+yr/RP++C/fqKivfluJ+EwqUQ2xLd59toQTnhInZO3qrrK1yHgbS88D0iNSY3LPlaf
oeyo2QKxvK0uvrWSltQvffbpedEv9o+XIZ9S735hRwuMG5w32Punhm6YTtEAJsMgmUQa
tGhg==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail
header.b=clM1AQAk;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
h6-20020a056a00000600b006430bec8238si10568906pfk.328.2023.06.16.07.02.57;
Fri, 16 Jun 2023 07:03:12 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass (test mode) header.i=@ideasonboard.com header.s=mail
header.b=clM1AQAk;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S1345594AbjFPOBM (ORCPT <rfc822;maxin.john@gmail.com>
+ 99 others); Fri, 16 Jun 2023 10:01:12 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51580 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S1345492AbjFPOAd (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Fri, 16 Jun 2023 10:00:33 -0400
Received: from perceval.ideasonboard.com (perceval.ideasonboard.com
[213.167.242.64])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BF7935A7;
Fri, 16 Jun 2023 07:00:29 -0700 (PDT)
Received: from desky.lan (91-154-35-171.elisa-laajakaista.fi [91.154.35.171])
by perceval.ideasonboard.com (Postfix) with ESMTPSA id DBB9DD51;
Fri, 16 Jun 2023 15:59:53 +0200 (CEST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;
s=mail; t=1686923995;
bh=XiVizTb0No6StkMtc0kGR0VnW/U20T7mUSmQ2HYOVRo=;
h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
b=clM1AQAk2PShriGlbT7FGLzCdjHxZdspc9QqMm/GQM9miFju/8veTuUS9Y4bm1X+M
UWc6cjBg0JvilA43K/VP1pThtL4vmqlZ8aA2OGWyXRa2Iss1zy2xFnLV6Ca3Sqe7N8
36zlxM0Anw5CEgBGREEwh3m49vG9jZDDn58YJd6Q=
From: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
To: linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
Luca Ceresoli <luca.ceresoli@bootlin.com>,
Andy Shevchenko <andriy.shevchenko@intel.com>,
Matti Vaittinen <Matti.Vaittinen@fi.rohmeurope.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: Wolfram Sang <wsa@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>, Peter Rosin <peda@axentia.se>,
Liam Girdwood <lgirdwood@gmail.com>, Mark Brown <broonie@kernel.org>,
Michael Tretter <m.tretter@pengutronix.de>,
Hans Verkuil <hverkuil@xs4all.nl>, Mike Pagano <mpagano@gentoo.org>,
=?utf-8?q?Krzysztof_Ha=C5=82asa?= <khalasa@piap.pl>,
Marek Vasut <marex@denx.de>,
Satish Nagireddy <satish.nagireddy@getcruise.com>,
Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Subject: [PATCH v14 11/18] media: i2c: ds90ub9xx: Select GPIOLIB rather than
OF_GPIO
Date: Fri, 16 Jun 2023 16:59:15 +0300
Message-Id: <20230616135922.442979-12-tomi.valkeinen@ideasonboard.com>
X-Mailer: git-send-email 2.34.1
In-Reply-To: <20230616135922.442979-1-tomi.valkeinen@ideasonboard.com>
References: <20230616135922.442979-1-tomi.valkeinen@ideasonboard.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS,
T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no
version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1768868222364702594?=
X-GMAIL-MSGID: =?utf-8?q?1768868222364702594?=
|
| Series |
i2c-atr and FPDLink
|
|
Commit Message
Tomi Valkeinen
June 16, 2023, 1:59 p.m. UTC
Select GPIOLIB rather than OF_GPIO, as the drivers use gpiolib
functionality, but no of_gpio (directly).
Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
---
drivers/media/i2c/Kconfig | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
Comments
On Fri, Jun 16, 2023 at 04:59:15PM +0300, Tomi Valkeinen wrote: > Select GPIOLIB rather than OF_GPIO, as the drivers use gpiolib > functionality, but no of_gpio (directly). This is useful change, but has to be folded in the original code. We do not want even a trace of newly added OF_GPIO. Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> > --- > drivers/media/i2c/Kconfig | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig > index 8a5f09a3de6c..29fc00e30d8b 100644 > --- a/drivers/media/i2c/Kconfig > +++ b/drivers/media/i2c/Kconfig > @@ -1622,7 +1622,7 @@ config VIDEO_DS90UB913 > depends on OF && I2C && VIDEO_DEV && COMMON_CLK > select I2C_ATR > select MEDIA_CONTROLLER > - select OF_GPIO > + select GPIOLIB > select REGMAP_I2C > select V4L2_FWNODE > select VIDEO_V4L2_SUBDEV_API > @@ -1635,7 +1635,7 @@ config VIDEO_DS90UB953 > depends on OF && I2C && VIDEO_DEV && COMMON_CLK > select I2C_ATR > select MEDIA_CONTROLLER > - select OF_GPIO > + select GPIOLIB > select REGMAP_I2C > select V4L2_FWNODE > select VIDEO_V4L2_SUBDEV_API > @@ -1648,7 +1648,7 @@ config VIDEO_DS90UB960 > depends on OF && I2C && VIDEO_DEV && COMMON_CLK > select I2C_ATR > select MEDIA_CONTROLLER > - select OF_GPIO > + select GPIOLIB > select REGMAP_I2C > select V4L2_FWNODE > select VIDEO_V4L2_SUBDEV_API > -- > 2.34.1 >
On 16/06/2023 17:17, Andy Shevchenko wrote: > On Fri, Jun 16, 2023 at 04:59:15PM +0300, Tomi Valkeinen wrote: >> Select GPIOLIB rather than OF_GPIO, as the drivers use gpiolib >> functionality, but no of_gpio (directly). > > This is useful change, but has to be folded in the original code. > We do not want even a trace of newly added OF_GPIO. Yes, I think the first three new patches should be squashed: media: i2c: ds90ub960: Fix use of UB960_SR_FWD_CTL1 media: i2c: ds90ub9xx: Add COMMON_CLK kconfig dependency media: i2c: ds90ub9xx: Select GPIOLIB rather than OF_GPIO The rest... Thinking about it now, I should have perhaps left them out, as they're not fixing issues, and perhaps they just confuse the merging process. Tomi > Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > >> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com> >> --- >> drivers/media/i2c/Kconfig | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig >> index 8a5f09a3de6c..29fc00e30d8b 100644 >> --- a/drivers/media/i2c/Kconfig >> +++ b/drivers/media/i2c/Kconfig >> @@ -1622,7 +1622,7 @@ config VIDEO_DS90UB913 >> depends on OF && I2C && VIDEO_DEV && COMMON_CLK >> select I2C_ATR >> select MEDIA_CONTROLLER >> - select OF_GPIO >> + select GPIOLIB >> select REGMAP_I2C >> select V4L2_FWNODE >> select VIDEO_V4L2_SUBDEV_API >> @@ -1635,7 +1635,7 @@ config VIDEO_DS90UB953 >> depends on OF && I2C && VIDEO_DEV && COMMON_CLK >> select I2C_ATR >> select MEDIA_CONTROLLER >> - select OF_GPIO >> + select GPIOLIB >> select REGMAP_I2C >> select V4L2_FWNODE >> select VIDEO_V4L2_SUBDEV_API >> @@ -1648,7 +1648,7 @@ config VIDEO_DS90UB960 >> depends on OF && I2C && VIDEO_DEV && COMMON_CLK >> select I2C_ATR >> select MEDIA_CONTROLLER >> - select OF_GPIO >> + select GPIOLIB >> select REGMAP_I2C >> select V4L2_FWNODE >> select VIDEO_V4L2_SUBDEV_API >> -- >> 2.34.1 >> >
diff --git a/drivers/media/i2c/Kconfig b/drivers/media/i2c/Kconfig index 8a5f09a3de6c..29fc00e30d8b 100644 --- a/drivers/media/i2c/Kconfig +++ b/drivers/media/i2c/Kconfig @@ -1622,7 +1622,7 @@ config VIDEO_DS90UB913 depends on OF && I2C && VIDEO_DEV && COMMON_CLK select I2C_ATR select MEDIA_CONTROLLER - select OF_GPIO + select GPIOLIB select REGMAP_I2C select V4L2_FWNODE select VIDEO_V4L2_SUBDEV_API @@ -1635,7 +1635,7 @@ config VIDEO_DS90UB953 depends on OF && I2C && VIDEO_DEV && COMMON_CLK select I2C_ATR select MEDIA_CONTROLLER - select OF_GPIO + select GPIOLIB select REGMAP_I2C select V4L2_FWNODE select VIDEO_V4L2_SUBDEV_API @@ -1648,7 +1648,7 @@ config VIDEO_DS90UB960 depends on OF && I2C && VIDEO_DEV && COMMON_CLK select I2C_ATR select MEDIA_CONTROLLER - select OF_GPIO + select GPIOLIB select REGMAP_I2C select V4L2_FWNODE select VIDEO_V4L2_SUBDEV_API