| Message ID | 20221027115745.240516-1-ulf.hansson@linaro.org |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a5d:6687:0:0:0:0:0 with SMTP id l7csp184265wru;
Thu, 27 Oct 2022 04:58:28 -0700 (PDT)
X-Google-Smtp-Source:
AMsMyM6p0iD0Zr0sBBWS1g+IGC8TMXS1iukbkyEE/WMdlwY6DR1bsOAiLwOUgSzMEUUMPuAuem+5
X-Received: by 2002:a63:91c7:0:b0:460:924:a34e with SMTP id
l190-20020a6391c7000000b004600924a34emr41369284pge.492.1666871908231;
Thu, 27 Oct 2022 04:58:28 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1666871908; cv=none;
d=google.com; s=arc-20160816;
b=h0ddUFmiqsHxfsqPPRxaoHyRD5NI+ecZZ5wiRaGiLVpJcN4nil3pXK7pfeUdrWdkeY
IuACVXMswbqavQhw67/CuWSVzXM3l01cC56utw3qmBVOgctbWQbqn2rV5SYjMYxDwskK
vFMIPR/VP21kwY6bOQPd6sRkgHwmfiGCTB/rEcG3F2fzqgiU4vxcTsRE6bAQIooeLtvx
CSmNmuw+ojTW8jcn443srHW14q9AH3nE/g8AW2OduoILZ60x/8e5adv1/ZyrpSO63ltm
3HoCpFRS71cCJi7cbhIL2SnrwZLenrtr7d929IcqsYuwvbK3kjKAqq170FI+ENsivPEg
XBbA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:message-id:date:subject:cc:to:from:dkim-signature;
bh=+haLpTJY+Yq4kbp0eK3uqAJ8H9p8YmI5+8lTBRSO0DU=;
b=h4jNEg3uv6+P6DaezeOw9+Bg+O4TLHQnfX+7wmphGXl0Il3CQPv48SDiwEloD1GOGO
277ZvFJBB670br3PdpPECha6DmjIE4DC/LyhAar/ij9mThbLvgdCYs2VOPI6g8sVW3bB
OZ9Thhebr4iHhpAoG0EIiHZZdnKQA8QCwmpkCXh552jIPuk1mx40HaVhZH6jGzmTnNaW
DjF1q+hkkG+P7wadV7oB3ChHLozECX2Q0lSTfWab/u0Pwluy0CjUbl4CMPmt4vgqyz0m
gpNmQbxxijDftWizwWxfcDhb7GAkjP5sUXt681MD11ilLUsFr+rB9rHN9kBjX94zMsUu
cxzw==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=bijkMGDp;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
e14-20020a63f54e000000b0046ebe02836fsi1278133pgk.504.2022.10.27.04.58.15;
Thu, 27 Oct 2022 04:58:28 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@linaro.org header.s=google header.b=bijkMGDp;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S235430AbiJ0L5z (ORCPT <rfc822;chrisfriedt@gmail.com>
+ 99 others); Thu, 27 Oct 2022 07:57:55 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34172 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S235407AbiJ0L5w (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Thu, 27 Oct 2022 07:57:52 -0400
Received: from mail-lj1-x22a.google.com (mail-lj1-x22a.google.com
[IPv6:2a00:1450:4864:20::22a])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 610F360EAE
for <linux-kernel@vger.kernel.org>;
Thu, 27 Oct 2022 04:57:51 -0700 (PDT)
Received: by mail-lj1-x22a.google.com with SMTP id z24so2086887ljn.4
for <linux-kernel@vger.kernel.org>;
Thu, 27 Oct 2022 04:57:51 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=linaro.org; s=google;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:from:to:cc:subject:date:message-id:reply-to;
bh=+haLpTJY+Yq4kbp0eK3uqAJ8H9p8YmI5+8lTBRSO0DU=;
b=bijkMGDpdA8sgHlIOQ7XcM13fnEgWD1TwSsfE8gS2+pLPiPPkIaJpHqo2uUDOHcUDT
SQeBsLBxgJoMoQH/iViYEVJ4JHW/NIOvD5ap6jPuFLzcRC3b2TNvWbxiFbUgW9oIBtp+
fCYQEa7piPcxHHe/z49q5Kz/g1C7LpGXrv2JCZboM/yz0wOKk6r4rz34OxaMqoSGfeTB
xHAyn8+OirvuDeHPlMAViArRlcpuefrGkWajpoPHUkILhWMVtkx7bswh41qrq7lpRyW4
Xxp42e0kTnoDop/zizBZ4bA4mO95z6xPjLixrmaOkCC7zmGbzZK4YAykuqG5WD4pc4dD
cqUg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20210112;
h=content-transfer-encoding:mime-version:message-id:date:subject:cc
:to:from:x-gm-message-state:from:to:cc:subject:date:message-id
:reply-to;
bh=+haLpTJY+Yq4kbp0eK3uqAJ8H9p8YmI5+8lTBRSO0DU=;
b=Z8KwexFthAsltCksLFiOpndgk87WWNwXHKmEriWOBFnGHMhhvdI5ObtJKAdzPktpRp
7YLanmJZWQ5bMNHKHRCQxK93OAnPtbzShM9XbTcc4ym+SjJC3ajIvhOo+FqX4ssrXxCu
p3w+Go/4WKLOVwu4cUoGzCPPU6PQ5BGF6mZKS14TQ5M15JR1EZ/88R0R4ALuOkF/V8BX
tyP0HYz4wbHdNr9Nrq7VEEe+AQQolepxjIwhqFGtVrP9QdElor8xeN0qHH5Cm5t2LVK2
Xp+K19rxlCPf3MVCpBL9ixg73wxAK5JfKaI6h+4eMmhhMXimw4siIP09MS80+mJpB/8E
uGsg==
X-Gm-Message-State: ACrzQf2QYK4hp65SHK0PO/eXiVMwOuaXEXPQp/Jeonvj2QLsjq7cXXvo
7zDKU9d0I2nsNu9VkiPgLNMYkQ==
X-Received: by 2002:a2e:a554:0:b0:26f:ea5d:a075 with SMTP id
e20-20020a2ea554000000b0026fea5da075mr18884164ljn.322.1666871869632;
Thu, 27 Oct 2022 04:57:49 -0700 (PDT)
Received: from uffe-XPS13.. (h-94-254-63-18.NA.cust.bahnhof.se.
[94.254.63.18])
by smtp.gmail.com with ESMTPSA id
z13-20020a056512370d00b0049f53b65790sm156841lfr.228.2022.10.27.04.57.48
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Thu, 27 Oct 2022 04:57:48 -0700 (PDT)
From: Ulf Hansson <ulf.hansson@linaro.org>
To: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@somainline.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>,
Maulik Shah <quic_mkshah@quicinc.com>,
Rajendra Nayak <quic_rjendra@quicinc.com>,
Sudeep Holla <sudeep.holla@arm.com>,
Amit Pundir <amit.pundir@linaro.org>,
Ulf Hansson <ulf.hansson@linaro.org>,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: [PATCH] arm64: dts: qcom: sm8250: Disable the not yet supported
cluster idle state
Date: Thu, 27 Oct 2022 13:57:45 +0200
Message-Id: <20221027115745.240516-1-ulf.hansson@linaro.org>
X-Mailer: git-send-email 2.34.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,
SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1747841878161267865?=
X-GMAIL-MSGID: =?utf-8?q?1747841878161267865?=
|
| Series |
arm64: dts: qcom: sm8250: Disable the not yet supported cluster idle state
|
|
Commit Message
Ulf Hansson
Oct. 27, 2022, 11:57 a.m. UTC
To support the deeper cluster idle state for sm8250 platforms, some
additional synchronization is needed between the rpmh-rsc device and the
CPU cluster PM domain. Until that is supported, let's disable the cluster
idle state.
This fixes a problem that has been reported for the Qcom RB5 platform (see
below), but most likely other sm8250 platforms suffers from similar issues,
so let's make the fix generic for sm8250.
vreg_l11c_3p3: failed to enable: -ETIMEDOUT
qcom-rpmh-regulator 18200000.rsc:pm8150l-rpmh-regulators: ldo11: devm_regulator_register() failed, ret=-110
qcom-rpmh-regulator: probe of 18200000.rsc:pm8150l-rpmh-regulators failed with error -110
Reported-by: Amit Pundir <amit.pundir@linaro.org>
Fixes: 32bc936d7321 ("arm64: dts: qcom: sm8250: Add cpuidle states")
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
This problem was reported by Amit [1] together with an attempt to fix it. It
turned, that we wanted a more generic fix, hence I posted $subject patch.
Also note that, $subject patch is also depending (from functionality point of
view) on a another for genpd [2]. Although, that should soon reach v6.1-rc[n] and
stable kernels.
Bjorn, can you pick this up as a fix for v6.1-rc and tag it for stable kernels?
Kind regards
Ulf Hansson
[1]
https://lore.kernel.org/lkml/20221018145348.4051809-1-amit.pundir@linaro.org/
[2]
https://lore.kernel.org/lkml/CAJZ5v0hJxRiL03XDFpU8FuabsHn5i6JMksJ=dfj8B+Dm=s3LYA@mail.gmail.com/
---
arch/arm64/boot/dts/qcom/sm8250.dtsi | 1 +
1 file changed, 1 insertion(+)
Comments
On Thu, Oct 27, 2022 at 01:57:45PM +0200, Ulf Hansson wrote: > To support the deeper cluster idle state for sm8250 platforms, some > additional synchronization is needed between the rpmh-rsc device and the > CPU cluster PM domain. Until that is supported, let's disable the cluster > idle state. > > This fixes a problem that has been reported for the Qcom RB5 platform (see > below), but most likely other sm8250 platforms suffers from similar issues, > so let's make the fix generic for sm8250. > > vreg_l11c_3p3: failed to enable: -ETIMEDOUT > qcom-rpmh-regulator 18200000.rsc:pm8150l-rpmh-regulators: ldo11: devm_regulator_register() failed, ret=-110 > qcom-rpmh-regulator: probe of 18200000.rsc:pm8150l-rpmh-regulators failed with error -110 > > Reported-by: Amit Pundir <amit.pundir@linaro.org> > Fixes: 32bc936d7321 ("arm64: dts: qcom: sm8250: Add cpuidle states") Thanks for the patience and fixing it this way :). I take it is only the cluster states that has the issue because [1] only disables the CPU level states which was confusing and I had asked the same. Anyways for this, Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
On Thu, 27 Oct 2022 at 17:27, Ulf Hansson <ulf.hansson@linaro.org> wrote: > > To support the deeper cluster idle state for sm8250 platforms, some > additional synchronization is needed between the rpmh-rsc device and the > CPU cluster PM domain. Until that is supported, let's disable the cluster > idle state. > > This fixes a problem that has been reported for the Qcom RB5 platform (see > below), but most likely other sm8250 platforms suffers from similar issues, > so let's make the fix generic for sm8250. > > vreg_l11c_3p3: failed to enable: -ETIMEDOUT > qcom-rpmh-regulator 18200000.rsc:pm8150l-rpmh-regulators: ldo11: devm_regulator_register() failed, ret=-110 > qcom-rpmh-regulator: probe of 18200000.rsc:pm8150l-rpmh-regulators failed with error -110 > > Reported-by: Amit Pundir <amit.pundir@linaro.org> > Fixes: 32bc936d7321 ("arm64: dts: qcom: sm8250: Add cpuidle states") > Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org> > --- > > This problem was reported by Amit [1] together with an attempt to fix it. It > turned, that we wanted a more generic fix, hence I posted $subject patch. Thanks Ulf and Sudeep. This patch along with [2], fixes the above mentioned crash on RB5 running AOSP. Tested-by: Amit Pundir <amit.pundir@linaro.org> Regards, Amit Pundir > > Also note that, $subject patch is also depending (from functionality point of > view) on a another for genpd [2]. Although, that should soon reach v6.1-rc[n] and > stable kernels. > > Bjorn, can you pick this up as a fix for v6.1-rc and tag it for stable kernels? > > Kind regards > Ulf Hansson > > [1] > https://lore.kernel.org/lkml/20221018145348.4051809-1-amit.pundir@linaro.org/ > [2] > https://lore.kernel.org/lkml/CAJZ5v0hJxRiL03XDFpU8FuabsHn5i6JMksJ=dfj8B+Dm=s3LYA@mail.gmail.com/ > > --- > arch/arm64/boot/dts/qcom/sm8250.dtsi | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi > index a5b62cadb129..e276eed1f8e2 100644 > --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi > +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi > @@ -334,6 +334,7 @@ CLUSTER_SLEEP_0: cluster-sleep-0 { > exit-latency-us = <6562>; > min-residency-us = <9987>; > local-timer-stop; > + status = "disabled"; > }; > }; > }; > -- > 2.34.1 >
On Thu, 27 Oct 2022 13:57:45 +0200, Ulf Hansson wrote: > To support the deeper cluster idle state for sm8250 platforms, some > additional synchronization is needed between the rpmh-rsc device and the > CPU cluster PM domain. Until that is supported, let's disable the cluster > idle state. > > This fixes a problem that has been reported for the Qcom RB5 platform (see > below), but most likely other sm8250 platforms suffers from similar issues, > so let's make the fix generic for sm8250. > > [...] Applied, thanks! [1/1] arm64: dts: qcom: sm8250: Disable the not yet supported cluster idle state commit: 5c7fa5de12a31c1425cc87ba2ef27e6ae0a1788c Best regards,
On Mon, 7 Nov 2022 at 08:43, Bjorn Andersson <andersson@kernel.org> wrote: > > On Thu, 27 Oct 2022 13:57:45 +0200, Ulf Hansson wrote: > > To support the deeper cluster idle state for sm8250 platforms, some > > additional synchronization is needed between the rpmh-rsc device and the > > CPU cluster PM domain. Until that is supported, let's disable the cluster > > idle state. > > > > This fixes a problem that has been reported for the Qcom RB5 platform (see > > below), but most likely other sm8250 platforms suffers from similar issues, > > so let's make the fix generic for sm8250. > > > > [...] > > Applied, thanks! > > [1/1] arm64: dts: qcom: sm8250: Disable the not yet supported cluster idle state > commit: 5c7fa5de12a31c1425cc87ba2ef27e6ae0a1788c Hi Bjorn, There seem to be some error while applying the patch "arm64: dts: qcom: sm8250: Disable the not yet supported cluster idle state". This patch is already applied in your arm64-fixes-for-6.1 tree (commit: cadaa773bcf161184fa428180516bae33a7bc667) The new commit: 5c7fa5de12a31c1425cc87ba2ef27e6ae0a1788c, however, disables the Big cpu idle state instead. I'm not sure if that is intentional though. Regards, Amit Pundir > > Best regards, > -- > Bjorn Andersson <andersson@kernel.org>
On Mon, 7 Nov 2022 at 06:55, Amit Pundir <amit.pundir@linaro.org> wrote: > > On Mon, 7 Nov 2022 at 08:43, Bjorn Andersson <andersson@kernel.org> wrote: > > > > On Thu, 27 Oct 2022 13:57:45 +0200, Ulf Hansson wrote: > > > To support the deeper cluster idle state for sm8250 platforms, some > > > additional synchronization is needed between the rpmh-rsc device and the > > > CPU cluster PM domain. Until that is supported, let's disable the cluster > > > idle state. > > > > > > This fixes a problem that has been reported for the Qcom RB5 platform (see > > > below), but most likely other sm8250 platforms suffers from similar issues, > > > so let's make the fix generic for sm8250. > > > > > > [...] > > > > Applied, thanks! > > > > [1/1] arm64: dts: qcom: sm8250: Disable the not yet supported cluster idle state > > commit: 5c7fa5de12a31c1425cc87ba2ef27e6ae0a1788c > > Hi Bjorn, > > There seem to be some error while applying the patch "arm64: dts: > qcom: sm8250: Disable the not yet supported cluster idle state". > This patch is already applied in your arm64-fixes-for-6.1 tree > (commit: cadaa773bcf161184fa428180516bae33a7bc667) > > The new commit: 5c7fa5de12a31c1425cc87ba2ef27e6ae0a1788c, > however, disables the Big cpu idle state instead. I'm not sure if that > is intentional though. It's a mistake. There have been a lot of various patches/discussions around this issue at LKML, not entirely easy to follow. Anyway to make it clear, we shouldn't need to disable the BIG_CPU_SLEEP_0 state, but only the CLUSTER_SLEEP_0. Bjorn, can you please have a look and drop/revert commit 5c7fa5de12a31c1425cc87ba2ef27e6ae0a1788c ? Kind regards Uffe
diff --git a/arch/arm64/boot/dts/qcom/sm8250.dtsi b/arch/arm64/boot/dts/qcom/sm8250.dtsi index a5b62cadb129..e276eed1f8e2 100644 --- a/arch/arm64/boot/dts/qcom/sm8250.dtsi +++ b/arch/arm64/boot/dts/qcom/sm8250.dtsi @@ -334,6 +334,7 @@ CLUSTER_SLEEP_0: cluster-sleep-0 { exit-latency-us = <6562>; min-residency-us = <9987>; local-timer-stop; + status = "disabled"; }; }; };