Message ID | 20230605131306.427682-1-neelchakrabortykernelwork@gmail.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp2702660vqr; Mon, 5 Jun 2023 06:57:03 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ7F8x6FBZrItVGW4sqDaEnTsLaMFedvMkmkx5arFi/UFEIaeuBRJxNYsNYk2iIGbAOxZy5g X-Received: by 2002:a05:6a20:12d6:b0:110:390f:6806 with SMTP id v22-20020a056a2012d600b00110390f6806mr3679430pzg.57.1685973423094; Mon, 05 Jun 2023 06:57:03 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1685973423; cv=none; d=google.com; s=arc-20160816; b=nck3ZNfmn0KsFwbkZGJ+80e77xvZzByU1nPj6orauQNadgD/w5x/Jmyqu2jkDLwRy+ KfofjSTgQu+oHy+fvCbpubhoirjQaTr1u2eBW586g1TaQIJiAbgBi8MkuXXTsPLqTAXO YiwOETimGz2WCwZVyh31nGdnHnO+oznmhp6Kpi2SD/xQ3N8zw7j7H8GREQJEuCQggRL8 05yaZ9edx0YBu3gh6nuMo7CGqDBNXRW9sLp6aeGlq4Z9xcod16LsA8/VJrxN4enoq7M3 s7HezKRLj4nxhFgIbVVcIyQrT/m3R7dK0+cZ4ybX3fG2x3mDFCLgnj51vcPA1wTlsoQ9 8Teg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :message-id:date:subject:cc:to:from:dkim-signature; bh=qRPb6J5NRktKRP7+z02Eos3uAz1yeGFclnQmG0HZ++4=; b=eSuVPoW336+e/z+vZEbotZxizV0AyMAsAvT/dwm1imF3gjnM3M7Kpl29zWCrlaMLNE kZ9oBDUnUr0yHhTa7LV2tis8BTYnhZXQtEGdLgV0E91zBe0PbnacdAzUGx9xH7XUqMRn buiqzYgehsLsBwLacAl9SuGPhxUy06W861dDFC/F6Q8gO3DCuRdqg/Pxm0d4nHRNprd5 xgXY8uKSD8XgQSoeJSZ0aXLzHZCENLHWOcD+nXnGL6NuDb8BfPL4tXxW4mrFjjZHq3u8 V00drHCr0CJggPSCnlnR8acZzg7alw1oFAZk74QxXOU4T65+kQPLW/Arue94GAT779G8 CUDg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=Dj0QqjOK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id x4-20020a636304000000b00542897dcc22si5322812pgb.516.2023.06.05.06.56.50; Mon, 05 Jun 2023 06:57:03 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20221208 header.b=Dj0QqjOK; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233842AbjFENNr (ORCPT <rfc822;pavtiger@gmail.com> + 99 others); Mon, 5 Jun 2023 09:13:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60566 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233953AbjFENNn (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Mon, 5 Jun 2023 09:13:43 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5EE6E197 for <linux-kernel@vger.kernel.org>; Mon, 5 Jun 2023 06:13:37 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1b1806264e9so24381395ad.0 for <linux-kernel@vger.kernel.org>; Mon, 05 Jun 2023 06:13:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685970817; x=1688562817; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=qRPb6J5NRktKRP7+z02Eos3uAz1yeGFclnQmG0HZ++4=; b=Dj0QqjOK7DmyQir8kYZnVV2n7Ftt7Oq7pfIhlAq0C5Rxki0R4ORhm02hwQ/TnzJGut 9gJFU4Ghkwe0wdmIInf0wMqXJ2UrOSM1kRcKwGGtkE9dgTIbfhSrHPIlVFXDZrjFkZJy 8cZ9KS6Oi3nSnQkCFRfxcw2x3zuUZeyhvvWDUGH2uuVFZNz90AKd/Hg2BNe641Pz2Qxh Jj/3jimsAa4fnn5qoxClncvorp1s9UwQi1i0Ny+0NWjAXTqKzWfrf49YKuyTL8zr31up T2jFa1vS4U1mi+wEKtOZYuXKwHJUwtMBImUGglUvk5wTtHHmSYH5FwXrws5t8PdJVyk7 L4Xg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685970817; x=1688562817; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qRPb6J5NRktKRP7+z02Eos3uAz1yeGFclnQmG0HZ++4=; b=fBZfGJhCwiXQruJtH61ZbQZmqRnRaW7UfT4hTkaO+QP9zaedPMc4YgVb0eW7o6iUeT RryTeEyb3IMdm5SxBEWQ3R8Ispw/VD/NiYu+aD/zCeLwVjjx08NsvLsXln+rP6wYvmp1 NgLDJFgc7fdkxYT3lLAIoL/FOeJrk6kuYDL5aH1ZNEj2zIN4K2WEyLiaKqrIAPc0nt0X jEimRpZtSDiZFu8zW0IfwNmOSDuEIEVqchEOKFIaB4jR5ourfxX34BNaZoptb9hQA+uc rnxsN/6lH3VV9s1n/Ovr7uiztTql4FXuKgdAswTp3soOE/W2wX8VFxFJb8A9gasSQIdW Wgxw== X-Gm-Message-State: AC+VfDzY7JateVxBXs4riiK23zB12Qy6tnB45D/mmam9RXcU1y5NbGRo B031OHksHRoQud8eY1rBKYIsm9oRPSaoZASL X-Received: by 2002:a17:902:e5c2:b0:1b1:e863:9e77 with SMTP id u2-20020a170902e5c200b001b1e8639e77mr3265400plf.18.1685970817152; Mon, 05 Jun 2023 06:13:37 -0700 (PDT) Received: from ubuntu.. ([103.165.115.136]) by smtp.gmail.com with ESMTPSA id jh1-20020a170903328100b001a6cd1e4205sm6537642plb.279.2023.06.05.06.13.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 05 Jun 2023 06:13:36 -0700 (PDT) From: Neel Chakraborty <neelchakrabortykernelwork@gmail.com> To: abbotti@mev.co.uk Cc: hsweeten@visionengravers.com, linux-kernel@vger.kernel.org, Neel Chakraborty <neelchakrabortykernelwork@gmail.com> Subject: [PATCH] drivers: comedi: drivers: s526: fixed a commented out if else coding style issue Date: Mon, 5 Jun 2023 18:43:06 +0530 Message-Id: <20230605131306.427682-1-neelchakrabortykernelwork@gmail.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM, RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1767871267933340213?= X-GMAIL-MSGID: =?utf-8?q?1767871267933340213?= |
Series |
drivers: comedi: drivers: s526: fixed a commented out if else coding style issue
|
|
Commit Message
Neel Chakraborty
June 5, 2023, 1:13 p.m. UTC
Fixed a coding style issue.
Signed-off-by: Neel Chakraborty <neelchakrabortykernelwork@gmail.com>
---
drivers/comedi/drivers/s526.c | 2 --
1 file changed, 2 deletions(-)
Comments
Hi Neel, kernel test robot noticed the following build errors: [auto build test ERROR on linus/master] [also build test ERROR on v6.4-rc5 next-20230605] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Neel-Chakraborty/drivers-comedi-drivers-s526-fixed-a-commented-out-if-else-coding-style-issue/20230605-211421 base: linus/master patch link: https://lore.kernel.org/r/20230605131306.427682-1-neelchakrabortykernelwork%40gmail.com patch subject: [PATCH] drivers: comedi: drivers: s526: fixed a commented out if else coding style issue config: i386-randconfig-r021-20230605 (https://download.01.org/0day-ci/archive/20230606/202306060401.K9HR1D1l-lkp@intel.com/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): # https://github.com/intel-lab-lkp/linux/commit/a93e6797ff3aa918bf48bcbf0d14c623eec12b89 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Neel-Chakraborty/drivers-comedi-drivers-s526-fixed-a-commented-out-if-else-coding-style-issue/20230605-211421 git checkout a93e6797ff3aa918bf48bcbf0d14c623eec12b89 # save the config file mkdir build_dir && cp config build_dir/.config make W=1 O=build_dir ARCH=i386 olddefconfig make W=1 O=build_dir ARCH=i386 SHELL=/bin/bash If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202306060401.K9HR1D1l-lkp@intel.com/ All errors (new ones prefixed by >>): drivers/comedi/drivers/s526.c: In function 's526_gpct_insn_config': >> drivers/comedi/drivers/s526.c:251:32: error: 'GPCT_X2' undeclared (first use in this function); did you mean 'GPCT_UP'? 251 | if (data[1] == GPCT_X2) | ^~~~~~~ | GPCT_UP drivers/comedi/drivers/s526.c:251:32: note: each undeclared identifier is reported only once for each function it appears in >> drivers/comedi/drivers/s526.c:253:37: error: 'GPCT_X4' undeclared (first use in this function); did you mean 'GPCT_UP'? 253 | else if (data[1] == GPCT_X4) | ^~~~~~~ | GPCT_UP >> drivers/comedi/drivers/s526.c:267:32: error: 'GPCT_RESET_COUNTER_ON_INDEX' undeclared (first use in this function) 267 | if (data[3] == GPCT_RESET_COUNTER_ON_INDEX) { | ^~~~~~~~~~~~~~~~~~~~~~~~~~~ >> drivers/comedi/drivers/s526.c:291:30: error: 'S526_GPCT_CTRL_CT_LOAD' undeclared (first use in this function); did you mean 'S525_GPCT_CTRL_CT_LOAD'? 291 | outw(S526_GPCT_CTRL_CT_LOAD, | ^~~~~~~~~~~~~~~~~~~~~~ | S525_GPCT_CTRL_CT_LOAD >> drivers/comedi/drivers/s526.c:294:2: error: #endif without #if 294 | #endif | ^~~~~ vim +251 drivers/comedi/drivers/s526.c 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 208 0a85b6f0ab0d2e drivers/staging/comedi/drivers/s526.c Mithlesh Thukral 2009-06-08 209 static int s526_gpct_insn_config(struct comedi_device *dev, 0a85b6f0ab0d2e drivers/staging/comedi/drivers/s526.c Mithlesh Thukral 2009-06-08 210 struct comedi_subdevice *s, 5a5614cb669f9f drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 211 struct comedi_insn *insn, 5a5614cb669f9f drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 212 unsigned int *data) 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 213 { 5f2210627f8d3c drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 214 struct s526_private *devpriv = dev->private; 43a352760e6c1c drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 215 unsigned int chan = CR_CHAN(insn->chanspec); 5a5614cb669f9f drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 216 unsigned int val; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 217 a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 218 /* a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 219 * Check what type of Counter the user requested a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 220 * data[0] contains the Application type a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 221 */ b2abd982c484ba drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 222 switch (data[0]) { 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 223 case INSN_CONFIG_GPCT_QUADRATURE_ENCODER: 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 224 /* a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 225 * data[0]: Application Type a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 226 * data[1]: Counter Mode Register Value a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 227 * data[2]: Pre-load Register Value a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 228 * data[3]: Conter Control Register 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 229 */ 675f98f101fb6d drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 230 devpriv->gpct_config[chan] = data[0]; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 231 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 232 /* Set Counter Mode Register */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 233 val = data[1] & 0xffff; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 234 outw(val, dev->iobase + S526_GPCT_MODE_REG(chan)); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 235 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 236 /* Reset the counter if it is software preload */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 237 if ((val & S526_GPCT_MODE_AUTOLOAD_MASK) == 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 238 S526_GPCT_MODE_AUTOLOAD_NONE) { c9c62f4e2c9b52 drivers/staging/comedi/drivers/s526.c Xenofon Foukas 2010-12-15 239 /* Reset the counter */ e5417e49965a47 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 240 outw(S526_GPCT_CTRL_CT_RESET, e5417e49965a47 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 241 dev->iobase + S526_GPCT_CTRL_REG(chan)); 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 242 /* 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 243 * Load the counter from PR0 e5417e49965a47 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 244 * outw(S526_GPCT_CTRL_CT_LOAD, e5417e49965a47 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 245 * dev->iobase + S526_GPCT_CTRL_REG(chan)); c9c62f4e2c9b52 drivers/staging/comedi/drivers/s526.c Xenofon Foukas 2010-12-15 246 */ 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 247 } 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 248 val = S526_GPCT_MODE_CTDIR_CTRL_QUAD; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 249 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 250 /* data[1] contains GPCT_X1, GPCT_X2 or GPCT_X4 */ b2abd982c484ba drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 @251 if (data[1] == GPCT_X2) 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 252 val |= S526_GPCT_MODE_CLK_SRC_QUADX2; b2abd982c484ba drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 @253 else if (data[1] == GPCT_X4) 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 254 val |= S526_GPCT_MODE_CLK_SRC_QUADX4; c9c62f4e2c9b52 drivers/staging/comedi/drivers/s526.c Xenofon Foukas 2010-12-15 255 else 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 256 val |= S526_GPCT_MODE_CLK_SRC_QUADX1; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 257 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 258 /* When to take into account the indexpulse: */ a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 259 /* a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 260 * if (data[2] == GPCT_IndexPhaseLowLow) { a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 261 * } else if (data[2] == GPCT_IndexPhaseLowHigh) { a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 262 * } else if (data[2] == GPCT_IndexPhaseHighLow) { a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 263 * } else if (data[2] == GPCT_IndexPhaseHighHigh) { a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 264 * } a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 265 */ 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 266 /* Take into account the index pulse? */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 @267 if (data[3] == GPCT_RESET_COUNTER_ON_INDEX) { c9c62f4e2c9b52 drivers/staging/comedi/drivers/s526.c Xenofon Foukas 2010-12-15 268 /* Auto load with INDEX^ */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 269 val |= S526_GPCT_MODE_AUTOLOAD_IXRISE; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 270 } 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 271 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 272 /* Set Counter Mode Register */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 273 val = data[1] & 0xffff; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 274 outw(val, dev->iobase + S526_GPCT_MODE_REG(chan)); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 275 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 276 /* Load the pre-load register */ 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 277 s526_gpct_write(dev, chan, data[2]); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 278 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 279 /* Write the Counter Control Register */ 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 280 if (data[3]) 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 281 outw(data[3] & 0xffff, 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 282 dev->iobase + S526_GPCT_CTRL_REG(chan)); 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 283 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 284 /* Reset the counter if it is software preload */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 285 if ((val & S526_GPCT_MODE_AUTOLOAD_MASK) == 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 286 S526_GPCT_MODE_AUTOLOAD_NONE) { c9c62f4e2c9b52 drivers/staging/comedi/drivers/s526.c Xenofon Foukas 2010-12-15 287 /* Reset the counter */ e5417e49965a47 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 288 outw(S526_GPCT_CTRL_CT_RESET, e5417e49965a47 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 289 dev->iobase + S526_GPCT_CTRL_REG(chan)); c9c62f4e2c9b52 drivers/staging/comedi/drivers/s526.c Xenofon Foukas 2010-12-15 290 /* Load the counter from PR0 */ e5417e49965a47 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 @291 outw(S526_GPCT_CTRL_CT_LOAD, e5417e49965a47 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 292 dev->iobase + S526_GPCT_CTRL_REG(chan)); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 293 } 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 @294 #endif 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 295 break; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 296 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 297 case INSN_CONFIG_GPCT_SINGLE_PULSE_GENERATOR: 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 298 /* a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 299 * data[0]: Application Type a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 300 * data[1]: Counter Mode Register Value a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 301 * data[2]: Pre-load Register 0 Value a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 302 * data[3]: Pre-load Register 1 Value a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 303 * data[4]: Conter Control Register 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 304 */ 675f98f101fb6d drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 305 devpriv->gpct_config[chan] = data[0]; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 306 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 307 /* Set Counter Mode Register */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 308 val = data[1] & 0xffff; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 309 /* Select PR0 */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 310 val &= ~S526_GPCT_MODE_PR_SELECT_MASK; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 311 val |= S526_GPCT_MODE_PR_SELECT_PR0; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 312 outw(val, dev->iobase + S526_GPCT_MODE_REG(chan)); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 313 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 314 /* Load the pre-load register 0 */ 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 315 s526_gpct_write(dev, chan, data[2]); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 316 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 317 /* Set Counter Mode Register */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 318 val = data[1] & 0xffff; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 319 /* Select PR1 */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 320 val &= ~S526_GPCT_MODE_PR_SELECT_MASK; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 321 val |= S526_GPCT_MODE_PR_SELECT_PR1; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 322 outw(val, dev->iobase + S526_GPCT_MODE_REG(chan)); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 323 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 324 /* Load the pre-load register 1 */ 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 325 s526_gpct_write(dev, chan, data[3]); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 326 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 327 /* Write the Counter Control Register */ 5a5614cb669f9f drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 328 if (data[4]) { 5a5614cb669f9f drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 329 val = data[4] & 0xffff; 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 330 outw(val, dev->iobase + S526_GPCT_CTRL_REG(chan)); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 331 } 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 332 break; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 333 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 334 case INSN_CONFIG_GPCT_PULSE_TRAIN_GENERATOR: 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 335 /* a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 336 * data[0]: Application Type a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 337 * data[1]: Counter Mode Register Value a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 338 * data[2]: Pre-load Register 0 Value a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 339 * data[3]: Pre-load Register 1 Value a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 340 * data[4]: Conter Control Register 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 341 */ 675f98f101fb6d drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 342 devpriv->gpct_config[chan] = data[0]; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 343 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 344 /* Set Counter Mode Register */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 345 val = data[1] & 0xffff; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 346 /* Select PR0 */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 347 val &= ~S526_GPCT_MODE_PR_SELECT_MASK; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 348 val |= S526_GPCT_MODE_PR_SELECT_PR0; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 349 outw(val, dev->iobase + S526_GPCT_MODE_REG(chan)); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 350 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 351 /* Load the pre-load register 0 */ 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 352 s526_gpct_write(dev, chan, data[2]); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 353 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 354 /* Set Counter Mode Register */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 355 val = data[1] & 0xffff; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 356 /* Select PR1 */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 357 val &= ~S526_GPCT_MODE_PR_SELECT_MASK; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 358 val |= S526_GPCT_MODE_PR_SELECT_PR1; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 359 outw(val, dev->iobase + S526_GPCT_MODE_REG(chan)); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 360 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 361 /* Load the pre-load register 1 */ 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 362 s526_gpct_write(dev, chan, data[3]); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 363 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 364 /* Write the Counter Control Register */ 5a5614cb669f9f drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 365 if (data[4]) { 5a5614cb669f9f drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 366 val = data[4] & 0xffff; 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 367 outw(val, dev->iobase + S526_GPCT_CTRL_REG(chan)); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 368 } 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 369 break; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 370 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 371 default: 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 372 return -EINVAL; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 373 } 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 374 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 375 return insn->n; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 376 } 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 377
Hi Neel, kernel test robot noticed the following build errors: [auto build test ERROR on linus/master] [also build test ERROR on v6.4-rc5 next-20230606] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Neel-Chakraborty/drivers-comedi-drivers-s526-fixed-a-commented-out-if-else-coding-style-issue/20230605-211421 base: linus/master patch link: https://lore.kernel.org/r/20230605131306.427682-1-neelchakrabortykernelwork%40gmail.com patch subject: [PATCH] drivers: comedi: drivers: s526: fixed a commented out if else coding style issue config: arm-randconfig-r031-20230606 (https://download.01.org/0day-ci/archive/20230606/202306062334.IyXxcuto-lkp@intel.com/config) compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07) reproduce (this is a W=1 build): mkdir -p ~/bin wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # install arm cross compiling tool for clang build # apt-get install binutils-arm-linux-gnueabi git checkout linus/master b4 shazam https://lore.kernel.org/r/20230605131306.427682-1-neelchakrabortykernelwork@gmail.com # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=arm olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=arm SHELL=/bin/bash drivers/comedi/drivers/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202306062334.IyXxcuto-lkp@intel.com/ All errors (new ones prefixed by >>): >> drivers/comedi/drivers/s526.c:251:18: error: use of undeclared identifier 'GPCT_X2' if (data[1] == GPCT_X2) ^ >> drivers/comedi/drivers/s526.c:251:18: error: use of undeclared identifier 'GPCT_X2' >> drivers/comedi/drivers/s526.c:251:18: error: use of undeclared identifier 'GPCT_X2' >> drivers/comedi/drivers/s526.c:253:23: error: use of undeclared identifier 'GPCT_X4' else if (data[1] == GPCT_X4) ^ >> drivers/comedi/drivers/s526.c:253:23: error: use of undeclared identifier 'GPCT_X4' >> drivers/comedi/drivers/s526.c:253:23: error: use of undeclared identifier 'GPCT_X4' >> drivers/comedi/drivers/s526.c:267:18: error: use of undeclared identifier 'GPCT_RESET_COUNTER_ON_INDEX' if (data[3] == GPCT_RESET_COUNTER_ON_INDEX) { ^ >> drivers/comedi/drivers/s526.c:267:18: error: use of undeclared identifier 'GPCT_RESET_COUNTER_ON_INDEX' >> drivers/comedi/drivers/s526.c:267:18: error: use of undeclared identifier 'GPCT_RESET_COUNTER_ON_INDEX' >> drivers/comedi/drivers/s526.c:291:9: error: use of undeclared identifier 'S526_GPCT_CTRL_CT_LOAD' outw(S526_GPCT_CTRL_CT_LOAD, ^ drivers/comedi/drivers/s526.c:294:2: error: #endif without #if #endif ^ 11 errors generated. vim +/GPCT_X2 +251 drivers/comedi/drivers/s526.c 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 208 0a85b6f0ab0d2e drivers/staging/comedi/drivers/s526.c Mithlesh Thukral 2009-06-08 209 static int s526_gpct_insn_config(struct comedi_device *dev, 0a85b6f0ab0d2e drivers/staging/comedi/drivers/s526.c Mithlesh Thukral 2009-06-08 210 struct comedi_subdevice *s, 5a5614cb669f9f drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 211 struct comedi_insn *insn, 5a5614cb669f9f drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 212 unsigned int *data) 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 213 { 5f2210627f8d3c drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 214 struct s526_private *devpriv = dev->private; 43a352760e6c1c drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 215 unsigned int chan = CR_CHAN(insn->chanspec); 5a5614cb669f9f drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 216 unsigned int val; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 217 a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 218 /* a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 219 * Check what type of Counter the user requested a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 220 * data[0] contains the Application type a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 221 */ b2abd982c484ba drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 222 switch (data[0]) { 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 223 case INSN_CONFIG_GPCT_QUADRATURE_ENCODER: 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 224 /* a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 225 * data[0]: Application Type a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 226 * data[1]: Counter Mode Register Value a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 227 * data[2]: Pre-load Register Value a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 228 * data[3]: Conter Control Register 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 229 */ 675f98f101fb6d drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 230 devpriv->gpct_config[chan] = data[0]; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 231 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 232 /* Set Counter Mode Register */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 233 val = data[1] & 0xffff; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 234 outw(val, dev->iobase + S526_GPCT_MODE_REG(chan)); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 235 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 236 /* Reset the counter if it is software preload */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 237 if ((val & S526_GPCT_MODE_AUTOLOAD_MASK) == 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 238 S526_GPCT_MODE_AUTOLOAD_NONE) { c9c62f4e2c9b52 drivers/staging/comedi/drivers/s526.c Xenofon Foukas 2010-12-15 239 /* Reset the counter */ e5417e49965a47 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 240 outw(S526_GPCT_CTRL_CT_RESET, e5417e49965a47 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 241 dev->iobase + S526_GPCT_CTRL_REG(chan)); 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 242 /* 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 243 * Load the counter from PR0 e5417e49965a47 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 244 * outw(S526_GPCT_CTRL_CT_LOAD, e5417e49965a47 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 245 * dev->iobase + S526_GPCT_CTRL_REG(chan)); c9c62f4e2c9b52 drivers/staging/comedi/drivers/s526.c Xenofon Foukas 2010-12-15 246 */ 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 247 } 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 248 val = S526_GPCT_MODE_CTDIR_CTRL_QUAD; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 249 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 250 /* data[1] contains GPCT_X1, GPCT_X2 or GPCT_X4 */ b2abd982c484ba drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 @251 if (data[1] == GPCT_X2) 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 252 val |= S526_GPCT_MODE_CLK_SRC_QUADX2; b2abd982c484ba drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 @253 else if (data[1] == GPCT_X4) 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 254 val |= S526_GPCT_MODE_CLK_SRC_QUADX4; c9c62f4e2c9b52 drivers/staging/comedi/drivers/s526.c Xenofon Foukas 2010-12-15 255 else 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 256 val |= S526_GPCT_MODE_CLK_SRC_QUADX1; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 257 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 258 /* When to take into account the indexpulse: */ a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 259 /* a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 260 * if (data[2] == GPCT_IndexPhaseLowLow) { a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 261 * } else if (data[2] == GPCT_IndexPhaseLowHigh) { a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 262 * } else if (data[2] == GPCT_IndexPhaseHighLow) { a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 263 * } else if (data[2] == GPCT_IndexPhaseHighHigh) { a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 264 * } a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 265 */ 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 266 /* Take into account the index pulse? */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 @267 if (data[3] == GPCT_RESET_COUNTER_ON_INDEX) { c9c62f4e2c9b52 drivers/staging/comedi/drivers/s526.c Xenofon Foukas 2010-12-15 268 /* Auto load with INDEX^ */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 269 val |= S526_GPCT_MODE_AUTOLOAD_IXRISE; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 270 } 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 271 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 272 /* Set Counter Mode Register */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 273 val = data[1] & 0xffff; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 274 outw(val, dev->iobase + S526_GPCT_MODE_REG(chan)); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 275 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 276 /* Load the pre-load register */ 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 277 s526_gpct_write(dev, chan, data[2]); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 278 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 279 /* Write the Counter Control Register */ 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 280 if (data[3]) 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 281 outw(data[3] & 0xffff, 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 282 dev->iobase + S526_GPCT_CTRL_REG(chan)); 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 283 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 284 /* Reset the counter if it is software preload */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 285 if ((val & S526_GPCT_MODE_AUTOLOAD_MASK) == 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 286 S526_GPCT_MODE_AUTOLOAD_NONE) { c9c62f4e2c9b52 drivers/staging/comedi/drivers/s526.c Xenofon Foukas 2010-12-15 287 /* Reset the counter */ e5417e49965a47 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 288 outw(S526_GPCT_CTRL_CT_RESET, e5417e49965a47 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 289 dev->iobase + S526_GPCT_CTRL_REG(chan)); c9c62f4e2c9b52 drivers/staging/comedi/drivers/s526.c Xenofon Foukas 2010-12-15 290 /* Load the counter from PR0 */ e5417e49965a47 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 @291 outw(S526_GPCT_CTRL_CT_LOAD, e5417e49965a47 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 292 dev->iobase + S526_GPCT_CTRL_REG(chan)); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 293 } 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 294 #endif 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 295 break; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 296 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 297 case INSN_CONFIG_GPCT_SINGLE_PULSE_GENERATOR: 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 298 /* a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 299 * data[0]: Application Type a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 300 * data[1]: Counter Mode Register Value a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 301 * data[2]: Pre-load Register 0 Value a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 302 * data[3]: Pre-load Register 1 Value a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 303 * data[4]: Conter Control Register 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 304 */ 675f98f101fb6d drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 305 devpriv->gpct_config[chan] = data[0]; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 306 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 307 /* Set Counter Mode Register */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 308 val = data[1] & 0xffff; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 309 /* Select PR0 */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 310 val &= ~S526_GPCT_MODE_PR_SELECT_MASK; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 311 val |= S526_GPCT_MODE_PR_SELECT_PR0; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 312 outw(val, dev->iobase + S526_GPCT_MODE_REG(chan)); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 313 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 314 /* Load the pre-load register 0 */ 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 315 s526_gpct_write(dev, chan, data[2]); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 316 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 317 /* Set Counter Mode Register */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 318 val = data[1] & 0xffff; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 319 /* Select PR1 */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 320 val &= ~S526_GPCT_MODE_PR_SELECT_MASK; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 321 val |= S526_GPCT_MODE_PR_SELECT_PR1; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 322 outw(val, dev->iobase + S526_GPCT_MODE_REG(chan)); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 323 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 324 /* Load the pre-load register 1 */ 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 325 s526_gpct_write(dev, chan, data[3]); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 326 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 327 /* Write the Counter Control Register */ 5a5614cb669f9f drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 328 if (data[4]) { 5a5614cb669f9f drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 329 val = data[4] & 0xffff; 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 330 outw(val, dev->iobase + S526_GPCT_CTRL_REG(chan)); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 331 } 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 332 break; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 333 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 334 case INSN_CONFIG_GPCT_PULSE_TRAIN_GENERATOR: 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 335 /* a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 336 * data[0]: Application Type a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 337 * data[1]: Counter Mode Register Value a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 338 * data[2]: Pre-load Register 0 Value a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 339 * data[3]: Pre-load Register 1 Value a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 340 * data[4]: Conter Control Register 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 341 */ 675f98f101fb6d drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 342 devpriv->gpct_config[chan] = data[0]; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 343 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 344 /* Set Counter Mode Register */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 345 val = data[1] & 0xffff; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 346 /* Select PR0 */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 347 val &= ~S526_GPCT_MODE_PR_SELECT_MASK; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 348 val |= S526_GPCT_MODE_PR_SELECT_PR0; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 349 outw(val, dev->iobase + S526_GPCT_MODE_REG(chan)); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 350 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 351 /* Load the pre-load register 0 */ 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 352 s526_gpct_write(dev, chan, data[2]); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 353 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 354 /* Set Counter Mode Register */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 355 val = data[1] & 0xffff; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 356 /* Select PR1 */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 357 val &= ~S526_GPCT_MODE_PR_SELECT_MASK; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 358 val |= S526_GPCT_MODE_PR_SELECT_PR1; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 359 outw(val, dev->iobase + S526_GPCT_MODE_REG(chan)); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 360 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 361 /* Load the pre-load register 1 */ 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 362 s526_gpct_write(dev, chan, data[3]); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 363 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 364 /* Write the Counter Control Register */ 5a5614cb669f9f drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 365 if (data[4]) { 5a5614cb669f9f drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 366 val = data[4] & 0xffff; 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 367 outw(val, dev->iobase + S526_GPCT_CTRL_REG(chan)); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 368 } 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 369 break; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 370 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 371 default: 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 372 return -EINVAL; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 373 } 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 374 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 375 return insn->n; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 376 } 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 377
Hi Neel, kernel test robot noticed the following build errors: [auto build test ERROR on linus/master] [also build test ERROR on v6.4-rc6 next-20230614] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Neel-Chakraborty/drivers-comedi-drivers-s526-fixed-a-commented-out-if-else-coding-style-issue/20230605-211421 base: linus/master patch link: https://lore.kernel.org/r/20230605131306.427682-1-neelchakrabortykernelwork%40gmail.com patch subject: [PATCH] drivers: comedi: drivers: s526: fixed a commented out if else coding style issue config: i386-randconfig-i062-20230605-CONFIG_SMP (https://download.01.org/0day-ci/archive/20230614/202306142240.bYcu8B7c-lkp@intel.com/config) compiler: clang version 15.0.7 (https://github.com/llvm/llvm-project.git 8dfdcc7b7bf66834a761bd8de445840ef68e4d1a) reproduce (this is a W=1 build): mkdir -p ~/bin wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross git checkout linus/master b4 shazam https://lore.kernel.org/r/20230605131306.427682-1-neelchakrabortykernelwork@gmail.com # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=i386 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang ~/bin/make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@intel.com> | Closes: https://lore.kernel.org/oe-kbuild-all/202306142240.bYcu8B7c-lkp@intel.com/ All errors (new ones prefixed by >>): >> drivers/comedi/drivers/s526.c:251:18: error: use of undeclared identifier 'GPCT_X2' if (data[1] == GPCT_X2) ^ >> drivers/comedi/drivers/s526.c:251:18: error: use of undeclared identifier 'GPCT_X2' >> drivers/comedi/drivers/s526.c:251:18: error: use of undeclared identifier 'GPCT_X2' >> drivers/comedi/drivers/s526.c:253:23: error: use of undeclared identifier 'GPCT_X4' else if (data[1] == GPCT_X4) ^ >> drivers/comedi/drivers/s526.c:253:23: error: use of undeclared identifier 'GPCT_X4' >> drivers/comedi/drivers/s526.c:253:23: error: use of undeclared identifier 'GPCT_X4' >> drivers/comedi/drivers/s526.c:267:18: error: use of undeclared identifier 'GPCT_RESET_COUNTER_ON_INDEX' if (data[3] == GPCT_RESET_COUNTER_ON_INDEX) { ^ >> drivers/comedi/drivers/s526.c:267:18: error: use of undeclared identifier 'GPCT_RESET_COUNTER_ON_INDEX' >> drivers/comedi/drivers/s526.c:267:18: error: use of undeclared identifier 'GPCT_RESET_COUNTER_ON_INDEX' >> drivers/comedi/drivers/s526.c:291:9: error: use of undeclared identifier 'S526_GPCT_CTRL_CT_LOAD' outw(S526_GPCT_CTRL_CT_LOAD, ^ >> drivers/comedi/drivers/s526.c:294:2: error: #endif without #if #endif ^ 11 errors generated. vim +/GPCT_X2 +251 drivers/comedi/drivers/s526.c 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 208 0a85b6f0ab0d2e drivers/staging/comedi/drivers/s526.c Mithlesh Thukral 2009-06-08 209 static int s526_gpct_insn_config(struct comedi_device *dev, 0a85b6f0ab0d2e drivers/staging/comedi/drivers/s526.c Mithlesh Thukral 2009-06-08 210 struct comedi_subdevice *s, 5a5614cb669f9f drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 211 struct comedi_insn *insn, 5a5614cb669f9f drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 212 unsigned int *data) 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 213 { 5f2210627f8d3c drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 214 struct s526_private *devpriv = dev->private; 43a352760e6c1c drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 215 unsigned int chan = CR_CHAN(insn->chanspec); 5a5614cb669f9f drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 216 unsigned int val; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 217 a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 218 /* a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 219 * Check what type of Counter the user requested a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 220 * data[0] contains the Application type a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 221 */ b2abd982c484ba drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 222 switch (data[0]) { 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 223 case INSN_CONFIG_GPCT_QUADRATURE_ENCODER: 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 224 /* a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 225 * data[0]: Application Type a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 226 * data[1]: Counter Mode Register Value a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 227 * data[2]: Pre-load Register Value a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 228 * data[3]: Conter Control Register 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 229 */ 675f98f101fb6d drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 230 devpriv->gpct_config[chan] = data[0]; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 231 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 232 /* Set Counter Mode Register */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 233 val = data[1] & 0xffff; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 234 outw(val, dev->iobase + S526_GPCT_MODE_REG(chan)); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 235 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 236 /* Reset the counter if it is software preload */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 237 if ((val & S526_GPCT_MODE_AUTOLOAD_MASK) == 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 238 S526_GPCT_MODE_AUTOLOAD_NONE) { c9c62f4e2c9b52 drivers/staging/comedi/drivers/s526.c Xenofon Foukas 2010-12-15 239 /* Reset the counter */ e5417e49965a47 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 240 outw(S526_GPCT_CTRL_CT_RESET, e5417e49965a47 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 241 dev->iobase + S526_GPCT_CTRL_REG(chan)); 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 242 /* 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 243 * Load the counter from PR0 e5417e49965a47 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 244 * outw(S526_GPCT_CTRL_CT_LOAD, e5417e49965a47 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 245 * dev->iobase + S526_GPCT_CTRL_REG(chan)); c9c62f4e2c9b52 drivers/staging/comedi/drivers/s526.c Xenofon Foukas 2010-12-15 246 */ 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 247 } 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 248 val = S526_GPCT_MODE_CTDIR_CTRL_QUAD; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 249 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 250 /* data[1] contains GPCT_X1, GPCT_X2 or GPCT_X4 */ b2abd982c484ba drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 @251 if (data[1] == GPCT_X2) 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 252 val |= S526_GPCT_MODE_CLK_SRC_QUADX2; b2abd982c484ba drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 @253 else if (data[1] == GPCT_X4) 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 254 val |= S526_GPCT_MODE_CLK_SRC_QUADX4; c9c62f4e2c9b52 drivers/staging/comedi/drivers/s526.c Xenofon Foukas 2010-12-15 255 else 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 256 val |= S526_GPCT_MODE_CLK_SRC_QUADX1; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 257 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 258 /* When to take into account the indexpulse: */ a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 259 /* a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 260 * if (data[2] == GPCT_IndexPhaseLowLow) { a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 261 * } else if (data[2] == GPCT_IndexPhaseLowHigh) { a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 262 * } else if (data[2] == GPCT_IndexPhaseHighLow) { a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 263 * } else if (data[2] == GPCT_IndexPhaseHighHigh) { a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 264 * } a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 265 */ 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 266 /* Take into account the index pulse? */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 @267 if (data[3] == GPCT_RESET_COUNTER_ON_INDEX) { c9c62f4e2c9b52 drivers/staging/comedi/drivers/s526.c Xenofon Foukas 2010-12-15 268 /* Auto load with INDEX^ */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 269 val |= S526_GPCT_MODE_AUTOLOAD_IXRISE; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 270 } 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 271 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 272 /* Set Counter Mode Register */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 273 val = data[1] & 0xffff; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 274 outw(val, dev->iobase + S526_GPCT_MODE_REG(chan)); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 275 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 276 /* Load the pre-load register */ 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 277 s526_gpct_write(dev, chan, data[2]); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 278 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 279 /* Write the Counter Control Register */ 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 280 if (data[3]) 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 281 outw(data[3] & 0xffff, 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 282 dev->iobase + S526_GPCT_CTRL_REG(chan)); 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 283 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 284 /* Reset the counter if it is software preload */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 285 if ((val & S526_GPCT_MODE_AUTOLOAD_MASK) == 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 286 S526_GPCT_MODE_AUTOLOAD_NONE) { c9c62f4e2c9b52 drivers/staging/comedi/drivers/s526.c Xenofon Foukas 2010-12-15 287 /* Reset the counter */ e5417e49965a47 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 288 outw(S526_GPCT_CTRL_CT_RESET, e5417e49965a47 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 289 dev->iobase + S526_GPCT_CTRL_REG(chan)); c9c62f4e2c9b52 drivers/staging/comedi/drivers/s526.c Xenofon Foukas 2010-12-15 290 /* Load the counter from PR0 */ e5417e49965a47 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 @291 outw(S526_GPCT_CTRL_CT_LOAD, e5417e49965a47 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 292 dev->iobase + S526_GPCT_CTRL_REG(chan)); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 293 } 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 @294 #endif 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 295 break; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 296 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 297 case INSN_CONFIG_GPCT_SINGLE_PULSE_GENERATOR: 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 298 /* a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 299 * data[0]: Application Type a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 300 * data[1]: Counter Mode Register Value a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 301 * data[2]: Pre-load Register 0 Value a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 302 * data[3]: Pre-load Register 1 Value a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 303 * data[4]: Conter Control Register 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 304 */ 675f98f101fb6d drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 305 devpriv->gpct_config[chan] = data[0]; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 306 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 307 /* Set Counter Mode Register */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 308 val = data[1] & 0xffff; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 309 /* Select PR0 */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 310 val &= ~S526_GPCT_MODE_PR_SELECT_MASK; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 311 val |= S526_GPCT_MODE_PR_SELECT_PR0; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 312 outw(val, dev->iobase + S526_GPCT_MODE_REG(chan)); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 313 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 314 /* Load the pre-load register 0 */ 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 315 s526_gpct_write(dev, chan, data[2]); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 316 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 317 /* Set Counter Mode Register */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 318 val = data[1] & 0xffff; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 319 /* Select PR1 */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 320 val &= ~S526_GPCT_MODE_PR_SELECT_MASK; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 321 val |= S526_GPCT_MODE_PR_SELECT_PR1; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 322 outw(val, dev->iobase + S526_GPCT_MODE_REG(chan)); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 323 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 324 /* Load the pre-load register 1 */ 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 325 s526_gpct_write(dev, chan, data[3]); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 326 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 327 /* Write the Counter Control Register */ 5a5614cb669f9f drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 328 if (data[4]) { 5a5614cb669f9f drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 329 val = data[4] & 0xffff; 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 330 outw(val, dev->iobase + S526_GPCT_CTRL_REG(chan)); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 331 } 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 332 break; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 333 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 334 case INSN_CONFIG_GPCT_PULSE_TRAIN_GENERATOR: 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 335 /* a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 336 * data[0]: Application Type a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 337 * data[1]: Counter Mode Register Value a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 338 * data[2]: Pre-load Register 0 Value a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 339 * data[3]: Pre-load Register 1 Value a399d81d41e174 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 340 * data[4]: Conter Control Register 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 341 */ 675f98f101fb6d drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 342 devpriv->gpct_config[chan] = data[0]; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 343 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 344 /* Set Counter Mode Register */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 345 val = data[1] & 0xffff; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 346 /* Select PR0 */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 347 val &= ~S526_GPCT_MODE_PR_SELECT_MASK; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 348 val |= S526_GPCT_MODE_PR_SELECT_PR0; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 349 outw(val, dev->iobase + S526_GPCT_MODE_REG(chan)); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 350 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 351 /* Load the pre-load register 0 */ 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 352 s526_gpct_write(dev, chan, data[2]); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 353 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 354 /* Set Counter Mode Register */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 355 val = data[1] & 0xffff; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 356 /* Select PR1 */ 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 357 val &= ~S526_GPCT_MODE_PR_SELECT_MASK; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 358 val |= S526_GPCT_MODE_PR_SELECT_PR1; 479bd5edab3ca8 drivers/staging/comedi/drivers/s526.c Ian Abbott 2015-11-19 359 outw(val, dev->iobase + S526_GPCT_MODE_REG(chan)); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 360 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 361 /* Load the pre-load register 1 */ 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 362 s526_gpct_write(dev, chan, data[3]); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 363 232f650253a04b drivers/staging/comedi/drivers/s526.c Bill Pemberton 2009-03-27 364 /* Write the Counter Control Register */ 5a5614cb669f9f drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 365 if (data[4]) { 5a5614cb669f9f drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2012-09-19 366 val = data[4] & 0xffff; 1d0d1c00daff96 drivers/staging/comedi/drivers/s526.c H Hartley Sweeten 2015-08-17 367 outw(val, dev->iobase + S526_GPCT_CTRL_REG(chan)); 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 368 } 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 369 break; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 370 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 371 default: 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 372 return -EINVAL; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 373 } 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 374 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 375 return insn->n; 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 376 } 0c988d008cedca drivers/staging/comedi/drivers/s526.c Everett Wang 2009-02-17 377
diff --git a/drivers/comedi/drivers/s526.c b/drivers/comedi/drivers/s526.c index 9245c679a3c4..12aa40920575 100644 --- a/drivers/comedi/drivers/s526.c +++ b/drivers/comedi/drivers/s526.c @@ -229,7 +229,6 @@ static int s526_gpct_insn_config(struct comedi_device *dev, */ devpriv->gpct_config[chan] = data[0]; -#if 1 /* Set Counter Mode Register */ val = data[1] & 0xffff; outw(val, dev->iobase + S526_GPCT_MODE_REG(chan)); @@ -246,7 +245,6 @@ static int s526_gpct_insn_config(struct comedi_device *dev, * dev->iobase + S526_GPCT_CTRL_REG(chan)); */ } -#else val = S526_GPCT_MODE_CTDIR_CTRL_QUAD; /* data[1] contains GPCT_X1, GPCT_X2 or GPCT_X4 */