diff mbox series

speakup: Fix warning comparing pointer to 0

Message ID 1de9cab8.c1.1844d7bdf4b.Coremail.wangkailong@jari.cn
State New
Headers
Series speakup: Fix warning comparing pointer to 0 |

Commit Message

KaiLong Wang Nov. 6, 2022, 3:07 p.m. UTC 
  Fix the following coccicheck warning:

drivers/accessibility/speakup/utils.h:39:15-16: WARNING comparing
pointer to 0

Signed-off-by: KaiLong Wang <wangkailong@jari.cn>
---
 drivers/accessibility/speakup/utils.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Samuel Thibault Nov. 6, 2022, 3:51 p.m. UTC | #1 
wangkailong@jari.cn, le dim. 06 nov. 2022 23:07:54 +0800, a ecrit:
> Fix the following coccicheck warning:
> 
> drivers/accessibility/speakup/utils.h:39:15-16: WARNING comparing
> pointer to 0

You're replacing it with the contrary of what it should be...

> ---
>  drivers/accessibility/speakup/utils.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h
> index 4bf2ee8ac246..5803b521df2b 100644
> --- a/drivers/accessibility/speakup/utils.h
> +++ b/drivers/accessibility/speakup/utils.h
> @@ -36,7 +36,7 @@ static inline void open_input(const char *dir_name, const char *name)
>  	else
>  		snprintf(filename, sizeof(filename), "%s", name);
>  	infile = fopen(filename, "r");
> -	if (infile == 0) {
> +	if (infile) {
>  		fprintf(stderr, "can't open %s\n", filename);
>  		exit(1);
>  	}
> -- 
> 2.25.1
diff mbox series

Patch

diff --git a/drivers/accessibility/speakup/utils.h b/drivers/accessibility/speakup/utils.h
index 4bf2ee8ac246..5803b521df2b 100644
--- a/drivers/accessibility/speakup/utils.h
+++ b/drivers/accessibility/speakup/utils.h
@@ -36,7 +36,7 @@  static inline void open_input(const char *dir_name, const char *name)
 	else
 		snprintf(filename, sizeof(filename), "%s", name);
 	infile = fopen(filename, "r");
-	if (infile == 0) {
+	if (infile) {
 		fprintf(stderr, "can't open %s\n", filename);
 		exit(1);
 	}