Message ID | 20230613070426.467389-2-manikandan.m@microchip.com |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp362357vqr; Tue, 13 Jun 2023 00:31:28 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ49GZKggvOZtVzT/+e/P9IYSajHs0kMHhjwTSRHufl1CPauoBPCDdPIZcdcguyplfQNK8We X-Received: by 2002:a17:902:e84a:b0:1ae:6a3:d058 with SMTP id t10-20020a170902e84a00b001ae06a3d058mr10116508plg.36.1686641488000; Tue, 13 Jun 2023 00:31:28 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686641487; cv=none; d=google.com; s=arc-20160816; b=Vcdx5Kp/NU4LUtKb54dVx3HHbpokZhnPmPolEIavnHblPQrDcuBn1J68bFa6hP6iwq gaB1Gng08se6L+Bjnfh554AmIlXUDz3bh5hsrT8VitqQihrF6cmRKNbtlG1y5L+xAz/0 HH9m2WZCbUQzw+RM62W2RQNtyGFLXFLYqLR0IRnqAoK8++aISUiWNA5XrkEcojWc7umK RHB7JBrIRdvcSkIzVUUmJkQDDXM60Zp64nDSMQlS3b53JntIeaLpLbT0eaALQT6Uj2FN dprQYnhT2oLhscYn7LTJujMjfK03zg1y09x5PE4At+juDWCmouwqhlzjzsedSnlcYkbu FxaA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=0QIo7FNWZ1UIM4tqZ9LSf2/VoGXwoKNu0Yk+WwCE7J4=; b=weIIqfSUBhwvPKL6LcFe7C5E83HFtShAd9LX++HTsw0QPe9wfow9Bevi25O5bahwpd FXuOdSQBZBEyuZPxxV8zSg/dYEuv5EaKEhuJt6mQKrE7SdpcH02h0+F1ADgrRtrtwggy sW6Xs5dSaQGEkK+vyOjgVTgchFc1eptAGMs7Ea+5HYcqJrvhNMGeZgZ109IrlntiXI9l MFk1I7eddjh2Rd/am+f4jLJGusx+O1FxZfYFN4bw2jzDGD/jimYlrBnxw5RssoleZU3q SboC44uavuN/Wadj3j5uWCgei1jQTNfIzIuYlY1/wJv9vxR6sB/3UJ0fP5XqAjBmRfp1 swWw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=CQBRJGAu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id a10-20020a170902ee8a00b001b0191881efsi8382167pld.37.2023.06.13.00.31.15; Tue, 13 Jun 2023 00:31:27 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@microchip.com header.s=mchp header.b=CQBRJGAu; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=microchip.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239750AbjFMHFV (ORCPT <rfc822;rust.linux@gmail.com> + 99 others); Tue, 13 Jun 2023 03:05:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:50964 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239738AbjFMHFQ (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 13 Jun 2023 03:05:16 -0400 Received: from esa.microchip.iphmx.com (esa.microchip.iphmx.com [68.232.153.233]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C9534173C; Tue, 13 Jun 2023 00:05:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=microchip.com; i=@microchip.com; q=dns/txt; s=mchp; t=1686639914; x=1718175914; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=fRjFS0tyWhibQ8jFtctjzfuGuQJU7LCgPahmmxu6a7A=; b=CQBRJGAu0JvhJFfEp4sebDhUB06zfGs/3ynbNiJXsK+hCEVcIY/zJ6yn wWvWXQQu58Zl0WdRiE6t+BD0E3SRAOWM9Wu2LeTGLIWtNIQxLDBCbRrvF 8A76godPW5pr6OKfyllZ2CuBDLJ2Pv08yxETg0NeK9miYRiJjzJdsdurd 8g8AgWQZOG9i5SWKSV7rM+W63qYmXMgMtJeTRvJzBHAlNo4dLI4O4+mt5 JCRrEyaMRN/PwLnWPlShcfxOTRfEgS94npHMqqAN13VLz3sfHsFl1XzWd xRJpv0YY6/D4thXIKfycorIODtZaCsEzG6IC57R50LfaVX4iA5m6Rns5A A==; X-IronPort-AV: E=Sophos;i="6.00,238,1681196400"; d="scan'208";a="218182139" X-Amp-Result: SKIPPED(no attachment in message) Received: from unknown (HELO email.microchip.com) ([170.129.1.10]) by esa5.microchip.iphmx.com with ESMTP/TLS/AES256-SHA256; 13 Jun 2023 00:05:12 -0700 Received: from chn-vm-ex02.mchp-main.com (10.10.85.144) by chn-vm-ex01.mchp-main.com (10.10.85.143) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.21; Tue, 13 Jun 2023 00:05:11 -0700 Received: from che-lt-i67131.microchip.com (10.10.115.15) by chn-vm-ex02.mchp-main.com (10.10.85.144) with Microsoft SMTP Server id 15.1.2507.21 via Frontend Transport; Tue, 13 Jun 2023 00:05:02 -0700 From: Manikandan Muralidharan <manikandan.m@microchip.com> To: <lee@kernel.org>, <robh+dt@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>, <nicolas.ferre@microchip.com>, <alexandre.belloni@bootlin.com>, <claudiu.beznea@microchip.com>, <sam@ravnborg.org>, <bbrezillon@kernel.org>, <airlied@gmail.com>, <daniel@ffwll.ch>, <devicetree@vger.kernel.org>, <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>, <dri-devel@lists.freedesktop.org> CC: <Hari.PrasathGE@microchip.com>, <Balamanikandan.Gunasundar@microchip.com>, <Durai.ManickamKR@microchip.com>, <Nayabbasha.Sayed@microchip.com>, <Dharma.B@microchip.com>, <Varshini.Rajendran@microchip.com>, <Balakrishnan.S@microchip.com>, Manikandan <manikandan.m@microchip.com> Subject: [PATCH 1/9] dt-bindings: mfd: Add bindings for SAM9X7 LCD controller Date: Tue, 13 Jun 2023 12:34:18 +0530 Message-ID: <20230613070426.467389-2-manikandan.m@microchip.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20230613070426.467389-1-manikandan.m@microchip.com> References: <20230613070426.467389-1-manikandan.m@microchip.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Spam-Status: No, score=-4.4 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_MED, SPF_HELO_PASS,SPF_NONE,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768571785243429551?= X-GMAIL-MSGID: =?utf-8?q?1768571785243429551?= |
Series |
Add support for XLCDC to sam9x7 SoC family.
|
|
Commit Message
Manikandan Muralidharan
June 13, 2023, 7:04 a.m. UTC
Add new compatible string for the XLCD controller on SAM9X7 SoC.
Signed-off-by: Manikandan Muralidharan <manikandan.m@microchip.com>
---
Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt | 1 +
1 file changed, 1 insertion(+)
Comments
On 13/06/2023 09:04, Manikandan Muralidharan wrote: > Add new compatible string for the XLCD controller on SAM9X7 SoC. > > Signed-off-by: Manikandan Muralidharan <manikandan.m@microchip.com> > --- > Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt b/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt > index 5f8880cc757e..7c77b6bf4adb 100644 > --- a/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt > +++ b/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt > @@ -8,6 +8,7 @@ Required properties: > "atmel,sama5d3-hlcdc" > "atmel,sama5d4-hlcdc" > "microchip,sam9x60-hlcdc" > + "microchip,sam9x7-xlcdc" Google says sam9x7 is a series, not a SoC. Please add compatibles for specific SoCs, not for series. Best regards, Krzysztof
On Tue, Jun 13, 2023 at 12:34:18PM +0530, Manikandan Muralidharan wrote: > Add new compatible string for the XLCD controller on SAM9X7 SoC. You should probably indicate here why this is not compatible with the existing SoCs that are supported. To hazard a guess, it is the HLCDC IP (I forget the exact letters!)? If so, Acked-by: Conor Dooley <conor.dooley@microchip.com> Cheers, Conor. > > Signed-off-by: Manikandan Muralidharan <manikandan.m@microchip.com> > --- > Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt b/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt > index 5f8880cc757e..7c77b6bf4adb 100644 > --- a/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt > +++ b/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt > @@ -8,6 +8,7 @@ Required properties: > "atmel,sama5d3-hlcdc" > "atmel,sama5d4-hlcdc" > "microchip,sam9x60-hlcdc" > + "microchip,sam9x7-xlcdc" > - reg: base address and size of the HLCDC device registers. > - clock-names: the name of the 3 clocks requested by the HLCDC device. > Should contain "periph_clk", "sys_clk" and "slow_clk". > -- > 2.25.1 >
On Tue, Jun 13, 2023 at 08:17:13PM +0200, Krzysztof Kozlowski wrote: > On 13/06/2023 09:04, Manikandan Muralidharan wrote: > > Add new compatible string for the XLCD controller on SAM9X7 SoC. > > > > Signed-off-by: Manikandan Muralidharan <manikandan.m@microchip.com> > > --- > > Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt b/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt > > index 5f8880cc757e..7c77b6bf4adb 100644 > > --- a/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt > > +++ b/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt > > @@ -8,6 +8,7 @@ Required properties: > > "atmel,sama5d3-hlcdc" > > "atmel,sama5d4-hlcdc" > > "microchip,sam9x60-hlcdc" > > + "microchip,sam9x7-xlcdc" > > Google says sam9x7 is a series, not a SoC. Please add compatibles for > specific SoCs, not for series. We had this one a few weeks ago, see https://lore.kernel.org/all/add5e49e-8416-ba9f-819a-da944938c05f@microchip.com/ and its parents. Outcome of that seemed to be that using "sam9x7" was fine.
On Tue, Jun 13, 2023 at 07:18:25PM +0100, Conor Dooley wrote: > On Tue, Jun 13, 2023 at 12:34:18PM +0530, Manikandan Muralidharan wrote: > > Add new compatible string for the XLCD controller on SAM9X7 SoC. > > You should probably indicate here why this is not compatible with the > existing SoCs that are supported. To hazard a guess, it is the HLCDC IP > (I forget the exact letters!)? Manikandan pointed out off list that this was not clear. Looking at it again, I think I actually truncated my sentence - it should've been something like "it is the HLCDC IP ... is not a subset of the XLCDC IP." Sorry for that Manikandan. > If so, > Acked-by: Conor Dooley <conor.dooley@microchip.com> > > Cheers, > Conor. > > > > > Signed-off-by: Manikandan Muralidharan <manikandan.m@microchip.com> > > --- > > Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt b/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt > > index 5f8880cc757e..7c77b6bf4adb 100644 > > --- a/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt > > +++ b/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt > > @@ -8,6 +8,7 @@ Required properties: > > "atmel,sama5d3-hlcdc" > > "atmel,sama5d4-hlcdc" > > "microchip,sam9x60-hlcdc" > > + "microchip,sam9x7-xlcdc" > > - reg: base address and size of the HLCDC device registers. > > - clock-names: the name of the 3 clocks requested by the HLCDC device. > > Should contain "periph_clk", "sys_clk" and "slow_clk". > > -- > > 2.25.1 > >
On 13/06/2023 at 20:21, Conor Dooley wrote: > On Tue, Jun 13, 2023 at 08:17:13PM +0200, Krzysztof Kozlowski wrote: >> On 13/06/2023 09:04, Manikandan Muralidharan wrote: >>> Add new compatible string for the XLCD controller on SAM9X7 SoC. >>> >>> Signed-off-by: Manikandan Muralidharan<manikandan.m@microchip.com> >>> --- >>> Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt | 1 + >>> 1 file changed, 1 insertion(+) >>> >>> diff --git a/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt b/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt >>> index 5f8880cc757e..7c77b6bf4adb 100644 >>> --- a/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt >>> +++ b/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt >>> @@ -8,6 +8,7 @@ Required properties: >>> "atmel,sama5d3-hlcdc" >>> "atmel,sama5d4-hlcdc" >>> "microchip,sam9x60-hlcdc" >>> + "microchip,sam9x7-xlcdc" >> Google says sam9x7 is a series, not a SoC. Please add compatibles for >> specific SoCs, not for series. > We had this one a few weeks ago, see > https://lore.kernel.org/all/add5e49e-8416-ba9f-819a-da944938c05f@microchip.com/ > and its parents. Outcome of that seemed to be that using "sam9x7" was fine. And it's where it begins to be funny, as the LCD is precisely one aspect where we differentiate between sam9x75, sam9x72 and sam9x70... So please Manikandan sort this out if difference between these chips will be better handled with different compatibility string, in particular about //, LVDS and MIPI-DSI variants! Regards, Nicolas
On Wed, Jun 14, 2023 at 04:40:50PM +0200, Nicolas Ferre wrote: > On 13/06/2023 at 20:21, Conor Dooley wrote: > > On Tue, Jun 13, 2023 at 08:17:13PM +0200, Krzysztof Kozlowski wrote: > > > On 13/06/2023 09:04, Manikandan Muralidharan wrote: > > > > Add new compatible string for the XLCD controller on SAM9X7 SoC. > > > > > > > > Signed-off-by: Manikandan Muralidharan<manikandan.m@microchip.com> > > > > --- > > > > Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt | 1 + > > > > 1 file changed, 1 insertion(+) > > > > > > > > diff --git a/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt b/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt > > > > index 5f8880cc757e..7c77b6bf4adb 100644 > > > > --- a/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt > > > > +++ b/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt > > > > @@ -8,6 +8,7 @@ Required properties: > > > > "atmel,sama5d3-hlcdc" > > > > "atmel,sama5d4-hlcdc" > > > > "microchip,sam9x60-hlcdc" > > > > + "microchip,sam9x7-xlcdc" > > > Google says sam9x7 is a series, not a SoC. Please add compatibles for > > > specific SoCs, not for series. > > We had this one a few weeks ago, see > > https://lore.kernel.org/all/add5e49e-8416-ba9f-819a-da944938c05f@microchip.com/ > > and its parents. Outcome of that seemed to be that using "sam9x7" was fine. > > And it's where it begins to be funny, as the LCD is precisely one aspect > where we differentiate between sam9x75, sam9x72 and sam9x70... Oh dear, just my luck... > So please Manikandan sort this out if difference between these chips will be > better handled with different compatibility string, in particular about //, > LVDS and MIPI-DSI variants! Yeah, providing some information about what the differences actually are would be good, for the same of the actually-knowledgeable-about-displays folk in the audience (IOW, not me). Probably then the display/atmel/hlcdc-dc.txt binding needs an update too?
On 14/06/23 20:10, Nicolas Ferre wrote: > On 13/06/2023 at 20:21, Conor Dooley wrote: >> On Tue, Jun 13, 2023 at 08:17:13PM +0200, Krzysztof Kozlowski wrote: >>> On 13/06/2023 09:04, Manikandan Muralidharan wrote: >>>> Add new compatible string for the XLCD controller on SAM9X7 SoC. >>>> >>>> Signed-off-by: Manikandan Muralidharan<manikandan.m@microchip.com> >>>> --- >>>> Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt >>>> b/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt >>>> index 5f8880cc757e..7c77b6bf4adb 100644 >>>> --- a/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt >>>> +++ b/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt >>>> @@ -8,6 +8,7 @@ Required properties: >>>> "atmel,sama5d3-hlcdc" >>>> "atmel,sama5d4-hlcdc" >>>> "microchip,sam9x60-hlcdc" >>>> + "microchip,sam9x7-xlcdc" >>> Google says sam9x7 is a series, not a SoC. Please add compatibles for >>> specific SoCs, not for series. >> We had this one a few weeks ago, see >> https://lore.kernel.org/all/add5e49e-8416-ba9f-819a-da944938c05f@microchip.com/ >> and its parents. Outcome of that seemed to be that using "sam9x7" was >> fine. > > And it's where it begins to be funny, as the LCD is precisely one aspect > where we differentiate between sam9x75, sam9x72 and sam9x70... > So please Manikandan sort this out if difference between these chips > will be better handled with different compatibility string, in > particular about //, LVDS and MIPI-DSI variants! Yes Sure, I will replace the compatible as s/sam9x7/sam9x75/g to handle the different variants of sam9x7 better. > > Regards, > Nicolas > -- Thanks and Regards, Manikandan M.
On 16/06/2023 at 08:44, Manikandan M - I67131 wrote: > On 14/06/23 20:10, Nicolas Ferre wrote: >> On 13/06/2023 at 20:21, Conor Dooley wrote: >>> On Tue, Jun 13, 2023 at 08:17:13PM +0200, Krzysztof Kozlowski wrote: >>>> On 13/06/2023 09:04, Manikandan Muralidharan wrote: >>>>> Add new compatible string for the XLCD controller on SAM9X7 SoC. >>>>> >>>>> Signed-off-by: Manikandan Muralidharan<manikandan.m@microchip.com> >>>>> --- >>>>> Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt | 1 + >>>>> 1 file changed, 1 insertion(+) >>>>> >>>>> diff --git a/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt >>>>> b/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt >>>>> index 5f8880cc757e..7c77b6bf4adb 100644 >>>>> --- a/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt >>>>> +++ b/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt >>>>> @@ -8,6 +8,7 @@ Required properties: >>>>> "atmel,sama5d3-hlcdc" >>>>> "atmel,sama5d4-hlcdc" >>>>> "microchip,sam9x60-hlcdc" >>>>> + "microchip,sam9x7-xlcdc" >>>> Google says sam9x7 is a series, not a SoC. Please add compatibles for >>>> specific SoCs, not for series. >>> We had this one a few weeks ago, see >>> https://lore.kernel.org/all/add5e49e-8416-ba9f-819a-da944938c05f@microchip.com/ >>> and its parents. Outcome of that seemed to be that using "sam9x7" was >>> fine. >> >> And it's where it begins to be funny, as the LCD is precisely one aspect >> where we differentiate between sam9x75, sam9x72 and sam9x70... >> So please Manikandan sort this out if difference between these chips >> will be better handled with different compatibility string, in >> particular about //, LVDS and MIPI-DSI variants! > Yes Sure, I will replace the compatible as s/sam9x7/sam9x75/g to handle > the different variants of sam9x7 better. Moving to sam9x75 is probably good. But what is your plan for differentiating parallel and LVDS (on sam9x72) and precisely this sam9x75 variant which in addition has MIPI-DSI? Regards, Nicolas
On 21/06/23 13:17, Nicolas Ferre wrote: > On 16/06/2023 at 08:44, Manikandan M - I67131 wrote: >> On 14/06/23 20:10, Nicolas Ferre wrote: >>> On 13/06/2023 at 20:21, Conor Dooley wrote: >>>> On Tue, Jun 13, 2023 at 08:17:13PM +0200, Krzysztof Kozlowski wrote: >>>>> On 13/06/2023 09:04, Manikandan Muralidharan wrote: >>>>>> Add new compatible string for the XLCD controller on SAM9X7 SoC. >>>>>> >>>>>> Signed-off-by: Manikandan Muralidharan<manikandan.m@microchip.com> >>>>>> --- >>>>>> Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt | 1 + >>>>>> 1 file changed, 1 insertion(+) >>>>>> >>>>>> diff --git a/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt >>>>>> b/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt >>>>>> index 5f8880cc757e..7c77b6bf4adb 100644 >>>>>> --- a/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt >>>>>> +++ b/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt >>>>>> @@ -8,6 +8,7 @@ Required properties: >>>>>> "atmel,sama5d3-hlcdc" >>>>>> "atmel,sama5d4-hlcdc" >>>>>> "microchip,sam9x60-hlcdc" >>>>>> + "microchip,sam9x7-xlcdc" >>>>> Google says sam9x7 is a series, not a SoC. Please add compatibles for >>>>> specific SoCs, not for series. >>>> We had this one a few weeks ago, see >>>> https://lore.kernel.org/all/add5e49e-8416-ba9f-819a-da944938c05f@microchip.com/ >>>> and its parents. Outcome of that seemed to be that using "sam9x7" was >>>> fine. >>> >>> And it's where it begins to be funny, as the LCD is precisely one aspect >>> where we differentiate between sam9x75, sam9x72 and sam9x70... >>> So please Manikandan sort this out if difference between these chips >>> will be better handled with different compatibility string, in >>> particular about //, LVDS and MIPI-DSI variants! >> Yes Sure, I will replace the compatible as s/sam9x7/sam9x75/g to handle >> the different variants of sam9x7 better. > > Moving to sam9x75 is probably good. But what is your plan for > differentiating parallel and LVDS (on sam9x72) and precisely this > sam9x75 variant which in addition has MIPI-DSI? In sam9x75 with support for LVDS and MIPI, Parallel interfacing peripherals, the additions performed on the LCD controller driver is the same.Considering the LCDC IP used in sam9x75, there are no registers sets that needs modification per connecting peripheral variants, only the clock and DRM_ENCODER_MODE_XXX (set by connecting peripheral driver) differs, which can be handled in DT, atmel-lcdc MFD driver and peripheral driver. In future, sam9x72 with XLCD controller can be differentiated with sam9x72 compatible string and with a IP version flag(is_xlcdc_v2) in its driver data if an upgraded XLCD IP is used with difference in bits or register set exist compared to current IP. > > Regards, > Nicolas > > -- Thanks and Regards, Manikandan M.
On Mon, Jun 26, 2023 at 05:31:59AM +0000, Manikandan.M@microchip.com wrote: > On 21/06/23 13:17, Nicolas Ferre wrote: > > On 16/06/2023 at 08:44, Manikandan M - I67131 wrote: > >> On 14/06/23 20:10, Nicolas Ferre wrote: > >>> On 13/06/2023 at 20:21, Conor Dooley wrote: > >>>> On Tue, Jun 13, 2023 at 08:17:13PM +0200, Krzysztof Kozlowski wrote: > >>>>> On 13/06/2023 09:04, Manikandan Muralidharan wrote: > >>>>>> Add new compatible string for the XLCD controller on SAM9X7 SoC. > >>>>>> > >>>>>> Signed-off-by: Manikandan Muralidharan<manikandan.m@microchip.com> > >>>>>> --- > >>>>>> Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt | 1 + > >>>>>> 1 file changed, 1 insertion(+) > >>>>>> > >>>>>> diff --git a/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt > >>>>>> b/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt > >>>>>> index 5f8880cc757e..7c77b6bf4adb 100644 > >>>>>> --- a/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt > >>>>>> +++ b/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt > >>>>>> @@ -8,6 +8,7 @@ Required properties: > >>>>>> "atmel,sama5d3-hlcdc" > >>>>>> "atmel,sama5d4-hlcdc" > >>>>>> "microchip,sam9x60-hlcdc" > >>>>>> + "microchip,sam9x7-xlcdc" > >>>>> Google says sam9x7 is a series, not a SoC. Please add compatibles for > >>>>> specific SoCs, not for series. > >>>> We had this one a few weeks ago, see > >>>> https://lore.kernel.org/all/add5e49e-8416-ba9f-819a-da944938c05f@microchip.com/ > >>>> and its parents. Outcome of that seemed to be that using "sam9x7" was > >>>> fine. > >>> > >>> And it's where it begins to be funny, as the LCD is precisely one aspect > >>> where we differentiate between sam9x75, sam9x72 and sam9x70... > >>> So please Manikandan sort this out if difference between these chips > >>> will be better handled with different compatibility string, in > >>> particular about //, LVDS and MIPI-DSI variants! > >> Yes Sure, I will replace the compatible as s/sam9x7/sam9x75/g to handle > >> the different variants of sam9x7 better. > > > > Moving to sam9x75 is probably good. But what is your plan for > > differentiating parallel and LVDS (on sam9x72) and precisely this > > sam9x75 variant which in addition has MIPI-DSI? > In sam9x75 with support for LVDS and MIPI, Parallel interfacing > peripherals, the additions performed on the LCD controller driver is the > same.Considering the LCDC IP used in sam9x75, there are no registers > sets that needs modification per connecting peripheral variants, only > the clock and DRM_ENCODER_MODE_XXX (set by connecting peripheral driver) > differs, which can be handled in DT, atmel-lcdc MFD driver and > peripheral driver. > > In future, sam9x72 with XLCD controller can be differentiated with > sam9x72 compatible string and with a IP version flag(is_xlcdc_v2) in its > driver data if an upgraded XLCD IP is used with difference in bits or > register set exist compared to current IP. Trying to covert that into what the binding will look like... sam9x72 & sam9x75 each get their own compatibles for the lcd controller. From there, we permit `compatible = "microchip,sam9x75-foo"` in isolation. It *sounds* like the basic featureset of the sam9x75 is compatible with the sam9x72, so for that we permit `compatible = "microchip,sam9x72-foo", "microchip,sam9x75-foo"`. Although, if the hardware for the sam9x72 isn't set in stone yet, it might be best to hold off on documenting it until things settle down, and only add the sam9x75 for now. Cheers, Conor.
diff --git a/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt b/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt index 5f8880cc757e..7c77b6bf4adb 100644 --- a/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt +++ b/Documentation/devicetree/bindings/mfd/atmel-hlcdc.txt @@ -8,6 +8,7 @@ Required properties: "atmel,sama5d3-hlcdc" "atmel,sama5d4-hlcdc" "microchip,sam9x60-hlcdc" + "microchip,sam9x7-xlcdc" - reg: base address and size of the HLCDC device registers. - clock-names: the name of the 3 clocks requested by the HLCDC device. Should contain "periph_clk", "sys_clk" and "slow_clk".