Message ID | 20230613130011.305589-8-linux@rasmusvillemoes.dk |
---|---|
State | New |
Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org> Delivered-To: ouuuleilei@gmail.com Received: by 2002:a59:994d:0:b0:3d9:f83d:47d9 with SMTP id k13csp526277vqr; Tue, 13 Jun 2023 06:04:12 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ5Z+WXnoNe+nflnjdviWAiLVvi+qHKVL/fCjQOAhyA2Ys5M5mTbDDKCTzlb19r1EdMzWYnM X-Received: by 2002:a17:90a:38e2:b0:259:c21:7106 with SMTP id x89-20020a17090a38e200b002590c217106mr9593094pjb.0.1686661451751; Tue, 13 Jun 2023 06:04:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1686661451; cv=none; d=google.com; s=arc-20160816; b=nd9MLH41GXSoLvhQ4hAYmedF5Xjb0XGFextsuqe3fhE5HCxf7xmxSqWY4fzQF/TCSI 3eXZKwqaR4AupbFHK3j7efLxXeB/M0BddMi7KN1O6Xpi0S26FuWYzmp1oGyfwekAlWhi lGf/yREj3vn8TrK9sQ6xjBrL4CKR3WSiDWgw6G8etOeUOF4etfy2s4d1r01FwQrAWyd5 96VND2l5KuYiYl/QVYJCqK6bhbDGBbxCyxyEgd98m1sJP3P6d0T+5GIY3gg+TFFHVB7m /VsONv78MCZeFD39jdJxZfYNnquQ+Iyc61Y1St563G7A9RMZ8HMzNqNPFMKSgc7ytfny xNcg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=C2BuYK+BLXe7S2DEn820yRWucPw/Ya8vxrHBKxBUFTU=; b=gArGUvrQdv+/K7N1dk+8uLOSDVIO5zFXTzqKUUCPHoIt0l5Vf7qWEPnxhaZk9xQdBQ 5dUXwXN9y/09v8GuvU6hI0fzZNuSVyYVTKmi/IO9U7MiFOprQROB7Kr8ZHzNHw1U8o7b howbprtCX4E5SOGf3L7C+SGkz7POO6OCf9lXxpUTAyN8gJYNrBl3v7TDjwNd7lCOcubW LeU1kgBu5gWGqjoumRrjNNwrV1wBt4ph6wOtVdbzXLG0dv7o7x/o1Y84i+nllC4c4gAz 2ElTTdcs9FsxhBxY6TLK0VD46EwyNOokf9DbdZDbGBHw4dTTYFJL+X+wOrLcaoVkBvDw IDQg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@rasmusvillemoes.dk header.s=google header.b=VW0s26oZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20]) by mx.google.com with ESMTP id h13-20020a17090a3d0d00b00259a3c7fb52si8504815pjc.27.2023.06.13.06.03.28; Tue, 13 Jun 2023 06:04:11 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) client-ip=2620:137:e000::1:20; Authentication-Results: mx.google.com; dkim=pass header.i=@rasmusvillemoes.dk header.s=google header.b=VW0s26oZ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 2620:137:e000::1:20 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242540AbjFMNBt (ORCPT <rfc822;lekhanya01809@gmail.com> + 99 others); Tue, 13 Jun 2023 09:01:49 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242496AbjFMNBO (ORCPT <rfc822;linux-kernel@vger.kernel.org>); Tue, 13 Jun 2023 09:01:14 -0400 Received: from mail-lf1-x12b.google.com (mail-lf1-x12b.google.com [IPv6:2a00:1450:4864:20::12b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 14B55191 for <linux-kernel@vger.kernel.org>; Tue, 13 Jun 2023 06:01:13 -0700 (PDT) Received: by mail-lf1-x12b.google.com with SMTP id 2adb3069b0e04-4f620583bc2so6678942e87.1 for <linux-kernel@vger.kernel.org>; Tue, 13 Jun 2023 06:01:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rasmusvillemoes.dk; s=google; t=1686661271; x=1689253271; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=C2BuYK+BLXe7S2DEn820yRWucPw/Ya8vxrHBKxBUFTU=; b=VW0s26oZQSMnoLdD1XtO6Sbm+5CKcWoB+Q7FT2wkCBByXrvyd4MuUxGUXjzW+Kp4CQ 5nCmJUneRGBaa3iNL1XLl8bypsgCWvBPhFjwjQ49ikffcabCQLAWsGKTlljZlHz+Z+TJ pl0F4PByr0eZ4axlzqCNUNCwr7XJ9AOFmx6bg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686661271; x=1689253271; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C2BuYK+BLXe7S2DEn820yRWucPw/Ya8vxrHBKxBUFTU=; b=YOvcMm+9NJJ4NV5FriUQCGSYEPLnp+EPP1jB5spncRFjGQzsCDUxyj05420lTGcBX9 hAB7BmkShKjGSV+MBSxkrjUqabUs5cwyPMmkLr+PpqIpDxlTWwQs3nfMgY3UthTXKPQW wD3T85CU8Ga8PAfj7ukWnkaUAS6dj0XVr+5rc6W2V4vhgTKj3SGFTVcksBGaJV/iXKJq p0soSOg/TBREJpU7eIOHQiHL+AJjiGRJwj2+Ako3IdrDIfKveqO3QRgZ4rWsezR1/xir cthSy5Giks7GAKh7mAeTEiAeH1J1xkKqjjZwK2iw/MXVNKYyJqYXwc3+B9EYF40+XiCS vRwg== X-Gm-Message-State: AC+VfDyI91IPd5gYa1MO3GwbyfKzRYLSP2aIAu6WI6m9KbWFErE/p0aP 7+5wTYVXR+7mf78V6/tK7mMceA== X-Received: by 2002:a19:915e:0:b0:4d8:6540:a731 with SMTP id y30-20020a19915e000000b004d86540a731mr5013742lfj.47.1686661271195; Tue, 13 Jun 2023 06:01:11 -0700 (PDT) Received: from prevas-ravi.prevas.se ([81.216.59.226]) by smtp.gmail.com with ESMTPSA id u24-20020ac243d8000000b004f14ae5ded8sm1793786lfl.28.2023.06.13.06.01.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 13 Jun 2023 06:01:10 -0700 (PDT) From: Rasmus Villemoes <linux@rasmusvillemoes.dk> To: Alessandro Zummo <a.zummo@towertech.it>, Alexandre Belloni <alexandre.belloni@bootlin.com> Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, devicetree@vger.kernel.org, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Conor Dooley <conor+dt@kernel.org>, linux-rtc@vger.kernel.org, Rasmus Villemoes <linux@rasmusvillemoes.dk>, linux-kernel@vger.kernel.org Subject: [PATCH v2 7/8] dt-bindings: rtc: isl12022: add #clock-cells property Date: Tue, 13 Jun 2023 15:00:09 +0200 Message-Id: <20230613130011.305589-8-linux@rasmusvillemoes.dk> X-Mailer: git-send-email 2.37.2 In-Reply-To: <20230613130011.305589-1-linux@rasmusvillemoes.dk> References: <20230612113059.247275-1-linux@rasmusvillemoes.dk> <20230613130011.305589-1-linux@rasmusvillemoes.dk> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_PASS,T_SCC_BODY_TEXT_LINE,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-kernel.vger.kernel.org> X-Mailing-List: linux-kernel@vger.kernel.org X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?= X-GMAIL-THRID: =?utf-8?q?1768497125681823641?= X-GMAIL-MSGID: =?utf-8?q?1768592717991120178?= |
Series |
rtc: isl12022: battery backup voltage and clock support
|
|
Commit Message
Rasmus Villemoes
June 13, 2023, 1 p.m. UTC
The isl12022 has a dual-purpose irq/f_out pin, which can either be
used as an interrupt or clock output.
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
---
.../devicetree/bindings/rtc/intersil,isl12022.yaml | 10 ++++++++++
1 file changed, 10 insertions(+)
Comments
On 13/06/2023 15:00, Rasmus Villemoes wrote: > The isl12022 has a dual-purpose irq/f_out pin, which can either be > used as an interrupt or clock output. > > Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk> > --- > .../devicetree/bindings/rtc/intersil,isl12022.yaml | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml b/Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml > index d5d3a687a34d..a9ef68b5fdcd 100644 > --- a/Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml > +++ b/Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml > @@ -11,6 +11,13 @@ maintainers: > > allOf: > - $ref: rtc.yaml# > + # If #clock-cells is present, interrupts must not be present > + - if: > + required: > + - '#clock-cells' > + then: > + properties: > + interrupts: false Entire allOf block should be like in example-schema, so before unevaluatedProperties. Please put it in correct place in your first patch so here it does not have to be moved. Best regards, Krzysztof
On 13/06/2023 21.10, Krzysztof Kozlowski wrote: > On 13/06/2023 15:00, Rasmus Villemoes wrote: >> diff --git a/Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml b/Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml >> index d5d3a687a34d..a9ef68b5fdcd 100644 >> --- a/Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml >> +++ b/Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml >> @@ -11,6 +11,13 @@ maintainers: >> >> allOf: >> - $ref: rtc.yaml# >> + # If #clock-cells is present, interrupts must not be present >> + - if: >> + required: >> + - '#clock-cells' >> + then: >> + properties: >> + interrupts: false > > Entire allOf block should be like in example-schema, so before > unevaluatedProperties. Please put it in correct place in your first > patch so here it does not have to be moved. > OK. That first patch was basically a copy-paste of c690048ed59b, and e.g. ingenic,rtc.yaml has a similar non-trivial allOf block between maintainers and properties. Is there somehow I could have known it should be right before unevaluatedProperties? Rasmus
On 13/06/2023 22:25, Rasmus Villemoes wrote: > On 13/06/2023 21.10, Krzysztof Kozlowski wrote: >> On 13/06/2023 15:00, Rasmus Villemoes wrote: > >>> diff --git a/Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml b/Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml >>> index d5d3a687a34d..a9ef68b5fdcd 100644 >>> --- a/Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml >>> +++ b/Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml >>> @@ -11,6 +11,13 @@ maintainers: >>> >>> allOf: >>> - $ref: rtc.yaml# >>> + # If #clock-cells is present, interrupts must not be present >>> + - if: >>> + required: >>> + - '#clock-cells' >>> + then: >>> + properties: >>> + interrupts: false >> >> Entire allOf block should be like in example-schema, so before >> unevaluatedProperties. Please put it in correct place in your first >> patch so here it does not have to be moved. >> > > OK. That first patch was basically a copy-paste of c690048ed59b, and > e.g. ingenic,rtc.yaml has a similar non-trivial allOf block between > maintainers and properties. Is there somehow I could have known it > should be right before unevaluatedProperties? The trivial - with a $ref - we keep often at the top. But once it starts growing, should be at the bottom. Since you know it will grow, just put it at the bottom (not total bottom, but like in example-schema, so after required:). Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml b/Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml index d5d3a687a34d..a9ef68b5fdcd 100644 --- a/Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml +++ b/Documentation/devicetree/bindings/rtc/intersil,isl12022.yaml @@ -11,6 +11,13 @@ maintainers: allOf: - $ref: rtc.yaml# + # If #clock-cells is present, interrupts must not be present + - if: + required: + - '#clock-cells' + then: + properties: + interrupts: false properties: compatible: @@ -22,6 +29,9 @@ properties: interrupts: maxItems: 1 + '#clock-cells': + const: 0 + isil,trip-level85-microvolt: description: | The battery voltage at which the first alarm should trigger