diff mbox series

dt-bindings: i2c: opencores: Add missing type for "regstep"

Message ID 20230613201105.2824399-1-robh@kernel.org
State New
Headers
Series dt-bindings: i2c: opencores: Add missing type for "regstep" |

Commit Message

Rob Herring June 13, 2023, 8:11 p.m. UTC 
  "regstep" may be deprecated, but it still needs a type.

Signed-off-by: Rob Herring <robh@kernel.org>
---
 Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml | 1 +
 1 file changed, 1 insertion(+)

Comments

Andrew Lunn June 13, 2023, 8:20 p.m. UTC | #1 
On Tue, Jun 13, 2023 at 02:11:04PM -0600, Rob Herring wrote:
> "regstep" may be deprecated, but it still needs a type.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew
Peter Korsgaard June 13, 2023, 8:51 p.m. UTC | #2 
>>>>> "Rob" == Rob Herring <robh@kernel.org> writes:

 > "regstep" may be deprecated, but it still needs a type.
 > Signed-off-by: Rob Herring <robh@kernel.org>
 > ---
 >  Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml | 1 +
 >  1 file changed, 1 insertion(+)

 > diff --git a/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml b/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml
 > index 85d9efb743ee..d9ef86729011 100644
 > --- a/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml
 > +++ b/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml
 > @@ -60,6 +60,7 @@ properties:
 >      default: 0
 
 >    regstep:
 > +    $ref: /schemas/types.yaml#/definitions/uint32

Reviewed-by: Peter Korsgaard <peter@korsgaard.com>
Conor Dooley June 13, 2023, 8:54 p.m. UTC | #3 
On Tue, Jun 13, 2023 at 02:11:04PM -0600, Rob Herring wrote:
> "regstep" may be deprecated, but it still needs a type.

Mea culpa!
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

> 
> Signed-off-by: Rob Herring <robh@kernel.org>
> ---
>  Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml b/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml
> index 85d9efb743ee..d9ef86729011 100644
> --- a/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml
> +++ b/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml
> @@ -60,6 +60,7 @@ properties:
>      default: 0
>  
>    regstep:
> +    $ref: /schemas/types.yaml#/definitions/uint32
>      description: |
>        deprecated, use reg-shift above
>      deprecated: true
> -- 
> 2.39.2
>
Andi Shyti June 14, 2023, 12:31 a.m. UTC | #4 
Hi Rob,

On Tue, Jun 13, 2023 at 02:11:04PM -0600, Rob Herring wrote:
> "regstep" may be deprecated, but it still needs a type.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Acked-by: Andi Shyti <andi.shyti@kernel.org> 

Thanks,
Andi
Wolfram Sang June 14, 2023, 8:33 a.m. UTC | #5 
On Tue, Jun 13, 2023 at 02:11:04PM -0600, Rob Herring wrote:
> "regstep" may be deprecated, but it still needs a type.
> 
> Signed-off-by: Rob Herring <robh@kernel.org>

Added fixes tag and applied to for-current, thanks!
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml b/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml
index 85d9efb743ee..d9ef86729011 100644
--- a/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml
+++ b/Documentation/devicetree/bindings/i2c/opencores,i2c-ocores.yaml
@@ -60,6 +60,7 @@  properties:
     default: 0
 
   regstep:
+    $ref: /schemas/types.yaml#/definitions/uint32
     description: |
       deprecated, use reg-shift above
     deprecated: true