diff mbox series

MAINTAINERS: Add source tree entry for kunit

Message ID 20230610180549.82560-1-sj@kernel.org
State New
Headers
Series MAINTAINERS: Add source tree entry for kunit |

Commit Message

SeongJae Park June 10, 2023, 6:05 p.m. UTC 
  Patches for kunit are managed in linux-kselftest tree before merged into
the mainline, but the MAINTAINERS section for kunit doesn't have the
entry for the tree.  Add it.

Signed-off-by: SeongJae Park <sj@kernel.org>
---
 MAINTAINERS | 1 +
 1 file changed, 1 insertion(+)

Comments

David Gow June 12, 2023, 11:54 p.m. UTC | #1 
On Sun, 11 Jun 2023 at 02:05, SeongJae Park <sj@kernel.org> wrote:
>
> Patches for kunit are managed in linux-kselftest tree before merged into
> the mainline, but the MAINTAINERS section for kunit doesn't have the
> entry for the tree.  Add it.
>
> Signed-off-by: SeongJae Park <sj@kernel.org>
> ---

Thanks very much.

Given KUnit work happens in the kunit and kunit-fixes branches here,
should we note those as well?

-- David


>  MAINTAINERS | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index ce5f343c1443..8a217438956b 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -11327,6 +11327,7 @@ L:      linux-kselftest@vger.kernel.org
>  L:     kunit-dev@googlegroups.com
>  S:     Maintained
>  W:     https://google.github.io/kunit-docs/third_party/kernel/docs/
> +T:     git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git

Should we also mention the branch here:
git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git
kunit

>  F:     Documentation/dev-tools/kunit/
>  F:     include/kunit/
>  F:     lib/kunit/
> --
> 2.25.1
>
SeongJae Park June 13, 2023, 12:01 a.m. UTC | #2 
On Tue, 13 Jun 2023 07:54:01 +0800 David Gow <davidgow@google.com> wrote:

> [-- Attachment #1: Type: text/plain, Size: 1120 bytes --]
> 
> On Sun, 11 Jun 2023 at 02:05, SeongJae Park <sj@kernel.org> wrote:
> >
> > Patches for kunit are managed in linux-kselftest tree before merged into
> > the mainline, but the MAINTAINERS section for kunit doesn't have the
> > entry for the tree.  Add it.
> >
> > Signed-off-by: SeongJae Park <sj@kernel.org>
> > ---
> 
> Thanks very much.

My pleasure! :)

> 
> Given KUnit work happens in the kunit and kunit-fixes branches here,
> should we note those as well?

That makes sense, I will add those in the commit message with the next version
of this.

> 
> -- David
> 
> 
> >  MAINTAINERS | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index ce5f343c1443..8a217438956b 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -11327,6 +11327,7 @@ L:      linux-kselftest@vger.kernel.org
> >  L:     kunit-dev@googlegroups.com
> >  S:     Maintained
> >  W:     https://google.github.io/kunit-docs/third_party/kernel/docs/
> > +T:     git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git
> 
> Should we also mention the branch here:
> git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git
> kunit

I think so.  Would you prefer having only one 'T' line with 'kunit' branch?
Or, both branches like below?  I have no strong opinion.

T:     git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git kunit
T:     git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git kunit-fixes


Thanks,
SJ

> 
> >  F:     Documentation/dev-tools/kunit/
> >  F:     include/kunit/
> >  F:     lib/kunit/
> > --
> > 2.25.1
> >
>
David Gow June 13, 2023, 12:45 a.m. UTC | #3 
On Tue, 13 Jun 2023 at 08:01, SeongJae Park <sj@kernel.org> wrote:
>
> On Tue, 13 Jun 2023 07:54:01 +0800 David Gow <davidgow@google.com> wrote:
>
> > [-- Attachment #1: Type: text/plain, Size: 1120 bytes --]
> >
> > On Sun, 11 Jun 2023 at 02:05, SeongJae Park <sj@kernel.org> wrote:
> > >
> > > Patches for kunit are managed in linux-kselftest tree before merged into
> > > the mainline, but the MAINTAINERS section for kunit doesn't have the
> > > entry for the tree.  Add it.
> > >
> > > Signed-off-by: SeongJae Park <sj@kernel.org>
> > > ---
> >
> > Thanks very much.
>
> My pleasure! :)
>
> >
> > Given KUnit work happens in the kunit and kunit-fixes branches here,
> > should we note those as well?
>
> That makes sense, I will add those in the commit message with the next version
> of this.
>
> >
> > -- David
> >
> >
> > >  MAINTAINERS | 1 +
> > >  1 file changed, 1 insertion(+)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index ce5f343c1443..8a217438956b 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -11327,6 +11327,7 @@ L:      linux-kselftest@vger.kernel.org
> > >  L:     kunit-dev@googlegroups.com
> > >  S:     Maintained
> > >  W:     https://google.github.io/kunit-docs/third_party/kernel/docs/
> > > +T:     git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git
> >
> > Should we also mention the branch here:
> > git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git
> > kunit
>
> I think so.  Would you prefer having only one 'T' line with 'kunit' branch?
> Or, both branches like below?  I have no strong opinion.
>
> T:     git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git kunit
> T:     git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git kunit-fixes
>
>

Let's go with both, assuming no-one else objects.

Cheers,
-- David
diff mbox series

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index ce5f343c1443..8a217438956b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11327,6 +11327,7 @@  L:	linux-kselftest@vger.kernel.org
 L:	kunit-dev@googlegroups.com
 S:	Maintained
 W:	https://google.github.io/kunit-docs/third_party/kernel/docs/
+T:	git git://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git
 F:	Documentation/dev-tools/kunit/
 F:	include/kunit/
 F:	lib/kunit/