| Message ID | 20230412112739.160376-4-angelogioacchino.delregno@collabora.com |
|---|---|
| State | New |
| Headers |
Return-Path: <linux-kernel-owner@vger.kernel.org>
Delivered-To: ouuuleilei@gmail.com
Received: by 2002:a59:b0ea:0:b0:3b6:4342:cba0 with SMTP id b10csp259451vqo;
Wed, 12 Apr 2023 04:48:36 -0700 (PDT)
X-Google-Smtp-Source:
AKy350ZnGPgrC06mjWUq8njxObO8avw8fM3u4La6v+px+qpC8dr/3nsosQr9OtgTydlAjfuf0NZK
X-Received: by 2002:a05:6a20:2926:b0:cd:a358:bb7 with SMTP id
t38-20020a056a20292600b000cda3580bb7mr16533214pzf.37.1681300116557;
Wed, 12 Apr 2023 04:48:36 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1681300116; cv=none;
d=google.com; s=arc-20160816;
b=KB4hU9/cnxIy1El9HKm4R6Hj4dwSClu60had3bwOhCsEFxpyYvm1qjTCHnklEavSS5
I8Y9ZdcuFoU3BrSinTBBdyrdXRsosqXPGhxNpGVTfIfds0opXar4pmfZTqt0LSGAtVlv
A79KADXEJdtBjw5RWYpMNtTj+qjFB6amowFun5xrQCz55d2ljZhTRgydDxGegXPEYiLk
VT2wI4XVpT36DRpNiao4CUNAueF/TqzjLHdAo3GUfkPixA2VqHuDd1+0DcDRMKuvDLI1
Lq1JQe2r/8/j/RlzdwzbxHw98xq8ZX92d7BjAnFS7anzGZAS41LFquoP7GTTdyYbrFIf
tTDg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com;
s=arc-20160816;
h=list-id:precedence:content-transfer-encoding:mime-version
:references:in-reply-to:message-id:date:subject:cc:to:from
:dkim-signature;
bh=rdnYKbf9/+W6WfCaMt9jMOWnB7v+S/jmGr08LRfvZz4=;
b=aCyaFpU8q+2kB8SLhQdAouZf/VxCJhHI5RYdj3SX1erZpZ/31K3rYn1hOlNvIHMKtA
lh040KecpsJ9VY28ize8U74luOxGgk8bZYcUPjuvGYl862SlZZVNrFBZnFGAEixy5z0/
LeIYUFrEgSdkMDY9/Qwisn32tCpLjSsR6lOSUWVIK8+BqZucr0YXMMxrI5XAfG7cLr0r
oYM+BrZMkDw2Gw9JQEOm7VnGJO7JqErnWuXZ5+EtRd3U0A84ItdKDMpNWVFW84LtsodL
Yt6DEtfMMrv9E2aYzoUMNN7f9DM3EE8CUNYpdAZOg9xDS+Wc7ISNwW5Ajlz6XvbOL7Q1
2ueQ==
ARC-Authentication-Results: i=1; mx.google.com;
dkim=pass header.i=@collabora.com header.s=mail header.b=DrLbBoxk;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=collabora.com
Received: from out1.vger.email (out1.vger.email. [2620:137:e000::1:20])
by mx.google.com with ESMTP id
j6-20020a654d46000000b005137bf7e2d3si16610201pgt.582.2023.04.12.04.48.24;
Wed, 12 Apr 2023 04:48:36 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
client-ip=2620:137:e000::1:20;
Authentication-Results: mx.google.com;
dkim=pass header.i=@collabora.com header.s=mail header.b=DrLbBoxk;
spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org
designates 2620:137:e000::1:20 as permitted sender)
smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE)
header.from=collabora.com
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
id S230406AbjDLL2R (ORCPT <rfc822;peter110.wang@gmail.com>
+ 99 others); Wed, 12 Apr 2023 07:28:17 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55836 "EHLO
lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
with ESMTP id S230288AbjDLL2D (ORCPT
<rfc822;linux-kernel@vger.kernel.org>);
Wed, 12 Apr 2023 07:28:03 -0400
Received: from madras.collabora.co.uk (madras.collabora.co.uk
[IPv6:2a00:1098:0:82:1000:25:2eeb:e5ab])
by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DAB262D50;
Wed, 12 Apr 2023 04:27:50 -0700 (PDT)
Received: from IcarusMOD.eternityproject.eu (2-237-20-237.ip236.fastwebnet.it
[2.237.20.237])
(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
key-exchange X25519 server-signature RSA-PSS (4096 bits)
server-digest SHA256)
(No client certificate requested)
(Authenticated sender: kholk11)
by madras.collabora.co.uk (Postfix) with ESMTPSA id 3F7C06603214;
Wed, 12 Apr 2023 12:27:48 +0100 (BST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com;
s=mail; t=1681298869;
bh=6Azvcn4i0Hycg0xDnvRheRJ+soYYO+v1kBon9Mg6Dyw=;
h=From:To:Cc:Subject:Date:In-Reply-To:References:From;
b=DrLbBoxkdz6ThJrt/c0Qxsir2AKyllHvXERWqJregc/3Ce0deMgfYXYzn62NK5ABR
JzwrpTqb0fsOT2izOuJPyv600oPn6JzxZ/OERDoL1n1kByF5T0Tb2uRWQiFIp/vsi8
rmJc00mOMM351G2ENBwfjk8VzYJl6YJ/BIVMY+2BO8ucRR6o/cu7XLQA93DlW9rtQ4
JY4zZ/gXADUViX46yeHWNFn7DyZBn6/c4okYDoSWfvxW+5TY5c7VRgGVdEJ2gvodIq
dL+i1U6iTPV0vxz8nhPmo8AxSMRJlehg0mRtWxfuvj5RlEgcfllulJxsdVeKaK8qy0
MpDkSw2kIjE2Q==
From: AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>
To: matthias.bgg@gmail.com
Cc: p.zabel@pengutronix.de, airlied@gmail.com, daniel@ffwll.ch,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
jassisinghbrar@gmail.com, chunfeng.yun@mediatek.com,
vkoul@kernel.org, kishon@kernel.org, thierry.reding@gmail.com,
u.kleine-koenig@pengutronix.de, chunkuang.hu@kernel.org,
angelogioacchino.delregno@collabora.com, ck.hu@mediatek.com,
jitao.shi@mediatek.com, xinlei.lee@mediatek.com,
houlong.wei@mediatek.com, dri-devel@lists.freedesktop.org,
linux-mediatek@lists.infradead.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-phy@lists.infradead.org, linux-pwm@vger.kernel.org,
kernel@collabora.com, phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: [PATCH 03/27] dt-bindings: display: mediatek: dpi: Add compatible for
MediaTek MT6795
Date: Wed, 12 Apr 2023 13:27:15 +0200
Message-Id: <20230412112739.160376-4-angelogioacchino.delregno@collabora.com>
X-Mailer: git-send-email 2.40.0
In-Reply-To: <20230412112739.160376-1-angelogioacchino.delregno@collabora.com>
References: <20230412112739.160376-1-angelogioacchino.delregno@collabora.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED,
DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,
URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on
lindbergh.monkeyblade.net
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
X-getmail-retrieved-from-mailbox: =?utf-8?q?INBOX?=
X-GMAIL-THRID: =?utf-8?q?1762970951350610976?=
X-GMAIL-MSGID: =?utf-8?q?1762970951350610976?=
|
| Series |
MediaTek Helio X10 - Mailbox, Display, MMC/SD/SDIO
|
|
Commit Message
AngeloGioacchino Del Regno
April 12, 2023, 11:27 a.m. UTC
Add a compatible string for the MediaTek Helio X10 MT6795 SoC, using
the same parameters as MT8183.
Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
---
.../display/mediatek/mediatek,dpi.yaml | 23 +++++++++++--------
1 file changed, 14 insertions(+), 9 deletions(-)
Comments
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: > Add a compatible string for the MediaTek Helio X10 MT6795 SoC, using > the same parameters as MT8183. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > .../display/mediatek/mediatek,dpi.yaml | 23 +++++++++++-------- > 1 file changed, 14 insertions(+), 9 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > index d976380801e3..803c00f26206 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > @@ -17,15 +17,20 @@ description: | > > properties: > compatible: > - enum: > - - mediatek,mt2701-dpi > - - mediatek,mt7623-dpi > - - mediatek,mt8173-dpi > - - mediatek,mt8183-dpi > - - mediatek,mt8186-dpi > - - mediatek,mt8188-dp-intf > - - mediatek,mt8192-dpi > - - mediatek,mt8195-dp-intf > + oneOf: > + - enum: > + - mediatek,mt2701-dpi > + - mediatek,mt7623-dpi > + - mediatek,mt8173-dpi > + - mediatek,mt8183-dpi > + - mediatek,mt8186-dpi > + - mediatek,mt8188-dp-intf > + - mediatek,mt8192-dpi > + - mediatek,mt8195-dp-intf > + - items: > + - enum: > + - mediatek,mt6795-dpi > + - const: mediatek,mt8183-dpi Shouldn't we declare both const: ?
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: > Add a compatible string for the MediaTek Helio X10 MT6795 SoC, using > the same parameters as MT8183. > > Signed-off-by: AngeloGioacchino Del Regno<angelogioacchino.delregno@collabora.com> Reviewed-by: Alexandre Mergnat <amergnat@baylibre.com>
On Wed, 12 Apr 2023 13:27:15 +0200, AngeloGioacchino Del Regno wrote: > Add a compatible string for the MediaTek Helio X10 MT6795 SoC, using > the same parameters as MT8183. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > .../display/mediatek/mediatek,dpi.yaml | 23 +++++++++++-------- > 1 file changed, 14 insertions(+), 9 deletions(-) > Running 'make dtbs_check' with the schema in this patch gives the following warnings. Consider if they are expected or the schema is incorrect. These may not be new warnings. Note that it is not yet a requirement to have 0 warnings for dtbs_check. This will change in the future. Full log is available here: https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230412112739.160376-4-angelogioacchino.delregno@collabora.com dpi@14014000: Additional properties are not allowed ('ports' was unexpected) arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dtb arch/arm/boot/dts/mt7623n-rfb-emmc.dtb dpi@14014000: compatible: 'oneOf' conditional failed, one must be fixed: arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dtb arch/arm/boot/dts/mt7623n-rfb-emmc.dtb dpi@14014000: 'port' is a required property arch/arm/boot/dts/mt7623n-bananapi-bpi-r2.dtb arch/arm/boot/dts/mt7623n-rfb-emmc.dtb dpi@1401d000: Additional properties are not allowed ('power-domains' was unexpected) arch/arm64/boot/dts/mediatek/mt8173-elm.dtb arch/arm64/boot/dts/mediatek/mt8173-elm-hana.dtb arch/arm64/boot/dts/mediatek/mt8173-elm-hana-rev7.dtb arch/arm64/boot/dts/mediatek/mt8173-evb.dtb dp-intf@1c015000: clock-names:0: 'pixel' was expected arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dtb arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dtb arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dtb arch/arm64/boot/dts/mediatek/mt8195-demo.dtb arch/arm64/boot/dts/mediatek/mt8195-evb.dtb dp-intf@1c015000: clock-names:1: 'engine' was expected arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dtb arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dtb arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dtb arch/arm64/boot/dts/mediatek/mt8195-demo.dtb arch/arm64/boot/dts/mediatek/mt8195-evb.dtb dp-intf@1c113000: Additional properties are not allowed ('power-domains' was unexpected) arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dtb arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dtb arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dtb arch/arm64/boot/dts/mediatek/mt8195-demo.dtb arch/arm64/boot/dts/mediatek/mt8195-evb.dtb dp-intf@1c113000: clock-names:0: 'pixel' was expected arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dtb arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dtb arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dtb arch/arm64/boot/dts/mediatek/mt8195-demo.dtb arch/arm64/boot/dts/mediatek/mt8195-evb.dtb dp-intf@1c113000: clock-names:1: 'engine' was expected arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r1.dtb arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r2.dtb arch/arm64/boot/dts/mediatek/mt8195-cherry-tomato-r3.dtb arch/arm64/boot/dts/mediatek/mt8195-demo.dtb arch/arm64/boot/dts/mediatek/mt8195-evb.dtb
On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: > Add a compatible string for the MediaTek Helio X10 MT6795 SoC, using > the same parameters as MT8183. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On 12/04/2023 14:35, Matthias Brugger wrote: > > > On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: >> Add a compatible string for the MediaTek Helio X10 MT6795 SoC, using >> the same parameters as MT8183. >> >> Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> >> --- >> .../display/mediatek/mediatek,dpi.yaml | 23 +++++++++++-------- >> 1 file changed, 14 insertions(+), 9 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml >> index d976380801e3..803c00f26206 100644 >> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml >> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml >> @@ -17,15 +17,20 @@ description: | >> >> properties: >> compatible: >> - enum: >> - - mediatek,mt2701-dpi >> - - mediatek,mt7623-dpi >> - - mediatek,mt8173-dpi >> - - mediatek,mt8183-dpi >> - - mediatek,mt8186-dpi >> - - mediatek,mt8188-dp-intf >> - - mediatek,mt8192-dpi >> - - mediatek,mt8195-dp-intf >> + oneOf: >> + - enum: >> + - mediatek,mt2701-dpi >> + - mediatek,mt7623-dpi >> + - mediatek,mt8173-dpi >> + - mediatek,mt8183-dpi >> + - mediatek,mt8186-dpi >> + - mediatek,mt8188-dp-intf >> + - mediatek,mt8192-dpi >> + - mediatek,mt8195-dp-intf >> + - items: >> + - enum: >> + - mediatek,mt6795-dpi >> + - const: mediatek,mt8183-dpi > > Shouldn't we declare both const: ? I assume it is likely the enum will grow. If this is reasonably anticipated, keep enum. Best regards, Krzysztof
Hi Chun-Kuang Hu, Can you help to merge the missing DT-binding patches in this series? Thanks a lot, Matthias On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: > Add a compatible string for the MediaTek Helio X10 MT6795 SoC, using > the same parameters as MT8183. > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > --- > .../display/mediatek/mediatek,dpi.yaml | 23 +++++++++++-------- > 1 file changed, 14 insertions(+), 9 deletions(-) > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > index d976380801e3..803c00f26206 100644 > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > @@ -17,15 +17,20 @@ description: | > > properties: > compatible: > - enum: > - - mediatek,mt2701-dpi > - - mediatek,mt7623-dpi > - - mediatek,mt8173-dpi > - - mediatek,mt8183-dpi > - - mediatek,mt8186-dpi > - - mediatek,mt8188-dp-intf > - - mediatek,mt8192-dpi > - - mediatek,mt8195-dp-intf > + oneOf: > + - enum: > + - mediatek,mt2701-dpi > + - mediatek,mt7623-dpi > + - mediatek,mt8173-dpi > + - mediatek,mt8183-dpi > + - mediatek,mt8186-dpi > + - mediatek,mt8188-dp-intf > + - mediatek,mt8192-dpi > + - mediatek,mt8195-dp-intf > + - items: > + - enum: > + - mediatek,mt6795-dpi > + - const: mediatek,mt8183-dpi > > reg: > maxItems: 1
Hi, Matthias: Matthias Brugger <matthias.bgg@gmail.com> 於 2023年5月29日 週一 下午10:07寫道： > > Hi Chun-Kuang Hu, > > Can you help to merge the missing DT-binding patches in this series? Apply display binding of this series to mediatek-drm-next [1]. [1] https://git.kernel.org/pub/scm/linux/kernel/git/chunkuang.hu/linux.git/log/?h=mediatek-drm-next Regards, Chun-Kuang. > > Thanks a lot, > Matthias > > On 12/04/2023 13:27, AngeloGioacchino Del Regno wrote: > > Add a compatible string for the MediaTek Helio X10 MT6795 SoC, using > > the same parameters as MT8183. > > > > Signed-off-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com> > > --- > > .../display/mediatek/mediatek,dpi.yaml | 23 +++++++++++-------- > > 1 file changed, 14 insertions(+), 9 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > > index d976380801e3..803c00f26206 100644 > > --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > > +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml > > @@ -17,15 +17,20 @@ description: | > > > > properties: > > compatible: > > - enum: > > - - mediatek,mt2701-dpi > > - - mediatek,mt7623-dpi > > - - mediatek,mt8173-dpi > > - - mediatek,mt8183-dpi > > - - mediatek,mt8186-dpi > > - - mediatek,mt8188-dp-intf > > - - mediatek,mt8192-dpi > > - - mediatek,mt8195-dp-intf > > + oneOf: > > + - enum: > > + - mediatek,mt2701-dpi > > + - mediatek,mt7623-dpi > > + - mediatek,mt8173-dpi > > + - mediatek,mt8183-dpi > > + - mediatek,mt8186-dpi > > + - mediatek,mt8188-dp-intf > > + - mediatek,mt8192-dpi > > + - mediatek,mt8195-dp-intf > > + - items: > > + - enum: > > + - mediatek,mt6795-dpi > > + - const: mediatek,mt8183-dpi > > > > reg: > > maxItems: 1
diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml index d976380801e3..803c00f26206 100644 --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.yaml @@ -17,15 +17,20 @@ description: | properties: compatible: - enum: - - mediatek,mt2701-dpi - - mediatek,mt7623-dpi - - mediatek,mt8173-dpi - - mediatek,mt8183-dpi - - mediatek,mt8186-dpi - - mediatek,mt8188-dp-intf - - mediatek,mt8192-dpi - - mediatek,mt8195-dp-intf + oneOf: + - enum: + - mediatek,mt2701-dpi + - mediatek,mt7623-dpi + - mediatek,mt8173-dpi + - mediatek,mt8183-dpi + - mediatek,mt8186-dpi + - mediatek,mt8188-dp-intf + - mediatek,mt8192-dpi + - mediatek,mt8195-dp-intf + - items: + - enum: + - mediatek,mt6795-dpi + - const: mediatek,mt8183-dpi reg: maxItems: 1